| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d14c98bb-85ab-2140-8cc2-b9dae2027267 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 84E4:B0660:13E266E:1BC3CEF:696A356B |
| html-safe-nonce | 6847e42946e48db0f53cbdfc7482b6d44e83050e29ff3cc0d22c4a683a360517 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEU0OkIwNjYwOjEzRTI2NkU6MUJDM0NFRjo2OTZBMzU2QiIsInZpc2l0b3JfaWQiOiIxNzY4NjAyODA0ODA5MjUwMTU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | de12f2bd9a7a82e1648529926f56c601877cfe46a86e35b067e19011e0ebc049 |
| hovercard-subject-tag | pull_request:104077572 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11096/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f72e4688b76c3f91a2bfcfc970050617763758fecef0952e7a5105f3fe4948ae/nodejs/node/pull/11096 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f72e4688b76c3f91a2bfcfc970050617763758fecef0952e7a5105f3fe4948ae/nodejs/node/pull/11096 |
| og:image:alt | group tests by error type
improve error validation for all messages
use assert.throws instead of try and catch
use arrow functions
add missing test for readdir
add missing test for readFileSync
rem... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | edsadr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/11096#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11096 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11096 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/11096 |
| Reload | https://github.com/nodejs/node/pull/11096 |
| Reload | https://github.com/nodejs/node/pull/11096 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/11096#issue-comment-box |
| edsadr | https://github.com/edsadr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| edsadr:fs-error | https://github.com/edsadr/node/tree/fs-error |
|
test: refactor test-fs-error-messages.js
| https://github.com/nodejs/node/pull/11096#top |
| edsadr | https://github.com/edsadr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| edsadr:fs-error | https://github.com/edsadr/node/tree/fs-error |
|
Conversation
11
| https://github.com/nodejs/node/pull/11096 |
|
Commits
1
| https://github.com/nodejs/node/pull/11096/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/11096/checks |
|
Files changed
| https://github.com/nodejs/node/pull/11096/files |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| Feb 1, 2017 | https://github.com/nodejs/node/pull/11096#issue-204501046 |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
|
| https://github.com/edsadr |
| test: refactor test-fs-error-messages.js | https://github.com/nodejs/node/pull/11096/commits/7f56b2d5ac48272422f6102669a5ee61934e9f3c |
| 7f56b2d | https://github.com/nodejs/node/pull/11096/commits/7f56b2d5ac48272422f6102669a5ee61934e9f3c |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Feb 1, 2017 | https://github.com/nodejs/node/pull/11096#event-944248805 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Feb 1, 2017 | https://github.com/nodejs/node/pull/11096#event-944255819 |
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
|
Feb 1, 2017
| https://github.com/nodejs/node/pull/11096#pullrequestreview-19486264 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11096/files/7f56b2d5ac48272422f6102669a5ee61934e9f3c |
| test/parallel/test-fs-error-messages.js | https://github.com/nodejs/node/pull/11096/files/7f56b2d5ac48272422f6102669a5ee61934e9f3c#diff-455dd1c2dc85a1b8757c583e26c214127f6209384269667ab887f363a099d7f9 |
| fhalde | https://github.com/fhalde |
| Feb 1, 2017 | https://github.com/nodejs/node/pull/11096#discussion_r98832000 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| edsadr | https://github.com/edsadr |
| Feb 1, 2017 | https://github.com/nodejs/node/pull/11096#discussion_r98881496 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 1, 2017
| https://github.com/nodejs/node/pull/11096#pullrequestreview-19596610 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11096/files/7f56b2d5ac48272422f6102669a5ee61934e9f3c |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Feb 3, 2017 | https://github.com/nodejs/node/pull/11096#issuecomment-277144743 |
| https://ci.nodejs.org/job/node-test-pull-request/6183/console | https://ci.nodejs.org/job/node-test-pull-request/6183/console |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Feb 3, 2017
| https://github.com/nodejs/node/pull/11096#pullrequestreview-19936898 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11096/files/7f56b2d5ac48272422f6102669a5ee61934e9f3c |
| jasnell | https://github.com/jasnell |
|
Feb 3, 2017
| https://github.com/nodejs/node/pull/11096#ref-commit-907ce8d |
|
| https://github.com/edsadr |
|
| https://github.com/jasnell |
| test: refactor test-fs-error-messages.js | https://github.com/nodejs/node/commit/907ce8dd6c297661a21a8ef5b638b76352523aa2 |
| 907ce8d | https://github.com/nodejs/node/commit/907ce8dd6c297661a21a8ef5b638b76352523aa2 |
| #11096 | https://github.com/nodejs/node/pull/11096 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 3, 2017 | https://github.com/nodejs/node/pull/11096#issuecomment-277308344 |
| 907ce8d | https://github.com/nodejs/node/commit/907ce8dd6c297661a21a8ef5b638b76352523aa2 |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 3, 2017 | https://github.com/nodejs/node/pull/11096#event-948404058 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 3, 2017
| https://github.com/nodejs/node/pull/11096#ref-pullrequest-205297640 |
|
Revert broken commits
#11155
| https://github.com/nodejs/node/pull/11155 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Feb 4, 2017 | https://github.com/nodejs/node/pull/11096#event-948935489 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Feb 4, 2017 | https://github.com/nodejs/node/pull/11096#issuecomment-277404149 |
| @edsadr | https://github.com/edsadr |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Feb 4, 2017 | https://github.com/nodejs/node/pull/11096#event-949142448 |
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| Feb 6, 2017 | https://github.com/nodejs/node/pull/11096#issuecomment-277753589 |
| @italoacasas | https://github.com/italoacasas |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
|
Feb 7, 2017
| https://github.com/nodejs/node/pull/11096#ref-pullrequest-205231103 |
|
doc: improve testing guide
#11150
| https://github.com/nodejs/node/pull/11150 |
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| Feb 7, 2017 | https://github.com/nodejs/node/pull/11096#issuecomment-277877026 |
| @italoacasas | https://github.com/italoacasas |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Feb 16, 2017 | https://github.com/nodejs/node/pull/11096#event-965708859 |
| krydos | https://github.com/krydos |
|
Feb 25, 2017
| https://github.com/nodejs/node/pull/11096#ref-commit-f01a745 |
|
| https://github.com/edsadr |
|
| https://github.com/krydos |
| test: refactor test-fs-error-messages.js | https://github.com/krydos/node/commit/f01a74510ef086a6d9d613dfa2ac9369f8dde62e |
| f01a745 | https://github.com/krydos/node/commit/f01a74510ef086a6d9d613dfa2ac9369f8dde62e |
| nodejs#11096 | https://github.com/nodejs/node/pull/11096 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| Mar 2, 2017 | https://github.com/nodejs/node/pull/11096#issuecomment-283513195 |
| @italoacasas | https://github.com/italoacasas |
| @edsadr | https://github.com/edsadr |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| Mar 27, 2017 | https://github.com/nodejs/node/pull/11096#issuecomment-289578256 |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 4, 2017
| https://github.com/nodejs/node/pull/11096#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
| 16073c0 | https://github.com/nodejs/node/commit/16073c083efdcaf70aef1e490679457dd0f624bd |
| fbe946b | https://github.com/nodejs/node/commit/fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
|
Compare
| https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
| April 14, 2017 04:11 | https://github.com/nodejs/node/pull/11096#event-1042928708 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/11096#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jun 17, 2017 | https://github.com/nodejs/node/pull/11096#event-1127953871 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jun 17, 2017 | https://github.com/nodejs/node/pull/11096#issuecomment-309237226 |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 26, 2017 | https://github.com/nodejs/node/pull/11096#issuecomment-325099632 |
| @edsadr | https://github.com/edsadr |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Aug 26, 2017 | https://github.com/nodejs/node/pull/11096#event-1222420188 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Aug 26, 2017 | https://github.com/nodejs/node/pull/11096#event-1222420264 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11096 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/11096/files/7f56b2d5ac48272422f6102669a5ee61934e9f3c |
|
| https://github.com/fhalde |
|
fhalde
| https://github.com/fhalde |
|
| https://github.com/nodejs/node/pull/11096/files/7f56b2d5ac48272422f6102669a5ee61934e9f3c |
|
| https://github.com/italoacasas |
|
italoacasas
| https://github.com/italoacasas |
|
| https://github.com/nodejs/node/pull/11096/files/7f56b2d5ac48272422f6102669a5ee61934e9f3c |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/11096 |
|
| https://github.com/edsadr |
|
| https://github.com/italoacasas |
|
| https://github.com/jasnell |
|
| https://github.com/hiroppy |
|
| https://github.com/gibfahn |
|
| https://github.com/BridgeAR |
|
| https://github.com/fhalde |
|
| https://github.com/mscdex |
|
| https://github.com/evanlucas |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |