René's URL Explorer Experiment


Title: readline: update 6 comparisons to strict by umairishaq · Pull Request #11078 · nodejs/node · GitHub

Open Graph Title: readline: update 6 comparisons to strict by umairishaq · Pull Request #11078 · nodejs/node

X Title: readline: update 6 comparisons to strict by umairishaq · Pull Request #11078 · nodejs/node

Description: In readline.js, update 6 comparisons to strict comparisons. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: In readline.js, update 6 comparisons to strict comparisons. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: In readline.js, update 6 comparisons to strict comparisons. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/11078

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:05503bb3-8354-9373-295c-18d87304c230
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB3E4:F40F2:1172105:17F5AE0:6969F82D
html-safe-nonce0f603e557c3f68ee98361ac508064da06436661a4cead14d0f4374e054418cde
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0U0OkY0MEYyOjExNzIxMDU6MTdGNUFFMDo2OTY5RjgyRCIsInZpc2l0b3JfaWQiOiIzMTcxNTMyNTEzMTc1MjcxNDcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac11349a349a6d133b643a631e918d8531708b736b5da2736b3f4115ad6b397b3f
hovercard-subject-tagpull_request:103876059
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11078/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/623966c52bec0b9186a07751d14c27162e51e5e388449df9a4e82c66bfa54d67/nodejs/node/pull/11078
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/623966c52bec0b9186a07751d14c27162e51e5e388449df9a4e82c66bfa54d67/nodejs/node/pull/11078
og:image:altIn readline.js, update 6 comparisons to strict comparisons. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameumairishaq
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/11078#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11078
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11078
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/11078
Reloadhttps://github.com/nodejs/node/pull/11078
Reloadhttps://github.com/nodejs/node/pull/11078
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/11078
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/11078
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/11078#issue-comment-box
umairishaqhttps://github.com/umairishaq
nodejs:masterhttps://github.com/nodejs/node/tree/master
umairishaq:readlinefixhttps://github.com/umairishaq/node/tree/readlinefix
readline: update 6 comparisons to strict https://github.com/nodejs/node/pull/11078#top
umairishaqhttps://github.com/umairishaq
nodejs:masterhttps://github.com/nodejs/node/tree/master
umairishaq:readlinefixhttps://github.com/umairishaq/node/tree/readlinefix
Conversation 6 https://github.com/nodejs/node/pull/11078
Commits 1 https://github.com/nodejs/node/pull/11078/commits
Checks 0 https://github.com/nodejs/node/pull/11078/checks
Files changed https://github.com/nodejs/node/pull/11078/files
Please reload this pagehttps://github.com/nodejs/node/pull/11078
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/umairishaq
umairishaqhttps://github.com/umairishaq
Jan 31, 2017https://github.com/nodejs/node/pull/11078#issue-204210708
Please reload this pagehttps://github.com/nodejs/node/pull/11078
https://github.com/umairishaq
readline: update 6 comparions to stricthttps://github.com/nodejs/node/pull/11078/commits/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
79f9fcahttps://github.com/nodejs/node/pull/11078/commits/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Jan 31, 2017https://github.com/nodejs/node/pull/11078#event-942541105
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 31, 2017 https://github.com/nodejs/node/pull/11078#pullrequestreview-19249713
View reviewed changes https://github.com/nodejs/node/pull/11078/files/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 31, 2017 https://github.com/nodejs/node/pull/11078#pullrequestreview-19264278
View reviewed changes https://github.com/nodejs/node/pull/11078/files/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
https://github.com/hiroppy
hiroppyhttps://github.com/hiroppy
Jan 31, 2017https://github.com/nodejs/node/pull/11078#issuecomment-276361383
https://ci.nodejs.org/job/node-test-pull-request/6119/https://ci.nodejs.org/job/node-test-pull-request/6119/
Please reload this pagehttps://github.com/nodejs/node/pull/11078
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 31, 2017https://github.com/nodejs/node/pull/11078#issuecomment-276363310
Windows failureshttps://ci.nodejs.org/job/node-compile-windows/6687/label=win-vcbt2015/console
@Fishrock123https://github.com/Fishrock123
@zkathttps://github.com/zkat
Please reload this pagehttps://github.com/nodejs/node/pull/11078
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 31, 2017https://github.com/nodejs/node/pull/11078#event-943439294
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 31, 2017 https://github.com/nodejs/node/pull/11078#pullrequestreview-19371707
View reviewed changes https://github.com/nodejs/node/pull/11078/files/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
https://github.com/targos
targoshttps://github.com/targos
Jan 31, 2017 https://github.com/nodejs/node/pull/11078#pullrequestreview-19375231
View reviewed changes https://github.com/nodejs/node/pull/11078/files/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 31, 2017 https://github.com/nodejs/node/pull/11078#pullrequestreview-19383635
View reviewed changes https://github.com/nodejs/node/pull/11078/files/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 31, 2017https://github.com/nodejs/node/pull/11078#issuecomment-276445394
#11085https://github.com/nodejs/node/pull/11085
Please reload this pagehttps://github.com/nodejs/node/pull/11078
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 31, 2017https://github.com/nodejs/node/pull/11078#issuecomment-276451028
#11085https://github.com/nodejs/node/pull/11085
https://ci.nodejs.org/job/node-test-commit-windows-fanned/6795/https://ci.nodejs.org/job/node-test-commit-windows-fanned/6795/
Please reload this pagehttps://github.com/nodejs/node/pull/11078
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 31, 2017https://github.com/nodejs/node/pull/11078#issuecomment-276452847
https://ci.nodejs.org/job/node-test-commit-windows-fanned/6796/https://ci.nodejs.org/job/node-test-commit-windows-fanned/6796/
Please reload this pagehttps://github.com/nodejs/node/pull/11078
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 4, 2017https://github.com/nodejs/node/pull/11078#issuecomment-277422707
b869ecahttps://github.com/nodejs/node/commit/b869ecaacfdd218e1920f1545a88a4304efd0288
Please reload this pagehttps://github.com/nodejs/node/pull/11078
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 4, 2017https://github.com/nodejs/node/pull/11078#event-949025043
addaleaxhttps://github.com/addaleax
Feb 4, 2017 https://github.com/nodejs/node/pull/11078#ref-commit-b869eca
https://github.com/umairishaq
https://github.com/addaleax
readline: update 6 comparions to stricthttps://github.com/nodejs/node/commit/b869ecaacfdd218e1920f1545a88a4304efd0288
b869ecahttps://github.com/nodejs/node/commit/b869ecaacfdd218e1920f1545a88a4304efd0288
#11078https://github.com/nodejs/node/pull/11078
italoacasashttps://github.com/italoacasas
Feb 5, 2017 https://github.com/nodejs/node/pull/11078#ref-commit-edc689d
https://github.com/umairishaq
readline: update 6 comparions to stricthttps://github.com/italoacasas/node/commit/edc689d328c31643da9d612300a802225d93036b
edc689dhttps://github.com/italoacasas/node/commit/edc689d328c31643da9d612300a802225d93036b
nodejs#11078https://github.com/nodejs/node/pull/11078
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Feb 5, 2017 https://github.com/nodejs/node/pull/11078#ref-pullrequest-205450090
Proposal - 7.6.0 (Current) #11185 https://github.com/nodejs/node/pull/11185
italoacasashttps://github.com/italoacasas
Feb 14, 2017 https://github.com/nodejs/node/pull/11078#ref-commit-6a45c81
https://github.com/umairishaq
readline: update 6 comparions to stricthttps://github.com/italoacasas/node/commit/6a45c81edd26f6639f47ddf9a452e21e71e9976c
6a45c81https://github.com/italoacasas/node/commit/6a45c81edd26f6639f47ddf9a452e21e71e9976c
nodejs#11078https://github.com/nodejs/node/pull/11078
krydoshttps://github.com/krydos
Feb 25, 2017 https://github.com/nodejs/node/pull/11078#ref-commit-cdbd878
https://github.com/umairishaq
https://github.com/krydos
readline: update 6 comparions to stricthttps://github.com/krydos/node/commit/cdbd8784de4f8adac61404933cccc1002662a1cd
cdbd878https://github.com/krydos/node/commit/cdbd8784de4f8adac61404933cccc1002662a1cd
nodejs#11078https://github.com/nodejs/node/pull/11078
jasnellhttps://github.com/jasnell
Mar 7, 2017 https://github.com/nodejs/node/pull/11078#ref-commit-d1375ad
https://github.com/umairishaq
https://github.com/jasnell
readline: update 6 comparions to stricthttps://github.com/nodejs/node/commit/d1375ad9eff171d39bc80399b7b1d2bd08a6c5d5
d1375adhttps://github.com/nodejs/node/commit/d1375ad9eff171d39bc80399b7b1d2bd08a6c5d5
#11078https://github.com/nodejs/node/pull/11078
jasnellhttps://github.com/jasnell
Mar 7, 2017 https://github.com/nodejs/node/pull/11078#ref-commit-92e2767
https://github.com/umairishaq
https://github.com/jasnell
readline: update 6 comparions to stricthttps://github.com/nodejs/node/commit/92e2767579f527349df54e817d84b7423b699f28
92e2767https://github.com/nodejs/node/commit/92e2767579f527349df54e817d84b7423b699f28
#11078https://github.com/nodejs/node/pull/11078
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11078#ref-commit-f7c6ad2
https://github.com/umairishaq
https://github.com/MylesBorins
readline: update 6 comparions to stricthttps://github.com/nodejs/node/commit/f7c6ad2df9d14cc7285282defe2c5abf02f15526
f7c6ad2https://github.com/nodejs/node/commit/f7c6ad2df9d14cc7285282defe2c5abf02f15526
#11078https://github.com/nodejs/node/pull/11078
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11078#ref-pullrequest-212909365
v6.10.1 proposal #11759 https://github.com/nodejs/node/pull/11759
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11078#ref-commit-a40f842
https://github.com/umairishaq
https://github.com/MylesBorins
readline: update 6 comparions to stricthttps://github.com/nodejs/node/commit/a40f8429e6ef51cb89eaa2bfab751c3594e66d19
a40f842https://github.com/nodejs/node/commit/a40f8429e6ef51cb89eaa2bfab751c3594e66d19
#11078https://github.com/nodejs/node/pull/11078
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11078#ref-pullrequest-212910576
v4.8.1 proposal #11760 https://github.com/nodejs/node/pull/11760
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 28, 2017 https://github.com/nodejs/node/pull/11078#ref-issue-216961042
Suspect memory leak in v6.10.1 #12033 https://github.com/nodejs/node/issues/12033
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11078
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/11078/files/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/11078/files/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/11078/files/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/11078/files/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/11078/files/79f9fcaabc27eddbe0e4bbbfcdbdc3466cd714bf
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Please reload this pagehttps://github.com/nodejs/node/pull/11078
https://github.com/umairishaq
https://github.com/hiroppy
https://github.com/addaleax
https://github.com/Trott
https://github.com/jasnell
https://github.com/lpinca
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.