René's URL Explorer Experiment


Title: src: fix v8 local handling in node_url.cc by addaleax · Pull Request #11064 · nodejs/node · GitHub

Open Graph Title: src: fix v8 local handling in node_url.cc by addaleax · Pull Request #11064 · nodejs/node

X Title: src: fix v8 local handling in node_url.cc by addaleax · Pull Request #11064 · nodejs/node

Description: Calling .As() on a non-object aborts in debug mode, but node_url.cc relied on it. Address that by using Local until it has been confirmed that the handle actually is an object. Check...

Open Graph Description: Calling .As<Object>() on a non-object aborts in debug mode, but node_url.cc relied on it. Address that by using Local<Value> until it has been confirmed that the handle actually is an o...

X Description: Calling .As&lt;Object&gt;() on a non-object aborts in debug mode, but node_url.cc relied on it. Address that by using Local&lt;Value&gt; until it has been confirmed that the handle ...

Opengraph URL: https://github.com/nodejs/node/pull/11064

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:514c3b6d-399a-5606-3410-665ac8437ded
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB2C6:338071:128B672:19B6E9E:696A9204
html-safe-nonceb3feb681b76372ba3b3feaefe39b0fbc52fcc040d2ec32b0b30e6dba43691ce1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkM2OjMzODA3MToxMjhCNjcyOjE5QjZFOUU6Njk2QTkyMDQiLCJ2aXNpdG9yX2lkIjoiMTYwOTA3OTA0MzYwMTg5NTk0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb269145ac6219018252b34306e3b9299954f4cbaa3452dac93a2701667717bf5
hovercard-subject-tagpull_request:103636107
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11064/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9eda85ad2d793fd29ce64602ce0fcb3ab904b99c22e6e09c2c2d815aeda4a595/nodejs/node/pull/11064
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9eda85ad2d793fd29ce64602ce0fcb3ab904b99c22e6e09c2c2d815aeda4a595/nodejs/node/pull/11064
og:image:altCalling .As<Object>() on a non-object aborts in debug mode, but node_url.cc relied on it. Address that by using Local<Value> until it has been confirmed that the handle actually is an o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/11064#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11064
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11064
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/11064
Reloadhttps://github.com/nodejs/node/pull/11064
Reloadhttps://github.com/nodejs/node/pull/11064
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/11064
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/11064
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/11064#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:src-url-debug-modehttps://github.com/addaleax/node/tree/src-url-debug-mode
src: fix v8 local handling in node_url.cc https://github.com/nodejs/node/pull/11064#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:src-url-debug-modehttps://github.com/addaleax/node/tree/src-url-debug-mode
Conversation 4 https://github.com/nodejs/node/pull/11064
Commits 1 https://github.com/nodejs/node/pull/11064/commits
Checks 0 https://github.com/nodejs/node/pull/11064/checks
Files changed https://github.com/nodejs/node/pull/11064/files
Please reload this pagehttps://github.com/nodejs/node/pull/11064
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 29, 2017https://github.com/nodejs/node/pull/11064#issue-203852138
Please reload this pagehttps://github.com/nodejs/node/pull/11064
https://ci.nodejs.org/job/node-test-commit/7535/https://ci.nodejs.org/job/node-test-commit/7535/
Please reload this pagehttps://github.com/nodejs/node/pull/11064
https://github.com/addaleax
src: fix v8 local handling in node_url.cchttps://github.com/nodejs/node/pull/11064/commits/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
c02f8echttps://github.com/nodejs/node/pull/11064/commits/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Jan 29, 2017https://github.com/nodejs/node/pull/11064#event-940460763
https://github.com/targos
targoshttps://github.com/targos
Jan 29, 2017 https://github.com/nodejs/node/pull/11064#pullrequestreview-18987820
View reviewed changes https://github.com/nodejs/node/pull/11064/files/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
https://github.com/targos
targoshttps://github.com/targos
Jan 29, 2017https://github.com/nodejs/node/pull/11064#issuecomment-275899037
Please reload this pagehttps://github.com/nodejs/node/pull/11064
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 29, 2017https://github.com/nodejs/node/pull/11064#issuecomment-275899355
@targoshttps://github.com/targos
#7144https://github.com/nodejs/node/issues/7144
c2c6ae5#commitcomment-20653421https://github.com/nodejs/node/commit/c2c6ae52eaf302da9c106699b69d17c083ced316#commitcomment-20653421
Please reload this pagehttps://github.com/nodejs/node/pull/11064
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jan 29, 2017 https://github.com/nodejs/node/pull/11064#pullrequestreview-18988047
View reviewed changes https://github.com/nodejs/node/pull/11064/files/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/11064#pullrequestreview-18988047
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11064
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jan 29, 2017 https://github.com/nodejs/node/pull/11064#pullrequestreview-18988051
View reviewed changes https://github.com/nodejs/node/pull/11064/files/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 29, 2017 https://github.com/nodejs/node/pull/11064#pullrequestreview-18989945
View reviewed changes https://github.com/nodejs/node/pull/11064/files/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 29, 2017 https://github.com/nodejs/node/pull/11064#pullrequestreview-18990323
View reviewed changes https://github.com/nodejs/node/pull/11064/files/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 30, 2017 https://github.com/nodejs/node/pull/11064#pullrequestreview-19139628
View reviewed changes https://github.com/nodejs/node/pull/11064/files/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
jasnellhttps://github.com/jasnell
Jan 30, 2017 https://github.com/nodejs/node/pull/11064#ref-commit-0d290a2
https://github.com/addaleax
https://github.com/jasnell
src: fix v8 local handling in node_url.cchttps://github.com/nodejs/node/commit/0d290a2ae01846e9628e90e1d37ccf18aba1ecb4
0d290a2https://github.com/nodejs/node/commit/0d290a2ae01846e9628e90e1d37ccf18aba1ecb4
#11064https://github.com/nodejs/node/pull/11064
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 30, 2017https://github.com/nodejs/node/pull/11064#issuecomment-276132508
0d290a2https://github.com/nodejs/node/commit/0d290a2ae01846e9628e90e1d37ccf18aba1ecb4
Please reload this pagehttps://github.com/nodejs/node/pull/11064
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 30, 2017https://github.com/nodejs/node/pull/11064#event-941753025
evanlucashttps://github.com/evanlucas
Jan 31, 2017 https://github.com/nodejs/node/pull/11064#ref-commit-a24264e
https://github.com/addaleax
https://github.com/evanlucas
src: fix v8 local handling in node_url.cchttps://github.com/nodejs/node/commit/a24264eb18962a1fdbc5a4d10fd7bcf65a401a54
a24264ehttps://github.com/nodejs/node/commit/a24264eb18962a1fdbc5a4d10fd7bcf65a401a54
#11064https://github.com/nodejs/node/pull/11064
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 31, 2017 https://github.com/nodejs/node/pull/11064#ref-pullrequest-203846723
v7.5.0 proposal #11062 https://github.com/nodejs/node/pull/11062
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11064
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/11064/files/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/11064/files/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/11064/files/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/11064/files/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/11064/files/c02f8ec09cdb65cddf0d3a5bed29578741b5084d
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Please reload this pagehttps://github.com/nodejs/node/pull/11064
https://github.com/addaleax
https://github.com/targos
https://github.com/jasnell
https://github.com/bnoordhuis
https://github.com/TimothyGu
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.