| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ca2493c3-88ae-9179-ec7b-db16c4e2700f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E988:34E8DF:59ACF1:7DF212:696A0FAB |
| html-safe-nonce | ef394220a498fc882471b03d26b3ebafa467fc498cadb2996e3afb0e66417d88 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTg4OjM0RThERjo1OUFDRjE6N0RGMjEyOjY5NkEwRkFCIiwidmlzaXRvcl9pZCI6IjM4NzAzODEzNDM1ODA0OTE2OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 55914a3eda77ec0e21796cbf75fc0bfa81aa2a8ec8405e9d5ad71af6ac05021a |
| hovercard-subject-tag | pull_request:103634337 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11063/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7148fc8e65d31892de7effa173e29ae7397e3af45d06f25f5137329642d3caf8/nodejs/node/pull/11063 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7148fc8e65d31892de7effa173e29ae7397e3af45d06f25f5137329642d3caf8/nodejs/node/pull/11063 |
| og:image:alt | Add a test when the argument is empty.
Adjust the position of the comment.
Make use of Arrow Function, Template Literals and Array.from.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hiroppy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/11063#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11063 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11063 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/11063 |
| Reload | https://github.com/nodejs/node/pull/11063 |
| Reload | https://github.com/nodejs/node/pull/11063 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/11063 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
698
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/11063 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/11063#issue-comment-box |
| hiroppy | https://github.com/hiroppy |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hiroppy:feature/test-path | https://github.com/hiroppy/node/tree/feature/test-path |
|
test: add path.join's test
| https://github.com/nodejs/node/pull/11063#top |
| hiroppy | https://github.com/hiroppy |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hiroppy:feature/test-path | https://github.com/hiroppy/node/tree/feature/test-path |
|
Conversation
3
| https://github.com/nodejs/node/pull/11063 |
|
Commits
1
| https://github.com/nodejs/node/pull/11063/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/11063/checks |
|
Files changed
| https://github.com/nodejs/node/pull/11063/files |
| Please reload this page | https://github.com/nodejs/node/pull/11063 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/11063#issue-203848764 |
| Please reload this page | https://github.com/nodejs/node/pull/11063 |
| Please reload this page | https://github.com/nodejs/node/pull/11063 |
|
| https://github.com/hiroppy |
| test: add path.join's test | https://github.com/nodejs/node/pull/11063/commits/adb1b8a67ba75575d8e01a6638542177a5dab5d2 |
| adb1b8a | https://github.com/nodejs/node/pull/11063/commits/adb1b8a67ba75575d8e01a6638542177a5dab5d2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/11063#event-940447531 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
path
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apath |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/11063#event-940448082 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/11063#pullrequestreview-18986667 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11063/files/adb1b8a67ba75575d8e01a6638542177a5dab5d2 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/11063#pullrequestreview-18988256 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11063/files/adb1b8a67ba75575d8e01a6638542177a5dab5d2 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/11063#pullrequestreview-19137277 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11063/files/adb1b8a67ba75575d8e01a6638542177a5dab5d2 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/11063#issuecomment-276128390 |
| https://ci.nodejs.org/job/node-test-pull-request/6110/ | https://ci.nodejs.org/job/node-test-pull-request/6110/ |
| Please reload this page | https://github.com/nodejs/node/pull/11063 |
| hiroppy | https://github.com/hiroppy |
|
Feb 2, 2017
| https://github.com/nodejs/node/pull/11063#ref-commit-81d1559 |
|
| https://github.com/hiroppy |
| test: add path.join's test | https://github.com/nodejs/node/commit/81d15594d7cd08be1990ad6341a3491a34e20d63 |
| 81d1559 | https://github.com/nodejs/node/commit/81d15594d7cd08be1990ad6341a3491a34e20d63 |
| #11063 | https://github.com/nodejs/node/pull/11063 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| Feb 2, 2017 | https://github.com/nodejs/node/pull/11063#issuecomment-276830979 |
| 81d1559 | https://github.com/nodejs/node/commit/81d15594d7cd08be1990ad6341a3491a34e20d63 |
| Please reload this page | https://github.com/nodejs/node/pull/11063 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| Feb 2, 2017 | https://github.com/nodejs/node/pull/11063#event-945721734 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| February 2, 2017 00:43 | https://github.com/nodejs/node/pull/11063#event-945722046 |
| italoacasas | https://github.com/italoacasas |
|
Feb 2, 2017
| https://github.com/nodejs/node/pull/11063#ref-commit-d103088 |
|
| https://github.com/hiroppy |
| test: add path.join's test | https://github.com/italoacasas/node/commit/d103088fc55489df4cd704d1e5fa4ada23bfc044 |
| d103088 | https://github.com/italoacasas/node/commit/d103088fc55489df4cd704d1e5fa4ada23bfc044 |
| nodejs#11063 | https://github.com/nodejs/node/pull/11063 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Feb 5, 2017
| https://github.com/nodejs/node/pull/11063#ref-pullrequest-205450090 |
|
Proposal - 7.6.0 (Current)
#11185
| https://github.com/nodejs/node/pull/11185 |
| italoacasas | https://github.com/italoacasas |
|
Feb 14, 2017
| https://github.com/nodejs/node/pull/11063#ref-commit-ea5bef5 |
|
| https://github.com/hiroppy |
| test: add path.join's test | https://github.com/italoacasas/node/commit/ea5bef5efe08d9056921c6bb2c17f1d9ce5918d4 |
| ea5bef5 | https://github.com/italoacasas/node/commit/ea5bef5efe08d9056921c6bb2c17f1d9ce5918d4 |
| nodejs#11063 | https://github.com/nodejs/node/pull/11063 |
| jasnell | https://github.com/jasnell |
|
Mar 7, 2017
| https://github.com/nodejs/node/pull/11063#ref-commit-e6b2ddd |
|
| https://github.com/hiroppy |
|
| https://github.com/jasnell |
| test: add path.join's test | https://github.com/nodejs/node/commit/e6b2ddd0c683e591e3aaa154ba229280c451b059 |
| e6b2ddd | https://github.com/nodejs/node/commit/e6b2ddd0c683e591e3aaa154ba229280c451b059 |
| #11063 | https://github.com/nodejs/node/pull/11063 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Mar 7, 2017 | https://github.com/nodejs/node/pull/11063#event-990441958 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 7, 2017 | https://github.com/nodejs/node/pull/11063#issuecomment-284880375 |
| Please reload this page | https://github.com/nodejs/node/pull/11063 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/11063#ref-commit-87488ba |
|
| https://github.com/hiroppy |
|
| https://github.com/MylesBorins |
| test: add path.join's test | https://github.com/nodejs/node/commit/87488ba2ff663d6f47d8ef6c3deef350d83d3b06 |
| 87488ba | https://github.com/nodejs/node/commit/87488ba2ff663d6f47d8ef6c3deef350d83d3b06 |
| #11063 | https://github.com/nodejs/node/pull/11063 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/11063#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11063 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/11063/files/adb1b8a67ba75575d8e01a6638542177a5dab5d2 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/11063/files/adb1b8a67ba75575d8e01a6638542177a5dab5d2 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/11063/files/adb1b8a67ba75575d8e01a6638542177a5dab5d2 |
|
path
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apath |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/11063 |
|
| https://github.com/hiroppy |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |