| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:223b090d-9df3-4791-3fcf-8a90a4abc5e4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 96E4:3C747C:26FE75:368400:696A0793 |
| html-safe-nonce | 67f8b8d1b60e2de4d93fb517a582139172254012188481aba616cae63a9c314a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkU0OjNDNzQ3QzoyNkZFNzU6MzY4NDAwOjY5NkEwNzkzIiwidmlzaXRvcl9pZCI6IjgyNTQwODY5NzkwOTUxMjA4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 69d9b5f83bdf76aa9cddfacf3f1c835d41a90533358f93bfeb3ca2f90ecff075 |
| hovercard-subject-tag | pull_request:103607066 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11049/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/61452f3224e68624991b4de0559a6e82d7a62d8dbca95a4b4c2a43601fd09f54/nodejs/node/pull/11049 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/61452f3224e68624991b4de0559a6e82d7a62d8dbca95a4b4c2a43601fd09f54/nodejs/node/pull/11049 |
| og:image:alt | Break up test-url.js into multiple files by the functionality they test against, so they would be easier to compare with their whatwg url counterparts.
Also remove some unecessary eslint-disable ma... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/11049#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11049 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11049 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/11049 |
| Reload | https://github.com/nodejs/node/pull/11049 |
| Reload | https://github.com/nodejs/node/pull/11049 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/11049#issue-comment-box |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:refactor-url-test | https://github.com/joyeecheung/node/tree/refactor-url-test |
|
test, url: break up test-url.js
| https://github.com/nodejs/node/pull/11049#top |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:refactor-url-test | https://github.com/joyeecheung/node/tree/refactor-url-test |
|
Conversation
7
| https://github.com/nodejs/node/pull/11049 |
|
Commits
2
| https://github.com/nodejs/node/pull/11049/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/11049/checks |
|
Files changed
| https://github.com/nodejs/node/pull/11049/files |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Jan 28, 2017 | https://github.com/nodejs/node/pull/11049#issue-203798654 |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jan 28, 2017 | https://github.com/nodejs/node/pull/11049#event-940227131 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl |
| Jan 28, 2017 | https://github.com/nodejs/node/pull/11049#event-940227189 |
|
| https://github.com/joyeecheung |
| url, test: break up test-url.js | https://github.com/nodejs/node/pull/11049/commits/fbab84e78a45d68012d390a8c3e5da8f634cf699 |
| fbab84e | https://github.com/nodejs/node/pull/11049/commits/fbab84e78a45d68012d390a8c3e5da8f634cf699 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/415352d90f64eab1258f62a290c7a99e6a07ebc6..54fbec1d88d3c360da5196ae28f9b2425a2ea8f9 |
| 415352d | https://github.com/nodejs/node/commit/415352d90f64eab1258f62a290c7a99e6a07ebc6 |
| 54fbec1 | https://github.com/nodejs/node/commit/54fbec1d88d3c360da5196ae28f9b2425a2ea8f9 |
|
Compare
| https://github.com/nodejs/node/compare/415352d90f64eab1258f62a290c7a99e6a07ebc6..54fbec1d88d3c360da5196ae28f9b2425a2ea8f9 |
| January 28, 2017 09:53 | https://github.com/nodejs/node/pull/11049#event-940227787 |
|
| https://github.com/joyeecheung |
| test: remove unnecessary eslint-disable max-len | https://github.com/nodejs/node/pull/11049/commits/54fbec1d88d3c360da5196ae28f9b2425a2ea8f9 |
| 54fbec1 | https://github.com/nodejs/node/pull/11049/commits/54fbec1d88d3c360da5196ae28f9b2425a2ea8f9 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/11049#pullrequestreview-18986776 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11049/files/54fbec1d88d3c360da5196ae28f9b2425a2ea8f9 |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/11049#pullrequestreview-18986776 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/11049#issuecomment-275922891 |
| https://ci.nodejs.org/job/node-test-pull-request/6098/ | https://ci.nodejs.org/job/node-test-pull-request/6098/ |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/11049#pullrequestreview-19141670 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11049/files/54fbec1d88d3c360da5196ae28f9b2425a2ea8f9 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/11049#pullrequestreview-19143230 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11049/files/54fbec1d88d3c360da5196ae28f9b2425a2ea8f9 |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/11049#pullrequestreview-19143230 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
| jasnell | https://github.com/jasnell |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/11049#ref-commit-147d2a6 |
|
| https://github.com/joyeecheung |
|
| https://github.com/jasnell |
| url, test: break up test-url.js | https://github.com/nodejs/node/commit/147d2a6419cb1e1dae5f9c2abf04cc21c52e0e0e |
| 147d2a6 | https://github.com/nodejs/node/commit/147d2a6419cb1e1dae5f9c2abf04cc21c52e0e0e |
| #11049 | https://github.com/nodejs/node/pull/11049 |
| jasnell | https://github.com/jasnell |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/11049#ref-commit-7854503 |
|
| https://github.com/joyeecheung |
|
| https://github.com/jasnell |
| test: remove unnecessary eslint-disable max-len | https://github.com/nodejs/node/commit/78545039d65fa24841454f161c3711ce4b5226bc |
| 7854503 | https://github.com/nodejs/node/commit/78545039d65fa24841454f161c3711ce4b5226bc |
| #11049 | https://github.com/nodejs/node/pull/11049 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/11049#issuecomment-276145542 |
| 147d2a6 | https://github.com/nodejs/node/commit/147d2a6419cb1e1dae5f9c2abf04cc21c52e0e0e |
| 7854503 | https://github.com/nodejs/node/commit/78545039d65fa24841454f161c3711ce4b5226bc |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/11049#event-941811181 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 31, 2017 | https://github.com/nodejs/node/pull/11049#event-943646843 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Jan 31, 2017 | https://github.com/nodejs/node/pull/11049#issuecomment-276466051 |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Feb 2, 2017 | https://github.com/nodejs/node/pull/11049#issuecomment-276971156 |
| @evanlucas | https://github.com/evanlucas |
| #9292 | https://github.com/nodejs/node/pull/9292 |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Feb 2, 2017 | https://github.com/nodejs/node/pull/11049#issuecomment-276971487 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| February 19, 2017 17:42 | https://github.com/nodejs/node/pull/11049#event-968383983 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 4, 2017
| https://github.com/nodejs/node/pull/11049#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/11049#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jun 17, 2017 | https://github.com/nodejs/node/pull/11049#event-1127953710 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11049 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/11049/files/54fbec1d88d3c360da5196ae28f9b2425a2ea8f9 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/11049/files/54fbec1d88d3c360da5196ae28f9b2425a2ea8f9 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/11049/files/54fbec1d88d3c360da5196ae28f9b2425a2ea8f9 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl |
| Please reload this page | https://github.com/nodejs/node/pull/11049 |
|
| https://github.com/joyeecheung |
|
| https://github.com/jasnell |
|
| https://github.com/evanlucas |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |