René's URL Explorer Experiment


Title: test: cover thrown errors from exec() kill by cjihrig · Pull Request #11038 · nodejs/node · GitHub

Open Graph Title: test: cover thrown errors from exec() kill by cjihrig · Pull Request #11038 · nodejs/node

X Title: test: cover thrown errors from exec() kill by cjihrig · Pull Request #11038 · nodejs/node

Description: This commit adds code coverage for the scenario where exec() kills a child process, but the call to ChildProcess#kill() throws an exception. Checklist make -j4 test (UNIX), or vcbuild test (Windo...

Open Graph Description: This commit adds code coverage for the scenario where exec() kills a child process, but the call to ChildProcess#kill() throws an exception. Checklist make -j4 test (UNIX), or vcbuild test (Windo...

X Description: This commit adds code coverage for the scenario where exec() kills a child process, but the call to ChildProcess#kill() throws an exception. Checklist make -j4 test (UNIX), or vcbuild test (Windo...

Opengraph URL: https://github.com/nodejs/node/pull/11038

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:956bf4e6-e37d-80a8-fbe5-7f31cbfb6fb7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADD2:371600:279EE0:372FAD:696A6643
html-safe-nonce5b601e4c6c8dbe263026e72877280dcadb389f4e32a0ecc1ecdd93f1de7fa86f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREQyOjM3MTYwMDoyNzlFRTA6MzcyRkFEOjY5NkE2NjQzIiwidmlzaXRvcl9pZCI6IjUzNDAxMDg5NTA0NjE3NDI3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac02c350980dadc0e12d7f6988e875e129951508a14c24b731f21bc5e842b63f56
hovercard-subject-tagpull_request:103559100
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11038/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/525d4554523b2c2b055559b151379c3cbfb4334f528d3b3fb894063cc068df72/nodejs/node/pull/11038
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/525d4554523b2c2b055559b151379c3cbfb4334f528d3b3fb894063cc068df72/nodejs/node/pull/11038
og:image:altThis commit adds code coverage for the scenario where exec() kills a child process, but the call to ChildProcess#kill() throws an exception. Checklist make -j4 test (UNIX), or vcbuild test (Windo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef2d9f6432a5a115ec709295ae70623f33bb80aee
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/11038#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11038
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11038
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/11038
Reloadhttps://github.com/nodejs/node/pull/11038
Reloadhttps://github.com/nodejs/node/pull/11038
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/11038
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/11038
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/11038#issue-comment-box
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:coveragehttps://github.com/cjihrig/node/tree/coverage
test: cover thrown errors from exec() kill https://github.com/nodejs/node/pull/11038#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:coveragehttps://github.com/cjihrig/node/tree/coverage
Conversation 12 https://github.com/nodejs/node/pull/11038
Commits 1 https://github.com/nodejs/node/pull/11038/commits
Checks 0 https://github.com/nodejs/node/pull/11038/checks
Files changed https://github.com/nodejs/node/pull/11038/files
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 27, 2017https://github.com/nodejs/node/pull/11038#issue-203729677
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Jan 27, 2017https://github.com/nodejs/node/pull/11038#event-939844834
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 27, 2017 https://github.com/nodejs/node/pull/11038#pullrequestreview-18924824
View reviewed changes https://github.com/nodejs/node/pull/11038/files
test/parallel/test-child-process-exec-kill-throws.jshttps://github.com/nodejs/node/pull/11038/files#diff-e7ab0eb3a40d6800f610fed81c6ab1d0afe677e30a55653523c60e32278b4066
lpincahttps://github.com/lpinca
Jan 27, 2017https://github.com/nodejs/node/pull/11038#discussion_r98284257
Please reload this pagehttps://github.com/nodejs/node/pull/11038
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jan 27, 2017 https://github.com/nodejs/node/pull/11038#pullrequestreview-18935512
View reviewed changes https://github.com/nodejs/node/pull/11038/files
test/parallel/test-child-process-exec-kill-throws.jshttps://github.com/nodejs/node/pull/11038/files#diff-e7ab0eb3a40d6800f610fed81c6ab1d0afe677e30a55653523c60e32278b4066
sam-githubhttps://github.com/sam-github
Jan 27, 2017https://github.com/nodejs/node/pull/11038#discussion_r98293941
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11038
cjihrighttps://github.com/cjihrig
Jan 27, 2017https://github.com/nodejs/node/pull/11038#discussion_r98296516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
thishttps://github.com/nodejs/node/blob/3268863ebc40d1f0beee61b044c492b43fa57fa5/lib/child_process.js#L262-L267
Please reload this pagehttps://github.com/nodejs/node/pull/11038
sam-githubhttps://github.com/sam-github
Jan 27, 2017https://github.com/nodejs/node/pull/11038#discussion_r98300413
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/lib/child_process.jshttps://github.com/nodejs/node/blob/3268863ebc40d1f0beee61b044c492b43fa57fa5/lib/child_process.js#L265
3268863https://github.com/nodejs/node/commit/3268863ebc40d1f0beee61b044c492b43fa57fa5
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jan 27, 2017 https://github.com/nodejs/node/pull/11038#pullrequestreview-18942808
View reviewed changes https://github.com/nodejs/node/pull/11038/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 27, 2017 https://github.com/nodejs/node/pull/11038#pullrequestreview-18944141
View reviewed changes https://github.com/nodejs/node/pull/11038/files
https://github.com/cjihrig
test: cover thrown errors from exec() killhttps://github.com/nodejs/node/pull/11038/commits/a514264f8805a8797685b46fc8fb126ee82f95b8
a514264https://github.com/nodejs/node/pull/11038/commits/a514264f8805a8797685b46fc8fb126ee82f95b8
nodejs#11038https://github.com/nodejs/node/pull/11038
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/6e228fceca4aa0dc89002488930a294de866f2d5..a514264f8805a8797685b46fc8fb126ee82f95b8
6e228fchttps://github.com/nodejs/node/commit/6e228fceca4aa0dc89002488930a294de866f2d5
a514264https://github.com/nodejs/node/commit/a514264f8805a8797685b46fc8fb126ee82f95b8
Compare https://github.com/nodejs/node/compare/6e228fceca4aa0dc89002488930a294de866f2d5..a514264f8805a8797685b46fc8fb126ee82f95b8
January 30, 2017 16:07https://github.com/nodejs/node/pull/11038#event-941579420
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Jan 30, 2017https://github.com/nodejs/node/pull/11038#event-941579595
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 30, 2017https://github.com/nodejs/node/pull/11038#issuecomment-276104661
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://ci.nodejs.org/job/node-test-pull-request/6104/https://ci.nodejs.org/job/node-test-pull-request/6104/
https://ci.nodejs.org/job/node-test-pull-request/6342/https://ci.nodejs.org/job/node-test-pull-request/6342/
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 10, 2017 https://github.com/nodejs/node/pull/11038#ref-pullrequest-206702835
test: improve child_process test coverage #11278 https://github.com/nodejs/node/pull/11278
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 10, 2017https://github.com/nodejs/node/pull/11038#issuecomment-279094051
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 17, 2017https://github.com/nodejs/node/pull/11038#issuecomment-280517927
https://ci.nodejs.org/job/node-test-pull-request/6461/https://ci.nodejs.org/job/node-test-pull-request/6461/
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Mar 26, 2017 https://github.com/nodejs/node/pull/11038#pullrequestreview-29066921
View reviewed changes https://github.com/nodejs/node/pull/11038/files/a514264f8805a8797685b46fc8fb126ee82f95b8
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Mar 26, 2017https://github.com/nodejs/node/pull/11038#issuecomment-289271346
9ac363bhttps://github.com/nodejs/node/commit/9ac363b5d65e02bc4b5d86b28e8b6dc232dcaa8d
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Mar 26, 2017https://github.com/nodejs/node/pull/11038#event-1015631265
fhinkelhttps://github.com/fhinkel
Mar 26, 2017 https://github.com/nodejs/node/pull/11038#ref-commit-9ac363b
https://github.com/cjihrig
https://github.com/fhinkel
test: cover thrown errors from exec() killhttps://github.com/nodejs/node/commit/9ac363b5d65e02bc4b5d86b28e8b6dc232dcaa8d
9ac363bhttps://github.com/nodejs/node/commit/9ac363b5d65e02bc4b5d86b28e8b6dc232dcaa8d
#11038https://github.com/nodejs/node/pull/11038
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
March 26, 2017 12:04https://github.com/nodejs/node/pull/11038#event-1015655157
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 26, 2017https://github.com/nodejs/node/pull/11038#issuecomment-289278889
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 26, 2017https://github.com/nodejs/node/pull/11038#issuecomment-289292165
https://ci.nodejs.org/job/node-stress-single-test/1141/https://ci.nodejs.org/job/node-stress-single-test/1141/
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 26, 2017https://github.com/nodejs/node/pull/11038#issuecomment-289313640
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 26, 2017 https://github.com/nodejs/node/pull/11038#ref-pullrequest-216992118
test: fix broken tests in test-buffer-includes #12040 https://github.com/nodejs/node/pull/12040
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 26, 2017https://github.com/nodejs/node/pull/11038#issuecomment-289321447
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 26, 2017 https://github.com/nodejs/node/pull/11038#ref-issue-217095914
Fix flaky parallel/test-child-process-exec-kill-throws #12053 https://github.com/nodejs/node/issues/12053
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 26, 2017 https://github.com/nodejs/node/pull/11038#ref-pullrequest-217096226
test: mark child-process-exec-kill-throws flaky #12054 https://github.com/nodejs/node/pull/12054
gibfahnhttps://github.com/gibfahn
Mar 27, 2017 https://github.com/nodejs/node/pull/11038#ref-commit-66e7dc5
https://github.com/gibfahn
test: mark child-process-exec-kill-throws flakyhttps://github.com/gibfahn/node/commit/66e7dc558705edb0f473c4df902e9e407a2896c4
66e7dc5https://github.com/gibfahn/node/commit/66e7dc558705edb0f473c4df902e9e407a2896c4
nodejs#12054https://github.com/nodejs/node/pull/12054
nodejs#12053https://github.com/nodejs/node/issues/12053
nodejs#11038https://github.com/nodejs/node/pull/11038
MylesBorinshttps://github.com/MylesBorins
Mar 28, 2017 https://github.com/nodejs/node/pull/11038#ref-commit-41284fb
https://github.com/cjihrig
https://github.com/MylesBorins
test: cover thrown errors from exec() killhttps://github.com/nodejs/node/commit/41284fbc5bc0d25d6fb2710e0fd6b3c475dd87ee
41284fbhttps://github.com/nodejs/node/commit/41284fbc5bc0d25d6fb2710e0fd6b3c475dd87ee
#11038https://github.com/nodejs/node/pull/11038
MylesBorinshttps://github.com/MylesBorins
Mar 28, 2017 https://github.com/nodejs/node/pull/11038#ref-commit-8b2b93f
https://github.com/gibfahn
https://github.com/MylesBorins
test: mark child-process-exec-kill-throws flakyhttps://github.com/nodejs/node/commit/8b2b93f148bf5a96b6af83921907152ce97d2ba5
8b2b93fhttps://github.com/nodejs/node/commit/8b2b93f148bf5a96b6af83921907152ce97d2ba5
#12054https://github.com/nodejs/node/pull/12054
#12053https://github.com/nodejs/node/issues/12053
#11038https://github.com/nodejs/node/pull/11038
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 28, 2017 https://github.com/nodejs/node/pull/11038#ref-pullrequest-217725272
V7.8.0 proposal #12104 https://github.com/nodejs/node/pull/12104
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 29, 2017 https://github.com/nodejs/node/pull/11038#ref-pullrequest-217771653
test: fix flaky child-process-exec-kill-throws #12111 https://github.com/nodejs/node/pull/12111
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Apr 10, 2017 https://github.com/nodejs/node/pull/11038#ref-pullrequest-220788961
v7.9.0 Release Proposal #12319 https://github.com/nodejs/node/pull/12319
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
May 8, 2017https://github.com/nodejs/node/pull/11038#event-1073006482
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
May 15, 2017https://github.com/nodejs/node/pull/11038#event-1082502724
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
baking-for-lts https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts
Aug 17, 2018https://github.com/nodejs/node/pull/11038#event-1795358294
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11038
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/11038/files/6e228fceca4aa0dc89002488930a294de866f2d5
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/11038/files/a514264f8805a8797685b46fc8fb126ee82f95b8
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/11038/files/6e228fceca4aa0dc89002488930a294de866f2d5
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/11038/files/6e228fceca4aa0dc89002488930a294de866f2d5
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/11038
https://github.com/cjihrig
https://github.com/jasnell
https://github.com/fhinkel
https://github.com/gibfahn
https://github.com/sam-github
https://github.com/lpinca
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.