| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ca0cb04d-9ac6-ef5c-e07c-598ff0b5d0c5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECD6:106A75:2CF990:3F5BFC:696A07C4 |
| html-safe-nonce | a78bcc2c680b7101fdf45717ab96b8ceb1bab6e26b540264935a7f19ea328ec8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0Q2OjEwNkE3NToyQ0Y5OTA6M0Y1QkZDOjY5NkEwN0M0IiwidmlzaXRvcl9pZCI6IjExMjkyODUyODc3MzMyMzM2MDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3edfba7f75aafb8f290b30ad007119417ba2b121fed055017a81e68ac800173a |
| hovercard-subject-tag | pull_request:102722909 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10964/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2a037ff56595e9dd9542fcd80b274bb447da7441490bc3012a67771bc49108c4/nodejs/node/pull/10964 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2a037ff56595e9dd9542fcd80b274bb447da7441490bc3012a67771bc49108c4/nodejs/node/pull/10964 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines
Affected core subsystem(s)
test |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DavidCai1111 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10964#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10964 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10964 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10964 |
| Reload | https://github.com/nodejs/node/pull/10964 |
| Reload | https://github.com/nodejs/node/pull/10964 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10964#issue-comment-box |
| DavidCai1111 | https://github.com/DavidCai1111 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| DavidCai1111:master | https://github.com/DavidCai1111/node/tree/master |
|
test: increase coverage of internal/util
| https://github.com/nodejs/node/pull/10964#top |
| DavidCai1111 | https://github.com/DavidCai1111 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| DavidCai1111:master | https://github.com/DavidCai1111/node/tree/master |
|
Conversation
11
| https://github.com/nodejs/node/pull/10964 |
|
Commits
1
| https://github.com/nodejs/node/pull/10964/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10964/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10964/files |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/DavidCai1111 |
| DavidCai1111 | https://github.com/DavidCai1111 |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10964#issue-202539896 |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10964#event-932835067 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10964#pullrequestreview-17927272 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10964/files |
| test/parallel/test-internal-util-assertCrypto.js | https://github.com/nodejs/node/pull/10964/files#diff-0658baf417c3d2102a0a4befb09d05f8cc69221188bf053f5ab8e8faa05c55af |
| cjihrig | https://github.com/cjihrig |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10964#discussion_r97322320 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10964#pullrequestreview-17927371 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10964/files |
| test/parallel/test-internal-util-assertCrypto.js | https://github.com/nodejs/node/pull/10964/files#diff-0658baf417c3d2102a0a4befb09d05f8cc69221188bf053f5ab8e8faa05c55af |
| cjihrig | https://github.com/cjihrig |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10964#discussion_r97322408 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10964#pullrequestreview-17927507 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10964/files |
| test/parallel/test-internal-util-assertCrypto.js | https://github.com/nodejs/node/pull/10964/files#diff-0658baf417c3d2102a0a4befb09d05f8cc69221188bf053f5ab8e8faa05c55af |
| cjihrig | https://github.com/cjihrig |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10964#discussion_r97322541 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
|
| https://github.com/davidtaikocha |
| test: increase coverage of internal/util | https://github.com/nodejs/node/pull/10964/commits/74ddde4c76b2934da1aa036281d351c19273d852 |
| 74ddde4 | https://github.com/nodejs/node/pull/10964/commits/74ddde4c76b2934da1aa036281d351c19273d852 |
| https://github.com/DavidCai1111 |
| DavidCai1111 | https://github.com/DavidCai1111 |
| force-pushed | https://github.com/nodejs/node/compare/cc6b7da6edb90b947d1810b664ba22b79d58791f..74ddde4c76b2934da1aa036281d351c19273d852 |
| cc6b7da | https://github.com/nodejs/node/commit/cc6b7da6edb90b947d1810b664ba22b79d58791f |
| 74ddde4 | https://github.com/nodejs/node/commit/74ddde4c76b2934da1aa036281d351c19273d852 |
|
Compare
| https://github.com/nodejs/node/compare/cc6b7da6edb90b947d1810b664ba22b79d58791f..74ddde4c76b2934da1aa036281d351c19273d852 |
| January 23, 2017 14:11 | https://github.com/nodejs/node/pull/10964#event-932857996 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10964#event-932858120 |
| https://github.com/DavidCai1111 |
| DavidCai1111 | https://github.com/DavidCai1111 |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10964#issuecomment-274497638 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10964#event-932884823 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10964#pullrequestreview-17973984 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10964/files/74ddde4c76b2934da1aa036281d351c19273d852 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10964#pullrequestreview-17985971 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10964/files/74ddde4c76b2934da1aa036281d351c19273d852 |
| test/parallel/test-internal-util-assertCrypto.js | https://github.com/nodejs/node/pull/10964/files/74ddde4c76b2934da1aa036281d351c19273d852#diff-0658baf417c3d2102a0a4befb09d05f8cc69221188bf053f5ab8e8faa05c55af |
| cjihrig | https://github.com/cjihrig |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10964#discussion_r97378646 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10964#pullrequestreview-17986336 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10964/files/74ddde4c76b2934da1aa036281d351c19273d852 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 29, 2017 | https://github.com/nodejs/node/pull/10964#issuecomment-275896148 |
| https://ci.nodejs.org/job/node-test-commit/7533/ | https://ci.nodejs.org/job/node-test-commit/7533/ |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/10964#issuecomment-276122989 |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| jasnell | https://github.com/jasnell |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10964#ref-commit-a7172b5 |
|
| https://github.com/davidtaikocha |
|
| https://github.com/jasnell |
| test: increase coverage of internal/util | https://github.com/nodejs/node/commit/a7172b5d3cac397f7feb10621038c9187086ed23 |
| a7172b5 | https://github.com/nodejs/node/commit/a7172b5d3cac397f7feb10621038c9187086ed23 |
| #10964 | https://github.com/nodejs/node/pull/10964 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/10964#issuecomment-276124464 |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 30, 2017 | https://github.com/nodejs/node/pull/10964#event-941704149 |
| evanlucas | https://github.com/evanlucas |
|
Jan 31, 2017
| https://github.com/nodejs/node/pull/10964#ref-commit-65691d6 |
|
| https://github.com/davidtaikocha |
|
| https://github.com/evanlucas |
| test: increase coverage of internal/util | https://github.com/nodejs/node/commit/65691d68d5daa0a07f8cd8d2a19d3745bc362d31 |
| 65691d6 | https://github.com/nodejs/node/commit/65691d68d5daa0a07f8cd8d2a19d3745bc362d31 |
| #10964 | https://github.com/nodejs/node/pull/10964 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 31, 2017
| https://github.com/nodejs/node/pull/10964#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| jasnell | https://github.com/jasnell |
|
Mar 7, 2017
| https://github.com/nodejs/node/pull/10964#ref-commit-d462f25 |
|
| https://github.com/davidtaikocha |
|
| https://github.com/jasnell |
| test: increase coverage of internal/util | https://github.com/nodejs/node/commit/d462f253413b09b395e144709e50f8915a16aaaa |
| d462f25 | https://github.com/nodejs/node/commit/d462f253413b09b395e144709e50f8915a16aaaa |
| #10964 | https://github.com/nodejs/node/pull/10964 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10964#issuecomment-284902893 |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10964#issuecomment-284921227 |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/10964#issuecomment-294598476 |
| #11620 | https://github.com/nodejs/node/pull/11620 |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backport-requested-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/10964#event-1045607077 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10964 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10964/files/74ddde4c76b2934da1aa036281d351c19273d852 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/10964/files/74ddde4c76b2934da1aa036281d351c19273d852 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/10964 |
|
| https://github.com/DavidCai1111 |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com/cjihrig |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/davidtaikocha |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |