René's URL Explorer Experiment


Title: test: refactor test-cli-eval.js by cjihrig · Pull Request #10898 · nodejs/node · GitHub

Open Graph Title: test: refactor test-cli-eval.js by cjihrig · Pull Request #10898 · nodejs/node

X Title: test: refactor test-cli-eval.js by cjihrig · Pull Request #10898 · nodejs/node

Description: Add missing common.mustCall(). Isolate tests using block statements where helpful. Cleanup comments. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows comm...

Open Graph Description: Add missing common.mustCall(). Isolate tests using block statements where helpful. Cleanup comments. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows comm...

X Description: Add missing common.mustCall(). Isolate tests using block statements where helpful. Cleanup comments. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows comm...

Opengraph URL: https://github.com/nodejs/node/pull/10898

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9c56853f-7ac3-dcae-82c9-5e49d11a13a0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDDC:181900:E60C1D:13A8159:6969EEFB
html-safe-noncec0d3d152a6b3a97896cad7e499c0249fce74664a2a3a57430734e6a3b0e854cc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERERDOjE4MTkwMDpFNjBDMUQ6MTNBODE1OTo2OTY5RUVGQiIsInZpc2l0b3JfaWQiOiI2OTkyMzE3MjQzMzk1MjcyNDQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb9b915eb2fe3274a96f9d0b72a633c330de49e91d9eccf433bd10652c6a43daf
hovercard-subject-tagpull_request:102291743
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10898/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b9e45a36160a9bff5ae2c72f6ad6d3c91c7e2b9f79bee71e0256d673220353bb/nodejs/node/pull/10898
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b9e45a36160a9bff5ae2c72f6ad6d3c91c7e2b9f79bee71e0256d673220353bb/nodejs/node/pull/10898
og:image:altAdd missing common.mustCall(). Isolate tests using block statements where helpful. Cleanup comments. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows comm...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/10898#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10898
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10898
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/10898
Reloadhttps://github.com/nodejs/node/pull/10898
Reloadhttps://github.com/nodejs/node/pull/10898
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/10898
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/10898
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/10898#issue-comment-box
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:testhttps://github.com/cjihrig/node/tree/test
test: refactor test-cli-eval.js https://github.com/nodejs/node/pull/10898#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:testhttps://github.com/cjihrig/node/tree/test
Conversation 5 https://github.com/nodejs/node/pull/10898
Commits 1 https://github.com/nodejs/node/pull/10898/commits
Checks 0 https://github.com/nodejs/node/pull/10898/checks
Files changed https://github.com/nodejs/node/pull/10898/files
Please reload this pagehttps://github.com/nodejs/node/pull/10898
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 19, 2017https://github.com/nodejs/node/pull/10898#issue-201896493
Please reload this pagehttps://github.com/nodejs/node/pull/10898
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jan 19, 2017https://github.com/nodejs/node/pull/10898#event-929308753
https://github.com/mscdex
mscdexhttps://github.com/mscdex
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 19, 2017https://github.com/nodejs/node/pull/10898#event-929318919
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 19, 2017 https://github.com/nodejs/node/pull/10898#pullrequestreview-17508419
View reviewed changes https://github.com/nodejs/node/pull/10898/files
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/10898#pullrequestreview-17508419
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10898
test/parallel/test-cli-eval.jshttps://github.com/nodejs/node/pull/10898/files#diff-8211d26e5c13b5ffd39149c78557d39f5c6d1aa1849b54f217d1868869c0d5b8
jasnellhttps://github.com/jasnell
Jan 19, 2017https://github.com/nodejs/node/pull/10898#discussion_r96910107
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10898
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 20, 2017 https://github.com/nodejs/node/pull/10898#pullrequestreview-17614779
View reviewed changes https://github.com/nodejs/node/pull/10898/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/10898#pullrequestreview-17614779
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10898
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/c30b3681bd277e20f2cc5f7e6ecd522c8e473f08..31e66889581f94c31f3868c096fe2fe059bad782
c30b368https://github.com/nodejs/node/commit/c30b3681bd277e20f2cc5f7e6ecd522c8e473f08
31e6688https://github.com/nodejs/node/commit/31e66889581f94c31f3868c096fe2fe059bad782
Compare https://github.com/nodejs/node/compare/c30b3681bd277e20f2cc5f7e6ecd522c8e473f08..31e66889581f94c31f3868c096fe2fe059bad782
January 23, 2017 16:17https://github.com/nodejs/node/pull/10898#event-933068398
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 23, 2017https://github.com/nodejs/node/pull/10898#event-933068493
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 23, 2017https://github.com/nodejs/node/pull/10898#issuecomment-274534068
Please reload this pagehttps://github.com/nodejs/node/pull/10898
https://ci.nodejs.org/job/node-test-pull-request/5998/https://ci.nodejs.org/job/node-test-pull-request/5998/
https://ci.nodejs.org/job/node-test-pull-request/6003/https://ci.nodejs.org/job/node-test-pull-request/6003/
https://ci.nodejs.org/job/node-test-pull-request/6005/https://ci.nodejs.org/job/node-test-pull-request/6005/
Please reload this pagehttps://github.com/nodejs/node/pull/10898
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 23, 2017https://github.com/nodejs/node/pull/10898#event-933140725
https://github.com/cjihrig
test: refactor test-cli-eval.jshttps://github.com/nodejs/node/pull/10898/commits/87039e307ed9dde762959da83bfd84cc3cf3e60e
87039e3https://github.com/nodejs/node/pull/10898/commits/87039e307ed9dde762959da83bfd84cc3cf3e60e
nodejs#10898https://github.com/nodejs/node/pull/10898
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/31e66889581f94c31f3868c096fe2fe059bad782..87039e307ed9dde762959da83bfd84cc3cf3e60e
31e6688https://github.com/nodejs/node/commit/31e66889581f94c31f3868c096fe2fe059bad782
87039e3https://github.com/nodejs/node/commit/87039e307ed9dde762959da83bfd84cc3cf3e60e
Compare https://github.com/nodejs/node/compare/31e66889581f94c31f3868c096fe2fe059bad782..87039e307ed9dde762959da83bfd84cc3cf3e60e
January 23, 2017 18:21https://github.com/nodejs/node/pull/10898#event-933267268
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 23, 2017https://github.com/nodejs/node/pull/10898#event-933267364
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
87039e3https://github.com/nodejs/node/commit/87039e307ed9dde762959da83bfd84cc3cf3e60e
Jan 23, 2017https://github.com/nodejs/node/pull/10898#event-933268923
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
January 23, 2017 18:22https://github.com/nodejs/node/pull/10898#event-933269072
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 28, 2017https://github.com/nodejs/node/pull/10898#event-940219942
targoshttps://github.com/targos
Jan 28, 2017 https://github.com/nodejs/node/pull/10898#ref-commit-b8d3cde
https://github.com/cjihrig
https://github.com/targos
test: refactor test-cli-eval.jshttps://github.com/nodejs/node/commit/b8d3cde2f9a49cdab9c4d09d1aab297a43eb6ac5
b8d3cdehttps://github.com/nodejs/node/commit/b8d3cde2f9a49cdab9c4d09d1aab297a43eb6ac5
#10898https://github.com/nodejs/node/pull/10898
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 29, 2017 https://github.com/nodejs/node/pull/10898#ref-pullrequest-203846723
v7.5.0 proposal #11062 https://github.com/nodejs/node/pull/11062
italoacasashttps://github.com/italoacasas
Jan 30, 2017 https://github.com/nodejs/node/pull/10898#ref-commit-efa9845
https://github.com/cjihrig
test: refactor test-cli-eval.jshttps://github.com/italoacasas/node/commit/efa9845946ba7e8e0d2d2fa8e3a5901b47a7cca8
efa9845https://github.com/italoacasas/node/commit/efa9845946ba7e8e0d2d2fa8e3a5901b47a7cca8
nodejs#10898https://github.com/nodejs/node/pull/10898
italoacasashttps://github.com/italoacasas
Jan 30, 2017 https://github.com/nodejs/node/pull/10898#ref-commit-d157b57
https://github.com/cjihrig
test: refactor test-cli-eval.jshttps://github.com/italoacasas/node/commit/d157b578cd26578ac5c786292319cb0c03a275a8
d157b57https://github.com/italoacasas/node/commit/d157b578cd26578ac5c786292319cb0c03a275a8
nodejs#10898https://github.com/nodejs/node/pull/10898
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 8, 2017https://github.com/nodejs/node/pull/10898#issuecomment-285187762
Please reload this pagehttps://github.com/nodejs/node/pull/10898
https://github.com/jasnell
jasnellhttps://github.com/jasnell
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Mar 8, 2017https://github.com/nodejs/node/pull/10898#event-992184389
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Apr 18, 2017https://github.com/nodejs/node/pull/10898#event-1047554086
MylesBorinshttps://github.com/MylesBorins
Apr 18, 2017 https://github.com/nodejs/node/pull/10898#ref-commit-627107a
https://github.com/cjihrig
https://github.com/MylesBorins
test: refactor test-cli-eval.jshttps://github.com/nodejs/node/commit/627107a926bd95b2f530050ff370a1571cdcc2e2
627107ahttps://github.com/nodejs/node/commit/627107a926bd95b2f530050ff370a1571cdcc2e2
#10898https://github.com/nodejs/node/pull/10898
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2017 https://github.com/nodejs/node/pull/10898#ref-commit-2ee2cc6
https://github.com/cjihrig
https://github.com/MylesBorins
test: refactor test-cli-eval.jshttps://github.com/nodejs/node/commit/2ee2cc69078edcebc31220178060c0a513987aad
2ee2cc6https://github.com/nodejs/node/commit/2ee2cc69078edcebc31220178060c0a513987aad
#10898https://github.com/nodejs/node/pull/10898
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2017 https://github.com/nodejs/node/pull/10898#ref-pullrequest-222580733
v6.10.3 proposal #12498 https://github.com/nodejs/node/pull/12498
andrew749https://github.com/andrew749
Jul 19, 2017 https://github.com/nodejs/node/pull/10898#ref-commit-5731206
https://github.com/cjihrig
https://github.com/andrew749
test: refactor test-cli-eval.jshttps://github.com/michielbaird/node/commit/573120690408c2fa7860004292a37394ab0c1103
5731206https://github.com/michielbaird/node/commit/573120690408c2fa7860004292a37394ab0c1103
nodejs/node#10898https://github.com/nodejs/node/pull/10898
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10898
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/10898/files/c30b3681bd277e20f2cc5f7e6ecd522c8e473f08
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/10898/files/c30b3681bd277e20f2cc5f7e6ecd522c8e473f08
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/10898
https://github.com/cjihrig
https://github.com/jasnell
https://github.com/Trott
https://github.com/mscdex
https://github.com/MylesBorins
https://github.com/targos
https://github.com/italoacasas
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.