| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:884af169-c138-0afd-94db-ccfa06ec6753 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DA0C:34359D:11BCFF7:18E8840:696A39CC |
| html-safe-nonce | 78767849316b2ef0a073e489d8ab531701aa7255cc0e18177c325cc06b5524e5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTBDOjM0MzU5RDoxMUJDRkY3OjE4RTg4NDA6Njk2QTM5Q0MiLCJ2aXNpdG9yX2lkIjoiMTU1NDEzNDY4NjYyNTMxNTI3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f8778960eafe771fe784f3322f212449c538e9b1fa3f96227273b06dd6e736ff |
| hovercard-subject-tag | pull_request:101784425 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10844/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/801923a663a4c2bb490aef4231702d1f913de0c84671cfd42c33e4703fae6970/nodejs/node/pull/10844 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/801923a663a4c2bb490aef4231702d1f913de0c84671cfd42c33e4703fae6970/nodejs/node/pull/10844 |
| og:image:alt | Rename test-dns-lookup-cb-error.js to test-dns-lookup.js.
lookup: https://github.com/nodejs/node/blob/master/lib/dns.js#L105.
Coverage: https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/dn... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hiroppy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 13581a31d51edf4a3aca179e10890a4d4f9b6d76 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10844#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10844 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10844 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10844 |
| Reload | https://github.com/nodejs/node/pull/10844 |
| Reload | https://github.com/nodejs/node/pull/10844 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10844#issue-comment-box |
| hiroppy | https://github.com/hiroppy |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hiroppy:feature/modify-test-dns-lookup | https://github.com/hiroppy/node/tree/feature/modify-test-dns-lookup |
|
test: increase coverage of dns-lookup
| https://github.com/nodejs/node/pull/10844#top |
| hiroppy | https://github.com/hiroppy |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hiroppy:feature/modify-test-dns-lookup | https://github.com/hiroppy/node/tree/feature/modify-test-dns-lookup |
|
Conversation
7
| https://github.com/nodejs/node/pull/10844 |
|
Commits
1
| https://github.com/nodejs/node/pull/10844/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10844/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10844/files |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10844#issue-201156486 |
| https://github.com/nodejs/node/blob/master/lib/dns.js#L105 | https://github.com/nodejs/node/blob/master/lib/dns.js#L105 |
| https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/dns.js.html | https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/dns.js.html |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10844#event-925085036 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dns
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10844#event-925095620 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 17, 2017
| https://github.com/nodejs/node/pull/10844#pullrequestreview-16917640 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10844/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 17, 2017
| https://github.com/nodejs/node/pull/10844#pullrequestreview-16946934 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10844/files |
| test/parallel/test-dns-lookup.js | https://github.com/nodejs/node/pull/10844/files#diff-e28a2ccda2524cb0c6137aeecf47c738307ae6844a7724999fc35d0b8e8a9f8e |
| lpinca | https://github.com/lpinca |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10844#discussion_r96368854 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
| hiroppy | https://github.com/hiroppy |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10844#discussion_r96419876 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| force-pushed | https://github.com/nodejs/node/compare/24b1329cd3d5817cee01df6bbd615005939ce2dc..2963c2df99057fea0ac9c23c383192f9c5cd23ac |
| 24b1329 | https://github.com/nodejs/node/commit/24b1329cd3d5817cee01df6bbd615005939ce2dc |
| 2963c2d | https://github.com/nodejs/node/commit/2963c2df99057fea0ac9c23c383192f9c5cd23ac |
|
Compare
| https://github.com/nodejs/node/compare/24b1329cd3d5817cee01df6bbd615005939ce2dc..2963c2df99057fea0ac9c23c383192f9c5cd23ac |
| January 17, 2017 14:12 | https://github.com/nodejs/node/pull/10844#event-925828994 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10844#event-925829114 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 17, 2017
| https://github.com/nodejs/node/pull/10844#pullrequestreview-17005615 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10844/files |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 17, 2017
| https://github.com/nodejs/node/pull/10844#pullrequestreview-17007851 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10844/files |
| test/parallel/test-dns-lookup.js | https://github.com/nodejs/node/pull/10844/files#diff-e28a2ccda2524cb0c6137aeecf47c738307ae6844a7724999fc35d0b8e8a9f8e |
| cjihrig | https://github.com/cjihrig |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10844#discussion_r96427598 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
| hiroppy | https://github.com/hiroppy |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10844#discussion_r96428683 |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 17, 2017
| https://github.com/nodejs/node/pull/10844#pullrequestreview-17008440 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10844/files |
|
| https://github.com/hiroppy |
| test: increase coverage of dns-lookup | https://github.com/nodejs/node/pull/10844/commits/820f71ae988c5a4f778da7d5f838fd78ce943561 |
| 820f71a | https://github.com/nodejs/node/pull/10844/commits/820f71ae988c5a4f778da7d5f838fd78ce943561 |
| https://github.com/nodejs/node/blob/master/lib/dns.js#L105 | https://github.com/nodejs/node/blob/master/lib/dns.js#L105 |
| https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/dns.js.html | https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/dns.js.html |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| force-pushed | https://github.com/nodejs/node/compare/2963c2df99057fea0ac9c23c383192f9c5cd23ac..820f71ae988c5a4f778da7d5f838fd78ce943561 |
| 2963c2d | https://github.com/nodejs/node/commit/2963c2df99057fea0ac9c23c383192f9c5cd23ac |
| 820f71a | https://github.com/nodejs/node/commit/820f71ae988c5a4f778da7d5f838fd78ce943561 |
|
Compare
| https://github.com/nodejs/node/compare/2963c2df99057fea0ac9c23c383192f9c5cd23ac..820f71ae988c5a4f778da7d5f838fd78ce943561 |
| January 17, 2017 14:57 | https://github.com/nodejs/node/pull/10844#event-925906823 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10844#event-925906925 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 17, 2017
| https://github.com/nodejs/node/pull/10844#pullrequestreview-17090226 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10844/files/820f71ae988c5a4f778da7d5f838fd78ce943561 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10844#issuecomment-273294782 |
| https://ci.nodejs.org/job/node-test-pull-request/5914/console | https://ci.nodejs.org/job/node-test-pull-request/5914/console |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 18, 2017 | https://github.com/nodejs/node/pull/10844#event-926937382 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Jan 18, 2017 | https://github.com/nodejs/node/pull/10844#issuecomment-273507787 |
| 48da656 | https://github.com/nodejs/node/commit/48da656b69a79fdbfe65b2dabcd44e349efc90f6 |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Jan 18, 2017 | https://github.com/nodejs/node/pull/10844#event-927642448 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10844#ref-commit-48da656 |
|
| https://github.com/hiroppy |
| test: improving coverage of dns-lookup | https://github.com/nodejs/node/commit/48da656b69a79fdbfe65b2dabcd44e349efc90f6 |
| 48da656 | https://github.com/nodejs/node/commit/48da656b69a79fdbfe65b2dabcd44e349efc90f6 |
| #10844 | https://github.com/nodejs/node/pull/10844 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10844#ref-commit-5288552 |
|
| https://github.com/hiroppy |
| test: improving coverage of dns-lookup | https://github.com/italoacasas/node/commit/528855209c2477ec84a66715ae07c236ceacc295 |
| 5288552 | https://github.com/italoacasas/node/commit/528855209c2477ec84a66715ae07c236ceacc295 |
| nodejs#10844 | https://github.com/nodejs/node/pull/10844 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| January 21, 2017 08:11 | https://github.com/nodejs/node/pull/10844#event-931624608 |
| italoacasas | https://github.com/italoacasas |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10844#ref-commit-54d52aa |
|
| https://github.com/hiroppy |
| test: improving coverage of dns-lookup | https://github.com/italoacasas/node/commit/54d52aa1d0996b90f06392114157d2dfe4c0f560 |
| 54d52aa | https://github.com/italoacasas/node/commit/54d52aa1d0996b90f06392114157d2dfe4c0f560 |
| nodejs#10844 | https://github.com/nodejs/node/pull/10844 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/10844#ref-pullrequest-203011190 |
|
Proposal to update v7.x-staging
#10989
| https://github.com/nodejs/node/pull/10989 |
| targos | https://github.com/targos |
|
Jan 28, 2017
| https://github.com/nodejs/node/pull/10844#ref-commit-de895b0 |
|
| https://github.com/hiroppy |
|
| https://github.com/targos |
| test: improving coverage of dns-lookup | https://github.com/nodejs/node/commit/de895b04b6be1e9fb25237144d7f04968bf8d2ec |
| de895b0 | https://github.com/nodejs/node/commit/de895b04b6be1e9fb25237144d7f04968bf8d2ec |
| #10844 | https://github.com/nodejs/node/pull/10844 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/10844#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10844#ref-commit-c8a069e |
|
| https://github.com/hiroppy |
| test: improving coverage of dns-lookup | https://github.com/italoacasas/node/commit/c8a069e54495cc34ec760bfdc9ae6efe2e791f99 |
| c8a069e | https://github.com/italoacasas/node/commit/c8a069e54495cc34ec760bfdc9ae6efe2e791f99 |
| nodejs#10844 | https://github.com/nodejs/node/pull/10844 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10844#ref-commit-6ac968f |
|
| https://github.com/hiroppy |
| test: improving coverage of dns-lookup | https://github.com/italoacasas/node/commit/6ac968fabbc0e258b6b99858448225510b269878 |
| 6ac968f | https://github.com/italoacasas/node/commit/6ac968fabbc0e258b6b99858448225510b269878 |
| nodejs#10844 | https://github.com/nodejs/node/pull/10844 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10844#event-992141547 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10844#issuecomment-285180249 |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
| jasnell | https://github.com/jasnell |
|
Mar 8, 2017
| https://github.com/nodejs/node/pull/10844#ref-commit-01a43fd |
|
| https://github.com/hiroppy |
|
| https://github.com/jasnell |
| test: improving coverage of dns-lookup | https://github.com/nodejs/node/commit/01a43fdfaf559e8a6329237f6f4b1c18e76ed6cc |
| 01a43fd | https://github.com/nodejs/node/commit/01a43fdfaf559e8a6329237f6f4b1c18e76ed6cc |
| #10844 | https://github.com/nodejs/node/pull/10844 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10844#ref-commit-d766f5e |
|
| https://github.com/hiroppy |
|
| https://github.com/MylesBorins |
| test: improving coverage of dns-lookup | https://github.com/nodejs/node/commit/d766f5e0ad53de667b47cd6bf2b8f69ee3ae4c37 |
| d766f5e | https://github.com/nodejs/node/commit/d766f5e0ad53de667b47cd6bf2b8f69ee3ae4c37 |
| #10844 | https://github.com/nodejs/node/pull/10844 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10844#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
May 19, 2017
| https://github.com/nodejs/node/pull/10844#ref-issue-230043355 |
|
dns.lookup allows a "falsy" hostname, but behaviour is undocumented and appears useless
#13119
| https://github.com/nodejs/node/issues/13119 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10844 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10844/files/24b1329cd3d5817cee01df6bbd615005939ce2dc |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/10844/files/2963c2df99057fea0ac9c23c383192f9c5cd23ac |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/10844/files/2963c2df99057fea0ac9c23c383192f9c5cd23ac |
|
| https://github.com/italoacasas |
|
italoacasas
| https://github.com/italoacasas |
|
| https://github.com/nodejs/node/pull/10844/files/820f71ae988c5a4f778da7d5f838fd78ce943561 |
|
dns
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/10844 |
|
| https://github.com/hiroppy |
|
| https://github.com/italoacasas |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |