René's URL Explorer Experiment


Title: test: Use `common.hasIntl` in tests related to ICU by watilde · Pull Request #10841 · nodejs/node · GitHub

Open Graph Title: test: Use `common.hasIntl` in tests related to ICU by watilde · Pull Request #10841 · nodejs/node

X Title: test: Use `common.hasIntl` in tests related to ICU by watilde · Pull Request #10841 · nodejs/node

Description: We should use common.hasIntl in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little f...

Open Graph Description: We should use common.hasIntl in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little f...

X Description: We should use common.hasIntl in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little f...

Opengraph URL: https://github.com/nodejs/node/pull/10841

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2425e904-f479-00f9-6bc0-ecef8f3bb20c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id854A:9445B:D5609D:127F422:696A8E02
html-safe-nonceeb31b30b5bb9e0353142148e520cccc764e206d6de6d9cadbbc2e30b953aa257
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTRBOjk0NDVCOkQ1NjA5RDoxMjdGNDIyOjY5NkE4RTAyIiwidmlzaXRvcl9pZCI6IjQ0MzcwMjMyOTM4MzkxNTA1OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac330ac58a4f7d9a151ae964a0cafb191d3c96da6549ba46cf93f8a9ab2d20d8ff
hovercard-subject-tagpull_request:101759745
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10841/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0b1752c5cf0517f4b80c0cd7833573cca0118066c7757d107580dbd4f27c0f3f/nodejs/node/pull/10841
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0b1752c5cf0517f4b80c0cd7833573cca0118066c7757d107580dbd4f27c0f3f/nodejs/node/pull/10841
og:image:altWe should use common.hasIntl in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewatilde
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/10841#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10841
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10841
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/10841
Reloadhttps://github.com/nodejs/node/pull/10841
Reloadhttps://github.com/nodejs/node/pull/10841
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/10841
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/10841
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/10841#issue-comment-box
watildehttps://github.com/watilde
nodejs:masterhttps://github.com/nodejs/node/tree/master
watilde:feature/hasIntlhttps://github.com/watilde/node/tree/feature/hasIntl
test: Use common.hasIntl in tests related to ICU https://github.com/nodejs/node/pull/10841#top
watildehttps://github.com/watilde
nodejs:masterhttps://github.com/nodejs/node/tree/master
watilde:feature/hasIntlhttps://github.com/watilde/node/tree/feature/hasIntl
Conversation 8 https://github.com/nodejs/node/pull/10841
Commits 1 https://github.com/nodejs/node/pull/10841/commits
Checks 0 https://github.com/nodejs/node/pull/10841/checks
Files changed https://github.com/nodejs/node/pull/10841/files
Please reload this pagehttps://github.com/nodejs/node/pull/10841
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/watilde
watildehttps://github.com/watilde
Jan 16, 2017https://github.com/nodejs/node/pull/10841#issue-201120742
Please reload this pagehttps://github.com/nodejs/node/pull/10841
#10707 (comment)https://github.com/nodejs/node/pull/10707#discussion_r96273895
Please reload this pagehttps://github.com/nodejs/node/pull/10841
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jan 16, 2017https://github.com/nodejs/node/pull/10841#event-924888064
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 16, 2017 https://github.com/nodejs/node/pull/10841#pullrequestreview-16885569
View reviewed changes https://github.com/nodejs/node/pull/10841/files
test/parallel/test-icu-stringwidth.jshttps://github.com/nodejs/node/pull/10841/files#diff-f6c1d7bea12c6de43e48c7dc702ae270ca20489eda490a2659b01e8121ac3084
cjihrighttps://github.com/cjihrig
Jan 16, 2017https://github.com/nodejs/node/pull/10841#discussion_r96307440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10841
watildehttps://github.com/watilde
Jan 16, 2017https://github.com/nodejs/node/pull/10841#discussion_r96307599
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10841
https://github.com/watilde
test: Use common.hasIntl in tests related to ICUhttps://github.com/nodejs/node/pull/10841/commits/73b533549fb2c186b6c60a3bb6d7fea07605d886
73b5335https://github.com/nodejs/node/pull/10841/commits/73b533549fb2c186b6c60a3bb6d7fea07605d886
nodejs#10707https://github.com/nodejs/node/pull/10707
https://github.com/watilde
watildehttps://github.com/watilde
force-pushedhttps://github.com/nodejs/node/compare/2f1fab9e6bce3ba8c157994172a6a9d1076deec3..73b533549fb2c186b6c60a3bb6d7fea07605d886
2f1fab9https://github.com/nodejs/node/commit/2f1fab9e6bce3ba8c157994172a6a9d1076deec3
73b5335https://github.com/nodejs/node/commit/73b533549fb2c186b6c60a3bb6d7fea07605d886
Compare https://github.com/nodejs/node/compare/2f1fab9e6bce3ba8c157994172a6a9d1076deec3..73b533549fb2c186b6c60a3bb6d7fea07605d886
January 16, 2017 21:34https://github.com/nodejs/node/pull/10841#event-924902927
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 16, 2017https://github.com/nodejs/node/pull/10841#event-924902967
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 16, 2017https://github.com/nodejs/node/pull/10841#event-924917688
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 16, 2017https://github.com/nodejs/node/pull/10841#issuecomment-272970026
https://ci.nodejs.org/job/node-test-pull-request/5898/consolehttps://ci.nodejs.org/job/node-test-pull-request/5898/console
Please reload this pagehttps://github.com/nodejs/node/pull/10841
https://github.com/mscdex
mscdexhttps://github.com/mscdex
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
Jan 16, 2017https://github.com/nodejs/node/pull/10841#event-924928009
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jan 16, 2017 https://github.com/nodejs/node/pull/10841#pullrequestreview-16890225
View reviewed changes https://github.com/nodejs/node/pull/10841/files/73b533549fb2c186b6c60a3bb6d7fea07605d886
test/parallel/test-icu-stringwidth.jshttps://github.com/nodejs/node/pull/10841/files/73b533549fb2c186b6c60a3bb6d7fea07605d886#diff-f6c1d7bea12c6de43e48c7dc702ae270ca20489eda490a2659b01e8121ac3084
mscdexhttps://github.com/mscdex
Jan 16, 2017https://github.com/nodejs/node/pull/10841#discussion_r96311978
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10841
lpincahttps://github.com/lpinca
Jan 17, 2017https://github.com/nodejs/node/pull/10841#discussion_r96365392
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/10841
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 17, 2017 https://github.com/nodejs/node/pull/10841#pullrequestreview-16904738
View reviewed changes https://github.com/nodejs/node/pull/10841/files/73b533549fb2c186b6c60a3bb6d7fea07605d886
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 17, 2017 https://github.com/nodejs/node/pull/10841#pullrequestreview-16904801
View reviewed changes https://github.com/nodejs/node/pull/10841/files/73b533549fb2c186b6c60a3bb6d7fea07605d886
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 17, 2017 https://github.com/nodejs/node/pull/10841#pullrequestreview-16915017
View reviewed changes https://github.com/nodejs/node/pull/10841/files/73b533549fb2c186b6c60a3bb6d7fea07605d886
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 17, 2017 https://github.com/nodejs/node/pull/10841#pullrequestreview-16943489
View reviewed changes https://github.com/nodejs/node/pull/10841/files/73b533549fb2c186b6c60a3bb6d7fea07605d886
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 19, 2017https://github.com/nodejs/node/pull/10841#issuecomment-273702980
https://ci.nodejs.org/job/node-test-pull-request/5942/https://ci.nodejs.org/job/node-test-pull-request/5942/
Please reload this pagehttps://github.com/nodejs/node/pull/10841
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 19, 2017https://github.com/nodejs/node/pull/10841#issuecomment-273709561
71650aahttps://github.com/nodejs/node/commit/71650aa8fc2bdd94bed7982ffb979004b5ef4fae
Please reload this pagehttps://github.com/nodejs/node/pull/10841
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jan 19, 2017https://github.com/nodejs/node/pull/10841#event-928716291
lpincahttps://github.com/lpinca
Jan 19, 2017 https://github.com/nodejs/node/pull/10841#ref-commit-71650aa
https://github.com/watilde
https://github.com/lpinca
test: use common.hasIntl in tests related to ICUhttps://github.com/nodejs/node/commit/71650aa8fc2bdd94bed7982ffb979004b5ef4fae
71650aahttps://github.com/nodejs/node/commit/71650aa8fc2bdd94bed7982ffb979004b5ef4fae
#10707https://github.com/nodejs/node/pull/10707
#10841https://github.com/nodejs/node/pull/10841
https://github.com/watilde
watildehttps://github.com/watilde
January 19, 2017 09:04https://github.com/nodejs/node/pull/10841#event-928763549
italoacasashttps://github.com/italoacasas
Jan 25, 2017 https://github.com/nodejs/node/pull/10841#ref-commit-116a662
https://github.com/watilde
test: use common.hasIntl in tests related to ICUhttps://github.com/italoacasas/node/commit/116a66245cd74e352d3f79e2907ddaa981adf770
116a662https://github.com/italoacasas/node/commit/116a66245cd74e352d3f79e2907ddaa981adf770
nodejs#10707https://github.com/nodejs/node/pull/10707
nodejs#10841https://github.com/nodejs/node/pull/10841
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 25, 2017 https://github.com/nodejs/node/pull/10841#ref-pullrequest-203011190
Proposal to update v7.x-staging #10989 https://github.com/nodejs/node/pull/10989
italoacasashttps://github.com/italoacasas
Jan 27, 2017 https://github.com/nodejs/node/pull/10841#ref-commit-aa8771f
https://github.com/watilde
test: use common.hasIntl in tests related to ICUhttps://github.com/italoacasas/node/commit/aa8771f84204b17adb843518a5814b1afdc6a0c6
aa8771fhttps://github.com/italoacasas/node/commit/aa8771f84204b17adb843518a5814b1afdc6a0c6
nodejs#10707https://github.com/nodejs/node/pull/10707
nodejs#10841https://github.com/nodejs/node/pull/10841
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 29, 2017 https://github.com/nodejs/node/pull/10841#ref-pullrequest-203846723
v7.5.0 proposal #11062 https://github.com/nodejs/node/pull/11062
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Mar 8, 2017https://github.com/nodejs/node/pull/10841#event-990672784
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 8, 2017https://github.com/nodejs/node/pull/10841#issuecomment-284924526
Please reload this pagehttps://github.com/nodejs/node/pull/10841
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10841
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/10841/files/73b533549fb2c186b6c60a3bb6d7fea07605d886
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/10841/files/73b533549fb2c186b6c60a3bb6d7fea07605d886
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/10841/files/73b533549fb2c186b6c60a3bb6d7fea07605d886
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/10841/files/73b533549fb2c186b6c60a3bb6d7fea07605d886
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/10841/files/73b533549fb2c186b6c60a3bb6d7fea07605d886
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/10841
https://github.com/watilde
https://github.com/italoacasas
https://github.com/lpinca
https://github.com/MylesBorins
https://github.com/mscdex
https://github.com/jasnell
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.