| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f252882e-78be-531d-3c90-8fb244be35a3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA12:F5C1C:B5237C:FC60B2:696A1D50 |
| html-safe-nonce | 6dea6ea039017d3c63106264e9f143b33db2653cf2a3d8dbca9a4c510bbc1122 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTEyOkY1QzFDOkI1MjM3QzpGQzYwQjI6Njk2QTFENTAiLCJ2aXNpdG9yX2lkIjoiNjg0OTg2MjExNjAxMzkwNzI4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 21014fa44d67dcb3fe69ac1c3691bf803415cbe8286d8577d2314b4a6f04ece2 |
| hovercard-subject-tag | pull_request:101653886 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10834/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7dd24a907044994a8a370dd9bbda5feede4adde249d79e54aed8447d803036b2/nodejs/node/pull/10834 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7dd24a907044994a8a370dd9bbda5feede4adde249d79e54aed8447d803036b2/nodejs/node/pull/10834 |
| og:image:alt | The exports parameter is unnecessary.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
_tls_legacy, _tls_w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JacksonTian |
| hostname | github.com |
| expected-hostname | github.com |
| None | 014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d515f6f09fa57a93bf90355cb894eb84ca4f458f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10834#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10834 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10834 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10834 |
| Reload | https://github.com/nodejs/node/pull/10834 |
| Reload | https://github.com/nodejs/node/pull/10834 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10834 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
698
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10834 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10834#issue-comment-box |
| JacksonTian | https://github.com/JacksonTian |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| JacksonTian:assert_crypto | https://github.com/JacksonTian/node/tree/assert_crypto |
|
lib: remove unnecessary parameter for assertCrypto()
| https://github.com/nodejs/node/pull/10834#top |
| JacksonTian | https://github.com/JacksonTian |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| JacksonTian:assert_crypto | https://github.com/JacksonTian/node/tree/assert_crypto |
|
Conversation
5
| https://github.com/nodejs/node/pull/10834 |
|
Commits
1
| https://github.com/nodejs/node/pull/10834/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10834/checks |
|
Files changed
6
| https://github.com/nodejs/node/pull/10834/files |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/JacksonTian |
| JacksonTian | https://github.com/JacksonTian |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10834#issue-200966781 |
| Please reload this page | https://github.com/nodejs/node/pull/10834 |
| Please reload this page | https://github.com/nodejs/node/pull/10834 |
|
| https://github.com/JacksonTian |
| lib: remove unnecessary parameter for assertCrypto() | https://github.com/nodejs/node/pull/10834/commits/019faee707ac638c37d894f118432fa1d4cc5e6e |
| 019faee | https://github.com/nodejs/node/pull/10834/commits/019faee707ac638c37d894f118432fa1d4cc5e6e |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10834#event-924010994 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jan 16, 2017
| https://github.com/nodejs/node/pull/10834#pullrequestreview-16813354 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10834/files/019faee707ac638c37d894f118432fa1d4cc5e6e |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 16, 2017
| https://github.com/nodejs/node/pull/10834#pullrequestreview-16817230 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10834/files/019faee707ac638c37d894f118432fa1d4cc5e6e |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10834#issuecomment-272886807 |
| Please reload this page | https://github.com/nodejs/node/pull/10834 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10834#event-924451594 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10834#issuecomment-272893316 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/10834 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 16, 2017
| https://github.com/nodejs/node/pull/10834#pullrequestreview-16830904 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10834/files/019faee707ac638c37d894f118432fa1d4cc5e6e |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/10834#pullrequestreview-16830904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10834 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Jan 16, 2017
| https://github.com/nodejs/node/pull/10834#pullrequestreview-16831278 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10834/files/019faee707ac638c37d894f118432fa1d4cc5e6e |
| https://github.com/JacksonTian |
| JacksonTian | https://github.com/JacksonTian |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10834#issuecomment-272895124 |
| https://ci.nodejs.org/job/node-test-pull-request/5882/ | https://ci.nodejs.org/job/node-test-pull-request/5882/ |
| Please reload this page | https://github.com/nodejs/node/pull/10834 |
| https://github.com/JacksonTian |
| JacksonTian | https://github.com/JacksonTian |
| Jan 18, 2017 | https://github.com/nodejs/node/pull/10834#issuecomment-273371981 |
| 69674f4 | https://github.com/nodejs/node/commit/69674f4d3eb171024d2d6a3c5180f6ba1def6801 |
| Please reload this page | https://github.com/nodejs/node/pull/10834 |
| https://github.com/JacksonTian |
| JacksonTian | https://github.com/JacksonTian |
| Jan 18, 2017 | https://github.com/nodejs/node/pull/10834#event-926865778 |
| https://github.com/JacksonTian |
| JacksonTian | https://github.com/JacksonTian |
| January 18, 2017 03:19 | https://github.com/nodejs/node/pull/10834#event-926865954 |
| JacksonTian | https://github.com/JacksonTian |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10834#ref-commit-69674f4 |
|
| https://github.com/JacksonTian |
| lib: remove unnecessary parameter for assertCrypto() | https://github.com/nodejs/node/commit/69674f4d3eb171024d2d6a3c5180f6ba1def6801 |
| 69674f4 | https://github.com/nodejs/node/commit/69674f4d3eb171024d2d6a3c5180f6ba1def6801 |
| #10834 | https://github.com/nodejs/node/pull/10834 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10834#ref-commit-e2c4986 |
|
| https://github.com/JacksonTian |
| lib: remove unnecessary parameter for assertCrypto() | https://github.com/italoacasas/node/commit/e2c4986771dd0f00c6ed13f16e7a38aceac9a7a9 |
| e2c4986 | https://github.com/italoacasas/node/commit/e2c4986771dd0f00c6ed13f16e7a38aceac9a7a9 |
| nodejs#10834 | https://github.com/nodejs/node/pull/10834 |
| italoacasas | https://github.com/italoacasas |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10834#ref-commit-33e7efb |
|
| https://github.com/JacksonTian |
| lib: remove unnecessary parameter for assertCrypto() | https://github.com/italoacasas/node/commit/33e7efb195d295c7a17d999edd88645280982f0a |
| 33e7efb | https://github.com/italoacasas/node/commit/33e7efb195d295c7a17d999edd88645280982f0a |
| nodejs#10834 | https://github.com/nodejs/node/pull/10834 |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/10834#ref-commit-62e92f4 |
|
| https://github.com/JacksonTian |
| lib: remove unnecessary parameter for assertCrypto() | https://github.com/italoacasas/node/commit/62e92f4f5eb7af811d5dc2df49d57738390825b0 |
| 62e92f4 | https://github.com/italoacasas/node/commit/62e92f4f5eb7af811d5dc2df49d57738390825b0 |
| nodejs#10834 | https://github.com/nodejs/node/pull/10834 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/10834#ref-pullrequest-203011190 |
|
Proposal to update v7.x-staging
#10989
| https://github.com/nodejs/node/pull/10989 |
| italoacasas | https://github.com/italoacasas |
|
Jan 27, 2017
| https://github.com/nodejs/node/pull/10834#ref-commit-a3abba0 |
|
| https://github.com/JacksonTian |
| lib: remove unnecessary parameter for assertCrypto() | https://github.com/italoacasas/node/commit/a3abba0b1a31926260e8ca5dc044c13c93ab5412 |
| a3abba0 | https://github.com/italoacasas/node/commit/a3abba0b1a31926260e8ca5dc044c13c93ab5412 |
| nodejs#10834 | https://github.com/nodejs/node/pull/10834 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/10834#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10834#event-990668427 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 8, 2017
| https://github.com/nodejs/node/pull/10834#ref-commit-670e976 |
|
| https://github.com/JacksonTian |
|
| https://github.com/MylesBorins |
| lib: remove unnecessary parameter for assertCrypto() | https://github.com/nodejs/node/commit/670e976ead96af539cfdd4b9bf01e57e7fb18d37 |
| 670e976 | https://github.com/nodejs/node/commit/670e976ead96af539cfdd4b9bf01e57e7fb18d37 |
| #10834 | https://github.com/nodejs/node/pull/10834 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10834#ref-commit-bde1a7e |
|
| https://github.com/JacksonTian |
|
| https://github.com/MylesBorins |
| lib: remove unnecessary parameter for assertCrypto() | https://github.com/nodejs/node/commit/bde1a7e09e5c41132b69acbb2927e676b28aacf4 |
| bde1a7e | https://github.com/nodejs/node/commit/bde1a7e09e5c41132b69acbb2927e676b28aacf4 |
| #10834 | https://github.com/nodejs/node/pull/10834 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10834#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10834 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10834/files/019faee707ac638c37d894f118432fa1d4cc5e6e |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/10834/files/019faee707ac638c37d894f118432fa1d4cc5e6e |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/10834/files/019faee707ac638c37d894f118432fa1d4cc5e6e |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/10834/files/019faee707ac638c37d894f118432fa1d4cc5e6e |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/10834 |
|
| https://github.com/JacksonTian |
|
| https://github.com/mscdex |
|
| https://github.com/sam-github |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |