René's URL Explorer Experiment


Title: Revert "fs: ensure readFile[Sync] reads from the beginning" by thefourtheye · Pull Request #10809 · nodejs/node · GitHub

Open Graph Title: Revert "fs: ensure readFile[Sync] reads from the beginning" by thefourtheye · Pull Request #10809 · nodejs/node

X Title: Revert "fs: ensure readFile[Sync] reads from the beginning" by thefourtheye · Pull Request #10809 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit 4444e73. Looks like #9699 was landed without a CI Run. It breaks three tests in my Mac OS. /usr/local/opt/python/bin/python2.7 tools/test.py --mode=release -J \ addons docto...

X Description: This reverts commit 4444e73. Looks like #9699 was landed without a CI Run. It breaks three tests in my Mac OS. /usr/local/opt/python/bin/python2.7 tools/test.py --mode=release -J \ addons docto...

Opengraph URL: https://github.com/nodejs/node/pull/10809

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:76c4a7ea-d662-5f26-1203-44b60dd029a3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC920:37E3D3:1D48DBD:2819CEA:6A4F3F4B
html-safe-nonced931ed68f9b8358dd1b0ba3306c3291c1ed243658974b29eb20b0b09417ed037
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTIwOjM3RTNEMzoxRDQ4REJEOjI4MTlDRUE6NkE0RjNGNEIiLCJ2aXNpdG9yX2lkIjoiMTU0NjA0NzA2MTM1ODQ5MzUxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1eeec7b23faaa4c187038e427e26f7d1acd76e6c1038f8cacefcecfbb164e573
hovercard-subject-tagpull_request:101571306
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10809/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cc7a3b8f1938420ec0c491a332e40fb193f4bf20dd7353c06190321b88a4a502/nodejs/node/pull/10809
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cc7a3b8f1938420ec0c491a332e40fb193f4bf20dd7353c06190321b88a4a502/nodejs/node/pull/10809
og:image:altThis reverts commit 4444e73. Looks like #9699 was landed without a CI Run. It breaks three tests in my Mac OS. /usr/local/opt/python/bin/python2.7 tools/test.py --mode=release -J \ addons docto...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamethefourtheye
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/10809#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10809
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10809
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/10809
Reloadhttps://github.com/nodejs/node/pull/10809
Reloadhttps://github.com/nodejs/node/pull/10809
Please reload this pagehttps://github.com/nodejs/node/pull/10809
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/10809
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 971 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
thefourtheyehttps://github.com/thefourtheye
nodejs:masterhttps://github.com/nodejs/node/tree/master
thefourtheye:revert-9699https://github.com/thefourtheye/io.js/tree/revert-9699
Conversationhttps://github.com/nodejs/node/pull/10809
Commits1 (1)https://github.com/nodejs/node/pull/10809/commits
Checkshttps://github.com/nodejs/node/pull/10809/checks
Files changedhttps://github.com/nodejs/node/pull/10809/files
Revert "fs: ensure readFile[Sync] reads from the beginning"https://github.com/nodejs/node/pull/10809#top
thefourtheyehttps://github.com/thefourtheye
nodejs:masterhttps://github.com/nodejs/node/tree/master
thefourtheye:revert-9699https://github.com/thefourtheye/io.js/tree/revert-9699
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Jan 14, 2017https://github.com/nodejs/node/pull/10809#issue-200823574
Please reload this pagehttps://github.com/nodejs/node/pull/10809
4444e73https://github.com/nodejs/node/commit/4444e731f218edf265a0b160bf1d561df2d5e5b3
#9699https://github.com/nodejs/node/pull/9699
@seishunhttps://github.com/seishun
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/thefourtheye
Revert "fs: ensure readFile[Sync] reads from the beginning"https://github.com/nodejs/node/pull/10809/commits/22b1b36f0dbec4462f760652daa77f675e971ef8
22b1b36https://github.com/nodejs/node/pull/10809/commits/22b1b36f0dbec4462f760652daa77f675e971ef8
4444e73https://github.com/thefourtheye/io.js/commit/4444e731f218edf265a0b160bf1d561df2d5e5b3
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 14, 2017https://github.com/nodejs/node/pull/10809#event-923291238
https://github.com/seishun
seishunhttps://github.com/seishun
Jan 14, 2017https://github.com/nodejs/node/pull/10809#issuecomment-272647664
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2017 https://github.com/nodejs/node/pull/10809#pullrequestreview-16700775
View reviewed changes https://github.com/nodejs/node/pull/10809/files/22b1b36f0dbec4462f760652daa77f675e971ef8
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/10809#pullrequestreview-16700775
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2017https://github.com/nodejs/node/pull/10809#issuecomment-272648249
@seishunhttps://github.com/seishun
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2017https://github.com/nodejs/node/pull/10809#issuecomment-272648481
66f09behttps://github.com/nodejs/node/commit/66f09be74399b61a433a58dfe48c6fd5b9d66594
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2017https://github.com/nodejs/node/pull/10809#event-923300039
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
January 14, 2017 19:51https://github.com/nodejs/node/pull/10809#event-923300104
addaleaxhttps://github.com/addaleax
Jan 14, 2017 https://github.com/nodejs/node/pull/10809#ref-commit-66f09be
https://github.com/thefourtheye
https://github.com/addaleax
Revert "fs: ensure readFile[Sync] reads from the beginning"https://github.com/nodejs/node/commit/66f09be74399b61a433a58dfe48c6fd5b9d66594
66f09behttps://github.com/nodejs/node/commit/66f09be74399b61a433a58dfe48c6fd5b9d66594
4444e73https://github.com/nodejs/node/commit/4444e731f218edf265a0b160bf1d561df2d5e5b3
#10809https://github.com/nodejs/node/pull/10809
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2017 https://github.com/nodejs/node/pull/10809#ref-issue-190262220
readFile(fd) does not read the whole file (at least on Windows, possibly other platforms) #9671 https://github.com/nodejs/node/issues/9671
https://github.com/seishun
seishunhttps://github.com/seishun
Jan 14, 2017https://github.com/nodejs/node/pull/10809#issuecomment-272654064
Please reload this pagehttps://github.com/nodejs/node/pull/10809
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2017https://github.com/nodejs/node/pull/10809#issuecomment-272655512
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/seishun
seishunhttps://github.com/seishun
Jan 14, 2017https://github.com/nodejs/node/pull/10809#issuecomment-272656151
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2017https://github.com/nodejs/node/pull/10809#issuecomment-272656665
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/seishun
seishunhttps://github.com/seishun
Jan 15, 2017https://github.com/nodejs/node/pull/10809#issuecomment-272683361
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 15, 2017https://github.com/nodejs/node/pull/10809#issuecomment-272683992
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 15, 2017https://github.com/nodejs/node/pull/10809#issuecomment-272706956
@joyeecheunghttps://github.com/joyeecheung
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 15, 2017https://github.com/nodejs/node/pull/10809#issuecomment-272726844
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Jan 16, 2017https://github.com/nodejs/node/pull/10809#event-924609140
https://github.com/seishun
seishunhttps://github.com/seishun
Jan 17, 2017 https://github.com/nodejs/node/pull/10809#ref-pullrequest-201219101
doc: clarify the behavior of readFile with fd #10853 https://github.com/nodejs/node/pull/10853
italoacasashttps://github.com/italoacasas
Jan 18, 2017 https://github.com/nodejs/node/pull/10809#ref-commit-5dd54a6
https://github.com/thefourtheye
Revert "fs: ensure readFile[Sync] reads from the beginning"https://github.com/italoacasas/node/commit/5dd54a676e5a8e83a97befb5ae5cb393c065be66
5dd54a6https://github.com/italoacasas/node/commit/5dd54a676e5a8e83a97befb5ae5cb393c065be66
4444e73https://github.com/italoacasas/node/commit/4444e731f218edf265a0b160bf1d561df2d5e5b3
nodejs#10809https://github.com/nodejs/node/pull/10809
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 4, 2017 https://github.com/nodejs/node/pull/10809#ref-pullrequest-219383958
8.0.0 Release Proposal #12220 https://github.com/nodejs/node/pull/12220
https://github.com/thisconnect
thisconnecthttps://github.com/thisconnect
Jun 9, 2017 https://github.com/nodejs/node/pull/10809#ref-issue-234798232
'fs' can not read data if same FD is used for write and readFile #13572 https://github.com/nodejs/node/issues/13572
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
Oct 11, 2018 https://github.com/nodejs/node/pull/10809#ref-issue-369348203
fs: behaviour of readFile and writeFile with file descriptors #23433 https://github.com/nodejs/node/issues/23433
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10809
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/10809/files/22b1b36f0dbec4462f760652daa77f675e971ef8
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/10809
https://github.com/thefourtheye
https://github.com/seishun
https://github.com/addaleax
https://github.com/joyeecheung
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.