| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2adca2ba-44fc-0da3-6bae-3935e248facc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 914C:D9995:17B08:20702:696A374C |
| html-safe-nonce | aeb14db996313d3821d900fb5e2f24f440734c63c1180cfe8d3c5e9e8360dbb9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTRDOkQ5OTk1OjE3QjA4OjIwNzAyOjY5NkEzNzRDIiwidmlzaXRvcl9pZCI6IjQ2MDQxNzgwNzI1MDI0MTM1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e1bc675aaab3589cfa56042a8d338fdedb4e1f8280e1dfbdb1c2569ce392a3ad |
| hovercard-subject-tag | pull_request:101316768 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10769/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/47fb2b2ee7676a38e4a9bb389c4ebbb4355e3aeec3427cfb6200121965697059/nodejs/node/pull/10769 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/47fb2b2ee7676a38e4a9bb389c4ebbb4355e3aeec3427cfb6200121965697059/nodejs/node/pull/10769 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines
Affected core subsystem(s)
child_process
Closes ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10769#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10769 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10769 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10769 |
| Reload | https://github.com/nodejs/node/pull/10769 |
| Reload | https://github.com/nodejs/node/pull/10769 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10769#issue-comment-box |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:10767 | https://github.com/cjihrig/node/tree/10767 |
|
child_process: allow Infinity as maxBuffer value
| https://github.com/nodejs/node/pull/10769#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:10767 | https://github.com/cjihrig/node/tree/10767 |
|
Conversation
17
| https://github.com/nodejs/node/pull/10769 |
|
Commits
2
| https://github.com/nodejs/node/pull/10769/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10769/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10769/files |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10769#issue-200447543 |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| #10767 | https://github.com/nodejs/node/pull/10767 |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10769#event-921184910 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10769#ref-pullrequest-200439714 |
|
child_process: Allow an unlimited maxBuffer size in child_process
#10767
| https://github.com/nodejs/node/pull/10767 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10769#issuecomment-272247279 |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10769#event-921190813 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10769#pullrequestreview-16427606 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10769/files |
| test/parallel/test-child-process-spawnsync-validation-errors.js | https://github.com/nodejs/node/pull/10769/files#diff-e2d8efafd2b86015223f32aa2b6f3ace18237a1022427aeb70c9a1e077579509 |
| jasnell | https://github.com/jasnell |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10769#discussion_r95858352 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10769#pullrequestreview-16430007 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10769/files |
| src/spawn_sync.cc | https://github.com/nodejs/node/pull/10769/files#diff-f774c89c36e3b418d01b3f9c2ef90f798f6360dda69811cf7472c3c6bbca36c7 |
| cjihrig | https://github.com/cjihrig |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10769#discussion_r95860678 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| cjihrig | https://github.com/cjihrig |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10769#discussion_r95864888 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/04bb78df966edc6738abb5de9169ca2ac0ee7feb..4bde5b00c59f74284427638a9e46bfc7661583bb |
| 04bb78d | https://github.com/nodejs/node/commit/04bb78df966edc6738abb5de9169ca2ac0ee7feb |
| 4bde5b0 | https://github.com/nodejs/node/commit/4bde5b00c59f74284427638a9e46bfc7661583bb |
|
Compare
| https://github.com/nodejs/node/compare/04bb78df966edc6738abb5de9169ca2ac0ee7feb..4bde5b00c59f74284427638a9e46bfc7661583bb |
| January 12, 2017 19:21 | https://github.com/nodejs/node/pull/10769#event-921237525 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10769#event-921237614 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10769#event-921249475 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10769#issuecomment-272259056 |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/sindresorhus |
| sindresorhus | https://github.com/sindresorhus |
|
Jan 13, 2017
| https://github.com/nodejs/node/pull/10769#pullrequestreview-16510686 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10769/files |
| lib/child_process.js | https://github.com/nodejs/node/pull/10769/files#diff-56c0eb11e943939908cf3d1d251bf1aadda236b5adbf8111d79b0809ec403f97 |
| sindresorhus | https://github.com/sindresorhus |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10769#discussion_r95939733 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| jasnell | https://github.com/jasnell |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10769#discussion_r96038860 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| cjihrig | https://github.com/cjihrig |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10769#discussion_r96039458 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 13, 2017
| https://github.com/nodejs/node/pull/10769#pullrequestreview-16615151 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10769/files |
| lib/child_process.js | https://github.com/nodejs/node/pull/10769/files#diff-56c0eb11e943939908cf3d1d251bf1aadda236b5adbf8111d79b0809ec403f97 |
| jasnell | https://github.com/jasnell |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10769#discussion_r96038860 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10769#event-922580493 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10769#event-922586878 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/8f597e851680e805cb4038e5b6991104a379ea58..901de6f9d34c318cb9337796dcb1c43dc1a11f12 |
| 8f597e8 | https://github.com/nodejs/node/commit/8f597e851680e805cb4038e5b6991104a379ea58 |
| 901de6f | https://github.com/nodejs/node/commit/901de6f9d34c318cb9337796dcb1c43dc1a11f12 |
|
Compare
| https://github.com/nodejs/node/compare/8f597e851680e805cb4038e5b6991104a379ea58..901de6f9d34c318cb9337796dcb1c43dc1a11f12 |
| January 13, 2017 18:17 | https://github.com/nodejs/node/pull/10769#event-922613583 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10769#event-922613725 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10769#issuecomment-272518322 |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10769#issuecomment-272518669 |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10769#issuecomment-272519500 |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10769#issuecomment-272519694 |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 13, 2017
| https://github.com/nodejs/node/pull/10769#pullrequestreview-16656318 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10769/files |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/901de6f9d34c318cb9337796dcb1c43dc1a11f12..92ac035a52ed3322921b56ffc5499f12f33bd63e |
| 901de6f | https://github.com/nodejs/node/commit/901de6f9d34c318cb9337796dcb1c43dc1a11f12 |
| 92ac035 | https://github.com/nodejs/node/commit/92ac035a52ed3322921b56ffc5499f12f33bd63e |
|
Compare
| https://github.com/nodejs/node/compare/901de6f9d34c318cb9337796dcb1c43dc1a11f12..92ac035a52ed3322921b56ffc5499f12f33bd63e |
| January 16, 2017 18:10 | https://github.com/nodejs/node/pull/10769#event-924698206 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10769#event-924698313 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/c3626e8156a1782afd5f51f3c6de13d1b0b3ffd4..6303d667bcc8fb06891d8067a1c257a3a1eb3e62 |
| c3626e8 | https://github.com/nodejs/node/commit/c3626e8156a1782afd5f51f3c6de13d1b0b3ffd4 |
| 6303d66 | https://github.com/nodejs/node/commit/6303d667bcc8fb06891d8067a1c257a3a1eb3e62 |
|
Compare
| https://github.com/nodejs/node/compare/c3626e8156a1782afd5f51f3c6de13d1b0b3ffd4..6303d667bcc8fb06891d8067a1c257a3a1eb3e62 |
| January 16, 2017 18:34 | https://github.com/nodejs/node/pull/10769#event-924725235 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10769#event-924725296 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10769#issuecomment-272934733 |
| https://ci.nodejs.org/job/node-test-pull-request/5889/ | https://ci.nodejs.org/job/node-test-pull-request/5889/ |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/6303d667bcc8fb06891d8067a1c257a3a1eb3e62..57d05c91a8fcd421970289ef851bbf8ef94a216d |
| 6303d66 | https://github.com/nodejs/node/commit/6303d667bcc8fb06891d8067a1c257a3a1eb3e62 |
| 57d05c9 | https://github.com/nodejs/node/commit/57d05c91a8fcd421970289ef851bbf8ef94a216d |
|
Compare
| https://github.com/nodejs/node/compare/6303d667bcc8fb06891d8067a1c257a3a1eb3e62..57d05c91a8fcd421970289ef851bbf8ef94a216d |
| January 16, 2017 20:32 | https://github.com/nodejs/node/pull/10769#event-924843138 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10769#event-924843196 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10769#issuecomment-272956031 |
| https://ci.nodejs.org/job/node-test-pull-request/5891/ | https://ci.nodejs.org/job/node-test-pull-request/5891/ |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/57d05c91a8fcd421970289ef851bbf8ef94a216d..78dec95f100794c6b8773926c9db1eb375ae8efb |
| 57d05c9 | https://github.com/nodejs/node/commit/57d05c91a8fcd421970289ef851bbf8ef94a216d |
| 78dec95 | https://github.com/nodejs/node/commit/78dec95f100794c6b8773926c9db1eb375ae8efb |
|
Compare
| https://github.com/nodejs/node/compare/57d05c91a8fcd421970289ef851bbf8ef94a216d..78dec95f100794c6b8773926c9db1eb375ae8efb |
| January 17, 2017 15:18 | https://github.com/nodejs/node/pull/10769#event-925942601 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10769#event-925942689 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10769#issuecomment-273198520 |
| https://ci.nodejs.org/job/node-test-pull-request/5911/ | https://ci.nodejs.org/job/node-test-pull-request/5911/ |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| cjihrig | https://github.com/cjihrig |
| January 17, 2017 10:47 | https://github.com/nodejs/node/pull/10769#commits-pushed-8f3ff98 |
|
| https://github.com/cjihrig |
| child_process: allow Infinity as maxBuffer value | https://github.com/nodejs/node/pull/10769/commits/8f3ff98f0e59926e7de3de56497cef270918629b |
| 8f3ff98 | https://github.com/nodejs/node/pull/10769/commits/8f3ff98f0e59926e7de3de56497cef270918629b |
| nodejs#10767 | https://github.com/nodejs/node/pull/10767 |
| nodejs#10769 | https://github.com/nodejs/node/pull/10769 |
|
| https://github.com/cjihrig |
| test: refactor test-child-process-spawnsync-maxbuf | https://github.com/nodejs/node/pull/10769/commits/5b30c4f24da8039bcfbd9d453b74fdd986cb000e |
| 5b30c4f | https://github.com/nodejs/node/pull/10769/commits/5b30c4f24da8039bcfbd9d453b74fdd986cb000e |
| nodejs#10769 | https://github.com/nodejs/node/pull/10769 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/78dec95f100794c6b8773926c9db1eb375ae8efb..5b30c4f24da8039bcfbd9d453b74fdd986cb000e |
| 78dec95 | https://github.com/nodejs/node/commit/78dec95f100794c6b8773926c9db1eb375ae8efb |
| 5b30c4f | https://github.com/nodejs/node/commit/5b30c4f24da8039bcfbd9d453b74fdd986cb000e |
|
Compare
| https://github.com/nodejs/node/compare/78dec95f100794c6b8773926c9db1eb375ae8efb..5b30c4f24da8039bcfbd9d453b74fdd986cb000e |
| January 17, 2017 15:49 | https://github.com/nodejs/node/pull/10769#event-925997218 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10769#event-925997324 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| 5b30c4f | https://github.com/nodejs/node/commit/5b30c4f24da8039bcfbd9d453b74fdd986cb000e |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10769#event-926000048 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| January 17, 2017 15:52 | https://github.com/nodejs/node/pull/10769#event-926002254 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10769#ref-commit-e4e29ad |
|
| https://github.com/cjihrig |
| child_process: allow Infinity as maxBuffer value | https://github.com/italoacasas/node/commit/e4e29ad6d12ff812ae4a78b72a21af374e059acd |
| e4e29ad | https://github.com/italoacasas/node/commit/e4e29ad6d12ff812ae4a78b72a21af374e059acd |
| nodejs#10767 | https://github.com/nodejs/node/pull/10767 |
| nodejs#10769 | https://github.com/nodejs/node/pull/10769 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10769#ref-commit-6d2eb84 |
|
| https://github.com/cjihrig |
| test: refactor test-child-process-spawnsync-maxbuf | https://github.com/italoacasas/node/commit/6d2eb8497916edf31712fb7f8ae4126224a2a381 |
| 6d2eb84 | https://github.com/italoacasas/node/commit/6d2eb8497916edf31712fb7f8ae4126224a2a381 |
| nodejs#10769 | https://github.com/nodejs/node/pull/10769 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 28, 2017 | https://github.com/nodejs/node/pull/10769#event-940218538 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 4, 2017
| https://github.com/nodejs/node/pull/10769#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Apr 11, 2017
| https://github.com/nodejs/node/pull/10769#ref-issue-200447415 |
|
maxBuffer of Infinity aborts child_process.execSync
#10768
| https://github.com/nodejs/node/issues/10768 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Apr 12, 2017 | https://github.com/nodejs/node/pull/10769#issuecomment-293711107 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Apr 12, 2017 | https://github.com/nodejs/node/pull/10769#issuecomment-293713405 |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Apr 23, 2017
| https://github.com/nodejs/node/pull/10769#ref-pullrequest-205271362 |
|
net: use actual Timeout instances on Sockets
#11154
| https://github.com/nodejs/node/pull/11154 |
| https://github.com/koh110 |
| koh110 | https://github.com/koh110 |
|
Oct 22, 2018
| https://github.com/nodejs/node/pull/10769#ref-pullrequest-362879400 |
|
child_process: use non-infinite maxBuffer defaults
#23027
| https://github.com/nodejs/node/pull/23027 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10769 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10769/files/901de6f9d34c318cb9337796dcb1c43dc1a11f12 |
|
| https://github.com/sindresorhus |
|
sindresorhus
| https://github.com/sindresorhus |
|
| https://github.com/nodejs/node/pull/10769/files/4bde5b00c59f74284427638a9e46bfc7661583bb |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Please reload this page | https://github.com/nodejs/node/pull/10769 |
|
| https://github.com/cjihrig |
|
| https://github.com/sam-github |
|
| https://github.com/mscdex |
|
| https://github.com/sindresorhus |
|
| https://github.com/jasnell |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |