| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:47c0f782-537d-f3f7-ed2c-b54934278dbc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E5D8:C9E9C:2D269E:3FE44E:696A07F1 |
| html-safe-nonce | 42dd5f3b2db035ec62cb68dcd28ca03b5ed1edfa8883b832d62647f0744d1ecc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUQ4OkM5RTlDOjJEMjY5RTozRkU0NEU6Njk2QTA3RjEiLCJ2aXNpdG9yX2lkIjoiNTAzNjYzNTE5OTc2ODIzMzk2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0136249673a5ddc83c5eeb12ef033f7077892c773caa9bfd94572fa5a28b8ad1 |
| hovercard-subject-tag | pull_request:101208489 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10762/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e7babec6b95cc9084071c29799a02e4f57e7fc8ac0f0fe93b067f32d4e0dfa20/nodejs/node/pull/10762 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e7babec6b95cc9084071c29799a02e4f57e7fc8ac0f0fe93b067f32d4e0dfa20/nodejs/node/pull/10762 |
| og:image:alt | There were no tests confirming situations where server.connections
should return null. Add a test for that situation.
Expand existing server.connection test slightly to check value.
Refactor (mostl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10762#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10762 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10762 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10762 |
| Reload | https://github.com/nodejs/node/pull/10762 |
| Reload | https://github.com/nodejs/node/pull/10762 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10762 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10762 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10762#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:connections | https://github.com/Trott/io.js/tree/connections |
|
test,net: add tests for server.connections
| https://github.com/nodejs/node/pull/10762#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:connections | https://github.com/Trott/io.js/tree/connections |
|
Conversation
4
| https://github.com/nodejs/node/pull/10762 |
|
Commits
2
| https://github.com/nodejs/node/pull/10762/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10762/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10762/files |
| Please reload this page | https://github.com/nodejs/node/pull/10762 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10762#issue-200296156 |
| Please reload this page | https://github.com/nodejs/node/pull/10762 |
|
| https://github.com/Trott |
| test,net: add tests for server.connections | https://github.com/nodejs/node/pull/10762/commits/1d9f9c0dd28b8ca8d95ad3cc1c3e700c567eece0 |
| 1d9f9c0 | https://github.com/nodejs/node/pull/10762/commits/1d9f9c0dd28b8ca8d95ad3cc1c3e700c567eece0 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10762#event-920293107 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10762#event-920293205 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10762#event-920294515 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10762#pullrequestreview-16398914 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10762/files/1d9f9c0dd28b8ca8d95ad3cc1c3e700c567eece0 |
| test/parallel/test-net-server-connections.js | https://github.com/nodejs/node/pull/10762/files/1d9f9c0dd28b8ca8d95ad3cc1c3e700c567eece0#diff-b597e1d8f259f7c138b6cc5c21aca3564f677bfaa9633931542f08130f4bd2d0 |
| jasnell | https://github.com/jasnell |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10762#discussion_r95831289 |
| Please reload this page | https://github.com/nodejs/node/pull/10762 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10762 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10762#pullrequestreview-16399020 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10762/files/1d9f9c0dd28b8ca8d95ad3cc1c3e700c567eece0 |
|
| https://github.com/Trott |
| squash | https://github.com/nodejs/node/pull/10762/commits/7d6aff4fcef5b45a4c682989b04d24c1e3036669 |
| 7d6aff4 | https://github.com/nodejs/node/pull/10762/commits/7d6aff4fcef5b45a4c682989b04d24c1e3036669 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10762#event-921116752 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10762#event-921148936 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10762#issuecomment-272527006 |
| https://ci.nodejs.org/job/node-test-pull-request/5852/ | https://ci.nodejs.org/job/node-test-pull-request/5852/ |
| Please reload this page | https://github.com/nodejs/node/pull/10762 |
| Trott | https://github.com/Trott |
|
Jan 15, 2017
| https://github.com/nodejs/node/pull/10762#ref-commit-97f001a |
|
| https://github.com/Trott |
| test,net: add tests for server.connections | https://github.com/Trott/io.js/commit/97f001ab167875c8e8e8418fa55ff14ef76a4064 |
| 97f001a | https://github.com/Trott/io.js/commit/97f001ab167875c8e8e8418fa55ff14ef76a4064 |
| nodejs#10762 | https://github.com/nodejs/node/pull/10762 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 15, 2017 | https://github.com/nodejs/node/pull/10762#issuecomment-272673931 |
| 97f001a | https://github.com/nodejs/node/commit/97f001ab167875c8e8e8418fa55ff14ef76a4064 |
| Please reload this page | https://github.com/nodejs/node/pull/10762 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 15, 2017 | https://github.com/nodejs/node/pull/10762#event-923401718 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10762#ref-commit-6f5c5bf |
|
| https://github.com/Trott |
| test,net: add tests for server.connections | https://github.com/italoacasas/node/commit/6f5c5bf0d4f55809f7e25fca1965040b05f98cdc |
| 6f5c5bf | https://github.com/italoacasas/node/commit/6f5c5bf0d4f55809f7e25fca1965040b05f98cdc |
| nodejs#10762 | https://github.com/nodejs/node/pull/10762 |
|
v7.x-staging update proposal
#10886
| https://github.com/nodejs/node/pull/10886 |
|
Proposal to update v7.x-staging
#10989
| https://github.com/nodejs/node/pull/10989 |
| targos | https://github.com/targos |
|
Jan 28, 2017
| https://github.com/nodejs/node/pull/10762#ref-commit-c31ec9e |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test,net: add tests for server.connections | https://github.com/nodejs/node/commit/c31ec9e7d2c133576d752c9c257aa90dd0516dfe |
| c31ec9e | https://github.com/nodejs/node/commit/c31ec9e7d2c133576d752c9c257aa90dd0516dfe |
| #10762 | https://github.com/nodejs/node/pull/10762 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/10762#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10762#ref-commit-33af09f |
|
| https://github.com/Trott |
| test,net: add tests for server.connections | https://github.com/italoacasas/node/commit/33af09fe6a6aebaddd0955c6fcd83124c3bcb934 |
| 33af09f | https://github.com/italoacasas/node/commit/33af09fe6a6aebaddd0955c6fcd83124c3bcb934 |
| nodejs#10762 | https://github.com/nodejs/node/pull/10762 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10762#ref-commit-60c63b7 |
|
| https://github.com/Trott |
| test,net: add tests for server.connections | https://github.com/italoacasas/node/commit/60c63b7a7d602c625dd6b56fb2c6c55e5c9bf7d7 |
| 60c63b7 | https://github.com/italoacasas/node/commit/60c63b7a7d602c625dd6b56fb2c6c55e5c9bf7d7 |
| nodejs#10762 | https://github.com/nodejs/node/pull/10762 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10762#issuecomment-285168081 |
| Please reload this page | https://github.com/nodejs/node/pull/10762 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10762#event-992071129 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:45 | https://github.com/nodejs/node/pull/10762#event-5890945176 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10762 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10762/files/1d9f9c0dd28b8ca8d95ad3cc1c3e700c567eece0 |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/10762 |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |