| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:622b5270-eaa8-91a3-d63c-8685c7c8e5f6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A8BA:6C43E:FEE925:15FEDDE:696A9256 |
| html-safe-nonce | b8471593e115c210bc0b81c028871faf18e42c9cb63136759d24ec8f8dd2507c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEJBOjZDNDNFOkZFRTkyNToxNUZFRERFOjY5NkE5MjU2IiwidmlzaXRvcl9pZCI6IjQ3Njc4MzcyNjE0MTMzODg4ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 653e36b603c726e0417d32f3c5a00de9c07083d845c4751233a0191d7bac187a |
| hovercard-subject-tag | pull_request:101189908 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10752/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/572a34a8decaf05e791f83c4fbb90c4f9298afab288911d248f1c15722836d89/nodejs/node/pull/10752 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/572a34a8decaf05e791f83c4fbb90c4f9298afab288911d248f1c15722836d89/nodejs/node/pull/10752 |
| og:image:alt | validate errors in assert.throws
use arrow functions
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guideli... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | edsadr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10752#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10752 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10752 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10752 |
| Reload | https://github.com/nodejs/node/pull/10752 |
| Reload | https://github.com/nodejs/node/pull/10752 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10752 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10752 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10752#issue-comment-box |
| edsadr | https://github.com/edsadr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| edsadr:buffer-indexof | https://github.com/edsadr/node/tree/buffer-indexof |
|
test: validate errors in test-buffer-indexof
| https://github.com/nodejs/node/pull/10752#top |
| edsadr | https://github.com/edsadr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| edsadr:buffer-indexof | https://github.com/edsadr/node/tree/buffer-indexof |
|
Conversation
3
| https://github.com/nodejs/node/pull/10752 |
|
Commits
1
| https://github.com/nodejs/node/pull/10752/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10752/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10752/files |
| Please reload this page | https://github.com/nodejs/node/pull/10752 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10752#issue-200268474 |
| Please reload this page | https://github.com/nodejs/node/pull/10752 |
|
| https://github.com/edsadr |
| test: validate errors in test-buffer-indexof | https://github.com/nodejs/node/pull/10752/commits/7282a6b81cd631ac49656c175c7b515b27355e38 |
| 7282a6b | https://github.com/nodejs/node/pull/10752/commits/7282a6b81cd631ac49656c175c7b515b27355e38 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10752#event-920140714 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10752#event-920151337 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10752#pullrequestreview-16293389 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10752/files/7282a6b81cd631ac49656c175c7b515b27355e38 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10752#pullrequestreview-16354949 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10752/files/7282a6b81cd631ac49656c175c7b515b27355e38 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10752#pullrequestreview-16370239 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10752/files/7282a6b81cd631ac49656c175c7b515b27355e38 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10752#issuecomment-272799774 |
| https://ci.nodejs.org/job/node-test-pull-request/5880/ | https://ci.nodejs.org/job/node-test-pull-request/5880/ |
| Please reload this page | https://github.com/nodejs/node/pull/10752 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10752#issuecomment-272823714 |
| f51d4f3 | https://github.com/nodejs/node/commit/f51d4f34ae9227173ef6dc471bafe27f7e92b791 |
| Please reload this page | https://github.com/nodejs/node/pull/10752 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10752#event-924090372 |
| lpinca | https://github.com/lpinca |
|
Jan 16, 2017
| https://github.com/nodejs/node/pull/10752#ref-commit-f51d4f3 |
|
| https://github.com/edsadr |
|
| https://github.com/lpinca |
| test: validate errors in test-buffer-indexof | https://github.com/nodejs/node/commit/f51d4f34ae9227173ef6dc471bafe27f7e92b791 |
| f51d4f3 | https://github.com/nodejs/node/commit/f51d4f34ae9227173ef6dc471bafe27f7e92b791 |
| #10752 | https://github.com/nodejs/node/pull/10752 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10752#ref-commit-1e3dac6 |
|
| https://github.com/edsadr |
| test: validate errors in test-buffer-indexof | https://github.com/italoacasas/node/commit/1e3dac6b2d1764602bd464a5484f5460ce33f2de |
| 1e3dac6 | https://github.com/italoacasas/node/commit/1e3dac6b2d1764602bd464a5484f5460ce33f2de |
| nodejs#10752 | https://github.com/nodejs/node/pull/10752 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10752#event-932234642 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10752#issuecomment-274386621 |
| Please reload this page | https://github.com/nodejs/node/pull/10752 |
| beca324 | https://github.com/nodejs/node/commit/beca3244e2792bc4257f480b138c1b603de3781c |
| Please reload this page | https://github.com/nodejs/node/pull/10752 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 28, 2017 | https://github.com/nodejs/node/pull/10752#event-940222688 |
| targos | https://github.com/targos |
|
Jan 28, 2017
| https://github.com/nodejs/node/pull/10752#ref-commit-db3cb66 |
|
| https://github.com/edsadr |
|
| https://github.com/targos |
| test: validate errors in test-buffer-indexof | https://github.com/nodejs/node/commit/db3cb664cee8f2d8687c9e168b1fa422338ceb8b |
| db3cb66 | https://github.com/nodejs/node/commit/db3cb664cee8f2d8687c9e168b1fa422338ceb8b |
| #10752 | https://github.com/nodejs/node/pull/10752 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/10752#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10752#ref-commit-807e99b |
|
| https://github.com/edsadr |
| test: validate errors in test-buffer-indexof | https://github.com/italoacasas/node/commit/807e99b81ddf41c0868a335caa5470d72b9f3e8c |
| 807e99b | https://github.com/italoacasas/node/commit/807e99b81ddf41c0868a335caa5470d72b9f3e8c |
| nodejs#10752 | https://github.com/nodejs/node/pull/10752 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10752#ref-commit-94c9631 |
|
| https://github.com/edsadr |
| test: validate errors in test-buffer-indexof | https://github.com/italoacasas/node/commit/94c9631a3c70ce2be033f25da7e9a520eab72590 |
| 94c9631 | https://github.com/italoacasas/node/commit/94c9631a3c70ce2be033f25da7e9a520eab72590 |
| nodejs#10752 | https://github.com/nodejs/node/pull/10752 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jun 19, 2017
| https://github.com/nodejs/node/pull/10752#ref-pullrequest-236818965 |
|
(v6.x backport) tools: enforce two arguments in assert.throws
#13785
| https://github.com/nodejs/node/pull/13785 |
| gibfahn | https://github.com/gibfahn |
|
Jun 19, 2017
| https://github.com/nodejs/node/pull/10752#ref-commit-493f072 |
|
| https://github.com/edsadr |
|
| https://github.com/gibfahn |
| test: validate errors in test-buffer-indexof | https://github.com/nodejs/node/commit/493f072922d6b185ff1a8e5affeaddc56352fb2e |
| 493f072 | https://github.com/nodejs/node/commit/493f072922d6b185ff1a8e5affeaddc56352fb2e |
| #10752 | https://github.com/nodejs/node/pull/10752 |
| #13785 | https://github.com/nodejs/node/pull/13785 |
| gibfahn | https://github.com/gibfahn |
|
Jun 20, 2017
| https://github.com/nodejs/node/pull/10752#ref-commit-9243b9d |
|
| https://github.com/edsadr |
|
| https://github.com/gibfahn |
| test: validate errors in test-buffer-indexof | https://github.com/nodejs/node/commit/9243b9dc518d9ba20288ea0b54a00fb0baa8bfc4 |
| 9243b9d | https://github.com/nodejs/node/commit/9243b9dc518d9ba20288ea0b54a00fb0baa8bfc4 |
| #10752 | https://github.com/nodejs/node/pull/10752 |
| #13785 | https://github.com/nodejs/node/pull/13785 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 11, 2017
| https://github.com/nodejs/node/pull/10752#ref-commit-752bc24 |
|
| https://github.com/edsadr |
|
| https://github.com/MylesBorins |
| test: validate errors in test-buffer-indexof | https://github.com/nodejs/node/commit/752bc249433b41b9782af01662b83727c4276a2b |
| 752bc24 | https://github.com/nodejs/node/commit/752bc249433b41b9782af01662b83727c4276a2b |
| #10752 | https://github.com/nodejs/node/pull/10752 |
| #13785 | https://github.com/nodejs/node/pull/13785 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 18, 2017
| https://github.com/nodejs/node/pull/10752#ref-pullrequest-243856504 |
|
v6.11.2 proposal
#14356
| https://github.com/nodejs/node/pull/14356 |
| abhishekumar-tyagi | https://github.com/abhishekumar-tyagi |
|
May 5, 2024
| https://github.com/nodejs/node/pull/10752#ref-commit-85b17c1 |
|
| https://github.com/edsadr |
|
| https://github.com/targos |
| test: validate errors in test-buffer-indexof | https://github.com/abhishekumar-tyagi/node/commit/85b17c115a6dc1b6a7e77a8726053215501be1d6 |
| 85b17c1 | https://github.com/abhishekumar-tyagi/node/commit/85b17c115a6dc1b6a7e77a8726053215501be1d6 |
| nodejs/node#10752 | https://github.com/nodejs/node/pull/10752 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10752 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10752/files/7282a6b81cd631ac49656c175c7b515b27355e38 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/10752/files/7282a6b81cd631ac49656c175c7b515b27355e38 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/10752/files/7282a6b81cd631ac49656c175c7b515b27355e38 |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/10752 |
|
| https://github.com/edsadr |
|
| https://github.com/lpinca |
|
| https://github.com/italoacasas |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/mscdex |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |