| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b21ef639-984c-3d54-f2bf-87bcbc4d8282 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F44:15CCBD:251AAB:3422EE:696A0761 |
| html-safe-nonce | 32cc3aa227f76d9c715c615b8c46304ceeec450e4359875d64d1ca6287c2be82 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjQ0OjE1Q0NCRDoyNTFBQUI6MzQyMkVFOjY5NkEwNzYxIiwidmlzaXRvcl9pZCI6IjQ1MTU1MjA5NTUxMTQxOTQ3ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 581d63219da561e0235b3713c031ef3c2d058a47215e1ee934b39ecd133c3c94 |
| hovercard-subject-tag | pull_request:101000319 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10734/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/82b4b282d77ff0ff03e635487a918824e7ea685d566a93b9008f578cac59ec50/nodejs/node/pull/10734 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/82b4b282d77ff0ff03e635487a918824e7ea685d566a93b9008f578cac59ec50/nodejs/node/pull/10734 |
| og:image:alt | validate the errors for some assert.throws
use arrow functions
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows comm... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | edsadr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10734#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10734 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10734 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10734 |
| Reload | https://github.com/nodejs/node/pull/10734 |
| Reload | https://github.com/nodejs/node/pull/10734 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10734#issue-comment-box |
| edsadr | https://github.com/edsadr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| edsadr:crypto-dh | https://github.com/edsadr/node/tree/crypto-dh |
|
test: improve the code in test-crypto-dh
| https://github.com/nodejs/node/pull/10734#top |
| edsadr | https://github.com/edsadr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| edsadr:crypto-dh | https://github.com/edsadr/node/tree/crypto-dh |
|
Conversation
16
| https://github.com/nodejs/node/pull/10734 |
|
Commits
1
| https://github.com/nodejs/node/pull/10734/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10734/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10734/files |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| Jan 11, 2017 | https://github.com/nodejs/node/pull/10734#issue-199998893 |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 11, 2017 | https://github.com/nodejs/node/pull/10734#event-918561211 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Jan 11, 2017 | https://github.com/nodejs/node/pull/10734#event-918579170 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 11, 2017
| https://github.com/nodejs/node/pull/10734#pullrequestreview-16071455 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10734/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 11, 2017
| https://github.com/nodejs/node/pull/10734#pullrequestreview-16080553 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10734/files |
| test/parallel/test-crypto-dh.js | https://github.com/nodejs/node/pull/10734/files#diff-07a942232c55ff014a06365cfe047ef10ad02029a98f523ef4c96d5cb860bb25 |
| lpinca | https://github.com/lpinca |
| Jan 11, 2017 | https://github.com/nodejs/node/pull/10734#discussion_r95524352 |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 11, 2017
| https://github.com/nodejs/node/pull/10734#pullrequestreview-16144241 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10734/files |
| test/parallel/test-crypto-dh.js | https://github.com/nodejs/node/pull/10734/files#diff-07a942232c55ff014a06365cfe047ef10ad02029a98f523ef4c96d5cb860bb25 |
| cjihrig | https://github.com/cjihrig |
| Jan 11, 2017 | https://github.com/nodejs/node/pull/10734#discussion_r95584742 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| force-pushed | https://github.com/nodejs/node/compare/ab48f94a35bf76cfb63f157a4ffda01fbc5911ff..725eb2d620002eb5b187c16164fcaf428b1e7e6f |
| ab48f94 | https://github.com/nodejs/node/commit/ab48f94a35bf76cfb63f157a4ffda01fbc5911ff |
| 725eb2d | https://github.com/nodejs/node/commit/725eb2d620002eb5b187c16164fcaf428b1e7e6f |
|
Compare
| https://github.com/nodejs/node/compare/ab48f94a35bf76cfb63f157a4ffda01fbc5911ff..725eb2d620002eb5b187c16164fcaf428b1e7e6f |
| January 12, 2017 02:39 | https://github.com/nodejs/node/pull/10734#event-920117032 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#event-920117091 |
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#issuecomment-272060321 |
| @cjihrig | https://github.com/cjihrig |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#issuecomment-272060482 |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| force-pushed | https://github.com/nodejs/node/compare/725eb2d620002eb5b187c16164fcaf428b1e7e6f..0c9faafa82b786a21a4bcb7c52d158863a42ea93 |
| 725eb2d | https://github.com/nodejs/node/commit/725eb2d620002eb5b187c16164fcaf428b1e7e6f |
| 0c9faaf | https://github.com/nodejs/node/commit/0c9faafa82b786a21a4bcb7c52d158863a42ea93 |
|
Compare
| https://github.com/nodejs/node/compare/725eb2d620002eb5b187c16164fcaf428b1e7e6f..0c9faafa82b786a21a4bcb7c52d158863a42ea93 |
| January 12, 2017 03:32 | https://github.com/nodejs/node/pull/10734#event-920151601 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#event-920151628 |
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#issuecomment-272067225 |
| @cjihrig | https://github.com/cjihrig |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10734#ref-pullrequest-200271620 |
|
test: cleanup test-crypto-dh.js
#10753
| https://github.com/nodejs/node/pull/10753 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#event-920170272 |
| https://github.com/fluxsauce |
| fluxsauce | https://github.com/fluxsauce |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10734#pullrequestreview-16293365 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10734/files |
| test/parallel/test-crypto-dh.js | https://github.com/nodejs/node/pull/10734/files#diff-07a942232c55ff014a06365cfe047ef10ad02029a98f523ef4c96d5cb860bb25 |
| fluxsauce | https://github.com/fluxsauce |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#discussion_r95729542 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #10753 | https://github.com/nodejs/node/pull/10753 |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| edsadr | https://github.com/edsadr |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#discussion_r95797755 |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @fluxsauce | https://github.com/fluxsauce |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
|
| https://github.com/edsadr |
| test: improve the code in test-crypto-dh | https://github.com/nodejs/node/pull/10734/commits/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
| e2c8c3c | https://github.com/nodejs/node/pull/10734/commits/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| force-pushed | https://github.com/nodejs/node/compare/0c9faafa82b786a21a4bcb7c52d158863a42ea93..e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
| 0c9faaf | https://github.com/nodejs/node/commit/0c9faafa82b786a21a4bcb7c52d158863a42ea93 |
| e2c8c3c | https://github.com/nodejs/node/commit/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
|
Compare
| https://github.com/nodejs/node/compare/0c9faafa82b786a21a4bcb7c52d158863a42ea93..e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
| January 12, 2017 14:14 | https://github.com/nodejs/node/pull/10734#event-920771258 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#event-920771357 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10734#pullrequestreview-16370795 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10734/files/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10734#pullrequestreview-16391842 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10734/files/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10734#pullrequestreview-16392369 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10734/files/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
| test/parallel/test-crypto-dh.js | https://github.com/nodejs/node/pull/10734/files/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b#diff-07a942232c55ff014a06365cfe047ef10ad02029a98f523ef4c96d5cb860bb25 |
| lpinca | https://github.com/lpinca |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#discussion_r95825109 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| gibfahn | https://github.com/gibfahn |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#discussion_r95837858 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| here | https://github.com/nodejs/node/pull/10714#discussion_r95296414 |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| lpinca | https://github.com/lpinca |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#discussion_r95838629 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gibfahn | https://github.com/gibfahn |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| edsadr | https://github.com/edsadr |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#discussion_r95841493 |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| lpinca | https://github.com/lpinca |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#discussion_r95841746 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#issuecomment-272226960 |
| https://ci.nodejs.org/job/node-test-pull-request/5825/ | https://ci.nodejs.org/job/node-test-pull-request/5825/ |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 12, 2017 | https://github.com/nodejs/node/pull/10734#event-921148998 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jan 12, 2017
| https://github.com/nodejs/node/pull/10734#pullrequestreview-16474982 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10734/files/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/10734#pullrequestreview-16474982 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| jasnell | https://github.com/jasnell |
|
Jan 13, 2017
| https://github.com/nodejs/node/pull/10734#ref-commit-5520e40 |
|
| https://github.com/edsadr |
|
| https://github.com/jasnell |
| test: improve the code in test-crypto-dh | https://github.com/nodejs/node/commit/5520e40af3c3f8780ae012e8b244d4c305152870 |
| 5520e40 | https://github.com/nodejs/node/commit/5520e40af3c3f8780ae012e8b244d4c305152870 |
| #10734 | https://github.com/nodejs/node/pull/10734 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10734#issuecomment-272497251 |
| 5520e40 | https://github.com/nodejs/node/commit/5520e40af3c3f8780ae012e8b244d4c305152870 |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10734#event-922555202 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10734#ref-commit-0612383 |
|
| https://github.com/edsadr |
| test: improve the code in test-crypto-dh | https://github.com/italoacasas/node/commit/061238321759f4ba41043fcda597d47c7ab5c0ad |
| 0612383 | https://github.com/italoacasas/node/commit/061238321759f4ba41043fcda597d47c7ab5c0ad |
| nodejs#10734 | https://github.com/nodejs/node/pull/10734 |
|
v7.x-staging update proposal
#10886
| https://github.com/nodejs/node/pull/10886 |
|
Proposal to update v7.x-staging
#10989
| https://github.com/nodejs/node/pull/10989 |
| targos | https://github.com/targos |
|
Jan 28, 2017
| https://github.com/nodejs/node/pull/10734#ref-commit-3e1c2d4 |
|
| https://github.com/edsadr |
|
| https://github.com/targos |
| test: improve the code in test-crypto-dh | https://github.com/nodejs/node/commit/3e1c2d4fbcef748a8279acf19c956329faa26747 |
| 3e1c2d4 | https://github.com/nodejs/node/commit/3e1c2d4fbcef748a8279acf19c956329faa26747 |
| #10734 | https://github.com/nodejs/node/pull/10734 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/10734#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10734#ref-commit-4a7bb5b |
|
| https://github.com/edsadr |
| test: improve the code in test-crypto-dh | https://github.com/italoacasas/node/commit/4a7bb5b4d1ef1f7e60904eb297e714f72f8c4eb8 |
| 4a7bb5b | https://github.com/italoacasas/node/commit/4a7bb5b4d1ef1f7e60904eb297e714f72f8c4eb8 |
| nodejs#10734 | https://github.com/nodejs/node/pull/10734 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10734#ref-commit-102a73d |
|
| https://github.com/edsadr |
| test: improve the code in test-crypto-dh | https://github.com/italoacasas/node/commit/102a73db952619d739e84012cd83149be0e6e8eb |
| 102a73d | https://github.com/italoacasas/node/commit/102a73db952619d739e84012cd83149be0e6e8eb |
| nodejs#10734 | https://github.com/nodejs/node/pull/10734 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10734#event-992066440 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10734#issuecomment-285167341 |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jun 19, 2017
| https://github.com/nodejs/node/pull/10734#ref-pullrequest-236818965 |
|
(v6.x backport) tools: enforce two arguments in assert.throws
#13785
| https://github.com/nodejs/node/pull/13785 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
backport-requested-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jun 19, 2017 | https://github.com/nodejs/node/pull/10734#event-1128858134 |
| gibfahn | https://github.com/gibfahn |
|
Jun 19, 2017
| https://github.com/nodejs/node/pull/10734#ref-commit-8dab28d |
|
| https://github.com/edsadr |
|
| https://github.com/gibfahn |
| test: improve the code in test-crypto-dh | https://github.com/nodejs/node/commit/8dab28dd77bd5b91df4966544840db4aa3d3e220 |
| 8dab28d | https://github.com/nodejs/node/commit/8dab28dd77bd5b91df4966544840db4aa3d3e220 |
| #10734 | https://github.com/nodejs/node/pull/10734 |
| #13785 | https://github.com/nodejs/node/pull/13785 |
| gibfahn | https://github.com/gibfahn |
|
Jun 20, 2017
| https://github.com/nodejs/node/pull/10734#ref-commit-11cb4d0 |
|
| https://github.com/edsadr |
|
| https://github.com/gibfahn |
| test: improve the code in test-crypto-dh | https://github.com/nodejs/node/commit/11cb4d001a0c027667a1aa4ecdd60747424ad940 |
| 11cb4d0 | https://github.com/nodejs/node/commit/11cb4d001a0c027667a1aa4ecdd60747424ad940 |
| #10734 | https://github.com/nodejs/node/pull/10734 |
| #13785 | https://github.com/nodejs/node/pull/13785 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 11, 2017
| https://github.com/nodejs/node/pull/10734#ref-commit-bab8a36 |
|
| https://github.com/edsadr |
|
| https://github.com/MylesBorins |
| test: improve the code in test-crypto-dh | https://github.com/nodejs/node/commit/bab8a36f946784b897c7c68db8ab6c842478aa25 |
| bab8a36 | https://github.com/nodejs/node/commit/bab8a36f946784b897c7c68db8ab6c842478aa25 |
| #10734 | https://github.com/nodejs/node/pull/10734 |
| #13785 | https://github.com/nodejs/node/pull/13785 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 18, 2017
| https://github.com/nodejs/node/pull/10734#ref-pullrequest-243856504 |
|
v6.11.2 proposal
#14356
| https://github.com/nodejs/node/pull/14356 |
| abhishekumar-tyagi | https://github.com/abhishekumar-tyagi |
|
May 5, 2024
| https://github.com/nodejs/node/pull/10734#ref-commit-15b4be8 |
|
| https://github.com/edsadr |
|
| https://github.com/targos |
| test: improve the code in test-crypto-dh | https://github.com/abhishekumar-tyagi/node/commit/15b4be84caffe4cb2230e0eac3afa5d677c6a6af |
| 15b4be8 | https://github.com/abhishekumar-tyagi/node/commit/15b4be84caffe4cb2230e0eac3afa5d677c6a6af |
| nodejs/node#10734 | https://github.com/nodejs/node/pull/10734 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10734 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/10734/files/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10734/files/ab48f94a35bf76cfb63f157a4ffda01fbc5911ff |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/10734/files/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/10734/files/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
|
| https://github.com/fluxsauce |
|
fluxsauce
| https://github.com/fluxsauce |
|
| https://github.com/nodejs/node/pull/10734/files/0c9faafa82b786a21a4bcb7c52d158863a42ea93 |
|
| https://github.com/gibfahn |
|
gibfahn
| https://github.com/gibfahn |
|
| https://github.com/nodejs/node/pull/10734/files/e2c8c3c12587c567d73fb7c777a89d21c1b9b66b |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/10734 |
|
| https://github.com/edsadr |
|
| https://github.com/cjihrig |
|
| https://github.com/lpinca |
|
| https://github.com/jasnell |
|
| https://github.com/fluxsauce |
|
| https://github.com/mhdawson |
|
| https://github.com/gibfahn |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |