| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ad18a214-5e4a-18c0-61d6-ae2711b8dab7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DCCC:95B65:DF8767:1314F71:6969F454 |
| html-safe-nonce | 80e90be2d2eee913e87c329b1d250b5ffffbe966ca5cee987eaa249b74b747ad |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0NDOjk1QjY1OkRGODc2NzoxMzE0RjcxOjY5NjlGNDU0IiwidmlzaXRvcl9pZCI6IjQwNTA5ODIxMzcxMDE5Mzk3OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ce150b3e3ee0bcc9f676686cf38c24317f8d1a02b7e595931815909bc91da3dc |
| hovercard-subject-tag | pull_request:100971640 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10729/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/38b83bf7c009b2c681bcddb8d3932c982db1914277d16b7051f72f515c0f63f5/nodejs/node/pull/10729 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/38b83bf7c009b2c681bcddb8d3932c982db1914277d16b7051f72f515c0f63f5/nodejs/node/pull/10729 |
| og:image:alt | Replace equal with strictEqual.
There is not this file in #10698.
Rebased because of the influence of #10698.
All replacement of equal and deepEqual is complete :)
Checklist
make -j4 test (UNIX)... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hiroppy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10729#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10729 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10729 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10729 |
| Reload | https://github.com/nodejs/node/pull/10729 |
| Reload | https://github.com/nodejs/node/pull/10729 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10729 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10729 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10729#issue-comment-box |
| hiroppy | https://github.com/hiroppy |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hiroppy:feature/refactor-test-fs-read-zero-length.js | https://github.com/hiroppy/node/tree/feature/refactor-test-fs-read-zero-length.js |
|
test: refactor test-fs-read-zero-length.js
| https://github.com/nodejs/node/pull/10729#top |
| hiroppy | https://github.com/hiroppy |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hiroppy:feature/refactor-test-fs-read-zero-length.js | https://github.com/hiroppy/node/tree/feature/refactor-test-fs-read-zero-length.js |
|
Conversation
4
| https://github.com/nodejs/node/pull/10729 |
|
Commits
1
| https://github.com/nodejs/node/pull/10729/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10729/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10729/files |
| Please reload this page | https://github.com/nodejs/node/pull/10729 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10729#issue-199958685 |
| Please reload this page | https://github.com/nodejs/node/pull/10729 |
| #10698 | https://github.com/nodejs/node/pull/10698 |
| #10698 | https://github.com/nodejs/node/pull/10698 |
| Please reload this page | https://github.com/nodejs/node/pull/10729 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10729#event-918325237 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10729#issuecomment-271730878 |
| Please reload this page | https://github.com/nodejs/node/pull/10729 |
| Please reload this page | https://github.com/nodejs/node/pull/10729 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10729#event-918351590 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10729#pullrequestreview-16040614 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10729/files |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 11, 2017
| https://github.com/nodejs/node/pull/10729#pullrequestreview-16143090 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10729/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 11, 2017 | https://github.com/nodejs/node/pull/10729#event-919195245 |
|
| https://github.com/hiroppy |
| test: refactor test-fs-read-zero-length.js | https://github.com/nodejs/node/pull/10729/commits/87461e816a87fdb067e11a8c899caf10870febc3 |
| 87461e8 | https://github.com/nodejs/node/pull/10729/commits/87461e816a87fdb067e11a8c899caf10870febc3 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| force-pushed | https://github.com/nodejs/node/compare/563265098416f14b227f86efb9ac729f9398feea..87461e816a87fdb067e11a8c899caf10870febc3 |
| 5632650 | https://github.com/nodejs/node/commit/563265098416f14b227f86efb9ac729f9398feea |
| 87461e8 | https://github.com/nodejs/node/commit/87461e816a87fdb067e11a8c899caf10870febc3 |
|
Compare
| https://github.com/nodejs/node/compare/563265098416f14b227f86efb9ac729f9398feea..87461e816a87fdb067e11a8c899caf10870febc3 |
| January 11, 2017 14:45 | https://github.com/nodejs/node/pull/10729#event-919206919 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 11, 2017 | https://github.com/nodejs/node/pull/10729#event-919206989 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 11, 2017 | https://github.com/nodejs/node/pull/10729#event-919397843 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/10729#issuecomment-272969453 |
| https://ci.nodejs.org/job/node-test-pull-request/5897/console | https://ci.nodejs.org/job/node-test-pull-request/5897/console |
| Please reload this page | https://github.com/nodejs/node/pull/10729 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10729#issuecomment-273240206 |
| d86ff5f | https://github.com/nodejs/node/commit/d86ff5fc291bd1cb604750cd83e3cef2d415069a |
| Please reload this page | https://github.com/nodejs/node/pull/10729 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Jan 17, 2017 | https://github.com/nodejs/node/pull/10729#event-926178285 |
| italoacasas | https://github.com/italoacasas |
|
Jan 17, 2017
| https://github.com/nodejs/node/pull/10729#ref-commit-d86ff5f |
|
| https://github.com/hiroppy |
| test: refactor test-fs-read-zero-length.js | https://github.com/nodejs/node/commit/d86ff5fc291bd1cb604750cd83e3cef2d415069a |
| d86ff5f | https://github.com/nodejs/node/commit/d86ff5fc291bd1cb604750cd83e3cef2d415069a |
| #10729 | https://github.com/nodejs/node/pull/10729 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10729#ref-commit-596f57f |
|
| https://github.com/hiroppy |
| test: refactor test-fs-read-zero-length.js | https://github.com/italoacasas/node/commit/596f57f8d5614074d8ea3ed8937831d7d00caa3a |
| 596f57f | https://github.com/italoacasas/node/commit/596f57f8d5614074d8ea3ed8937831d7d00caa3a |
| nodejs#10729 | https://github.com/nodejs/node/pull/10729 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 19, 2017
| https://github.com/nodejs/node/pull/10729#ref-pullrequest-201733360 |
|
v7.x-staging update proposal
#10886
| https://github.com/nodejs/node/pull/10886 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| January 21, 2017 08:11 | https://github.com/nodejs/node/pull/10729#event-931624624 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/10729#ref-pullrequest-203011190 |
|
Proposal to update v7.x-staging
#10989
| https://github.com/nodejs/node/pull/10989 |
| targos | https://github.com/targos |
|
Jan 28, 2017
| https://github.com/nodejs/node/pull/10729#ref-commit-4317a57 |
|
| https://github.com/hiroppy |
|
| https://github.com/targos |
| test: refactor test-fs-read-zero-length.js | https://github.com/nodejs/node/commit/4317a5730c076a5b7b6e08b71d07dc421ac9939c |
| 4317a57 | https://github.com/nodejs/node/commit/4317a5730c076a5b7b6e08b71d07dc421ac9939c |
| #10729 | https://github.com/nodejs/node/pull/10729 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/10729#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10729#ref-commit-939517a |
|
| https://github.com/hiroppy |
| test: refactor test-fs-read-zero-length.js | https://github.com/italoacasas/node/commit/939517abfdd28a5f72a79409cc82974bb729b2aa |
| 939517a | https://github.com/italoacasas/node/commit/939517abfdd28a5f72a79409cc82974bb729b2aa |
| nodejs#10729 | https://github.com/nodejs/node/pull/10729 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10729#ref-commit-8773694 |
|
| https://github.com/hiroppy |
| test: refactor test-fs-read-zero-length.js | https://github.com/italoacasas/node/commit/87736945a5e5b8a2b83f60c3d732e3c91858f7a0 |
| 8773694 | https://github.com/italoacasas/node/commit/87736945a5e5b8a2b83f60c3d732e3c91858f7a0 |
| nodejs#10729 | https://github.com/nodejs/node/pull/10729 |
| jasnell | https://github.com/jasnell |
|
Mar 8, 2017
| https://github.com/nodejs/node/pull/10729#ref-commit-d481a63 |
|
| https://github.com/hiroppy |
|
| https://github.com/jasnell |
| test: refactor test-fs-read-zero-length.js | https://github.com/nodejs/node/commit/d481a63149abba3a27f9d7af14f517826bb5e834 |
| d481a63 | https://github.com/nodejs/node/commit/d481a63149abba3a27f9d7af14f517826bb5e834 |
| #10729 | https://github.com/nodejs/node/pull/10729 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10729#event-992135731 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10729#issuecomment-285179235 |
| Please reload this page | https://github.com/nodejs/node/pull/10729 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10729#ref-commit-8f984c3 |
|
| https://github.com/hiroppy |
|
| https://github.com/MylesBorins |
| test: refactor test-fs-read-zero-length.js | https://github.com/nodejs/node/commit/8f984c3a8a1c42fb190bfdc3dd05565af2c145c9 |
| 8f984c3 | https://github.com/nodejs/node/commit/8f984c3a8a1c42fb190bfdc3dd05565af2c145c9 |
| #10729 | https://github.com/nodejs/node/pull/10729 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10729#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10729 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10729/files/a42ced25203b1d86e381edc50255d7d3c2a5522a |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/10729/files/a42ced25203b1d86e381edc50255d7d3c2a5522a |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/10729 |
|
| https://github.com/hiroppy |
|
| https://github.com/gibfahn |
|
| https://github.com/italoacasas |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |