René's URL Explorer Experiment


Title: test: improve test-stream2-large-read-stall by stefanjudis · Pull Request #10725 · nodejs/node · GitHub

Open Graph Title: test: improve test-stream2-large-read-stall by stefanjudis · Pull Request #10725 · nodejs/node

X Title: test: improve test-stream2-large-read-stall by stefanjudis · Pull Request #10725 · nodejs/node

Description: use const instead of var use assert.strictEqual instead of assert.equal use common.mustCall instead of process.on( 'exit', fn ) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passe...

Open Graph Description: use const instead of var use assert.strictEqual instead of assert.equal use common.mustCall instead of process.on( 'exit', fn ) Checklist make -j4 test (UNIX), or vcbuild test (Window...

X Description: use const instead of var use assert.strictEqual instead of assert.equal use common.mustCall instead of process.on( 'exit', fn ) Checklist make -j4 test (UNIX), or vcbuild test...

Opengraph URL: https://github.com/nodejs/node/pull/10725

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:af3bcb93-0bb4-c205-f45c-5dfd00633241
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9480:392B41:5112A9:6F92A9:696A76BB
html-safe-nonce90a5632c0c66d5ca7f269f475477ec8344b33753b00983e6dfa63c0957e27811
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDgwOjM5MkI0MTo1MTEyQTk6NkY5MkE5OjY5NkE3NkJCIiwidmlzaXRvcl9pZCI6Ijc5Mjg1MTg2MTA5NjEyMDA4MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac90d8adf6fada360d9610757b5041c7d9f29ff5f9cc63ae6eac6e576524a4f408
hovercard-subject-tagpull_request:100909868
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10725/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/814bc28515ae859eca241bc5f6ff62f7e4f666e5cadc81702fda7443e6194332/nodejs/node/pull/10725
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/814bc28515ae859eca241bc5f6ff62f7e4f666e5cadc81702fda7443e6194332/nodejs/node/pull/10725
og:image:altuse const instead of var use assert.strictEqual instead of assert.equal use common.mustCall instead of process.on( 'exit', fn ) Checklist make -j4 test (UNIX), or vcbuild test (Window...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestefanjudis
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/10725#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10725
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10725
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/10725
Reloadhttps://github.com/nodejs/node/pull/10725
Reloadhttps://github.com/nodejs/node/pull/10725
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/10725
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/10725
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/10725#issue-comment-box
stefanjudishttps://github.com/stefanjudis
nodejs:masterhttps://github.com/nodejs/node/tree/master
test: improve test-stream2-large-read-stall https://github.com/nodejs/node/pull/10725#top
stefanjudishttps://github.com/stefanjudis
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversation 9 https://github.com/nodejs/node/pull/10725
Commits 1 https://github.com/nodejs/node/pull/10725/commits
Checks 0 https://github.com/nodejs/node/pull/10725/checks
Files changed https://github.com/nodejs/node/pull/10725/files
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/stefanjudis
stefanjudishttps://github.com/stefanjudis
Jan 10, 2017https://github.com/nodejs/node/pull/10725#issue-199872378
Please reload this pagehttps://github.com/nodejs/node/pull/10725
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 10, 2017https://github.com/nodejs/node/pull/10725#event-917800874
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 10, 2017 https://github.com/nodejs/node/pull/10725#pullrequestreview-15962030
View reviewed changes https://github.com/nodejs/node/pull/10725/files
https://github.com/mscdex
mscdexhttps://github.com/mscdex
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 10, 2017https://github.com/nodejs/node/pull/10725#event-917859595
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 10, 2017 https://github.com/nodejs/node/pull/10725#pullrequestreview-16023274
View reviewed changes https://github.com/nodejs/node/pull/10725/files
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 10, 2017https://github.com/nodejs/node/pull/10725#issuecomment-271711843
https://ci.nodejs.org/job/node-test-pull-request/5796/consolehttps://ci.nodejs.org/job/node-test-pull-request/5796/console
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.com/stefanjudis
stefanjudishttps://github.com/stefanjudis
Jan 10, 2017https://github.com/nodejs/node/pull/10725#issuecomment-271713349
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 10, 2017https://github.com/nodejs/node/pull/10725#issuecomment-271716072
@stefanjudishttps://github.com/stefanjudis
https://ci.nodejs.org/job/node-test-pull-request/5797/https://ci.nodejs.org/job/node-test-pull-request/5797/
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 10, 2017https://github.com/nodejs/node/pull/10725#issuecomment-271716169
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.com/stefanjudis
stefanjudishttps://github.com/stefanjudis
Jan 10, 2017https://github.com/nodejs/node/pull/10725#issuecomment-271716797
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 10, 2017https://github.com/nodejs/node/pull/10725#issuecomment-271717352
the Reviewing PRs section of the onboarding dochttps://github.com/nodejs/node/blob/master/doc/onboarding.md#reviewing-prs
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 16, 2017https://github.com/nodejs/node/pull/10725#issuecomment-272969348
@stefanjudishttps://github.com/stefanjudis
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.com/stefanjudis
test: improve test-stream2-large-read-stallhttps://github.com/nodejs/node/pull/10725/commits/d633d3a27d2df097f50df78d56ce8cf9740d34db
d633d3ahttps://github.com/nodejs/node/pull/10725/commits/d633d3a27d2df097f50df78d56ce8cf9740d34db
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 16, 2017https://github.com/nodejs/node/pull/10725#event-924929413
https://github.com/stefanjudis
stefanjudishttps://github.com/stefanjudis
Jan 16, 2017https://github.com/nodejs/node/pull/10725#issuecomment-272972475
@italoacasashttps://github.com/italoacasas
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Jan 16, 2017https://github.com/nodejs/node/pull/10725#event-924932514
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 16, 2017https://github.com/nodejs/node/pull/10725#issuecomment-272973164
c685638https://github.com/nodejs/node/commit/c685638986347557b70f9a1d3437508282012ba3
@stefanjudishttps://github.com/stefanjudis
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 16, 2017https://github.com/nodejs/node/pull/10725#event-924934624
italoacasashttps://github.com/italoacasas
Jan 16, 2017 https://github.com/nodejs/node/pull/10725#ref-commit-c685638
https://github.com/stefanjudis
test: improve test-stream2-large-read-stallhttps://github.com/nodejs/node/commit/c685638986347557b70f9a1d3437508282012ba3
c685638https://github.com/nodejs/node/commit/c685638986347557b70f9a1d3437508282012ba3
#10725https://github.com/nodejs/node/pull/10725
https://github.com/stefanjudis
stefanjudishttps://github.com/stefanjudis
January 16, 2017 22:12https://github.com/nodejs/node/pull/10725#event-924937988
italoacasashttps://github.com/italoacasas
Jan 18, 2017 https://github.com/nodejs/node/pull/10725#ref-commit-e9f5b7c
https://github.com/stefanjudis
test: improve test-stream2-large-read-stallhttps://github.com/italoacasas/node/commit/e9f5b7ca7591e6ca3929401450786318f612d4f9
e9f5b7chttps://github.com/italoacasas/node/commit/e9f5b7ca7591e6ca3929401450786318f612d4f9
nodejs#10725https://github.com/nodejs/node/pull/10725
v7.x-staging update proposal #10886 https://github.com/nodejs/node/pull/10886
Proposal to update v7.x-staging #10989 https://github.com/nodejs/node/pull/10989
targoshttps://github.com/targos
Jan 28, 2017 https://github.com/nodejs/node/pull/10725#ref-commit-bdc445c
https://github.com/stefanjudis
https://github.com/targos
test: improve test-stream2-large-read-stallhttps://github.com/nodejs/node/commit/bdc445c309ca67feed8b5393832899c827a95346
bdc445chttps://github.com/nodejs/node/commit/bdc445c309ca67feed8b5393832899c827a95346
#10725https://github.com/nodejs/node/pull/10725
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 29, 2017 https://github.com/nodejs/node/pull/10725#ref-pullrequest-203846723
v7.5.0 proposal #11062 https://github.com/nodejs/node/pull/11062
italoacasashttps://github.com/italoacasas
Jan 30, 2017 https://github.com/nodejs/node/pull/10725#ref-commit-46bbabe
https://github.com/stefanjudis
test: improve test-stream2-large-read-stallhttps://github.com/italoacasas/node/commit/46bbabe6c218d08f771c8b85ae04ca8374349856
46bbabehttps://github.com/italoacasas/node/commit/46bbabe6c218d08f771c8b85ae04ca8374349856
nodejs#10725https://github.com/nodejs/node/pull/10725
italoacasashttps://github.com/italoacasas
Jan 30, 2017 https://github.com/nodejs/node/pull/10725#ref-commit-ab335fd
https://github.com/stefanjudis
test: improve test-stream2-large-read-stallhttps://github.com/italoacasas/node/commit/ab335fd3929391d385187c89910f692db1f9bc13
ab335fdhttps://github.com/italoacasas/node/commit/ab335fd3929391d385187c89910f692db1f9bc13
nodejs#10725https://github.com/nodejs/node/pull/10725
jasnellhttps://github.com/jasnell
Mar 8, 2017 https://github.com/nodejs/node/pull/10725#ref-commit-562f23f
https://github.com/stefanjudis
https://github.com/jasnell
test: improve test-stream2-large-read-stallhttps://github.com/nodejs/node/commit/562f23f2f97848cdc46512b8246b31d80b8765e5
562f23fhttps://github.com/nodejs/node/commit/562f23f2f97848cdc46512b8246b31d80b8765e5
#10725https://github.com/nodejs/node/pull/10725
jasnellhttps://github.com/jasnell
Mar 8, 2017 https://github.com/nodejs/node/pull/10725#ref-commit-3c5f65f
https://github.com/stefanjudis
https://github.com/jasnell
test: improve test-stream2-large-read-stallhttps://github.com/nodejs/node/commit/3c5f65fcf5289023c3d6390b9a6ffa053a695dca
3c5f65fhttps://github.com/nodejs/node/commit/3c5f65fcf5289023c3d6390b9a6ffa053a695dca
#10725https://github.com/nodejs/node/pull/10725
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/10725#ref-commit-b01db3a
https://github.com/stefanjudis
https://github.com/MylesBorins
test: improve test-stream2-large-read-stallhttps://github.com/nodejs/node/commit/b01db3a73f53b50a454333c992063692470e16e3
b01db3ahttps://github.com/nodejs/node/commit/b01db3a73f53b50a454333c992063692470e16e3
#10725https://github.com/nodejs/node/pull/10725
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/10725#ref-pullrequest-212909365
v6.10.1 proposal #11759 https://github.com/nodejs/node/pull/11759
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/10725#ref-commit-ee27917
https://github.com/stefanjudis
https://github.com/MylesBorins
test: improve test-stream2-large-read-stallhttps://github.com/nodejs/node/commit/ee27917a651ae0c8868dcdee16c5eb1b375425c3
ee27917https://github.com/nodejs/node/commit/ee27917a651ae0c8868dcdee16c5eb1b375425c3
#10725https://github.com/nodejs/node/pull/10725
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/10725#ref-pullrequest-212910576
v4.8.1 proposal #11760 https://github.com/nodejs/node/pull/11760
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10725
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/10725/files/8df9b5cc1d6cce82941b7dcc57fd506aa03828da
https://github.com/italoacasas
italoacasas https://github.com/italoacasas
https://github.com/nodejs/node/pull/10725/files/8df9b5cc1d6cce82941b7dcc57fd506aa03828da
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/10725
https://github.com/stefanjudis
https://github.com/italoacasas
https://github.com/Trott
https://github.com/jasnell
https://github.com/mscdex
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.