| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4b956ae1-18dc-e005-7b12-3ab1c1b4fe4e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ADF0:3B18F:11EBA6B:18B4C85:6969F817 |
| html-safe-nonce | 640c612eb6569c06259076026d258da8b2ecced36b0d43f01cf535546ebc2bd5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREYwOjNCMThGOjExRUJBNkI6MThCNEM4NTo2OTY5RjgxNyIsInZpc2l0b3JfaWQiOiI4NzUxMjY0NzAyMjU2NTEwOTk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4f21d80a2c48cfa90c618fb8b8fff89dc00d9aa4cb750b952a66aef2a0285096 |
| hovercard-subject-tag | pull_request:100756023 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10716/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/83cd0abb2e29a3b06f16adad6be51af83976fc51b9dd111306165fb746cf8e32/nodejs/node/pull/10716 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/83cd0abb2e29a3b06f16adad6be51af83976fc51b9dd111306165fb746cf8e32/nodejs/node/pull/10716 |
| og:image:alt | And allow anchor links to the various sections, to more easily reference
them when reviewing PRs.
Checklist
documentation is changed or added
commit message follows commit guidelines
Affected c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sam-github |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10716#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10716 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10716 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10716 |
| Reload | https://github.com/nodejs/node/pull/10716 |
| Reload | https://github.com/nodejs/node/pull/10716 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10716 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10716 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10716#issue-comment-box |
| sam-github | https://github.com/sam-github |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sam-github:tests-sort-requires | https://github.com/sam-github/node/tree/tests-sort-requires |
|
doc: specify sorted tests
| https://github.com/nodejs/node/pull/10716#top |
| sam-github | https://github.com/sam-github |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sam-github:tests-sort-requires | https://github.com/sam-github/node/tree/tests-sort-requires |
|
Conversation
2
| https://github.com/nodejs/node/pull/10716 |
|
Commits
0
| https://github.com/nodejs/node/pull/10716/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10716/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10716/files |
| Please reload this page | https://github.com/nodejs/node/pull/10716 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jan 9, 2017 | https://github.com/nodejs/node/pull/10716#issue-199655396 |
| Please reload this page | https://github.com/nodejs/node/pull/10716 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Jan 9, 2017 | https://github.com/nodejs/node/pull/10716#event-916536985 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Trott | https://github.com/Trott |
| gibfahn | https://github.com/gibfahn |
| January 9, 2017 20:37 | https://github.com/nodejs/node/pull/10716#event-916537244 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Jan 9, 2017
| https://github.com/nodejs/node/pull/10716#ref-pullrequest-196996139 |
|
Doc and test cert apis
#10389
| https://github.com/nodejs/node/pull/10389 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jan 9, 2017 | https://github.com/nodejs/node/pull/10716#event-916710463 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 9, 2017
| https://github.com/nodejs/node/pull/10716#pullrequestreview-15822985 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10716/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10716#pullrequestreview-15828052 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10716/files |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/10716#pullrequestreview-15828052 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10716 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10716#pullrequestreview-15844458 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10716/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10716#pullrequestreview-15858359 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10716/files |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10716#pullrequestreview-15865289 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10716/files |
| gibfahn | https://github.com/gibfahn |
| https://github.com/nodejs/node/pull/10716#pullrequestreview-15865289 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10716 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/f47799004570a2e77943c27993154001ff5d4249..a1ba90d682aaa4b8a4e6dd6912b31238c2cdff06 |
| f477990 | https://github.com/nodejs/node/commit/f47799004570a2e77943c27993154001ff5d4249 |
| a1ba90d | https://github.com/nodejs/node/commit/a1ba90d682aaa4b8a4e6dd6912b31238c2cdff06 |
|
Compare
| https://github.com/nodejs/node/compare/f47799004570a2e77943c27993154001ff5d4249..a1ba90d682aaa4b8a4e6dd6912b31238c2cdff06 |
| January 10, 2017 15:31 | https://github.com/nodejs/node/pull/10716#event-917677286 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10716#event-917678763 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/a1ba90d682aaa4b8a4e6dd6912b31238c2cdff06..5aa210afe6f204682d6859ce5644b89cb91d3f13 |
| a1ba90d | https://github.com/nodejs/node/commit/a1ba90d682aaa4b8a4e6dd6912b31238c2cdff06 |
| 5aa210a | https://github.com/nodejs/node/commit/5aa210afe6f204682d6859ce5644b89cb91d3f13 |
|
Compare
| https://github.com/nodejs/node/compare/a1ba90d682aaa4b8a4e6dd6912b31238c2cdff06..5aa210afe6f204682d6859ce5644b89cb91d3f13 |
| January 10, 2017 15:32 | https://github.com/nodejs/node/pull/10716#event-917678764 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| January 10, 2017 15:32 | https://github.com/nodejs/node/pull/10716#event-917678869 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10716#event-917678939 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| 5aa210a | https://github.com/nodejs/node/commit/5aa210afe6f204682d6859ce5644b89cb91d3f13 |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10716#event-917679377 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10716#ref-commit-73527d1 |
|
| https://github.com/sam-github |
| doc: specify sorted requires in tests | https://github.com/italoacasas/node/commit/73527d1b6a82cd402f870965b58cda33bea8e6c1 |
| 73527d1 | https://github.com/italoacasas/node/commit/73527d1b6a82cd402f870965b58cda33bea8e6c1 |
| nodejs#10716 | https://github.com/nodejs/node/pull/10716 |
| italoacasas | https://github.com/italoacasas |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10716#ref-commit-19e1220 |
|
| https://github.com/sam-github |
| doc: specify sorted requires in tests | https://github.com/italoacasas/node/commit/19e1220c4128f48e22a55cc6704c0dda0fbdcbda |
| 19e1220 | https://github.com/italoacasas/node/commit/19e1220c4128f48e22a55cc6704c0dda0fbdcbda |
| nodejs#10716 | https://github.com/nodejs/node/pull/10716 |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/10716#ref-commit-27067c7 |
|
| https://github.com/sam-github |
| doc: specify sorted requires in tests | https://github.com/italoacasas/node/commit/27067c7c1f1d0bc7e8d035d32e277cd2c1293fe5 |
| 27067c7 | https://github.com/italoacasas/node/commit/27067c7c1f1d0bc7e8d035d32e277cd2c1293fe5 |
| nodejs#10716 | https://github.com/nodejs/node/pull/10716 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/10716#ref-pullrequest-203011190 |
|
Proposal to update v7.x-staging
#10989
| https://github.com/nodejs/node/pull/10989 |
| italoacasas | https://github.com/italoacasas |
|
Jan 27, 2017
| https://github.com/nodejs/node/pull/10716#ref-commit-09ac2a2 |
|
| https://github.com/sam-github |
| doc: specify sorted requires in tests | https://github.com/italoacasas/node/commit/09ac2a2cb7a8a18068016b8b2c707bcd297c04c8 |
| 09ac2a2 | https://github.com/italoacasas/node/commit/09ac2a2cb7a8a18068016b8b2c707bcd297c04c8 |
| nodejs#10716 | https://github.com/nodejs/node/pull/10716 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/10716#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 8, 2017
| https://github.com/nodejs/node/pull/10716#ref-commit-ea2973e |
|
| https://github.com/sam-github |
|
| https://github.com/MylesBorins |
| doc: specify sorted requires in tests | https://github.com/nodejs/node/commit/ea2973e87bdbee9ed263462ea1b85e4d1261c998 |
| ea2973e | https://github.com/nodejs/node/commit/ea2973e87bdbee9ed263462ea1b85e4d1261c998 |
| #10716 | https://github.com/nodejs/node/pull/10716 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10716#event-990580445 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10716#event-990580450 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10716#ref-commit-fa8a394 |
|
| https://github.com/sam-github |
|
| https://github.com/MylesBorins |
| doc: specify sorted requires in tests | https://github.com/nodejs/node/commit/fa8a394e51f07f67cd8d6e82af10968c614e8cfd |
| fa8a394 | https://github.com/nodejs/node/commit/fa8a394e51f07f67cd8d6e82af10968c614e8cfd |
| #10716 | https://github.com/nodejs/node/pull/10716 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10716#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10716 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10716/files/f47799004570a2e77943c27993154001ff5d4249 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/10716/files/f47799004570a2e77943c27993154001ff5d4249 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/10716/files/f47799004570a2e77943c27993154001ff5d4249 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/10716/files/f47799004570a2e77943c27993154001ff5d4249 |
|
| https://github.com/gibfahn |
|
gibfahn
| https://github.com/gibfahn |
|
| https://github.com/nodejs/node/pull/10716/files/f47799004570a2e77943c27993154001ff5d4249 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/10716 |
|
| https://github.com/sam-github |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/gibfahn |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |