| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4ee339ed-ca73-29d8-16c2-3cee2c1bb607 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC10:6FDD1:5CF6E0:7C42F9:6969B4CD |
| html-safe-nonce | 6c37e0bc4452709efa658b2964bd35a27f969fbbfbf3c3689f3bc1191d1f636a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzEwOjZGREQxOjVDRjZFMDo3QzQyRjk6Njk2OUI0Q0QiLCJ2aXNpdG9yX2lkIjoiNzU5NzYzNzk1NTQyOTcwOTAwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | df224a3cc614e688fd89c0dc03e87fe5b85875bba21526f71cdc2ecf70a5b960 |
| hovercard-subject-tag | pull_request:100621270 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10698/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/37403ef4f9b3ee22d7ee9eba659f00880405a7d52514feba7a184dc3d4437940/nodejs/node/pull/10698 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/37403ef4f9b3ee22d7ee9eba659f00880405a7d52514feba7a184dc3d4437940/nodejs/node/pull/10698 |
| og:image:alt | Convert assert.equal() to assert.strictEqual() in test/ (no instances found elsewhere by eslint). Also adds a rule to enforce strict equal/notEqual.
Checklist
make -j4 test (UNIX), or vcbuild te... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gibfahn |
| hostname | github.com |
| expected-hostname | github.com |
| None | b23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0672399d88424758731ec07fe24509e23bb17fb5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10698#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10698 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10698 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10698 |
| Reload | https://github.com/nodejs/node/pull/10698 |
| Reload | https://github.com/nodejs/node/pull/10698 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10698#issue-comment-box |
| gibfahn | https://github.com/gibfahn |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gibfahn:assert-strict | https://github.com/gibfahn/node/tree/assert-strict |
|
test, eslintrc: s/assert.equal/assert.strictEqual/
| https://github.com/nodejs/node/pull/10698#top |
| gibfahn | https://github.com/gibfahn |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| gibfahn:assert-strict | https://github.com/gibfahn/node/tree/assert-strict |
|
Conversation
30
| https://github.com/nodejs/node/pull/10698 |
|
Commits
2
| https://github.com/nodejs/node/pull/10698/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10698/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10698/files |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10698#issue-199455969 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10698#event-915383328 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-271188873 |
| 44ee9af | https://github.com/nodejs/node/commit/44ee9af02d4ce405c65b1a1a528edabe7b1339da |
| f8c6620 | https://github.com/nodejs/node/commit/f8c66203e7a981908162fe43edf95619c9023759 |
| https://ci.nodejs.org/job/node-test-commit/7105/ | https://ci.nodejs.org/job/node-test-commit/7105/ |
| @Trott | https://github.com/Trott |
| @silverwind | https://github.com/silverwind |
| @not-an-aardvark | https://github.com/not-an-aardvark |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10698#event-915384174 |
| https://github.com/not-an-aardvark |
| not-an-aardvark | https://github.com/not-an-aardvark |
| Jan 9, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-271191159 |
| no-restricted-properties | http://eslint.org/docs/rules/no-restricted-properties |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 9, 2017 | https://github.com/nodejs/node/pull/10698#event-915473306 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 9, 2017
| https://github.com/nodejs/node/pull/10698#pullrequestreview-15646297 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10698/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/10698#pullrequestreview-15646297 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| Jan 9, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-271211358 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
|
Jan 9, 2017
| https://github.com/nodejs/node/pull/10698#ref-pullrequest-199489778 |
|
test: refactor cluster-preload.js
#10701
| https://github.com/nodejs/node/pull/10701 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 9, 2017
| https://github.com/nodejs/node/pull/10698#pullrequestreview-15731240 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10698/files |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jan 9, 2017
| https://github.com/nodejs/node/pull/10698#pullrequestreview-15822773 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10698/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/10698#pullrequestreview-15822773 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10698#pullrequestreview-15850415 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10698/files |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| force-pushed | https://github.com/nodejs/node/compare/f8c66203e7a981908162fe43edf95619c9023759..156eb3224336b1da1ad93a81acdc7e6af13ee5b5 |
| f8c6620 | https://github.com/nodejs/node/commit/f8c66203e7a981908162fe43edf95619c9023759 |
| 156eb32 | https://github.com/nodejs/node/commit/156eb3224336b1da1ad93a81acdc7e6af13ee5b5 |
|
Compare
| https://github.com/nodejs/node/compare/f8c66203e7a981908162fe43edf95619c9023759..156eb3224336b1da1ad93a81acdc7e6af13ee5b5 |
| January 10, 2017 09:44 | https://github.com/nodejs/node/pull/10698#event-917229348 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#event-917229420 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-271540200 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| @not-an-aardvark | https://github.com/not-an-aardvark |
| @Trott | https://github.com/Trott |
| @targos | https://github.com/targos |
| @silverwind | https://github.com/silverwind |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| force-pushed | https://github.com/nodejs/node/compare/156eb3224336b1da1ad93a81acdc7e6af13ee5b5..fb9c76fdcebb4c5319e3595aa1764a91109561bf |
| 156eb32 | https://github.com/nodejs/node/commit/156eb3224336b1da1ad93a81acdc7e6af13ee5b5 |
| fb9c76f | https://github.com/nodejs/node/commit/fb9c76fdcebb4c5319e3595aa1764a91109561bf |
|
Compare
| https://github.com/nodejs/node/compare/156eb3224336b1da1ad93a81acdc7e6af13ee5b5..fb9c76fdcebb4c5319e3595aa1764a91109561bf |
| January 10, 2017 10:34 | https://github.com/nodejs/node/pull/10698#event-917293768 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#event-917293829 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-271541495 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://ci.nodejs.org/job/node-test-commit/7137/ | https://ci.nodejs.org/job/node-test-commit/7137/ |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10698#pullrequestreview-15900055 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10698/files |
| test/parallel/test-process-kill-pid.js | https://github.com/nodejs/node/pull/10698/files#diff-331b5f2604e5f3e7badd16965768b176d307daeb318afede927d983e3c38dcca |
| targos | https://github.com/targos |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#discussion_r95349273 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| gibfahn | https://github.com/gibfahn |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#discussion_r95463693 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| .eslintrc | https://github.com/nodejs/node/pull/10698/files#diff-e7e195d3d8fa5b82fa51ed952f3a179d429cbc46c0432ce1f7b357c54c162822 |
| targos | https://github.com/targos |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#discussion_r95349580 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| gibfahn | https://github.com/gibfahn |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#discussion_r95463729 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| .eslintrc | https://github.com/nodejs/node/pull/10698/files#diff-e7e195d3d8fa5b82fa51ed952f3a179d429cbc46c0432ce1f7b357c54c162822 |
| targos | https://github.com/targos |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#discussion_r95349739 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| gibfahn | https://github.com/gibfahn |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#discussion_r95463719 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/not-an-aardvark |
| not-an-aardvark | https://github.com/not-an-aardvark |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10698#pullrequestreview-15932971 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10698/files |
| not-an-aardvark | https://github.com/not-an-aardvark |
| https://github.com/nodejs/node/pull/10698#pullrequestreview-15932971 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| lib/assert.js | https://github.com/nodejs/node/pull/10698/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f |
| not-an-aardvark | https://github.com/not-an-aardvark |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#discussion_r95380484 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| gibfahn | https://github.com/gibfahn |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#discussion_r95409718 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| L136 | https://github.com/nodejs/node/pull/10698/commits/fb9c76fdcebb4c5319e3595aa1764a91109561bf#diff-f76cd6d4ba3dad8b6b9a393af1fce15bL136 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| Trott | https://github.com/Trott |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#discussion_r95414964 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-271634523 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| force-pushed | https://github.com/nodejs/node/compare/fb9c76fdcebb4c5319e3595aa1764a91109561bf..b74cb12c330951208c49d27b3769dd0ab391ed89 |
| fb9c76f | https://github.com/nodejs/node/commit/fb9c76fdcebb4c5319e3595aa1764a91109561bf |
| b74cb12 | https://github.com/nodejs/node/commit/b74cb12c330951208c49d27b3769dd0ab391ed89 |
|
Compare
| https://github.com/nodejs/node/compare/fb9c76fdcebb4c5319e3595aa1764a91109561bf..b74cb12c330951208c49d27b3769dd0ab391ed89 |
| January 10, 2017 21:41 | https://github.com/nodejs/node/pull/10698#event-918220366 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#event-918220462 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| force-pushed | https://github.com/nodejs/node/compare/b74cb12c330951208c49d27b3769dd0ab391ed89..c2e0cd998f18102c0081caeba3bb54677537e9cd |
| b74cb12 | https://github.com/nodejs/node/commit/b74cb12c330951208c49d27b3769dd0ab391ed89 |
| c2e0cd9 | https://github.com/nodejs/node/commit/c2e0cd998f18102c0081caeba3bb54677537e9cd |
|
Compare
| https://github.com/nodejs/node/compare/b74cb12c330951208c49d27b3769dd0ab391ed89..c2e0cd998f18102c0081caeba3bb54677537e9cd |
| January 10, 2017 21:48 | https://github.com/nodejs/node/pull/10698#event-918228465 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#event-918228528 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-271709476 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| here | https://github.com/nodejs/node/pull/10698#discussion_r95463693 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-271711522 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| force-pushed | https://github.com/nodejs/node/compare/c2e0cd998f18102c0081caeba3bb54677537e9cd..947fd997b81231efdeee301de2fab465e9ac47ef |
| c2e0cd9 | https://github.com/nodejs/node/commit/c2e0cd998f18102c0081caeba3bb54677537e9cd |
| 947fd99 | https://github.com/nodejs/node/commit/947fd997b81231efdeee301de2fab465e9ac47ef |
|
Compare
| https://github.com/nodejs/node/compare/c2e0cd998f18102c0081caeba3bb54677537e9cd..947fd997b81231efdeee301de2fab465e9ac47ef |
| January 10, 2017 22:47 | https://github.com/nodejs/node/pull/10698#event-918306579 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#event-918306663 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-271723124 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10698#ref-pullrequest-199958685 |
|
test: refactor test-fs-read-zero-length.js
#10729
| https://github.com/nodejs/node/pull/10729 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-274555367 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| @italoacasas | https://github.com/italoacasas |
| #10685 | https://github.com/nodejs/node/pull/10685 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| italoacasas | https://github.com/italoacasas |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-5159f6c |
|
| https://github.com/gibfahn |
| assert, tools: enforce strict (not)equal in eslint | https://github.com/italoacasas/node/commit/5159f6c23da3f741e2583c7697b29398072286bb |
| 5159f6c | https://github.com/italoacasas/node/commit/5159f6c23da3f741e2583c7697b29398072286bb |
| nodejs#10698 | https://github.com/nodejs/node/pull/10698 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/10698#ref-pullrequest-203011190 |
|
Proposal to update v7.x-staging
#10989
| https://github.com/nodejs/node/pull/10989 |
| targos | https://github.com/targos |
|
Jan 28, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-fb2e16f |
|
| https://github.com/gibfahn |
|
| https://github.com/targos |
| test: s/assert.equal/assert.strictEqual/ | https://github.com/nodejs/node/commit/fb2e16fc0d7d209e99a5236f8e24b1c84ae77cb9 |
| fb2e16f | https://github.com/nodejs/node/commit/fb2e16fc0d7d209e99a5236f8e24b1c84ae77cb9 |
| #10698 | https://github.com/nodejs/node/pull/10698 |
| targos | https://github.com/targos |
|
Jan 28, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-3dd2124 |
|
| https://github.com/gibfahn |
|
| https://github.com/targos |
| assert, tools: enforce strict (not)equal in eslint | https://github.com/nodejs/node/commit/3dd212498affb6bcd0b025f0ad563c214b063795 |
| 3dd2124 | https://github.com/nodejs/node/commit/3dd212498affb6bcd0b025f0ad563c214b063795 |
| #10698 | https://github.com/nodejs/node/pull/10698 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/10698#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| January 29, 2017 22:29 | https://github.com/nodejs/node/pull/10698#event-940688432 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| January 29, 2017 22:32 | https://github.com/nodejs/node/pull/10698#event-940689197 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-51f4c8b |
|
| https://github.com/gibfahn |
| test: s/assert.equal/assert.strictEqual/ | https://github.com/italoacasas/node/commit/51f4c8bf5cd80d41071589ecafacbad7053f02d1 |
| 51f4c8b | https://github.com/italoacasas/node/commit/51f4c8bf5cd80d41071589ecafacbad7053f02d1 |
| nodejs#10698 | https://github.com/nodejs/node/pull/10698 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-c217b43 |
|
| https://github.com/gibfahn |
| assert, tools: enforce strict (not)equal in eslint | https://github.com/italoacasas/node/commit/c217b438f2793cbc9c85ae4bf9ba981fcb8f1f5a |
| c217b43 | https://github.com/italoacasas/node/commit/c217b438f2793cbc9c85ae4bf9ba981fcb8f1f5a |
| nodejs#10698 | https://github.com/nodejs/node/pull/10698 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-1917139 |
|
| https://github.com/gibfahn |
| test: s/assert.equal/assert.strictEqual/ | https://github.com/italoacasas/node/commit/1917139e0c28cef835491e97a97a438cd4304c20 |
| 1917139 | https://github.com/italoacasas/node/commit/1917139e0c28cef835491e97a97a438cd4304c20 |
| nodejs#10698 | https://github.com/nodejs/node/pull/10698 |
| italoacasas | https://github.com/italoacasas |
|
Jan 30, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-7cbb9e5 |
|
| https://github.com/gibfahn |
| assert, tools: enforce strict (not)equal in eslint | https://github.com/italoacasas/node/commit/7cbb9e59c2b7c71111ad1a06a66cad745155f051 |
| 7cbb9e5 | https://github.com/italoacasas/node/commit/7cbb9e59c2b7c71111ad1a06a66cad745155f051 |
| nodejs#10698 | https://github.com/nodejs/node/pull/10698 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-285166066 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10698#event-992059882 |
| https://github.com/davidben |
| davidben | https://github.com/davidben |
|
Mar 8, 2017
| https://github.com/nodejs/node/pull/10698#ref-pullrequest-201683013 |
|
crypto: Remove unused access of tlsext_hostname.
#10882
| https://github.com/nodejs/node/pull/10882 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Mar 9, 2017 | https://github.com/nodejs/node/pull/10698#issuecomment-285271560 |
| #10685 | https://github.com/nodejs/node/pull/10685 |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| March 9, 2017 08:28 | https://github.com/nodejs/node/pull/10698#event-992717016 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Mar 10, 2017
| https://github.com/nodejs/node/pull/10698#ref-pullrequest-213094282 |
|
v4.x backport - test: convert var->const/let in tests
#11773
| https://github.com/nodejs/node/pull/11773 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Mar 11, 2017
| https://github.com/nodejs/node/pull/10698#ref-pullrequest-213492244 |
|
v6.x Backport - test, eslintrc: s/assert.equal/assert.strictEqual/
#11795
| https://github.com/nodejs/node/pull/11795 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 14, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-a654502 |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
| test: s/assert.equal/assert.strictEqual/ | https://github.com/nodejs/node/commit/a6545029104ab6412bea5de70fa224384adda858 |
| a654502 | https://github.com/nodejs/node/commit/a6545029104ab6412bea5de70fa224384adda858 |
| #11795 | https://github.com/nodejs/node/pull/11795 |
| #10698 | https://github.com/nodejs/node/pull/10698 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 14, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-acd9bc3 |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
| assert, tools: enforce strict (not)equal in eslint | https://github.com/nodejs/node/commit/acd9bc315b214ea226c43413acaa351495e594b6 |
| acd9bc3 | https://github.com/nodejs/node/commit/acd9bc315b214ea226c43413acaa351495e594b6 |
| #11795 | https://github.com/nodejs/node/pull/11795 |
| #10698 | https://github.com/nodejs/node/pull/10698 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 19, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-6f85c81 |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
| test: s/assert.equal/assert.strictEqual/ | https://github.com/nodejs/node/commit/6f85c81f0dc9e40511e98bd034c0a841ed764d3c |
| 6f85c81 | https://github.com/nodejs/node/commit/6f85c81f0dc9e40511e98bd034c0a841ed764d3c |
| #11795 | https://github.com/nodejs/node/pull/11795 |
| #10698 | https://github.com/nodejs/node/pull/10698 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 19, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-12c0ce7 |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
| assert, tools: enforce strict (not)equal in eslint | https://github.com/nodejs/node/commit/12c0ce749f3b4038b1847dfd18710655e565a5f4 |
| 12c0ce7 | https://github.com/nodejs/node/commit/12c0ce749f3b4038b1847dfd18710655e565a5f4 |
| #11795 | https://github.com/nodejs/node/pull/11795 |
| #10698 | https://github.com/nodejs/node/pull/10698 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 19, 2017
| https://github.com/nodejs/node/pull/10698#ref-pullrequest-222580733 |
|
v6.10.3 proposal
#12498
| https://github.com/nodejs/node/pull/12498 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| June 3, 2017 14:34 | https://github.com/nodejs/node/pull/10698#event-1108856808 |
| andrew749 | https://github.com/andrew749 |
|
Jul 19, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-3c6dbbb |
|
| https://github.com/gibfahn |
|
| https://github.com/andrew749 |
| test: s/assert.equal/assert.strictEqual/ | https://github.com/michielbaird/node/commit/3c6dbbb25d7fb28315d33107c20b8094eeb20fdc |
| 3c6dbbb | https://github.com/michielbaird/node/commit/3c6dbbb25d7fb28315d33107c20b8094eeb20fdc |
| nodejs/node#11795 | https://github.com/nodejs/node/pull/11795 |
| nodejs/node#10698 | https://github.com/nodejs/node/pull/10698 |
| andrew749 | https://github.com/andrew749 |
|
Jul 19, 2017
| https://github.com/nodejs/node/pull/10698#ref-commit-88a4ebc |
|
| https://github.com/gibfahn |
|
| https://github.com/andrew749 |
| assert, tools: enforce strict (not)equal in eslint | https://github.com/michielbaird/node/commit/88a4ebcbc53a65e18929c17765e1080ee6438cfc |
| 88a4ebc | https://github.com/michielbaird/node/commit/88a4ebcbc53a65e18929c17765e1080ee6438cfc |
| nodejs/node#11795 | https://github.com/nodejs/node/pull/11795 |
| nodejs/node#10698 | https://github.com/nodejs/node/pull/10698 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10698 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/10698/files/fb9c76fdcebb4c5319e3595aa1764a91109561bf |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10698/files/f8c66203e7a981908162fe43edf95619c9023759 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/10698/files/c5c8ea4a19909fd1070be4346880ae9a7c644935 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/10698/files/f8c66203e7a981908162fe43edf95619c9023759 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/10698/files/f8c66203e7a981908162fe43edf95619c9023759 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/10698/files/f8c66203e7a981908162fe43edf95619c9023759 |
|
| https://github.com/not-an-aardvark |
|
not-an-aardvark
| https://github.com/not-an-aardvark |
|
| https://github.com/nodejs/node/pull/10698/files/fb9c76fdcebb4c5319e3595aa1764a91109561bf |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/10698 |
|
| https://github.com/gibfahn |
|
| https://github.com/not-an-aardvark |
|
| https://github.com/hiroppy |
|
| https://github.com/jasnell |
|
| https://github.com/italoacasas |
|
| https://github.com/MylesBorins |
|
| https://github.com/bnoordhuis |
|
| https://github.com/thefourtheye |
|
| https://github.com/Trott |
|
| https://github.com/targos |
|
| https://github.com/cjihrig |
|
| https://github.com/mhdawson |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |