| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b76ba5f3-8de1-4eff-ed42-bd6527bceb94 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB02:363784:7B73:A329:6969F882 |
| html-safe-nonce | 5934f83fff652d7388a78580ab4ee22363752a15b362861fad8fdde872b25369 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjAyOjM2Mzc4NDo3QjczOkEzMjk6Njk2OUY4ODIiLCJ2aXNpdG9yX2lkIjoiMTI2MzUyMjg2NzA3MjA3MTgxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e91a6527c0e8d0ce622368ecc2975a75a1c83fa25dce3c80dd70b822ab0f79d0 |
| hovercard-subject-tag | pull_request:100618608 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10696/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a69c414ef0330320f8a950f9e892003adf9e56335548fd2576d2b40c41d1439f/nodejs/node/pull/10696 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a69c414ef0330320f8a950f9e892003adf9e56335548fd2576d2b40c41d1439f/nodejs/node/pull/10696 |
| og:image:alt | Use let or const and arrow function.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
test |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hiroppy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10696#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10696 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10696 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10696 |
| Reload | https://github.com/nodejs/node/pull/10696 |
| Reload | https://github.com/nodejs/node/pull/10696 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10696 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10696 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10696#issue-comment-box |
| hiroppy | https://github.com/hiroppy |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hiroppy:feature/refactor-test-doctool | https://github.com/hiroppy/node/tree/feature/refactor-test-doctool |
|
test: refactor test doctool
| https://github.com/nodejs/node/pull/10696#top |
| hiroppy | https://github.com/hiroppy |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| hiroppy:feature/refactor-test-doctool | https://github.com/hiroppy/node/tree/feature/refactor-test-doctool |
|
Conversation
4
| https://github.com/nodejs/node/pull/10696 |
|
Commits
2
| https://github.com/nodejs/node/pull/10696/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10696/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10696/files |
| Please reload this page | https://github.com/nodejs/node/pull/10696 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10696#issue-199451691 |
| Please reload this page | https://github.com/nodejs/node/pull/10696 |
| hiroppy | https://github.com/hiroppy |
| January 9, 2017 07:16 | https://github.com/nodejs/node/pull/10696#commits-pushed-e97ee2f |
|
| https://github.com/hiroppy |
| test: refactor test-doctool-html.js | https://github.com/nodejs/node/pull/10696/commits/e97ee2f095130aa225c6218c28a32868b9c7fb7e |
| e97ee2f | https://github.com/nodejs/node/pull/10696/commits/e97ee2f095130aa225c6218c28a32868b9c7fb7e |
|
| https://github.com/hiroppy |
| test: refactor test-doctool-json.js | https://github.com/nodejs/node/pull/10696/commits/27a85b5d225eda767bd0c8ff319074fdd30dd045 |
| 27a85b5 | https://github.com/nodejs/node/pull/10696/commits/27a85b5d225eda767bd0c8ff319074fdd30dd045 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10696#event-915362619 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10696#event-915363644 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10696#event-915370638 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 9, 2017
| https://github.com/nodejs/node/pull/10696#pullrequestreview-15646448 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10696/files/27a85b5d225eda767bd0c8ff319074fdd30dd045 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 9, 2017
| https://github.com/nodejs/node/pull/10696#pullrequestreview-15653652 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10696/files/27a85b5d225eda767bd0c8ff319074fdd30dd045 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10696#pullrequestreview-15926389 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10696/files/27a85b5d225eda767bd0c8ff319074fdd30dd045 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/10696#pullrequestreview-15926389 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10696 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10696#issuecomment-271590868 |
| https://ci.nodejs.org/job/node-test-pull-request/5780/ | https://ci.nodejs.org/job/node-test-pull-request/5780/ |
| Please reload this page | https://github.com/nodejs/node/pull/10696 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10696#issuecomment-271635197 |
| Please reload this page | https://github.com/nodejs/node/pull/10696 |
| jasnell | https://github.com/jasnell |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10696#ref-commit-c61d9ba |
|
| https://github.com/hiroppy |
|
| https://github.com/jasnell |
| test: refactor test-doctool-html.js | https://github.com/nodejs/node/commit/c61d9bade0a90c9ad1a7c53637d1bdd80d6fbe63 |
| c61d9ba | https://github.com/nodejs/node/commit/c61d9bade0a90c9ad1a7c53637d1bdd80d6fbe63 |
| #10696 | https://github.com/nodejs/node/pull/10696 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10696#issuecomment-271637015 |
| c61d9ba | https://github.com/nodejs/node/commit/c61d9bade0a90c9ad1a7c53637d1bdd80d6fbe63 |
| Please reload this page | https://github.com/nodejs/node/pull/10696 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10696#event-917852103 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10696#ref-commit-6be3ab5 |
|
| https://github.com/hiroppy |
| test: refactor test-doctool-html.js | https://github.com/italoacasas/node/commit/6be3ab5be2483dd3855c6177d79027833979868b |
| 6be3ab5 | https://github.com/italoacasas/node/commit/6be3ab5be2483dd3855c6177d79027833979868b |
| nodejs#10696 | https://github.com/nodejs/node/pull/10696 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
| January 21, 2017 08:12 | https://github.com/nodejs/node/pull/10696#event-931624744 |
| italoacasas | https://github.com/italoacasas |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10696#ref-commit-71ac1c9 |
|
| https://github.com/hiroppy |
| test: refactor test-doctool-html.js | https://github.com/italoacasas/node/commit/71ac1c940822cbfdb70048223dc916d78b68b02d |
| 71ac1c9 | https://github.com/italoacasas/node/commit/71ac1c940822cbfdb70048223dc916d78b68b02d |
| nodejs#10696 | https://github.com/nodejs/node/pull/10696 |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/10696#ref-commit-ecb1771 |
|
| https://github.com/hiroppy |
| test: refactor test-doctool-html.js | https://github.com/italoacasas/node/commit/ecb177159a289fc22cc722352a6afa9039b5f1d4 |
| ecb1771 | https://github.com/italoacasas/node/commit/ecb177159a289fc22cc722352a6afa9039b5f1d4 |
| nodejs#10696 | https://github.com/nodejs/node/pull/10696 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/10696#ref-pullrequest-203011190 |
|
Proposal to update v7.x-staging
#10989
| https://github.com/nodejs/node/pull/10989 |
| italoacasas | https://github.com/italoacasas |
|
Jan 27, 2017
| https://github.com/nodejs/node/pull/10696#ref-commit-4c8676b |
|
| https://github.com/hiroppy |
| test: refactor test-doctool-html.js | https://github.com/italoacasas/node/commit/4c8676bc26357f561b8a5aeb2396bc75d51648d8 |
| 4c8676b | https://github.com/italoacasas/node/commit/4c8676bc26357f561b8a5aeb2396bc75d51648d8 |
| nodejs#10696 | https://github.com/nodejs/node/pull/10696 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/10696#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 8, 2017
| https://github.com/nodejs/node/pull/10696#ref-commit-4a9a43c |
|
| https://github.com/hiroppy |
|
| https://github.com/MylesBorins |
| test: refactor test-doctool-html.js | https://github.com/nodejs/node/commit/4a9a43c3edfd8d8c24050ef721f23a7fddb6b480 |
| 4a9a43c | https://github.com/nodejs/node/commit/4a9a43c3edfd8d8c24050ef721f23a7fddb6b480 |
| #10696 | https://github.com/nodejs/node/pull/10696 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 8, 2017
| https://github.com/nodejs/node/pull/10696#ref-commit-d494d84 |
|
| https://github.com/hiroppy |
|
| https://github.com/MylesBorins |
| test: refactor test-doctool-html.js | https://github.com/nodejs/node/commit/d494d84ea127fabd6c47fc84c640ff7b67832e79 |
| d494d84 | https://github.com/nodejs/node/commit/d494d84ea127fabd6c47fc84c640ff7b67832e79 |
| #10696 | https://github.com/nodejs/node/pull/10696 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10696#event-990581803 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10696#ref-commit-8565a06 |
|
| https://github.com/hiroppy |
|
| https://github.com/MylesBorins |
| test: refactor test-doctool-html.js | https://github.com/nodejs/node/commit/8565a06b093454d9121aa4b13ee5bb828c0df9b7 |
| 8565a06 | https://github.com/nodejs/node/commit/8565a06b093454d9121aa4b13ee5bb828c0df9b7 |
| #10696 | https://github.com/nodejs/node/pull/10696 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10696#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10696#ref-commit-4d51db8 |
|
| https://github.com/hiroppy |
|
| https://github.com/MylesBorins |
| test: refactor test-doctool-html.js | https://github.com/nodejs/node/commit/4d51db87dcac503bcfcd047d24debd5e88b696f3 |
| 4d51db8 | https://github.com/nodejs/node/commit/4d51db87dcac503bcfcd047d24debd5e88b696f3 |
| #10696 | https://github.com/nodejs/node/pull/10696 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10696#ref-pullrequest-212910576 |
|
v4.8.1 proposal
#11760
| https://github.com/nodejs/node/pull/11760 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10696 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10696/files/27a85b5d225eda767bd0c8ff319074fdd30dd045 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/10696/files/27a85b5d225eda767bd0c8ff319074fdd30dd045 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/10696/files/27a85b5d225eda767bd0c8ff319074fdd30dd045 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/10696 |
|
| https://github.com/hiroppy |
|
| https://github.com/mhdawson |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |