| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0fd2b7e8-dbb2-5667-9e2b-826b64341537 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AAA2:14EC01:1227EF5:195C532:696A3981 |
| html-safe-nonce | 6c263ce3b8a2dee1875915c43b04be8d5f1d364dab5ab746f02161eefb8fdb26 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUEyOjE0RUMwMToxMjI3RUY1OjE5NUM1MzI6Njk2QTM5ODEiLCJ2aXNpdG9yX2lkIjoiMTE5MDk4ODU1MzEzOTE0MDk5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 680e63ec22a896f4c2ecab9f760c7d005fcd7c2164ca402cbff9b7076b854e6b |
| hovercard-subject-tag | pull_request:100592237 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10682/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e7babec6b95cc9084071c29799a02e4f57e7fc8ac0f0fe93b067f32d4e0dfa20/nodejs/node/pull/10682 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e7babec6b95cc9084071c29799a02e4f57e7fc8ac0f0fe93b067f32d4e0dfa20/nodejs/node/pull/10682 |
| og:image:alt | refactor internal util.filterDuplicateStrings() to eliminate unused
code paths
.indexOf() -> .includes() in test
more concise arrow functions
Checklist
make -j4 test (UNIX), or vcbuild test... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10682#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10682 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10682 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10682 |
| Reload | https://github.com/nodejs/node/pull/10682 |
| Reload | https://github.com/nodejs/node/pull/10682 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10682 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10682 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10682#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:crypto-refactor | https://github.com/Trott/io.js/tree/crypto-refactor |
|
lib: refactor crypto cipher/hash/curve getters
| https://github.com/nodejs/node/pull/10682#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:crypto-refactor | https://github.com/Trott/io.js/tree/crypto-refactor |
|
Conversation
4
| https://github.com/nodejs/node/pull/10682 |
|
Commits
1
| https://github.com/nodejs/node/pull/10682/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10682/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10682/files |
| Please reload this page | https://github.com/nodejs/node/pull/10682 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10682#issue-199403084 |
| Please reload this page | https://github.com/nodejs/node/pull/10682 |
| Please reload this page | https://github.com/nodejs/node/pull/10682 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10682#event-915135106 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10682#event-915135114 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10682#issuecomment-271129980 |
| Please reload this page | https://github.com/nodejs/node/pull/10682 |
|
| https://github.com/Trott |
| lib: refactor crypto cipher/hash/curve getters | https://github.com/nodejs/node/pull/10682/commits/6c87bfc944bf44594a5ceb6cad4f221a704e9a13 |
| 6c87bfc | https://github.com/nodejs/node/pull/10682/commits/6c87bfc944bf44594a5ceb6cad4f221a704e9a13 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/f1fb91ee4ca5315de618e8c0710816c319677b31..6c87bfc944bf44594a5ceb6cad4f221a704e9a13 |
| f1fb91e | https://github.com/nodejs/node/commit/f1fb91ee4ca5315de618e8c0710816c319677b31 |
| 6c87bfc | https://github.com/nodejs/node/commit/6c87bfc944bf44594a5ceb6cad4f221a704e9a13 |
|
Compare
| https://github.com/nodejs/node/compare/f1fb91ee4ca5315de618e8c0710816c319677b31..6c87bfc944bf44594a5ceb6cad4f221a704e9a13 |
| January 8, 2017 04:57 | https://github.com/nodejs/node/pull/10682#event-915135574 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10682#event-915135576 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10682#issuecomment-271130074 |
| https://ci.nodejs.org/job/node-test-pull-request/5754/ | https://ci.nodejs.org/job/node-test-pull-request/5754/ |
| Please reload this page | https://github.com/nodejs/node/pull/10682 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 8, 2017 | https://github.com/nodejs/node/pull/10682#issuecomment-271133617 |
| Please reload this page | https://github.com/nodejs/node/pull/10682 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 8, 2017
| https://github.com/nodejs/node/pull/10682#pullrequestreview-15618783 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10682/files/6c87bfc944bf44594a5ceb6cad4f221a704e9a13 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 8, 2017
| https://github.com/nodejs/node/pull/10682#pullrequestreview-15624496 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10682/files/6c87bfc944bf44594a5ceb6cad4f221a704e9a13 |
| jasnell | https://github.com/jasnell |
|
Jan 10, 2017
| https://github.com/nodejs/node/pull/10682#ref-commit-022b53c |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
| lib: refactor crypto cipher/hash/curve getters | https://github.com/nodejs/node/commit/022b53c9de7e54afca6a368c196b207031c0dd42 |
| 022b53c | https://github.com/nodejs/node/commit/022b53c9de7e54afca6a368c196b207031c0dd42 |
| #10682 | https://github.com/nodejs/node/pull/10682 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10682#issuecomment-271668564 |
| 022b53c | https://github.com/nodejs/node/commit/022b53c9de7e54afca6a368c196b207031c0dd42 |
| Please reload this page | https://github.com/nodejs/node/pull/10682 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 10, 2017 | https://github.com/nodejs/node/pull/10682#event-918018954 |
| italoacasas | https://github.com/italoacasas |
|
Jan 18, 2017
| https://github.com/nodejs/node/pull/10682#ref-commit-578e542 |
|
| https://github.com/Trott |
| lib: refactor crypto cipher/hash/curve getters | https://github.com/italoacasas/node/commit/578e54297b4c9325aa8f4fe70525e5807be9f11a |
| 578e542 | https://github.com/italoacasas/node/commit/578e54297b4c9325aa8f4fe70525e5807be9f11a |
| nodejs#10682 | https://github.com/nodejs/node/pull/10682 |
| italoacasas | https://github.com/italoacasas |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10682#ref-commit-10a978f |
|
| https://github.com/Trott |
| lib: refactor crypto cipher/hash/curve getters | https://github.com/italoacasas/node/commit/10a978f428f42ad5b4e7e8dff7ffaaa83b7a50c9 |
| 10a978f | https://github.com/italoacasas/node/commit/10a978f428f42ad5b4e7e8dff7ffaaa83b7a50c9 |
| nodejs#10682 | https://github.com/nodejs/node/pull/10682 |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/10682#ref-commit-991f84b |
|
| https://github.com/Trott |
| lib: refactor crypto cipher/hash/curve getters | https://github.com/italoacasas/node/commit/991f84bb1fa1e0b8a20c41f984be7009d628aa55 |
| 991f84b | https://github.com/italoacasas/node/commit/991f84bb1fa1e0b8a20c41f984be7009d628aa55 |
| nodejs#10682 | https://github.com/nodejs/node/pull/10682 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 25, 2017
| https://github.com/nodejs/node/pull/10682#ref-pullrequest-203011190 |
|
Proposal to update v7.x-staging
#10989
| https://github.com/nodejs/node/pull/10989 |
| italoacasas | https://github.com/italoacasas |
|
Jan 27, 2017
| https://github.com/nodejs/node/pull/10682#ref-commit-a6c93af |
|
| https://github.com/Trott |
| lib: refactor crypto cipher/hash/curve getters | https://github.com/italoacasas/node/commit/a6c93af24411abffd2b5fb10b28438b9eadb326b |
| a6c93af | https://github.com/italoacasas/node/commit/a6c93af24411abffd2b5fb10b28438b9eadb326b |
| nodejs#10682 | https://github.com/nodejs/node/pull/10682 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Jan 29, 2017
| https://github.com/nodejs/node/pull/10682#ref-pullrequest-203846723 |
|
v7.5.0 proposal
#11062
| https://github.com/nodejs/node/pull/11062 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Mar 8, 2017 | https://github.com/nodejs/node/pull/10682#event-990589289 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 8, 2017
| https://github.com/nodejs/node/pull/10682#ref-commit-4153c36 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| lib: refactor crypto cipher/hash/curve getters | https://github.com/nodejs/node/commit/4153c362431d27fc32a1c1aab88dbf16660ca606 |
| 4153c36 | https://github.com/nodejs/node/commit/4153c362431d27fc32a1c1aab88dbf16660ca606 |
| #10682 | https://github.com/nodejs/node/pull/10682 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10682#ref-commit-797d9ee |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| lib: refactor crypto cipher/hash/curve getters | https://github.com/nodejs/node/commit/797d9ee9249c55eb28e0eacb4f2d128c6381b78f |
| 797d9ee | https://github.com/nodejs/node/commit/797d9ee9249c55eb28e0eacb4f2d128c6381b78f |
| #10682 | https://github.com/nodejs/node/pull/10682 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10682#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:45 | https://github.com/nodejs/node/pull/10682#event-5890945191 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10682 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10682/files/6c87bfc944bf44594a5ceb6cad4f221a704e9a13 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/10682/files/6c87bfc944bf44594a5ceb6cad4f221a704e9a13 |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/10682 |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/targos |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |