René's URL Explorer Experiment


Title: build: don't bundle deps/zlib if --shared-zlib set by gibfahn · Pull Request #10657 · nodejs/node · GitHub

Open Graph Title: build: don't bundle deps/zlib if --shared-zlib set by gibfahn · Pull Request #10657 · nodejs/node

X Title: build: don't bundle deps/zlib if --shared-zlib set by gibfahn · Pull Request #10657 · nodejs/node

Description: Even if the --shared-zlib flag was used, the bundled deps/zlib was still being compiled into the binary as it was required by the C++ test suite. Fixes: #10649 Checklist make -j4 test (UNIX), or...

Open Graph Description: Even if the --shared-zlib flag was used, the bundled deps/zlib was still being compiled into the binary as it was required by the C++ test suite. Fixes: #10649 Checklist make -j4 test (UNIX), or...

X Description: Even if the --shared-zlib flag was used, the bundled deps/zlib was still being compiled into the binary as it was required by the C++ test suite. Fixes: #10649 Checklist make -j4 test (UNIX), or...

Opengraph URL: https://github.com/nodejs/node/pull/10657

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:8227d88a-954a-f1af-9214-4e02f3f8a0ff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA7A:3B507F:E71EB6:13F9014:696A90EF
html-safe-nonce7bb47ea010aa396ca8851aa7723a3580559d744e25084a405ef3b3af284304b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTdBOjNCNTA3RjpFNzFFQjY6MTNGOTAxNDo2OTZBOTBFRiIsInZpc2l0b3JfaWQiOiI0MzM3NDg0NzMzODA5ODU2NzUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac224459c5a3e4f62bdb31f9febd52c260af90abf7d3f1880792d3a15a13323113
hovercard-subject-tagpull_request:100437198
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/10657
twitter:imagehttps://opengraph.githubassets.com/4232daf3dae530a4b42d00c871becdc1f404a0ffad785d8a5f313084a6e842b4/nodejs/node/pull/10657
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4232daf3dae530a4b42d00c871becdc1f404a0ffad785d8a5f313084a6e842b4/nodejs/node/pull/10657
og:image:altEven if the --shared-zlib flag was used, the bundled deps/zlib was still being compiled into the binary as it was required by the C++ test suite. Fixes: #10649 Checklist make -j4 test (UNIX), or...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegibfahn
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/10657#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10657
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10657
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/10657
Reloadhttps://github.com/nodejs/node/pull/10657
Reloadhttps://github.com/nodejs/node/pull/10657
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/10657
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/10657
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/10657#issue-comment-box
gibfahnhttps://github.com/gibfahn
nodejs:masterhttps://github.com/nodejs/node/tree/master
gibfahn:share-zlibhttps://github.com/gibfahn/node/tree/share-zlib
build: don't bundle deps/zlib if --shared-zlib set https://github.com/nodejs/node/pull/10657#top
gibfahnhttps://github.com/gibfahn
nodejs:masterhttps://github.com/nodejs/node/tree/master
gibfahn:share-zlibhttps://github.com/gibfahn/node/tree/share-zlib
Conversation 8 https://github.com/nodejs/node/pull/10657
Commits 1 https://github.com/nodejs/node/pull/10657/commits
Checks 0 https://github.com/nodejs/node/pull/10657/checks
Files changed https://github.com/nodejs/node/pull/10657/files
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jan 6, 2017https://github.com/nodejs/node/pull/10657#issue-199164499
Please reload this pagehttps://github.com/nodejs/node/pull/10657
#10649https://github.com/nodejs/node/issues/10649
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
zlib https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib
Jan 6, 2017https://github.com/nodejs/node/pull/10657#event-913854314
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Jan 6, 2017https://github.com/nodejs/node/pull/10657#event-913854381
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jan 6, 2017https://github.com/nodejs/node/pull/10657#issuecomment-270930462
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jan 8, 2017https://github.com/nodejs/node/pull/10657#event-915236976
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
force-pushedhttps://github.com/nodejs/node/compare/62349ac598a9ae67e3423b6ea66ea43ce27711d5..86b2433b6f28983dcc340a820a7e47fe3aa9a432
62349achttps://github.com/nodejs/node/commit/62349ac598a9ae67e3423b6ea66ea43ce27711d5
86b2433https://github.com/nodejs/node/commit/86b2433b6f28983dcc340a820a7e47fe3aa9a432
Compare https://github.com/nodejs/node/compare/62349ac598a9ae67e3423b6ea66ea43ce27711d5..86b2433b6f28983dcc340a820a7e47fe3aa9a432
January 8, 2017 14:25https://github.com/nodejs/node/pull/10657#event-915237830
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jan 8, 2017https://github.com/nodejs/node/pull/10657#event-915238152
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 10, 2017https://github.com/nodejs/node/pull/10657#issuecomment-271673842
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 29, 2017 https://github.com/nodejs/node/pull/10657#pullrequestreview-18986902
View reviewed changes https://github.com/nodejs/node/pull/10657/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 29, 2017https://github.com/nodejs/node/pull/10657#issuecomment-275896239
https://ci.nodejs.org/job/node-test-commit/7534/https://ci.nodejs.org/job/node-test-commit/7534/
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 29, 2017 https://github.com/nodejs/node/pull/10657#pullrequestreview-18990291
View reviewed changes https://github.com/nodejs/node/pull/10657/files
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/10657#pullrequestreview-18990291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
force-pushedhttps://github.com/nodejs/node/compare/86b2433b6f28983dcc340a820a7e47fe3aa9a432..d8e33fae526d556730914eaad6f98564ba26ed0f
86b2433https://github.com/nodejs/node/commit/86b2433b6f28983dcc340a820a7e47fe3aa9a432
d8e33fahttps://github.com/nodejs/node/commit/d8e33fae526d556730914eaad6f98564ba26ed0f
Compare https://github.com/nodejs/node/compare/86b2433b6f28983dcc340a820a7e47fe3aa9a432..d8e33fae526d556730914eaad6f98564ba26ed0f
January 29, 2017 21:04https://github.com/nodejs/node/pull/10657#event-940662838
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jan 29, 2017https://github.com/nodejs/node/pull/10657#event-940662985
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jan 29, 2017https://github.com/nodejs/node/pull/10657#issuecomment-275946025
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://ci.nodejs.org/job/node-test-commit/7544/https://ci.nodejs.org/job/node-test-commit/7544/
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jan 29, 2017https://github.com/nodejs/node/pull/10657#issuecomment-275951947
https://ci.nodejs.org/job/node-test-commit-linux/7574/nodes=fedora24/tapTestReport/test.tap-1326/https://ci.nodejs.org/job/node-test-commit-linux/7574/nodes=fedora24/tapTestReport/test.tap-1326/
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://github.com/gibfahn
build: don't build deps/zlib if --shared-zlib sethttps://github.com/nodejs/node/pull/10657/commits/ae21a51154d5e2b909e3e770767c6aa92ecc105d
ae21a51https://github.com/nodejs/node/pull/10657/commits/ae21a51154d5e2b909e3e770767c6aa92ecc105d
nodejs#10657https://github.com/nodejs/node/pull/10657
nodejs#10649https://github.com/nodejs/node/issues/10649
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
force-pushedhttps://github.com/nodejs/node/compare/d8e33fae526d556730914eaad6f98564ba26ed0f..ae21a51154d5e2b909e3e770767c6aa92ecc105d
d8e33fahttps://github.com/nodejs/node/commit/d8e33fae526d556730914eaad6f98564ba26ed0f
ae21a51https://github.com/nodejs/node/commit/ae21a51154d5e2b909e3e770767c6aa92ecc105d
Compare https://github.com/nodejs/node/compare/d8e33fae526d556730914eaad6f98564ba26ed0f..ae21a51154d5e2b909e3e770767c6aa92ecc105d
January 29, 2017 22:42https://github.com/nodejs/node/pull/10657#event-940692525
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
ae21a51https://github.com/nodejs/node/commit/ae21a51154d5e2b909e3e770767c6aa92ecc105d
Jan 29, 2017https://github.com/nodejs/node/pull/10657#event-940693382
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
January 29, 2017 22:44https://github.com/nodejs/node/pull/10657#event-940693443
TimothyGuhttps://github.com/TimothyGu
Jan 29, 2017 https://github.com/nodejs/node/pull/10657#ref-commit-b834000
https://github.com/TimothyGu
Only look for LGTMs in

's

https://github.com/TimothyGu/node-review/commit/b834000c8df55f708168dd6152a5345b7ab2ce25
b834000https://github.com/TimothyGu/node-review/commit/b834000c8df55f708168dd6152a5345b7ab2ce25
nodejs/node#10657https://github.com/nodejs/node/pull/10657
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jan 30, 2017 https://github.com/nodejs/node/pull/10657#ref-pullrequest-203861171
Improvements nodejs/node-review#7 https://github.com/nodejs/node-review/pull/7
evanlucashttps://github.com/evanlucas
Jan 31, 2017 https://github.com/nodejs/node/pull/10657#ref-commit-9c2f686
https://github.com/gibfahn
https://github.com/evanlucas
build: don't build deps/zlib if --shared-zlib sethttps://github.com/nodejs/node/commit/9c2f686f7ec04646d0b41d115ebfa044d611f260
9c2f686https://github.com/nodejs/node/commit/9c2f686f7ec04646d0b41d115ebfa044d611f260
#10657https://github.com/nodejs/node/pull/10657
#10649https://github.com/nodejs/node/issues/10649
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Jan 31, 2017 https://github.com/nodejs/node/pull/10657#ref-pullrequest-203846723
v7.5.0 proposal #11062 https://github.com/nodejs/node/pull/11062
TimothyGuhttps://github.com/TimothyGu
Feb 1, 2017 https://github.com/nodejs/node/pull/10657#ref-commit-ca1c671
https://github.com/TimothyGu
review: only look for LGTMs in

's

https://github.com/TimothyGu/node-review/commit/ca1c6714dcf15097a48bd6ab0c6287378eb5b90a
ca1c671https://github.com/TimothyGu/node-review/commit/ca1c6714dcf15097a48bd6ab0c6287378eb5b90a
nodejs/node#10657https://github.com/nodejs/node/pull/10657
evanlucashttps://github.com/evanlucas
Feb 6, 2017 https://github.com/nodejs/node/pull/10657#ref-commit-0b323f0
https://github.com/TimothyGu
https://github.com/evanlucas
Improvements (https://github.com/nodejs/node-review/commit/0b323f04a6a31542fa4c1871185af87d28a77af4
#7https://github.com/nodejs/node-review/pull/7
)https://github.com/nodejs/node-review/commit/0b323f04a6a31542fa4c1871185af87d28a77af4
0b323f0https://github.com/nodejs/node-review/commit/0b323f04a6a31542fa4c1871185af87d28a77af4
nodejs/node#10952https://github.com/nodejs/node/pull/10952
#5https://github.com/nodejs/node-review/issues/5
nodejs/node#10657https://github.com/nodejs/node/pull/10657
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 8, 2017https://github.com/nodejs/node/pull/10657#issuecomment-285204347
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
March 9, 2017 08:27https://github.com/nodejs/node/pull/10657#event-992716565
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
March 11, 2017 01:29https://github.com/nodejs/node/pull/10657#event-995804644
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 11, 2017https://github.com/nodejs/node/pull/10657#issuecomment-285828675
#9630https://github.com/nodejs/node/pull/9630
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 11, 2017 https://github.com/nodejs/node/pull/10657#ref-pullrequest-189559538
inspector: split HTTP/WS server from the inspector #9630 https://github.com/nodejs/node/pull/9630
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
Apr 17, 2017https://github.com/nodejs/node/pull/10657#event-1045199346
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10657
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/10657/files/86b2433b6f28983dcc340a820a7e47fe3aa9a432
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/10657/files/86b2433b6f28983dcc340a820a7e47fe3aa9a432
https://github.com/gibfahn
gibfahn https://github.com/gibfahn
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
zlib https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Azlib
Please reload this pagehttps://github.com/nodejs/node/pull/10657
https://github.com/gibfahn
https://github.com/jasnell
https://github.com/addaleax
https://github.com/bnoordhuis
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.