| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:83de9672-7e5a-0d4d-2d15-d00cb8341f4a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9BE0:2C2A02:6945AD7:935A814:6A501E1B |
| html-safe-nonce | b926a3c6cf55a0a0a0f49fbe5d91e0dd540bc70f98a879774af23a1b167d4de9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkUwOjJDMkEwMjo2OTQ1QUQ3OjkzNUE4MTQ6NkE1MDFFMUIiLCJ2aXNpdG9yX2lkIjoiNTkzOTAwNzUxMTMzMTU4NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3461e770b78e5ad16cc81a273038159e03cba85ee74da534de50dad4e3c8871d |
| hovercard-subject-tag | pull_request:99967866 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10593/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e68c9b792a9180a094acb59e7dbe9b685d65a00910634ccffbb3bd9026e4b92e/nodejs/node/pull/10593 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e68c9b792a9180a094acb59e7dbe9b685d65a00910634ccffbb3bd9026e4b92e/nodejs/node/pull/10593 |
| og:image:alt | Allow fs.read, fs.write and fs.writeFile to take
Uint8Array arguments.
PR-URL: #10382
The only difference from the original commit is the added line in node_util.cc
/cc @evanlucas |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 14f013003d3992e8746116a6f2f55cd2fdaccd329ee0423392831ae051ecb535 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26ee7c1a62943cf19a6fcc1d1ac93ac83465c885 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10593#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10593 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10593 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10593 |
| Reload | https://github.com/nodejs/node/pull/10593 |
| Reload | https://github.com/nodejs/node/pull/10593 |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
977
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| addaleax | https://github.com/addaleax |
| nodejs:v7.x-staging | https://github.com/nodejs/node/tree/v7.x-staging |
| addaleax:backport-v7.x-10382 | https://github.com/addaleax/node/tree/backport-v7.x-10382 |
| Conversation | https://github.com/nodejs/node/pull/10593 |
| Commits1 (1) | https://github.com/nodejs/node/pull/10593/commits |
| Checks | https://github.com/nodejs/node/pull/10593/checks |
| Files changed | https://github.com/nodejs/node/pull/10593/files |
| v7.x backport: fs: support Uint8Array input to methods | https://github.com/nodejs/node/pull/10593#top |
| addaleax | https://github.com/addaleax |
| nodejs:v7.x-staging | https://github.com/nodejs/node/tree/v7.x-staging |
| addaleax:backport-v7.x-10382 | https://github.com/addaleax/node/tree/backport-v7.x-10382 |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 3, 2017 | https://github.com/nodejs/node/pull/10593#issue-198493523 |
| #10382 | https://github.com/nodejs/node/pull/10382 |
| @evanlucas | https://github.com/evanlucas |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
|
| https://github.com/addaleax |
| fs: support Uint8Array input to methods | https://github.com/nodejs/node/pull/10593/commits/abde7644a57cb642e02747b8ff8510a9baef1850 |
| abde764 | https://github.com/nodejs/node/pull/10593/commits/abde7644a57cb642e02747b8ff8510a9baef1850 |
| nodejs#10382 | https://github.com/nodejs/node/pull/10382 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av7.x |
| Jan 3, 2017 | https://github.com/nodejs/node/pull/10593#event-909887285 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
|
v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av7.x |
| Jan 3, 2017 | https://github.com/nodejs/node/pull/10593#event-909887381 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/10593#ref-pullrequest-196865643 |
|
fs: support Uint8Array input to methods
#10382
| https://github.com/nodejs/node/pull/10382 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 3, 2017 | https://github.com/nodejs/node/pull/10593#issuecomment-270135052 |
| https://ci.nodejs.org/job/node-test-commit/7005/ | https://ci.nodejs.org/job/node-test-commit/7005/ |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Jan 3, 2017 | https://github.com/nodejs/node/pull/10593#event-909890673 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/10593#pullrequestreview-14952286 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10593/files/abde7644a57cb642e02747b8ff8510a9baef1850 |
| test/parallel/test-fs-read-buffer.js | https://github.com/nodejs/node/pull/10593/files/abde7644a57cb642e02747b8ff8510a9baef1850#diff-7369ee65eb541ccb0582a31517d901ff472386508cc287826150b101445d7fa6 |
| thefourtheye | https://github.com/thefourtheye |
| Jan 3, 2017 | https://github.com/nodejs/node/pull/10593#discussion_r94425365 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/10593#pullrequestreview-14952621 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10593/files/abde7644a57cb642e02747b8ff8510a9baef1850 |
| test/parallel/test-fs-write-buffer.js | https://github.com/nodejs/node/pull/10593/files/abde7644a57cb642e02747b8ff8510a9baef1850#diff-e53942874c92cd9334794e74dbe901894ad2a164f682f9bae69b8ca6a3a42572 |
| thefourtheye | https://github.com/thefourtheye |
| Jan 3, 2017 | https://github.com/nodejs/node/pull/10593#discussion_r94425706 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 3, 2017 | https://github.com/nodejs/node/pull/10593#issuecomment-270143658 |
| @thefourtheye | https://github.com/thefourtheye |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/10593#pullrequestreview-14953121 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10593/files/abde7644a57cb642e02747b8ff8510a9baef1850 |
| evanlucas | https://github.com/evanlucas |
| https://github.com/nodejs/node/pull/10593#pullrequestreview-14953121 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/10593#pullrequestreview-14953434 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10593/files/abde7644a57cb642e02747b8ff8510a9baef1850 |
| thefourtheye | https://github.com/thefourtheye |
| https://github.com/nodejs/node/pull/10593#pullrequestreview-14953434 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 4, 2017 | https://github.com/nodejs/node/pull/10593#issuecomment-270411702 |
| @evanlucas | https://github.com/evanlucas |
| #10589 | https://github.com/nodejs/node/pull/10589 |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Jan 4, 2017 | https://github.com/nodejs/node/pull/10593#issuecomment-270412098 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| abde764 | https://github.com/nodejs/node/commit/abde7644a57cb642e02747b8ff8510a9baef1850 |
| Jan 4, 2017 | https://github.com/nodejs/node/pull/10593#event-911413720 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| January 4, 2017 16:22 | https://github.com/nodejs/node/pull/10593#event-911414778 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jan 4, 2017
| https://github.com/nodejs/node/pull/10593#ref-pullrequest-198755173 |
|
test: minor cleanup in test-fs-*-buffer tests
#10611
| https://github.com/nodejs/node/pull/10611 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10593 |
|
| https://github.com/evanlucas |
|
evanlucas
| https://github.com/evanlucas |
|
| https://github.com/nodejs/node/pull/10593/files/abde7644a57cb642e02747b8ff8510a9baef1850 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/10593/files/abde7644a57cb642e02747b8ff8510a9baef1850 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/10593 |
|
| https://github.com/addaleax |
|
| https://github.com/evanlucas |
|
| https://github.com/thefourtheye |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |