| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:021cd8e9-ec3d-bc78-630f-f2cdf1e4baca |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DD2A:21115C:2CCD15:3E7640:696A07F6 |
| html-safe-nonce | fe7930715ca75777fbde3a16727fda039275624d1af3d72cc33190e938b4e088 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDJBOjIxMTE1QzoyQ0NEMTU6M0U3NjQwOjY5NkEwN0Y2IiwidmlzaXRvcl9pZCI6Ijg2MTc5OTk5NjczNjk5NTUzMTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f2c0f5a32be68378c4eab84a7eb54b1c0a03b1456702d09ffec2d4c1c1db1459 |
| hovercard-subject-tag | pull_request:99766401 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10544/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/126e83b02558c63db8bf4a0ca986ccb8354ecc0b2c2cd8128d582b55fe6d1ff6/nodejs/node/pull/10544 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/126e83b02558c63db8bf4a0ca986ccb8354ecc0b2c2cd8128d582b55fe6d1ff6/nodejs/node/pull/10544 |
| og:image:alt | This commit addresses an inconsistency with eight tests. These tests use the assert module, but named the variable ASSERT. This goes against the project's typical coding style, and negatively
i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10544#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10544 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10544 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10544 |
| Reload | https://github.com/nodejs/node/pull/10544 |
| Reload | https://github.com/nodejs/node/pull/10544 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10544 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10544 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10544#issue-comment-box |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:lowercase | https://github.com/cjihrig/node/tree/lowercase |
|
test: s/ASSERT/assert/
| https://github.com/nodejs/node/pull/10544#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:lowercase | https://github.com/cjihrig/node/tree/lowercase |
|
Conversation
2
| https://github.com/nodejs/node/pull/10544 |
|
Commits
1
| https://github.com/nodejs/node/pull/10544/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10544/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10544/files |
| Please reload this page | https://github.com/nodejs/node/pull/10544 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 30, 2016 | https://github.com/nodejs/node/pull/10544#issue-198169235 |
| Please reload this page | https://github.com/nodejs/node/pull/10544 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Dec 30, 2016 | https://github.com/nodejs/node/pull/10544#event-908195198 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 30, 2016
| https://github.com/nodejs/node/pull/10544#pullrequestreview-14772771 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10544/files |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 30, 2016 | https://github.com/nodejs/node/pull/10544#issuecomment-269794180 |
| https://ci.nodejs.org/job/node-test-pull-request/5639/ | https://ci.nodejs.org/job/node-test-pull-request/5639/ |
| Please reload this page | https://github.com/nodejs/node/pull/10544 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 30, 2016
| https://github.com/nodejs/node/pull/10544#pullrequestreview-14773481 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10544/files |
| https://github.com/JacksonTian |
| JacksonTian | https://github.com/JacksonTian |
| Dec 30, 2016 | https://github.com/nodejs/node/pull/10544#issuecomment-269796442 |
| Please reload this page | https://github.com/nodejs/node/pull/10544 |
| https://github.com/princejwesley |
| princejwesley | https://github.com/princejwesley |
|
Dec 30, 2016
| https://github.com/nodejs/node/pull/10544#pullrequestreview-14778870 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10544/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Dec 31, 2016
| https://github.com/nodejs/node/pull/10544#pullrequestreview-14801195 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10544/files |
|
| https://github.com/cjihrig |
| test: s/ASSERT/assert/ | https://github.com/nodejs/node/pull/10544/commits/6540fb9f1f02fe1d9a4a783cc768826d5e759aad |
| 6540fb9 | https://github.com/nodejs/node/pull/10544/commits/6540fb9f1f02fe1d9a4a783cc768826d5e759aad |
| nodejs#10544 | https://github.com/nodejs/node/pull/10544 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/1a70172a9db2821edb9a9e52427a432ca0f69eaa..6540fb9f1f02fe1d9a4a783cc768826d5e759aad |
| 1a70172 | https://github.com/nodejs/node/commit/1a70172a9db2821edb9a9e52427a432ca0f69eaa |
| 6540fb9 | https://github.com/nodejs/node/commit/6540fb9f1f02fe1d9a4a783cc768826d5e759aad |
|
Compare
| https://github.com/nodejs/node/compare/1a70172a9db2821edb9a9e52427a432ca0f69eaa..6540fb9f1f02fe1d9a4a783cc768826d5e759aad |
| January 2, 2017 14:56 | https://github.com/nodejs/node/pull/10544#event-909065893 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 2, 2017 | https://github.com/nodejs/node/pull/10544#event-909065960 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| 6540fb9 | https://github.com/nodejs/node/commit/6540fb9f1f02fe1d9a4a783cc768826d5e759aad |
| Jan 2, 2017 | https://github.com/nodejs/node/pull/10544#event-909066551 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| January 2, 2017 14:58 | https://github.com/nodejs/node/pull/10544#event-909066815 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/10544#ref-pullrequest-198417482 |
|
v7.4.0 release proposal
#10589
| https://github.com/nodejs/node/pull/10589 |
| evanlucas | https://github.com/evanlucas |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/10544#ref-commit-8f86b5d |
|
| https://github.com/cjihrig |
|
| https://github.com/evanlucas |
| test: s/ASSERT/assert/ | https://github.com/nodejs/node/commit/8f86b5d0f837636441c17dfac28eec3ed0c56db0 |
| 8f86b5d | https://github.com/nodejs/node/commit/8f86b5d0f837636441c17dfac28eec3ed0c56db0 |
| #10544 | https://github.com/nodejs/node/pull/10544 |
| evanlucas | https://github.com/evanlucas |
|
Jan 4, 2017
| https://github.com/nodejs/node/pull/10544#ref-commit-e1fbd72 |
|
| https://github.com/cjihrig |
|
| https://github.com/evanlucas |
| test: s/ASSERT/assert/ | https://github.com/nodejs/node/commit/e1fbd72ae79f60abddc56da2920ffd89132c6cc0 |
| e1fbd72 | https://github.com/nodejs/node/commit/e1fbd72ae79f60abddc56da2920ffd89132c6cc0 |
| #10544 | https://github.com/nodejs/node/pull/10544 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10544#ref-commit-755eed8 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| test: s/ASSERT/assert/ | https://github.com/nodejs/node/commit/755eed8f8157c8477c16590b506160e305b4e56c |
| 755eed8 | https://github.com/nodejs/node/commit/755eed8f8157c8477c16590b506160e305b4e56c |
| #10544 | https://github.com/nodejs/node/pull/10544 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10544#event-932189643 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10544#ref-commit-cbbe46a |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| test: s/ASSERT/assert/ | https://github.com/nodejs/node/commit/cbbe46adbef1fbe39f740734974f66412e46fec3 |
| cbbe46a | https://github.com/nodejs/node/commit/cbbe46adbef1fbe39f740734974f66412e46fec3 |
| #10544 | https://github.com/nodejs/node/pull/10544 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/10544#ref-commit-5630810 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| test: s/ASSERT/assert/ | https://github.com/nodejs/node/commit/5630810df265a90c3b846775d7e2ba35daa36d67 |
| 5630810 | https://github.com/nodejs/node/commit/5630810df265a90c3b846775d7e2ba35daa36d67 |
| #10544 | https://github.com/nodejs/node/pull/10544 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/10544#ref-commit-0d59cda |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| test: s/ASSERT/assert/ | https://github.com/nodejs/node/commit/0d59cda169e790008c8e94c10bfe95e912063380 |
| 0d59cda | https://github.com/nodejs/node/commit/0d59cda169e790008c8e94c10bfe95e912063380 |
| #10544 | https://github.com/nodejs/node/pull/10544 |
|
v4.8.0 proposal
#10973
| https://github.com/nodejs/node/pull/10973 |
|
v6.10.0 proposal
#10974
| https://github.com/nodejs/node/pull/10974 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 31, 2017
| https://github.com/nodejs/node/pull/10544#ref-commit-f3d1b72 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| test: s/ASSERT/assert/ | https://github.com/nodejs/node/commit/f3d1b7209d05215fda6a2540bd0b1b0d5fc5be4d |
| f3d1b72 | https://github.com/nodejs/node/commit/f3d1b7209d05215fda6a2540bd0b1b0d5fc5be4d |
| #10544 | https://github.com/nodejs/node/pull/10544 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 1, 2017
| https://github.com/nodejs/node/pull/10544#ref-commit-2f8bc9a |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| test: s/ASSERT/assert/ | https://github.com/nodejs/node/commit/2f8bc9a7bc721794d1534946f3b62d9adb0b8a90 |
| 2f8bc9a | https://github.com/nodejs/node/commit/2f8bc9a7bc721794d1534946f3b62d9adb0b8a90 |
| #10544 | https://github.com/nodejs/node/pull/10544 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10544 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10544/files/1a70172a9db2821edb9a9e52427a432ca0f69eaa |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/10544/files/1a70172a9db2821edb9a9e52427a432ca0f69eaa |
|
| https://github.com/princejwesley |
|
princejwesley
| https://github.com/princejwesley |
|
| https://github.com/nodejs/node/pull/10544/files/1a70172a9db2821edb9a9e52427a432ca0f69eaa |
|
| https://github.com/gibfahn |
|
gibfahn
| https://github.com/gibfahn |
|
| https://github.com/nodejs/node/pull/10544/files/1a70172a9db2821edb9a9e52427a432ca0f69eaa |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/10544 |
|
| https://github.com/cjihrig |
|
| https://github.com/JacksonTian |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/princejwesley |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |