René's URL Explorer Experiment


Title: test: refactor several parallel/test-timer tests by BethGriggs · Pull Request #10524 · nodejs/node · GitHub

Open Graph Title: test: refactor several parallel/test-timer tests by BethGriggs · Pull Request #10524 · nodejs/node

X Title: test: refactor several parallel/test-timer tests by BethGriggs · Pull Request #10524 · nodejs/node

Description: Change var to const/let. Simplify test-timers-uncaught-exception. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsystem(s) test Description of change Refactored several of the parallel/test-timer-* tests - mainly changing vars to const and adding common.mustCall() where possible. parallel/test-timers-uncaught-exception has been simplified. Any further suggestions for improvement are welcome 😄

Open Graph Description: Change var to const/let. Simplify test-timers-uncaught-exception. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsy...

X Description: Change var to const/let. Simplify test-timers-uncaught-exception. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsy...

Opengraph URL: https://github.com/nodejs/node/pull/10524

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:fd72daac-9a30-c960-44f5-69ce822ede35
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDC8:42FD0:426D6A:434797:699761A2
html-safe-noncece8487939754514cf3696061cb48fee3f91b84e48c42045e243b2d3288d4c3bf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREM4OjQyRkQwOjQyNkQ2QTo0MzQ3OTc6Njk5NzYxQTIiLCJ2aXNpdG9yX2lkIjoiODY4MTE3NDY2NzA5OTU5NTE3MCIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9
visitor-hmac76a5a356a3ad603d599b2b9a9ba0c8f85deb64134526fdfcfb69f39be433c412
hovercard-subject-tagpull_request:99679722
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
twitter:imagehttps://avatars.githubusercontent.com/u/8297234?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8297234?s=400&v=4
og:image:altChange var to const/let. Simplify test-timers-uncaught-exception. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsy...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec2f6b9675e9141deef3eda21e5cb896d461bd4d25aeaeeba804502ef0e8d01f2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb05d982477497a3bcc7dafa43a01757894c08f44
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10524%2Fcommits%2F7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10524%2Fcommits%2F7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
Reloadhttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
Reloadhttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.8k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
BethGriggshttps://github.com/BethGriggs
nodejs:masterhttps://github.com/nodejs/node/tree/master
BethGriggs:pr-test-timers-es6https://github.com/BethGriggs/node/tree/pr-test-timers-es6
Conversation 10 https://github.com/nodejs/node/pull/10524
Commits 2 https://github.com/nodejs/node/pull/10524/commits
Checks 0 https://github.com/nodejs/node/pull/10524/checks
Files changed https://github.com/nodejs/node/pull/10524/files
Please reload this pagehttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
test: refactor several parallel/test-timer tests https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#top
Show all changes 2 commits https://github.com/nodejs/node/pull/10524/files
7d2a771 test: refactor several parallel/test-timer tests BethGriggs Dec 29, 2016 https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
ff0f0c8 fixup! test: refactor several parallel/test-timer tests BethGriggs Jan 3, 2017 https://github.com/nodejs/node/pull/10524/commits/ff0f0c8e60ac7335181a1db536d68c2dea51c492
Clear filters https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
Please reload this pagehttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
Please reload this pagehttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
test-timers-args.js https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-e00bcaa54ee4dac61ae7b30f653bf32d74e5f41b39659c11428345772b3d1f89
test-timers-immediate-queue.js https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-2fff0f37cc43bc96ef5e8332c10736364942af8d6776d455dbdd214286b32f51
test-timers-non-integer-delay.js https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-606866a9dcaa3ce122f05fd8c0e1a5984a589344516e006023bc93716273a5b4
test-timers-ordering.js https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-bbd782adfbe451ba268725077e8eb0c5fcbe25c5f4c94493752cb8fa1f4c70c2
test-timers-uncaught-exception.js https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-d7e1f0793ccfa1e57146922afce77a2c8d78561bd3d23bd282c96d27d4e20d58
Next https://github.com/nodejs/node/pull/10524/commits/ff0f0c8e60ac7335181a1db536d68c2dea51c492
Please reload this pagehttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
https://github.com/BethGriggs
BethGriggshttps://github.com/nodejs/node/commits?author=BethGriggs
test/parallel/test-timers-args.jshttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-e00bcaa54ee4dac61ae7b30f653bf32d74e5f41b39659c11428345772b3d1f89
View file https://github.com/BethGriggs/node/blob/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac/test/parallel/test-timers-args.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/10524/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-e00bcaa54ee4dac61ae7b30f653bf32d74e5f41b39659c11428345772b3d1f89
https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-e00bcaa54ee4dac61ae7b30f653bf32d74e5f41b39659c11428345772b3d1f89
https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-e00bcaa54ee4dac61ae7b30f653bf32d74e5f41b39659c11428345772b3d1f89
test/parallel/test-timers-immediate-queue.jshttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-2fff0f37cc43bc96ef5e8332c10736364942af8d6776d455dbdd214286b32f51
View file https://github.com/BethGriggs/node/blob/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac/test/parallel/test-timers-immediate-queue.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/10524/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-2fff0f37cc43bc96ef5e8332c10736364942af8d6776d455dbdd214286b32f51
https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-2fff0f37cc43bc96ef5e8332c10736364942af8d6776d455dbdd214286b32f51
test/parallel/test-timers-non-integer-delay.jshttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-606866a9dcaa3ce122f05fd8c0e1a5984a589344516e006023bc93716273a5b4
View file https://github.com/BethGriggs/node/blob/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac/test/parallel/test-timers-non-integer-delay.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/10524/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-606866a9dcaa3ce122f05fd8c0e1a5984a589344516e006023bc93716273a5b4
https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-606866a9dcaa3ce122f05fd8c0e1a5984a589344516e006023bc93716273a5b4
test/parallel/test-timers-ordering.jshttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-bbd782adfbe451ba268725077e8eb0c5fcbe25c5f4c94493752cb8fa1f4c70c2
View file https://github.com/BethGriggs/node/blob/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac/test/parallel/test-timers-ordering.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/10524/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-bbd782adfbe451ba268725077e8eb0c5fcbe25c5f4c94493752cb8fa1f4c70c2
test/parallel/test-timers-uncaught-exception.jshttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#diff-d7e1f0793ccfa1e57146922afce77a2c8d78561bd3d23bd282c96d27d4e20d58
View file https://github.com/BethGriggs/node/blob/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac/test/parallel/test-timers-uncaught-exception.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/10524/commits/{{ revealButtonHref }}
Fishrock123https://github.com/Fishrock123
Dec 31, 2016https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#r94278795
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
BethGriggshttps://github.com/BethGriggs
Jan 3, 2017https://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac#r94423105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10524/commits/7d2a7710c34f67e01e38ac32ba95bcb9e24388ac
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.