| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f24b64ba-28ef-592f-a8cd-386f8cb2d761 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A118:7E3A0:4DD829:6E4B6F:696A0CDC |
| html-safe-nonce | 499ccf600a2cc557685f5e5e89950b334d913caaf24efb9d6a00581a1c4b5234 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTE4OjdFM0EwOjRERDgyOTo2RTRCNkY6Njk2QTBDREMiLCJ2aXNpdG9yX2lkIjoiMjc1ODc2NjIyNzM4MTQyMzMyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | acf412d702fc18fd758a41e96ec89f2905b788a48f31596d4f71409b33684b3a |
| hovercard-subject-tag | pull_request:99676606 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10522/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6c61e8101722e5c8dbafc94b22c53c2bfda3359283a4146686e689b46e98c769/nodejs/node/pull/10522 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6c61e8101722e5c8dbafc94b22c53c2bfda3359283a4146686e689b46e98c769/nodejs/node/pull/10522 |
| og:image:alt | Checklist
make -j4 test (UNIX)
tests and/or benchmarks are included
commit message follows commit guidelines
Affected core subsystem(s)
timer, domain, tests
Description of change
The issue ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jBarz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10522#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10522 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10522 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10522 |
| Reload | https://github.com/nodejs/node/pull/10522 |
| Reload | https://github.com/nodejs/node/pull/10522 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10522#issue-comment-box |
| jBarz | https://github.com/jBarz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jBarz:domain_timers | https://github.com/jBarz/node-core/tree/domain_timers |
|
timer,domain: maintain order of timers upon uncaught exception
| https://github.com/nodejs/node/pull/10522#top |
| jBarz | https://github.com/jBarz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jBarz:domain_timers | https://github.com/jBarz/node-core/tree/domain_timers |
|
Conversation
24
| https://github.com/nodejs/node/pull/10522 |
|
Commits
1
| https://github.com/nodejs/node/pull/10522/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10522/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10522/files |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/jBarz |
| jBarz | https://github.com/jBarz |
| Dec 29, 2016 | https://github.com/nodejs/node/pull/10522#issue-198037151 |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| #1271 | https://github.com/nodejs/node/issues/1271 |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Dec 29, 2016 | https://github.com/nodejs/node/pull/10522#event-907502475 |
| https://github.com/jBarz |
| jBarz | https://github.com/jBarz |
| force-pushed | https://github.com/nodejs/node/compare/73b1d182a4965456458376dcb6c5fda5656dcc56..3e36d54a07bc3c1501fa69f5da112347d8bb04ae |
| 73b1d18 | https://github.com/nodejs/node/commit/73b1d182a4965456458376dcb6c5fda5656dcc56 |
| 3e36d54 | https://github.com/nodejs/node/commit/3e36d54a07bc3c1501fa69f5da112347d8bb04ae |
|
Compare
| https://github.com/nodejs/node/compare/73b1d182a4965456458376dcb6c5fda5656dcc56..3e36d54a07bc3c1501fa69f5da112347d8bb04ae |
| December 29, 2016 16:59 | https://github.com/nodejs/node/pull/10522#event-907504082 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Dec 29, 2016 | https://github.com/nodejs/node/pull/10522#event-907504151 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 29, 2016 | https://github.com/nodejs/node/pull/10522#issuecomment-269667294 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 29, 2016
| https://github.com/nodejs/node/pull/10522#pullrequestreview-14712283 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10522/files |
| test/parallel/test-domain-timers-uncaught-exception.js | https://github.com/nodejs/node/pull/10522/files#diff-9aca886c96757c762c025dff227b2a12d0645145722a8329fb6707a0ab61a722 |
| gibfahn | https://github.com/gibfahn |
| Dec 29, 2016 | https://github.com/nodejs/node/pull/10522#discussion_r94181150 |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| guide to writing tests | https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md |
| common.js API | https://github.com/nodejs/node/blob/master/test/README.md#common-module-api |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| jBarz | https://github.com/jBarz |
| Dec 29, 2016 | https://github.com/nodejs/node/pull/10522#discussion_r94187127 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Dec 29, 2016
| https://github.com/nodejs/node/pull/10522#pullrequestreview-14712389 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10522/files |
| test/parallel/test-domain-timers-uncaught-exception.js | https://github.com/nodejs/node/pull/10522/files#diff-9aca886c96757c762c025dff227b2a12d0645145722a8329fb6707a0ab61a722 |
| sam-github | https://github.com/sam-github |
| Dec 29, 2016 | https://github.com/nodejs/node/pull/10522#discussion_r94181258 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| jBarz | https://github.com/jBarz |
| Dec 29, 2016 | https://github.com/nodejs/node/pull/10522#discussion_r94187484 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| test/parallel/test-domain-timers-uncaught-exception.js | https://github.com/nodejs/node/pull/10522/files#diff-9aca886c96757c762c025dff227b2a12d0645145722a8329fb6707a0ab61a722 |
| sam-github | https://github.com/sam-github |
| Dec 29, 2016 | https://github.com/nodejs/node/pull/10522#discussion_r94181353 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| jBarz | https://github.com/jBarz |
| Dec 29, 2016 | https://github.com/nodejs/node/pull/10522#discussion_r94187804 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Dec 29, 2016 | https://github.com/nodejs/node/pull/10522#event-907735796 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 29, 2016
| https://github.com/nodejs/node/pull/10522#pullrequestreview-14722652 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10522/files |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 30, 2016
| https://github.com/nodejs/node/pull/10522#pullrequestreview-14742974 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10522/files |
| gibfahn | https://github.com/gibfahn |
| https://github.com/nodejs/node/pull/10522#pullrequestreview-14742974 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Fishrock123 | https://github.com/Fishrock123 |
| December 30, 2016 10:03 | https://github.com/nodejs/node/pull/10522#event-907977047 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Dec 30, 2016 | https://github.com/nodejs/node/pull/10522#issuecomment-269781469 |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://ci.nodejs.org/job/node-test-commit/6931/ | https://ci.nodejs.org/job/node-test-commit/6931/ |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Dec 30, 2016
| https://github.com/nodejs/node/pull/10522#pullrequestreview-14765319 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10522/files |
| test/parallel/test-domain-timers-uncaught-exception.js | https://github.com/nodejs/node/pull/10522/files#diff-9aca886c96757c762c025dff227b2a12d0645145722a8329fb6707a0ab61a722 |
| sam-github | https://github.com/sam-github |
| Dec 30, 2016 | https://github.com/nodejs/node/pull/10522#discussion_r94234241 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| test/parallel/test-domain-timers-uncaught-exception.js | https://github.com/nodejs/node/pull/10522/files#diff-9aca886c96757c762c025dff227b2a12d0645145722a8329fb6707a0ab61a722 |
| sam-github | https://github.com/sam-github |
| Dec 30, 2016 | https://github.com/nodejs/node/pull/10522#discussion_r94234335 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| jBarz | https://github.com/jBarz |
| Dec 30, 2016 | https://github.com/nodejs/node/pull/10522#discussion_r94240385 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| test/parallel/test-domain-timers-uncaught-exception.js | https://github.com/nodejs/node/pull/10522/files#diff-9aca886c96757c762c025dff227b2a12d0645145722a8329fb6707a0ab61a722 |
| sam-github | https://github.com/sam-github |
| Dec 30, 2016 | https://github.com/nodejs/node/pull/10522#discussion_r94234393 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Dec 30, 2016 | https://github.com/nodejs/node/pull/10522#event-908199704 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Dec 30, 2016
| https://github.com/nodejs/node/pull/10522#pullrequestreview-14774754 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10522/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 6, 2017 | https://github.com/nodejs/node/pull/10522#issuecomment-270962306 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10522#event-922526708 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jan 13, 2017
| https://github.com/nodejs/node/pull/10522#pullrequestreview-16608869 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10522/files |
| Fishrock123 | https://github.com/Fishrock123 |
| https://github.com/nodejs/node/pull/10522#pullrequestreview-16608869 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://ci.nodejs.org/job/node-test-pull-request/5849/ | https://ci.nodejs.org/job/node-test-pull-request/5849/ |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| lib/timers.js | https://github.com/nodejs/node/pull/10522/files#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724 |
| Fishrock123 | https://github.com/Fishrock123 |
| Jan 13, 2017 | https://github.com/nodejs/node/pull/10522#discussion_r96032949 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 14, 2017 | https://github.com/nodejs/node/pull/10522#event-923087541 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jan 19, 2017 | https://github.com/nodejs/node/pull/10522#issuecomment-273770234 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Feb 10, 2017
| https://github.com/nodejs/node/pull/10522#pullrequestreview-21337317 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10522/files |
| Fishrock123 | https://github.com/Fishrock123 |
| https://github.com/nodejs/node/pull/10522#pullrequestreview-21337317 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jBarz | https://github.com/jBarz |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| test/parallel/test-domain-timers-uncaught-exception.js | https://github.com/nodejs/node/pull/10522/files#diff-9aca886c96757c762c025dff227b2a12d0645145722a8329fb6707a0ab61a722 |
| Fishrock123 | https://github.com/Fishrock123 |
| Feb 10, 2017 | https://github.com/nodejs/node/pull/10522#discussion_r100619829 |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jBarz | https://github.com/jBarz |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/jBarz |
| jBarz | https://github.com/jBarz |
| force-pushed | https://github.com/nodejs/node/compare/cbbaab33feb1a1fc615d3fd1824f23c983aa689d..595d9f1610d7ee222745c21caa065bf583a7f821 |
| cbbaab3 | https://github.com/nodejs/node/commit/cbbaab33feb1a1fc615d3fd1824f23c983aa689d |
| 595d9f1 | https://github.com/nodejs/node/commit/595d9f1610d7ee222745c21caa065bf583a7f821 |
|
Compare
| https://github.com/nodejs/node/compare/cbbaab33feb1a1fc615d3fd1824f23c983aa689d..595d9f1610d7ee222745c21caa065bf583a7f821 |
| February 12, 2017 16:20 | https://github.com/nodejs/node/pull/10522#event-958694950 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Feb 12, 2017 | https://github.com/nodejs/node/pull/10522#event-958694962 |
| https://github.com/jBarz |
| jBarz | https://github.com/jBarz |
| force-pushed | https://github.com/nodejs/node/compare/ab06bf2420b2e70aaaf4a21a439d37a62e4253d5..60c458b2a88006cfb7e00cfb11f776a303539d77 |
| ab06bf2 | https://github.com/nodejs/node/commit/ab06bf2420b2e70aaaf4a21a439d37a62e4253d5 |
| 60c458b | https://github.com/nodejs/node/commit/60c458b2a88006cfb7e00cfb11f776a303539d77 |
|
Compare
| https://github.com/nodejs/node/compare/ab06bf2420b2e70aaaf4a21a439d37a62e4253d5..60c458b2a88006cfb7e00cfb11f776a303539d77 |
| February 12, 2017 16:26 | https://github.com/nodejs/node/pull/10522#event-958696565 |
|
| https://github.com/jBarz |
| timer,domain: maintain order of timer callbacks | https://github.com/nodejs/node/pull/10522/commits/a4ed667d560efb0da8e3730cb3ec019d738060b4 |
| a4ed667 | https://github.com/nodejs/node/pull/10522/commits/a4ed667d560efb0da8e3730cb3ec019d738060b4 |
| https://github.com/jBarz |
| jBarz | https://github.com/jBarz |
| force-pushed | https://github.com/nodejs/node/compare/60c458b2a88006cfb7e00cfb11f776a303539d77..a4ed667d560efb0da8e3730cb3ec019d738060b4 |
| 60c458b | https://github.com/nodejs/node/commit/60c458b2a88006cfb7e00cfb11f776a303539d77 |
| a4ed667 | https://github.com/nodejs/node/commit/a4ed667d560efb0da8e3730cb3ec019d738060b4 |
|
Compare
| https://github.com/nodejs/node/compare/60c458b2a88006cfb7e00cfb11f776a303539d77..a4ed667d560efb0da8e3730cb3ec019d738060b4 |
| February 13, 2017 20:01 | https://github.com/nodejs/node/pull/10522#event-960242321 |
| https://github.com/jBarz |
| jBarz | https://github.com/jBarz |
| Feb 13, 2017 | https://github.com/nodejs/node/pull/10522#issuecomment-279505430 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Feb 13, 2017
| https://github.com/nodejs/node/pull/10522#pullrequestreview-21610601 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10522/files/a4ed667d560efb0da8e3730cb3ec019d738060b4 |
| Fishrock123 | https://github.com/Fishrock123 |
| https://github.com/nodejs/node/pull/10522#pullrequestreview-21610601 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://ci.nodejs.org/job/node-test-pull-request/6388/ | https://ci.nodejs.org/job/node-test-pull-request/6388/ |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/10522#issuecomment-279875083 |
| @evanlucas | https://github.com/evanlucas |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Feb 15, 2017 | https://github.com/nodejs/node/pull/10522#issuecomment-279876899 |
| 9dac165 | https://github.com/nodejs/node/commit/9dac1651604ee44ef99672107d8ad0286583400e |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Feb 15, 2017 | https://github.com/nodejs/node/pull/10522#event-962314871 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Feb 15, 2017
| https://github.com/nodejs/node/pull/10522#ref-commit-9dac165 |
|
| https://github.com/jBarz |
|
| https://github.com/Fishrock123 |
| timer,domain: maintain order of timer callbacks | https://github.com/nodejs/node/commit/9dac1651604ee44ef99672107d8ad0286583400e |
| 9dac165 | https://github.com/nodejs/node/commit/9dac1651604ee44ef99672107d8ad0286583400e |
| #10522 | https://github.com/nodejs/node/pull/10522 |
| #1271 | https://github.com/nodejs/node/issues/1271 |
| https://github.com/jBarz |
| jBarz | https://github.com/jBarz |
| February 16, 2017 14:25 | https://github.com/nodejs/node/pull/10522#event-965050873 |
| italoacasas | https://github.com/italoacasas |
|
Feb 16, 2017
| https://github.com/nodejs/node/pull/10522#ref-commit-7561c07 |
|
| https://github.com/jBarz |
| timer,domain: maintain order of timer callbacks | https://github.com/italoacasas/node/commit/7561c072ad66bcc2e949a542ca4a4436325bdef3 |
| 7561c07 | https://github.com/italoacasas/node/commit/7561c072ad66bcc2e949a542ca4a4436325bdef3 |
| nodejs#10522 | https://github.com/nodejs/node/pull/10522 |
| nodejs#1271 | https://github.com/nodejs/node/issues/1271 |
| italoacasas | https://github.com/italoacasas |
|
Feb 22, 2017
| https://github.com/nodejs/node/pull/10522#ref-commit-506a1cb |
|
| https://github.com/jBarz |
| timer,domain: maintain order of timer callbacks | https://github.com/nodejs/node/commit/506a1cb03f68168bb43e71c91014ae7e8974637a |
| 506a1cb | https://github.com/nodejs/node/commit/506a1cb03f68168bb43e71c91014ae7e8974637a |
| #10522 | https://github.com/nodejs/node/pull/10522 |
| #1271 | https://github.com/nodejs/node/issues/1271 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Feb 25, 2017
| https://github.com/nodejs/node/pull/10522#ref-pullrequest-210245474 |
|
7.7.0 Proposal
#11553
| https://github.com/nodejs/node/pull/11553 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 7, 2017 | https://github.com/nodejs/node/pull/10522#issuecomment-284788809 |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Mar 7, 2017 | https://github.com/nodejs/node/pull/10522#event-989942903 |
| jasnell | https://github.com/jasnell |
|
Mar 7, 2017
| https://github.com/nodejs/node/pull/10522#ref-commit-c4bf1b5 |
|
| https://github.com/jBarz |
|
| https://github.com/jasnell |
| timer,domain: maintain order of timer callbacks | https://github.com/nodejs/node/commit/c4bf1b5ef3ab11dab59613d3b06ce33436a44715 |
| c4bf1b5 | https://github.com/nodejs/node/commit/c4bf1b5ef3ab11dab59613d3b06ce33436a44715 |
| #10522 | https://github.com/nodejs/node/pull/10522 |
| #1271 | https://github.com/nodejs/node/issues/1271 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10522#ref-commit-d71ebb9 |
|
| https://github.com/jBarz |
|
| https://github.com/MylesBorins |
| timer,domain: maintain order of timer callbacks | https://github.com/nodejs/node/commit/d71ebb90ecce4bf5b3702e3806f97db50862f7e5 |
| d71ebb9 | https://github.com/nodejs/node/commit/d71ebb90ecce4bf5b3702e3806f97db50862f7e5 |
| #10522 | https://github.com/nodejs/node/pull/10522 |
| #1271 | https://github.com/nodejs/node/issues/1271 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/10522#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 21, 2017
| https://github.com/nodejs/node/pull/10522#ref-commit-e70d0b0 |
|
| https://github.com/MylesBorins |
| 2017-03-21, Version 6.10.1 'Boron' (LTS) | https://github.com/nodejs/node/commit/e70d0b0904239ed7f47d8c8701f0d8bc85ea5c28 |
| e70d0b0 | https://github.com/nodejs/node/commit/e70d0b0904239ed7f47d8c8701f0d8bc85ea5c28 |
| #10927 | https://github.com/nodejs/node/pull/10927 |
| #10895 | https://github.com/nodejs/node/pull/10895 |
| #11522 | https://github.com/nodejs/node/pull/11522 |
| #11516 | https://github.com/nodejs/node/pull/11516 |
| #11497 | https://github.com/nodejs/node/pull/11497 |
| #10837 | https://github.com/nodejs/node/pull/10837 |
| #10852 | https://github.com/nodejs/node/pull/10852 |
| #10874 | https://github.com/nodejs/node/pull/10874 |
| #10677 | https://github.com/nodejs/node/pull/10677 |
| #11288 | https://github.com/nodejs/node/pull/11288 |
| #8923 | https://github.com/nodejs/node/pull/8923 |
| #9195 | https://github.com/nodejs/node/pull/9195 |
| #10186 | https://github.com/nodejs/node/pull/10186 |
| #10522 | https://github.com/nodejs/node/pull/10522 |
| #11759 | https://github.com/nodejs/node/pull/11759 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 21, 2017
| https://github.com/nodejs/node/pull/10522#ref-commit-2569c90 |
|
| https://github.com/MylesBorins |
| 2017-03-21, Version 6.10.1 'Boron' (LTS) | https://github.com/nodejs/node/commit/2569c909bae0699e62d99bf1488e09e874a647a8 |
| 2569c90 | https://github.com/nodejs/node/commit/2569c909bae0699e62d99bf1488e09e874a647a8 |
| #10927 | https://github.com/nodejs/node/pull/10927 |
| #10895 | https://github.com/nodejs/node/pull/10895 |
| #11522 | https://github.com/nodejs/node/pull/11522 |
| #11516 | https://github.com/nodejs/node/pull/11516 |
| #11497 | https://github.com/nodejs/node/pull/11497 |
| #10837 | https://github.com/nodejs/node/pull/10837 |
| #10852 | https://github.com/nodejs/node/pull/10852 |
| #10874 | https://github.com/nodejs/node/pull/10874 |
| #10677 | https://github.com/nodejs/node/pull/10677 |
| #11288 | https://github.com/nodejs/node/pull/11288 |
| #8923 | https://github.com/nodejs/node/pull/8923 |
| #9195 | https://github.com/nodejs/node/pull/9195 |
| #10186 | https://github.com/nodejs/node/pull/10186 |
| #10522 | https://github.com/nodejs/node/pull/10522 |
| #11759 | https://github.com/nodejs/node/pull/11759 |
| imyller | https://github.com/imyller |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/10522#ref-commit-ccdb8bf |
|
| https://github.com/imyller |
| 2017-03-21, Version 6.10.1 'Boron' (LTS) | https://github.com/imyller/meta-nodejs/commit/ccdb8bfc7b432c7bf8a0203742d1370dae9c09e2 |
| ccdb8bf | https://github.com/imyller/meta-nodejs/commit/ccdb8bfc7b432c7bf8a0203742d1370dae9c09e2 |
| nodejs/node#10927 | https://github.com/nodejs/node/pull/10927 |
| nodejs/node#10895 | https://github.com/nodejs/node/pull/10895 |
| nodejs/node#11522 | https://github.com/nodejs/node/pull/11522 |
| nodejs/node#11516 | https://github.com/nodejs/node/pull/11516 |
| nodejs/node#11497 | https://github.com/nodejs/node/pull/11497 |
| nodejs/node#10837 | https://github.com/nodejs/node/pull/10837 |
| nodejs/node#10852 | https://github.com/nodejs/node/pull/10852 |
| nodejs/node#10874 | https://github.com/nodejs/node/pull/10874 |
| nodejs/node#10677 | https://github.com/nodejs/node/pull/10677 |
| nodejs/node#11288 | https://github.com/nodejs/node/pull/11288 |
| nodejs/node#8923 | https://github.com/nodejs/node/pull/8923 |
| nodejs/node#9195 | https://github.com/nodejs/node/pull/9195 |
| nodejs/node#10186 | https://github.com/nodejs/node/pull/10186 |
| nodejs/node#10522 | https://github.com/nodejs/node/pull/10522 |
| nodejs/node#11759 | https://github.com/nodejs/node/pull/11759 |
| imyller | https://github.com/imyller |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/10522#ref-commit-e47cbbd |
|
| https://github.com/imyller |
| 2017-03-21, Version 6.10.1 'Boron' (LTS) | https://github.com/imyller/meta-nodejs/commit/e47cbbd12d0f28c76381afd4f8c7112684e22f70 |
| e47cbbd | https://github.com/imyller/meta-nodejs/commit/e47cbbd12d0f28c76381afd4f8c7112684e22f70 |
| nodejs/node#10927 | https://github.com/nodejs/node/pull/10927 |
| nodejs/node#10895 | https://github.com/nodejs/node/pull/10895 |
| nodejs/node#11522 | https://github.com/nodejs/node/pull/11522 |
| nodejs/node#11516 | https://github.com/nodejs/node/pull/11516 |
| nodejs/node#11497 | https://github.com/nodejs/node/pull/11497 |
| nodejs/node#10837 | https://github.com/nodejs/node/pull/10837 |
| nodejs/node#10852 | https://github.com/nodejs/node/pull/10852 |
| nodejs/node#10874 | https://github.com/nodejs/node/pull/10874 |
| nodejs/node#10677 | https://github.com/nodejs/node/pull/10677 |
| nodejs/node#11288 | https://github.com/nodejs/node/pull/11288 |
| nodejs/node#8923 | https://github.com/nodejs/node/pull/8923 |
| nodejs/node#9195 | https://github.com/nodejs/node/pull/9195 |
| nodejs/node#10186 | https://github.com/nodejs/node/pull/10186 |
| nodejs/node#10522 | https://github.com/nodejs/node/pull/10522 |
| nodejs/node#11759 | https://github.com/nodejs/node/pull/11759 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10522 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10522/files/a1ac43525615b9547bd8c44727e8c0eca8695108 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/10522/files/5ecbe2ccb62fe1110350777b8a4ac425e3f6ad0e |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
| https://github.com/nodejs/node/pull/10522/files/a4ed667d560efb0da8e3730cb3ec019d738060b4 |
|
| https://github.com/gibfahn |
|
gibfahn
| https://github.com/gibfahn |
|
| https://github.com/nodejs/node/pull/10522/files/a1ac43525615b9547bd8c44727e8c0eca8695108 |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Please reload this page | https://github.com/nodejs/node/pull/10522 |
|
| https://github.com/jBarz |
|
| https://github.com/jasnell |
|
| https://github.com/gibfahn |
|
| https://github.com/Fishrock123 |
|
| https://github.com/sam-github |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |