René's URL Explorer Experiment


Title: test: fix flaky test-https-timeout by Trott · Pull Request #10404 · nodejs/node · GitHub

Open Graph Title: test: fix flaky test-https-timeout by Trott · Pull Request #10404 · nodejs/node

X Title: test: fix flaky test-https-timeout by Trott · Pull Request #10404 · nodejs/node

Description: Remove setTimeout() in test and instead rely on common.mustCall() on a timeout event handler. The test was flaky on CI. The flakiness was replicable by running the test under load. This version, in...

Open Graph Description: Remove setTimeout() in test and instead rely on common.mustCall() on a timeout event handler. The test was flaky on CI. The flakiness was replicable by running the test under load. This version, in...

X Description: Remove setTimeout() in test and instead rely on common.mustCall() on a timeout event handler. The test was flaky on CI. The flakiness was replicable by running the test under load. This version, in...

Opengraph URL: https://github.com/nodejs/node/pull/10404

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d8c8bed4-1e2d-ea99-d38e-4e2bc4020c90
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD992:14EC01:111C4BA:17E5C0A:696A36DF
html-safe-nonce28aa16365179da9572170e8dc130cbe293a78aa787a8dc5336789aa3ae733c43
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTkyOjE0RUMwMToxMTFDNEJBOjE3RTVDMEE6Njk2QTM2REYiLCJ2aXNpdG9yX2lkIjoiMTkwMzQ4NDE1Njc5NjA5MDA3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5f58fea561cc637b755f12ecb551765980255db646f346fabac74739139266be
hovercard-subject-tagpull_request:99036638
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10404/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/79e8c2857559b55773ed2d890bfbf0064d4027d9796d3aad813744a130587bd7/nodejs/node/pull/10404
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/79e8c2857559b55773ed2d890bfbf0064d4027d9796d3aad813744a130587bd7/nodejs/node/pull/10404
og:image:altRemove setTimeout() in test and instead rely on common.mustCall() on a timeout event handler. The test was flaky on CI. The flakiness was replicable by running the test under load. This version, in...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/10404#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10404
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10404
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/10404
Reloadhttps://github.com/nodejs/node/pull/10404
Reloadhttps://github.com/nodejs/node/pull/10404
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/10404
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/10404
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/10404#issue-comment-box
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:https-timeouthttps://github.com/Trott/io.js/tree/https-timeout
test: fix flaky test-https-timeout https://github.com/nodejs/node/pull/10404#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:https-timeouthttps://github.com/Trott/io.js/tree/https-timeout
Conversation 4 https://github.com/nodejs/node/pull/10404
Commits 1 https://github.com/nodejs/node/pull/10404/commits
Checks 0 https://github.com/nodejs/node/pull/10404/checks
Files changed https://github.com/nodejs/node/pull/10404/files
Please reload this pagehttps://github.com/nodejs/node/pull/10404
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 22, 2016https://github.com/nodejs/node/pull/10404#issue-197077138
Please reload this pagehttps://github.com/nodejs/node/pull/10404
https://github.com/Trott
Trotthttps://github.com/Trott
https https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttps
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Dec 22, 2016https://github.com/nodejs/node/pull/10404#event-902441719
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 22, 2016https://github.com/nodejs/node/pull/10404#event-902441803
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 22, 2016https://github.com/nodejs/node/pull/10404#issuecomment-268698524
https://ci.nodejs.org/job/node-test-commit-freebsd/6013/nodes=freebsd10-64/consolehttps://ci.nodejs.org/job/node-test-commit-freebsd/6013/nodes=freebsd10-64/console
Please reload this pagehttps://github.com/nodejs/node/pull/10404
https://github.com/Trott
test: fix flaky test-https-timeouthttps://github.com/nodejs/node/pull/10404/commits/2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
2677dfchttps://github.com/nodejs/node/pull/10404/commits/2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/3758cb6072fd326a8b103deb988d06a4dc653f84..2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
3758cb6https://github.com/nodejs/node/commit/3758cb6072fd326a8b103deb988d06a4dc653f84
2677dfchttps://github.com/nodejs/node/commit/2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
Compare https://github.com/nodejs/node/compare/3758cb6072fd326a8b103deb988d06a4dc653f84..2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
December 22, 2016 03:45https://github.com/nodejs/node/pull/10404#event-902504778
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 22, 2016https://github.com/nodejs/node/pull/10404#event-902504826
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 22, 2016https://github.com/nodejs/node/pull/10404#issuecomment-268716744
https://ci.nodejs.org/job/node-stress-single-test/1091/nodes=freebsd10-64/consolehttps://ci.nodejs.org/job/node-stress-single-test/1091/nodes=freebsd10-64/console
https://ci.nodejs.org/job/node-stress-single-test/1092/nodes=freebsd10-64/consolehttps://ci.nodejs.org/job/node-stress-single-test/1092/nodes=freebsd10-64/console
Please reload this pagehttps://github.com/nodejs/node/pull/10404
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 22, 2016https://github.com/nodejs/node/pull/10404#issuecomment-268716812
https://ci.nodejs.org/job/node-test-pull-request/5527/https://ci.nodejs.org/job/node-test-pull-request/5527/
Please reload this pagehttps://github.com/nodejs/node/pull/10404
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
Dec 22, 2016 https://github.com/nodejs/node/pull/10404#pullrequestreview-14114072
View reviewed changes https://github.com/nodejs/node/pull/10404/files/2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 22, 2016 https://github.com/nodejs/node/pull/10404#pullrequestreview-14197984
View reviewed changes https://github.com/nodejs/node/pull/10404/files/2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Dec 23, 2016 https://github.com/nodejs/node/pull/10404#pullrequestreview-14256578
View reviewed changes https://github.com/nodejs/node/pull/10404/files/2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 23, 2016 https://github.com/nodejs/node/pull/10404#pullrequestreview-14269892
View reviewed changes https://github.com/nodejs/node/pull/10404/files/2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
Trotthttps://github.com/Trott
Dec 24, 2016 https://github.com/nodejs/node/pull/10404#ref-commit-3f52ce3
https://github.com/Trott
test: fix flaky test-https-timeouthttps://github.com/Trott/io.js/commit/3f52ce35bce7e9df816d6ed884f1194986fa76ed
3f52ce3https://github.com/Trott/io.js/commit/3f52ce35bce7e9df816d6ed884f1194986fa76ed
nodejs#10404https://github.com/nodejs/node/pull/10404
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 24, 2016https://github.com/nodejs/node/pull/10404#issuecomment-269068934
3f52ce3https://github.com/nodejs/node/commit/3f52ce35bce7e9df816d6ed884f1194986fa76ed
Please reload this pagehttps://github.com/nodejs/node/pull/10404
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 24, 2016https://github.com/nodejs/node/pull/10404#event-904486411
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Jan 3, 2017 https://github.com/nodejs/node/pull/10404#ref-pullrequest-198417482
v7.4.0 release proposal #10589 https://github.com/nodejs/node/pull/10589
evanlucashttps://github.com/evanlucas
Jan 3, 2017 https://github.com/nodejs/node/pull/10404#ref-commit-c36984b
https://github.com/Trott
https://github.com/evanlucas
test: fix flaky test-https-timeouthttps://github.com/nodejs/node/commit/c36984b00c78c064b0ede52576ab9a2a152c3589
c36984bhttps://github.com/nodejs/node/commit/c36984b00c78c064b0ede52576ab9a2a152c3589
#10404https://github.com/nodejs/node/pull/10404
evanlucashttps://github.com/evanlucas
Jan 4, 2017 https://github.com/nodejs/node/pull/10404#ref-commit-e6702d6
https://github.com/Trott
https://github.com/evanlucas
test: fix flaky test-https-timeouthttps://github.com/nodejs/node/commit/e6702d6d9b58f1358e0f5cd0ce03df93bbbd558b
e6702d6https://github.com/nodejs/node/commit/e6702d6d9b58f1358e0f5cd0ce03df93bbbd558b
#10404https://github.com/nodejs/node/pull/10404
MylesBorinshttps://github.com/MylesBorins
Jan 23, 2017 https://github.com/nodejs/node/pull/10404#ref-commit-8abceb4
https://github.com/Trott
https://github.com/MylesBorins
test: fix flaky test-https-timeouthttps://github.com/nodejs/node/commit/8abceb48e27c23b542f0e7cb8e3ea0713520be5d
8abceb4https://github.com/nodejs/node/commit/8abceb48e27c23b542f0e7cb8e3ea0713520be5d
#10404https://github.com/nodejs/node/pull/10404
MylesBorinshttps://github.com/MylesBorins
Jan 23, 2017 https://github.com/nodejs/node/pull/10404#ref-commit-fd2005c
https://github.com/Trott
https://github.com/MylesBorins
test: fix flaky test-https-timeouthttps://github.com/nodejs/node/commit/fd2005caa71e2a4c4eb5dcb54bbca3b6284d8517
fd2005chttps://github.com/nodejs/node/commit/fd2005caa71e2a4c4eb5dcb54bbca3b6284d8517
#10404https://github.com/nodejs/node/pull/10404
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Jan 23, 2017https://github.com/nodejs/node/pull/10404#event-932228188
MylesBorinshttps://github.com/MylesBorins
Jan 23, 2017 https://github.com/nodejs/node/pull/10404#ref-commit-b3bc996
https://github.com/Trott
https://github.com/MylesBorins
test: fix flaky test-https-timeouthttps://github.com/nodejs/node/commit/b3bc996b91dca139a67a5c61b583d7951c1e7a0c
b3bc996https://github.com/nodejs/node/commit/b3bc996b91dca139a67a5c61b583d7951c1e7a0c
#10404https://github.com/nodejs/node/pull/10404
MylesBorinshttps://github.com/MylesBorins
Jan 24, 2017 https://github.com/nodejs/node/pull/10404#ref-commit-c93ef72
https://github.com/Trott
https://github.com/MylesBorins
test: fix flaky test-https-timeouthttps://github.com/nodejs/node/commit/c93ef725d5ebaf8a065d65078e42d22018ca6d82
c93ef72https://github.com/nodejs/node/commit/c93ef725d5ebaf8a065d65078e42d22018ca6d82
#10404https://github.com/nodejs/node/pull/10404
MylesBorinshttps://github.com/MylesBorins
Jan 24, 2017 https://github.com/nodejs/node/pull/10404#ref-commit-feede6a
https://github.com/Trott
https://github.com/MylesBorins
test: fix flaky test-https-timeouthttps://github.com/nodejs/node/commit/feede6a33cb97e6365e58a5bea7907bf96add5b0
feede6ahttps://github.com/nodejs/node/commit/feede6a33cb97e6365e58a5bea7907bf96add5b0
#10404https://github.com/nodejs/node/pull/10404
v4.8.0 proposal #10973 https://github.com/nodejs/node/pull/10973
v6.10.0 proposal #10974 https://github.com/nodejs/node/pull/10974
MylesBorinshttps://github.com/MylesBorins
Jan 31, 2017 https://github.com/nodejs/node/pull/10404#ref-commit-b1f2aeb
https://github.com/Trott
https://github.com/MylesBorins
test: fix flaky test-https-timeouthttps://github.com/nodejs/node/commit/b1f2aeb8013e58a560a4c3fc49f1b4306b616ad8
b1f2aebhttps://github.com/nodejs/node/commit/b1f2aeb8013e58a560a4c3fc49f1b4306b616ad8
#10404https://github.com/nodejs/node/pull/10404
MylesBorinshttps://github.com/MylesBorins
Feb 1, 2017 https://github.com/nodejs/node/pull/10404#ref-commit-8a26ba1
https://github.com/Trott
https://github.com/MylesBorins
test: fix flaky test-https-timeouthttps://github.com/nodejs/node/commit/8a26ba142fdafd0ceb8d0121a15587739de7cff2
8a26ba1https://github.com/nodejs/node/commit/8a26ba142fdafd0ceb8d0121a15587739de7cff2
#10404https://github.com/nodejs/node/pull/10404
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:44https://github.com/nodejs/node/pull/10404#event-5890944864
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10404
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/10404/files/2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
https://github.com/santigimeno
santigimeno https://github.com/santigimeno
https://github.com/nodejs/node/pull/10404/files/2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/10404/files/2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
https://github.com/italoacasas
italoacasas https://github.com/italoacasas
https://github.com/nodejs/node/pull/10404/files/2677dfc9ad130a5fc9db514110e8ed7a3a03ae96
https https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttps
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/10404
https://github.com/Trott
https://github.com/jasnell
https://github.com/santigimeno
https://github.com/cjihrig
https://github.com/italoacasas
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.