| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3196e07c-e83c-9bb9-24a6-1aa6710bffdc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9EDA:25CBEE:242AC2:32B39A:696A0710 |
| html-safe-nonce | 49014716d7235a0f53d75fd5e7d3e2f58ca175e4e99e28eda5a56f067976e8a8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RURBOjI1Q0JFRToyNDJBQzI6MzJCMzlBOjY5NkEwNzEwIiwidmlzaXRvcl9pZCI6IjY1NjUxMDE4NTQzOTQwMjU3NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0e794caa1714bdbd0c06cf02b2f0c4032e1c328ed97bbe9d9a9929ffb4154839 |
| hovercard-subject-tag | pull_request:98642254 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10345/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/26c520fd53a2637b27ccfd591412547bfee2293ec93e4cb53ee7959db1e4db46/nodejs/node/pull/10345 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/26c520fd53a2637b27ccfd591412547bfee2293ec93e4cb53ee7959db1e4db46/nodejs/node/pull/10345 |
| og:image:alt | Checklist
documentation is changed or added
commit message follows commit guidelines
Affected core subsystem(s)
doc,tls
Description of change
Addresses comment after PR #6933 merged.
#6933 (rev... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sam-github |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10345#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10345 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10345 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10345 |
| Reload | https://github.com/nodejs/node/pull/10345 |
| Reload | https://github.com/nodejs/node/pull/10345 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10345 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10345 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10345#issue-comment-box |
| italoacasas | https://github.com/italoacasas |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sam-github:typo-in-ecdh-property-name | https://github.com/sam-github/node/tree/typo-in-ecdh-property-name |
|
doc: fix typo in ecdhCurve, a tls property name
| https://github.com/nodejs/node/pull/10345#top |
| italoacasas | https://github.com/italoacasas |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sam-github:typo-in-ecdh-property-name | https://github.com/sam-github/node/tree/typo-in-ecdh-property-name |
|
Conversation
1
| https://github.com/nodejs/node/pull/10345 |
|
Commits
∞
| https://github.com/nodejs/node/pull/10345/commits |
|
Checks
| https://github.com/nodejs/node/pull/10345/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10345/files |
| Please reload this page | https://github.com/nodejs/node/pull/10345 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Dec 19, 2016 | https://github.com/nodejs/node/pull/10345#issue-196523957 |
| #6933 | https://github.com/nodejs/node/pull/6933 |
| #6933 (review) | https://github.com/nodejs/node/pull/6933#pullrequestreview-13318708 |
| Please reload this page | https://github.com/nodejs/node/pull/10345 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Dec 19, 2016 | https://github.com/nodejs/node/pull/10345#event-899253460 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Dec 19, 2016 | https://github.com/nodejs/node/pull/10345#event-899253668 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Dec 19, 2016
| https://github.com/nodejs/node/pull/10345#pullrequestreview-13647264 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10345/files |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Dec 19, 2016
| https://github.com/nodejs/node/pull/10345#pullrequestreview-13647840 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10345/files |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| force-pushed | https://github.com/nodejs/node/compare/0e223bd6cb08b0c09e68740e485506d45bfb396d..7b924f1713006219e20ae7f011405d18b3ac7426 |
| 0e223bd | https://github.com/nodejs/node/commit/0e223bd6cb08b0c09e68740e485506d45bfb396d |
| 7b924f1 | https://github.com/nodejs/node/commit/7b924f1713006219e20ae7f011405d18b3ac7426 |
|
Compare
| https://github.com/nodejs/node/compare/0e223bd6cb08b0c09e68740e485506d45bfb396d..7b924f1713006219e20ae7f011405d18b3ac7426 |
| December 20, 2016 14:30 | https://github.com/nodejs/node/pull/10345#event-900186586 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/10345#event-900186747 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/10345#issuecomment-268257283 |
| 7b924f1 | https://github.com/nodejs/node/commit/7b924f1713006219e20ae7f011405d18b3ac7426 |
| Please reload this page | https://github.com/nodejs/node/pull/10345 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/10345#event-900188254 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| 7b924f1 | https://github.com/nodejs/node/commit/7b924f1713006219e20ae7f011405d18b3ac7426 |
| Dec 20, 2016 | https://github.com/nodejs/node/pull/10345#event-900188484 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| force-pushed | https://github.com/nodejs/node/compare/dea6e83148e054fbfab4d3c872069828eb275618..1081f0f33df3a6e8825489600967a6f9e469ebb6 |
| dea6e83 | https://github.com/nodejs/node/commit/dea6e83148e054fbfab4d3c872069828eb275618 |
| 1081f0f | https://github.com/nodejs/node/commit/1081f0f33df3a6e8825489600967a6f9e469ebb6 |
|
Compare
| https://github.com/nodejs/node/compare/dea6e83148e054fbfab4d3c872069828eb275618..1081f0f33df3a6e8825489600967a6f9e469ebb6 |
| December 20, 2016 14:32 | https://github.com/nodejs/node/pull/10345#event-900188486 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| December 20, 2016 15:15 | https://github.com/nodejs/node/pull/10345#event-900251415 |
| cjihrig | https://github.com/cjihrig |
|
Dec 20, 2016
| https://github.com/nodejs/node/pull/10345#ref-commit-02dc680 |
|
| https://github.com/sam-github |
|
| https://github.com/cjihrig |
| doc: fix typo in ecdhCurve, a tls property name | https://github.com/cjihrig/node/commit/02dc680b0422cb1a0fa8744fadab0e92bd2b03dd |
| 02dc680 | https://github.com/cjihrig/node/commit/02dc680b0422cb1a0fa8744fadab0e92bd2b03dd |
| nodejs#6933 | https://github.com/nodejs/node/pull/6933 |
| nodejs#6933 (review) | https://github.com/nodejs/node/pull/6933#pullrequestreview-13318708 |
| nodejs#10345 | https://github.com/nodejs/node/pull/10345 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Dec 20, 2016
| https://github.com/nodejs/node/pull/10345#ref-pullrequest-195698085 |
|
v7.3.0 proposal
#10277
| https://github.com/nodejs/node/pull/10277 |
| cjihrig | https://github.com/cjihrig |
|
Dec 20, 2016
| https://github.com/nodejs/node/pull/10345#ref-commit-5654c83 |
|
| https://github.com/sam-github |
|
| https://github.com/cjihrig |
| doc: fix typo in ecdhCurve, a tls property name | https://github.com/nodejs/node/commit/5654c83fb3cb49f64316003066b51050a972991d |
| 5654c83 | https://github.com/nodejs/node/commit/5654c83fb3cb49f64316003066b51050a972991d |
| #6933 | https://github.com/nodejs/node/pull/6933 |
| #6933 (review) | https://github.com/nodejs/node/pull/6933#pullrequestreview-13318708 |
| #10345 | https://github.com/nodejs/node/pull/10345 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 22, 2017
| https://github.com/nodejs/node/pull/10345#ref-commit-27dba16 |
|
| https://github.com/sam-github |
|
| https://github.com/MylesBorins |
| doc: fix typo in ecdhCurve, a tls property name | https://github.com/nodejs/node/commit/27dba162837d42e54ca83ee413bb907e307cb0c3 |
| 27dba16 | https://github.com/nodejs/node/commit/27dba162837d42e54ca83ee413bb907e307cb0c3 |
| #6933 | https://github.com/nodejs/node/pull/6933 |
| #6933 (review) | https://github.com/nodejs/node/pull/6933#pullrequestreview-13318708 |
| #10345 | https://github.com/nodejs/node/pull/10345 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 22, 2017 | https://github.com/nodejs/node/pull/10345#event-932160801 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/10345#ref-commit-1da1af5 |
|
| https://github.com/sam-github |
|
| https://github.com/MylesBorins |
| doc: fix typo in ecdhCurve, a tls property name | https://github.com/nodejs/node/commit/1da1af5e7c2bf967e984ac0652e962ddbe2e5b3f |
| 1da1af5 | https://github.com/nodejs/node/commit/1da1af5e7c2bf967e984ac0652e962ddbe2e5b3f |
| #6933 | https://github.com/nodejs/node/pull/6933 |
| #6933 (review) | https://github.com/nodejs/node/pull/6933#pullrequestreview-13318708 |
| #10345 | https://github.com/nodejs/node/pull/10345 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/10345#ref-pullrequest-202753839 |
|
v6.10.0 proposal
#10974
| https://github.com/nodejs/node/pull/10974 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 31, 2017
| https://github.com/nodejs/node/pull/10345#ref-commit-24bf753 |
|
| https://github.com/sam-github |
|
| https://github.com/MylesBorins |
| doc: fix typo in ecdhCurve, a tls property name | https://github.com/nodejs/node/commit/24bf75309a804402588e9223eae81fd247527a6e |
| 24bf753 | https://github.com/nodejs/node/commit/24bf75309a804402588e9223eae81fd247527a6e |
| #6933 | https://github.com/nodejs/node/pull/6933 |
| #6933 (review) | https://github.com/nodejs/node/pull/6933#pullrequestreview-13318708 |
| #10345 | https://github.com/nodejs/node/pull/10345 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10345 |
|
| https://github.com/silverwind |
|
silverwind
| https://github.com/silverwind |
|
| https://github.com/nodejs/node/pull/10345/files/0e223bd6cb08b0c09e68740e485506d45bfb396d |
|
| https://github.com/italoacasas |
|
italoacasas
| https://github.com/italoacasas |
|
| https://github.com/nodejs/node/pull/10345/files/0e223bd6cb08b0c09e68740e485506d45bfb396d |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Please reload this page | https://github.com/nodejs/node/pull/10345 |
|
| https://github.com/sam-github |
|
| https://github.com/silverwind |
|
| https://github.com/italoacasas |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |