| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d9456005-d9bc-7b34-e98d-6a79e7ffef51 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9AB6:13A4F6:DC769:1320CA:696A662D |
| html-safe-nonce | eceb42a3b3024c3b3afdee6a0019ac8c2ed2453394eb57883a24459351e03a22 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUI2OjEzQTRGNjpEQzc2OToxMzIwQ0E6Njk2QTY2MkQiLCJ2aXNpdG9yX2lkIjoiODk4OTY5NDMxNzE2ODE2NDI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fea0a9dd838fa82d1bfba4780a02b08cb5c5effab78a4f410c802a7025754b17 |
| hovercard-subject-tag | pull_request:98447911 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10318/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fe58f353edb11eb2ed4999fd10c6201ff0d794206e6a3cc48e9b7c995f2c0663/nodejs/node/pull/10318 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fe58f353edb11eb2ed4999fd10c6201ff0d794206e6a3cc48e9b7c995f2c0663/nodejs/node/pull/10318 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines
Affected core subsystem(s)
test
Descriptio... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | edsadr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10318#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10318 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10318 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10318 |
| Reload | https://github.com/nodejs/node/pull/10318 |
| Reload | https://github.com/nodejs/node/pull/10318 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10318 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/10318 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/10318#issue-comment-box |
| edsadr | https://github.com/edsadr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| edsadr:http-bind-twice | https://github.com/edsadr/node/tree/http-bind-twice |
|
test: improve code in test-http-bind-twice.js
| https://github.com/nodejs/node/pull/10318#top |
| edsadr | https://github.com/edsadr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| edsadr:http-bind-twice | https://github.com/edsadr/node/tree/http-bind-twice |
|
Conversation
2
| https://github.com/nodejs/node/pull/10318 |
|
Commits
1
| https://github.com/nodejs/node/pull/10318/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/10318/checks |
|
Files changed
| https://github.com/nodejs/node/pull/10318/files |
| Please reload this page | https://github.com/nodejs/node/pull/10318 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/edsadr |
| edsadr | https://github.com/edsadr |
| Dec 17, 2016 | https://github.com/nodejs/node/pull/10318#issue-196229221 |
| Please reload this page | https://github.com/nodejs/node/pull/10318 |
|
| https://github.com/edsadr |
| test: improve code in test-http-bind-twice.js | https://github.com/nodejs/node/pull/10318/commits/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
| 02560ab | https://github.com/nodejs/node/pull/10318/commits/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Dec 17, 2016 | https://github.com/nodejs/node/pull/10318#event-897631054 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Dec 17, 2016
| https://github.com/nodejs/node/pull/10318#pullrequestreview-13449084 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10318/files/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Dec 17, 2016
| https://github.com/nodejs/node/pull/10318#pullrequestreview-13449146 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10318/files/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Dec 17, 2016
| https://github.com/nodejs/node/pull/10318#pullrequestreview-13449488 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10318/files/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
| Dec 17, 2016 | https://github.com/nodejs/node/pull/10318#issuecomment-267774136 |
| https://ci.nodejs.org/job/node-test-pull-request/5456/console | https://ci.nodejs.org/job/node-test-pull-request/5456/console |
| Please reload this page | https://github.com/nodejs/node/pull/10318 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Dec 17, 2016
| https://github.com/nodejs/node/pull/10318#pullrequestreview-13449577 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10318/files/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Dec 17, 2016 | https://github.com/nodejs/node/pull/10318#event-897664654 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Dec 19, 2016
| https://github.com/nodejs/node/pull/10318#ref-issue-196480454 |
|
Correctly identify pLinux LE and BE in the Github CI plugin
nodejs/build#575
| https://github.com/nodejs/build/issues/575 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 23, 2016
| https://github.com/nodejs/node/pull/10318#pullrequestreview-14266141 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10318/files/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
| jasnell | https://github.com/jasnell |
|
Dec 23, 2016
| https://github.com/nodejs/node/pull/10318#ref-commit-80f19b0 |
|
| https://github.com/edsadr |
|
| https://github.com/jasnell |
| test: improve code in test-http-bind-twice.js | https://github.com/nodejs/node/commit/80f19b043dda93135d69459def5944e60518c690 |
| 80f19b0 | https://github.com/nodejs/node/commit/80f19b043dda93135d69459def5944e60518c690 |
| #10318 | https://github.com/nodejs/node/pull/10318 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 23, 2016 | https://github.com/nodejs/node/pull/10318#issuecomment-268945765 |
| Please reload this page | https://github.com/nodejs/node/pull/10318 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 23, 2016 | https://github.com/nodejs/node/pull/10318#event-903788713 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/10318#ref-pullrequest-198417482 |
|
v7.4.0 release proposal
#10589
| https://github.com/nodejs/node/pull/10589 |
| evanlucas | https://github.com/evanlucas |
|
Jan 3, 2017
| https://github.com/nodejs/node/pull/10318#ref-commit-b17046c |
|
| https://github.com/edsadr |
|
| https://github.com/evanlucas |
| test: improve code in test-http-bind-twice.js | https://github.com/nodejs/node/commit/b17046c4d80702fc1381cbdd4161abb2542bcb02 |
| b17046c | https://github.com/nodejs/node/commit/b17046c4d80702fc1381cbdd4161abb2542bcb02 |
| #10318 | https://github.com/nodejs/node/pull/10318 |
| evanlucas | https://github.com/evanlucas |
|
Jan 4, 2017
| https://github.com/nodejs/node/pull/10318#ref-commit-9a0711d |
|
| https://github.com/edsadr |
|
| https://github.com/evanlucas |
| test: improve code in test-http-bind-twice.js | https://github.com/nodejs/node/commit/9a0711d37fc70ecd5c61d3ac18d8440281163eae |
| 9a0711d | https://github.com/nodejs/node/commit/9a0711d37fc70ecd5c61d3ac18d8440281163eae |
| #10318 | https://github.com/nodejs/node/pull/10318 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/10318#ref-commit-7f9035d |
|
| https://github.com/edsadr |
|
| https://github.com/MylesBorins |
| test: improve code in test-http-bind-twice.js | https://github.com/nodejs/node/commit/7f9035decc16416dafec7a7dc0e622cb6e086ce6 |
| 7f9035d | https://github.com/nodejs/node/commit/7f9035decc16416dafec7a7dc0e622cb6e086ce6 |
| #10318 | https://github.com/nodejs/node/pull/10318 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/10318#event-932168927 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/10318#ref-commit-be7917e |
|
| https://github.com/edsadr |
|
| https://github.com/MylesBorins |
| test: improve code in test-http-bind-twice.js | https://github.com/nodejs/node/commit/be7917ed095a3e5f3747fa1f56025b76832e0ddb |
| be7917e | https://github.com/nodejs/node/commit/be7917ed095a3e5f3747fa1f56025b76832e0ddb |
| #10318 | https://github.com/nodejs/node/pull/10318 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/10318#ref-pullrequest-202753839 |
|
v6.10.0 proposal
#10974
| https://github.com/nodejs/node/pull/10974 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 31, 2017
| https://github.com/nodejs/node/pull/10318#ref-commit-781d04a |
|
| https://github.com/edsadr |
|
| https://github.com/MylesBorins |
| test: improve code in test-http-bind-twice.js | https://github.com/nodejs/node/commit/781d04a1b3f7a5682eac7540c30fa1d74805bc79 |
| 781d04a | https://github.com/nodejs/node/commit/781d04a1b3f7a5682eac7540c30fa1d74805bc79 |
| #10318 | https://github.com/nodejs/node/pull/10318 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10318 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/10318/files/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/10318/files/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/10318/files/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/10318/files/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
|
| https://github.com/italoacasas |
|
italoacasas
| https://github.com/italoacasas |
|
| https://github.com/nodejs/node/pull/10318/files/02560ab13932bcdf38b0a14f8245e519477c2fa6 |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/10318 |
|
| https://github.com/edsadr |
|
| https://github.com/italoacasas |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
|
| https://github.com/cjihrig |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |