René's URL Explorer Experiment


Title: assert: enforce type check in deepStrictEqual by joyeecheung · Pull Request #10282 · nodejs/node · GitHub

Open Graph Title: assert: enforce type check in deepStrictEqual by joyeecheung · Pull Request #10282 · nodejs/node

X Title: assert: enforce type check in deepStrictEqual by joyeecheung · Pull Request #10282 · nodejs/node

Description: For a write-up on this PR, see #10282 (comment) The less-breaking part of this PR has been moved to #11128 Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or ...

Open Graph Description: For a write-up on this PR, see #10282 (comment) The less-breaking part of this PR has been moved to #11128 Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or ...

X Description: For a write-up on this PR, see #10282 (comment) The less-breaking part of this PR has been moved to #11128 Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or ...

Opengraph URL: https://github.com/nodejs/node/pull/10282

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:354e0e8f-b7dd-ce3a-0113-d7a59cee0244
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8E8:1DECF9:1D2924:261396:696AD828
html-safe-nonce6f65c1432d1ff6d205088a241f8e9e7476ae92a73669c94bbbcc5b5fa7a4c1ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEU4OjFERUNGOToxRDI5MjQ6MjYxMzk2OjY5NkFEODI4IiwidmlzaXRvcl9pZCI6IjI4OTMzODYyMTM0Mjg0ODQxMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2cd6d3d7d7a85688eb794e17b9c83f6ca05eb80c95c483430cdc634b1bd14b7d
hovercard-subject-tagpull_request:98107571
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10282/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8e761c938867c04ef684973fd1916a0ffe8f1c8ee785de2709ac6447d25e2355/nodejs/node/pull/10282
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8e761c938867c04ef684973fd1916a0ffe8f1c8ee785de2709ac6447d25e2355/nodejs/node/pull/10282
og:image:altFor a write-up on this PR, see #10282 (comment) The less-breaking part of this PR has been moved to #11128 Checklist make -j4 test (UNIX), or vcbuild test nosign (Windows) passes tests and/or ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/10282#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10282
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10282
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/10282
Reloadhttps://github.com/nodejs/node/pull/10282
Reloadhttps://github.com/nodejs/node/pull/10282
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/10282
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/10282
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/10282#issue-comment-box
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:fix-asserthttps://github.com/joyeecheung/node/tree/fix-assert
assert: enforce type check in deepStrictEqual https://github.com/nodejs/node/pull/10282#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:fix-asserthttps://github.com/joyeecheung/node/tree/fix-assert
Conversation 91 https://github.com/nodejs/node/pull/10282
Commits 2 https://github.com/nodejs/node/pull/10282/commits
Checks 0 https://github.com/nodejs/node/pull/10282/checks
Files changed https://github.com/nodejs/node/pull/10282/files
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 15, 2016https://github.com/nodejs/node/pull/10282#issue-195746896
Please reload this pagehttps://github.com/nodejs/node/pull/10282
#10282 (comment)https://github.com/nodejs/node/pull/10282#issuecomment-274590846
#11128https://github.com/nodejs/node/pull/11128
nodejs/node-v0.x-archive#7178https://github.com/nodejs/node-v0.x-archive/pull/7178
#10258https://github.com/nodejs/node/issues/10258
#7815https://github.com/nodejs/node/pull/7815
https://tc39.github.io/ecma262/#sec-object.prototype.tostringhttps://tc39.github.io/ecma262/#sec-object.prototype.tostring
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 15, 2016https://github.com/nodejs/node/pull/10282#event-894876922
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/ecdd02454fb124d0bf853fa0d539995610d30cb0..d065c7c82130c4f5ccd252ff4b6a670d8d77dff4
ecdd024https://github.com/nodejs/node/commit/ecdd02454fb124d0bf853fa0d539995610d30cb0
d065c7chttps://github.com/nodejs/node/commit/d065c7c82130c4f5ccd252ff4b6a670d8d77dff4
Compare https://github.com/nodejs/node/compare/ecdd02454fb124d0bf853fa0d539995610d30cb0..d065c7c82130c4f5ccd252ff4b6a670d8d77dff4
December 15, 2016 09:00https://github.com/nodejs/node/pull/10282#event-894896903
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 15, 2016https://github.com/nodejs/node/pull/10282#event-894896988
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 15, 2016https://github.com/nodejs/node/pull/10282#event-895183499
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 15, 2016 https://github.com/nodejs/node/pull/10282#pullrequestreview-13123882
View reviewed changes https://github.com/nodejs/node/pull/10282/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/10282#pullrequestreview-13123882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#10258https://github.com/nodejs/node/issues/10258
Please reload this pagehttps://github.com/nodejs/node/pull/10282
lib/assert.jshttps://github.com/nodejs/node/pull/10282/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
addaleaxhttps://github.com/addaleax
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92605480
Please reload this pagehttps://github.com/nodejs/node/pull/10282
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
joyeecheunghttps://github.com/joyeecheung
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92632146
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
lib/assert.jshttps://github.com/nodejs/node/pull/10282/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
addaleaxhttps://github.com/addaleax
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92606169
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
joyeecheunghttps://github.com/joyeecheung
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92632352
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
test/parallel/test-assert-strict-typecheck.jshttps://github.com/nodejs/node/pull/10282/files#diff-8c6523644e3c0f11bc16953c9316ab8763191ec4bb2ef6f9fa52d1d4d963c297
addaleaxhttps://github.com/addaleax
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92606716
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
test/parallel/test-assert-strict-typecheck.jshttps://github.com/nodejs/node/pull/10282/files#diff-8c6523644e3c0f11bc16953c9316ab8763191ec4bb2ef6f9fa52d1d4d963c297
addaleaxhttps://github.com/addaleax
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92606906
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
joyeecheunghttps://github.com/joyeecheung
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92632852
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
addaleaxhttps://github.com/addaleax
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92685476
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/10282
joyeecheunghttps://github.com/joyeecheung
Dec 16, 2016https://github.com/nodejs/node/pull/10282#discussion_r92743930
Please reload this pagehttps://github.com/nodejs/node/pull/10282
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
Trotthttps://github.com/Trott
Dec 16, 2016https://github.com/nodejs/node/pull/10282#discussion_r92753436
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
joyeecheunghttps://github.com/joyeecheung
Dec 16, 2016https://github.com/nodejs/node/pull/10282#discussion_r92791257
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
test/parallel/test-assert-strict-typecheck.jshttps://github.com/nodejs/node/pull/10282/files#diff-8c6523644e3c0f11bc16953c9316ab8763191ec4bb2ef6f9fa52d1d4d963c297
addaleaxhttps://github.com/addaleax
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92607290
Please reload this pagehttps://github.com/nodejs/node/pull/10282
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://nodejs.org/api/assert.html#assert_assert_throws_block_error_messagehttps://nodejs.org/api/assert.html#assert_assert_throws_block_error_message
Please reload this pagehttps://github.com/nodejs/node/pull/10282
joyeecheunghttps://github.com/joyeecheung
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92633526
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
addaleaxhttps://github.com/addaleax
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92685487
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/10282
test/parallel/test-assert-strict-typecheck.jshttps://github.com/nodejs/node/pull/10282/files#diff-8c6523644e3c0f11bc16953c9316ab8763191ec4bb2ef6f9fa52d1d4d963c297
addaleaxhttps://github.com/addaleax
Dec 15, 2016https://github.com/nodejs/node/pull/10282#discussion_r92607424
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/d065c7c82130c4f5ccd252ff4b6a670d8d77dff4..89cdd8fd7159186ba0240559d552f7a7f22bce25
d065c7chttps://github.com/nodejs/node/commit/d065c7c82130c4f5ccd252ff4b6a670d8d77dff4
89cdd8fhttps://github.com/nodejs/node/commit/89cdd8fd7159186ba0240559d552f7a7f22bce25
Compare https://github.com/nodejs/node/compare/d065c7c82130c4f5ccd252ff4b6a670d8d77dff4..89cdd8fd7159186ba0240559d552f7a7f22bce25
December 15, 2016 16:29https://github.com/nodejs/node/pull/10282#event-895477996
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 15, 2016https://github.com/nodejs/node/pull/10282#event-895478184
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/89cdd8fd7159186ba0240559d552f7a7f22bce25..df77ce15f5ef9237bfdfb862eb1bdbb350ae9955
89cdd8fhttps://github.com/nodejs/node/commit/89cdd8fd7159186ba0240559d552f7a7f22bce25
df77ce1https://github.com/nodejs/node/commit/df77ce15f5ef9237bfdfb862eb1bdbb350ae9955
Compare https://github.com/nodejs/node/compare/89cdd8fd7159186ba0240559d552f7a7f22bce25..df77ce15f5ef9237bfdfb862eb1bdbb350ae9955
December 15, 2016 16:32https://github.com/nodejs/node/pull/10282#event-895481970
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 15, 2016https://github.com/nodejs/node/pull/10282#event-895482120
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 15, 2016https://github.com/nodejs/node/pull/10282#issuecomment-267374214
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/df77ce15f5ef9237bfdfb862eb1bdbb350ae9955..5cdfc0e3e936168a4380af1c29c88b47fd4bfef3
df77ce1https://github.com/nodejs/node/commit/df77ce15f5ef9237bfdfb862eb1bdbb350ae9955
5cdfc0ehttps://github.com/nodejs/node/commit/5cdfc0e3e936168a4380af1c29c88b47fd4bfef3
Compare https://github.com/nodejs/node/compare/df77ce15f5ef9237bfdfb862eb1bdbb350ae9955..5cdfc0e3e936168a4380af1c29c88b47fd4bfef3
December 15, 2016 16:34https://github.com/nodejs/node/pull/10282#event-895485921
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 15, 2016https://github.com/nodejs/node/pull/10282#event-895486076
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 15, 2016https://github.com/nodejs/node/pull/10282#event-895751230
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 15, 2016https://github.com/nodejs/node/pull/10282#issuecomment-267457180
https://ci.nodejs.org/job/node-test-commit/6668/https://ci.nodejs.org/job/node-test-commit/6668/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/481/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/481/
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Trotthttps://github.com/Trott
December 15, 2016 22:01https://github.com/nodejs/node/pull/10282#event-895932641
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 16, 2016 https://github.com/nodejs/node/pull/10282#pullrequestreview-13273268
View reviewed changes https://github.com/nodejs/node/pull/10282/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/10282#pullrequestreview-13273268
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
lib/assert.jshttps://github.com/nodejs/node/pull/10282/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
Trotthttps://github.com/Trott
Dec 16, 2016https://github.com/nodejs/node/pull/10282#discussion_r92752541
Please reload this pagehttps://github.com/nodejs/node/pull/10282
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
http://wiki.commonjs.org/wiki/Unit_Testing/1.0http://wiki.commonjs.org/wiki/Unit_Testing/1.0
Please reload this pagehttps://github.com/nodejs/node/pull/10282
joyeecheunghttps://github.com/joyeecheung
Dec 16, 2016https://github.com/nodejs/node/pull/10282#discussion_r92791361
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
test/parallel/test-assert.jshttps://github.com/nodejs/node/pull/10282/files#diff-968e57a9f4d4ce7494523f71b2594d844620c2794a68049cce33fcdc8c7c7b7c
Trotthttps://github.com/Trott
Dec 16, 2016https://github.com/nodejs/node/pull/10282#discussion_r92752846
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
joyeecheunghttps://github.com/joyeecheung
Dec 16, 2016https://github.com/nodejs/node/pull/10282#discussion_r92791731
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
test/parallel/test-assert.jshttps://github.com/nodejs/node/pull/10282/files#diff-968e57a9f4d4ce7494523f71b2594d844620c2794a68049cce33fcdc8c7c7b7c
Trotthttps://github.com/Trott
Dec 16, 2016https://github.com/nodejs/node/pull/10282#discussion_r92752857
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/targos
targoshttps://github.com/targos
Dec 16, 2016 https://github.com/nodejs/node/pull/10282#ref-pullrequest-196008356
tools: forbid template literals in assert.throws #10301 https://github.com/nodejs/node/pull/10301
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 16, 2016https://github.com/nodejs/node/pull/10282#event-896799833
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 16, 2016https://github.com/nodejs/node/pull/10282#issuecomment-267620403
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 16, 2016 https://github.com/nodejs/node/pull/10282#pullrequestreview-13415295
View reviewed changes https://github.com/nodejs/node/pull/10282/files
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 16, 2016https://github.com/nodejs/node/pull/10282#issuecomment-267702138
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/Trott
Trotthttps://github.com/Trott
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Dec 16, 2016https://github.com/nodejs/node/pull/10282#event-897283267
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 16, 2016https://github.com/nodejs/node/pull/10282#issuecomment-267702209
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 16, 2016 https://github.com/nodejs/node/pull/10282#pullrequestreview-13416149
View reviewed changes https://github.com/nodejs/node/pull/10282/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/10282#pullrequestreview-13416149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 17, 2016 https://github.com/nodejs/node/pull/10282#pullrequestreview-13438574
View reviewed changes https://github.com/nodejs/node/pull/10282/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/10282#pullrequestreview-13438574
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
targoshttps://github.com/targos
Dec 19, 2016 https://github.com/nodejs/node/pull/10282#ref-commit-7cb9813
https://github.com/targos
tools: forbid template literals in assert.throwshttps://github.com/targos/node/commit/7cb98138a9bd5b87010c49011e281ee4c4024eec
7cb9813https://github.com/targos/node/commit/7cb98138a9bd5b87010c49011e281ee4c4024eec
nodejs#10301https://github.com/nodejs/node/pull/10301
nodejs#10282 (comment)https://github.com/nodejs/node/pull/10282#discussion_r92607290
cjihrighttps://github.com/cjihrig
Dec 20, 2016 https://github.com/nodejs/node/pull/10282#ref-commit-be6d362
https://github.com/targos
https://github.com/cjihrig
tools: forbid template literals in assert.throwshttps://github.com/cjihrig/node/commit/be6d362e36e0c19dc71eb88ad373d9b73cd4a727
be6d362https://github.com/cjihrig/node/commit/be6d362e36e0c19dc71eb88ad373d9b73cd4a727
nodejs#10301https://github.com/nodejs/node/pull/10301
nodejs#10282 (comment)https://github.com/nodejs/node/pull/10282#discussion_r92607290
cjihrighttps://github.com/cjihrig
Dec 20, 2016 https://github.com/nodejs/node/pull/10282#ref-commit-367eb3e
https://github.com/targos
https://github.com/cjihrig
tools: forbid template literals in assert.throwshttps://github.com/nodejs/node/commit/367eb3ea410216b7717966baa19744929258384e
367eb3ehttps://github.com/nodejs/node/commit/367eb3ea410216b7717966baa19744929258384e
#10301https://github.com/nodejs/node/pull/10301
#10282 (comment)https://github.com/nodejs/node/pull/10282#discussion_r92607290
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Feb 6, 2017 https://github.com/nodejs/node/pull/10282#pullrequestreview-20208135
View reviewed changes https://github.com/nodejs/node/pull/10282/files
ljharbhttps://github.com/ljharb
https://github.com/nodejs/node/pull/10282#pullrequestreview-20208135
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
lib/assert.jshttps://github.com/nodejs/node/pull/10282/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
ljharbhttps://github.com/ljharb
Feb 6, 2017https://github.com/nodejs/node/pull/10282#discussion_r99529848
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
joyeecheunghttps://github.com/joyeecheung
Feb 6, 2017https://github.com/nodejs/node/pull/10282#discussion_r99531528
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
lib/assert.jshttps://github.com/nodejs/node/pull/10282/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
ljharbhttps://github.com/ljharb
Feb 6, 2017https://github.com/nodejs/node/pull/10282#discussion_r99529904
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
lib/assert.jshttps://github.com/nodejs/node/pull/10282/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
ljharbhttps://github.com/ljharb
Feb 6, 2017https://github.com/nodejs/node/pull/10282#discussion_r99529990
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
lib/assert.jshttps://github.com/nodejs/node/pull/10282/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
ljharbhttps://github.com/ljharb
Feb 6, 2017https://github.com/nodejs/node/pull/10282#discussion_r99530032
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Feb 8, 2017 https://github.com/nodejs/node/pull/10282#ref-issue-205671760
Changing Definition of "Locked" for Stability Index in API Docs #11200 https://github.com/nodejs/node/issues/11200
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Feb 17, 2017https://github.com/nodejs/node/pull/10282#event-967150112
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Feb 17, 2017https://github.com/nodejs/node/pull/10282#issuecomment-280692456
#11128https://github.com/nodejs/node/pull/11128
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Feb 18, 2017 https://github.com/nodejs/node/pull/10282#ref-pullrequest-208648336
util: eliminate unecessary internal/util export #11455 https://github.com/nodejs/node/pull/11455
joyeecheunghttps://github.com/joyeecheung
Feb 25, 2017 https://github.com/nodejs/node/pull/10282#ref-commit-aa023db
https://github.com/joyeecheung
assert: fix premature deep strict comparisonhttps://github.com/joyeecheung/node/commit/aa023dbcc242143bb102cb2a29e93da93ba52c99
aa023dbhttps://github.com/joyeecheung/node/commit/aa023dbcc242143bb102cb2a29e93da93ba52c99
nodejs#10282 (comment)https://github.com/nodejs/node/pull/10282#issuecomment-274267895
nodejs#10258 (comment)https://github.com/nodejs/node/issues/10258#issuecomment-266963234
joyeecheunghttps://github.com/joyeecheung
Feb 27, 2017 https://github.com/nodejs/node/pull/10282#ref-commit-562cf5a
https://github.com/joyeecheung
assert: fix premature deep strict comparisonhttps://github.com/nodejs/node/commit/562cf5a81c213f893a4787d1143e322c720e0eb9
562cf5ahttps://github.com/nodejs/node/commit/562cf5a81c213f893a4787d1143e322c720e0eb9
#11128https://github.com/nodejs/node/pull/11128
#10282 (comment)https://github.com/nodejs/node/pull/10282#issuecomment-274267895
#10258 (comment)https://github.com/nodejs/node/issues/10258#issuecomment-266963234
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Mar 6, 2017https://github.com/nodejs/node/pull/10282#issuecomment-284447503
#11304https://github.com/nodejs/node/pull/11304
#11128https://github.com/nodejs/node/pull/11128
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Mar 6, 2017https://github.com/nodejs/node/pull/10282#event-988010530
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 7, 2017https://github.com/nodejs/node/pull/10282#issuecomment-284593723
@ChALkeRhttps://github.com/ChALkeR
#10282 (comment)https://github.com/nodejs/node/pull/10282#issuecomment-275194045
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/d27e611237e9e6c544d4b388bdd36b01d3fe3462..855ac04bf9466a865f638a535cc6946feec043be
d27e611https://github.com/nodejs/node/commit/d27e611237e9e6c544d4b388bdd36b01d3fe3462
855ac04https://github.com/nodejs/node/commit/855ac04bf9466a865f638a535cc6946feec043be
Compare https://github.com/nodejs/node/compare/d27e611237e9e6c544d4b388bdd36b01d3fe3462..855ac04bf9466a865f638a535cc6946feec043be
March 11, 2017 13:49https://github.com/nodejs/node/pull/10282#event-995973718
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 11, 2017 https://github.com/nodejs/node/pull/10282#ref-issue-213528698
assert.deepStrictEqual() fails to compare ES6 style object properties #11803 https://github.com/nodejs/node/issues/11803
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/2dabb6782f818d6fa23c110e926150907d11b331..3efc5149a9716dd519c33d31edbf580add7ae5b2
2dabb67https://github.com/nodejs/node/commit/2dabb6782f818d6fa23c110e926150907d11b331
3efc514https://github.com/nodejs/node/commit/3efc5149a9716dd519c33d31edbf580add7ae5b2
Compare https://github.com/nodejs/node/compare/2dabb6782f818d6fa23c110e926150907d11b331..3efc5149a9716dd519c33d31edbf580add7ae5b2
March 11, 2017 14:51https://github.com/nodejs/node/pull/10282#event-995989757
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 11, 2017https://github.com/nodejs/node/pull/10282#issuecomment-285871411
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/joyeecheung
assert: enforce type check in deepStrictEqualhttps://github.com/nodejs/node/pull/10282/commits/3efc5149a9716dd519c33d31edbf580add7ae5b2
3efc514https://github.com/nodejs/node/pull/10282/commits/3efc5149a9716dd519c33d31edbf580add7ae5b2
https://tc39.github.io/ecma262/#sec-object.prototype.tostringhttps://tc39.github.io/ecma262/#sec-object.prototype.tostring
nodejs#10258https://github.com/nodejs/node/issues/10258
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 11, 2017 https://github.com/nodejs/node/pull/10282#pullrequestreview-26424293
View reviewed changes https://github.com/nodejs/node/pull/10282/files/3efc5149a9716dd519c33d31edbf580add7ae5b2
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/10282#pullrequestreview-26424293
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
doc/api/assert.mdhttps://github.com/nodejs/node/pull/10282/files/3efc5149a9716dd519c33d31edbf580add7ae5b2#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97
addaleaxhttps://github.com/addaleax
Mar 11, 2017https://github.com/nodejs/node/pull/10282#discussion_r105535065
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
joyeecheunghttps://github.com/joyeecheung
Mar 12, 2017https://github.com/nodejs/node/pull/10282#discussion_r105549068
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
doc/api/assert.mdhttps://github.com/nodejs/node/pull/10282/files/3efc5149a9716dd519c33d31edbf580add7ae5b2#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97
addaleaxhttps://github.com/addaleax
Mar 11, 2017https://github.com/nodejs/node/pull/10282#discussion_r105535069
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 12, 2017https://github.com/nodejs/node/pull/10282#issuecomment-285923127
@addaleaxhttps://github.com/addaleax
https://ci.nodejs.org/job/node-test-pull-request/6804/https://ci.nodejs.org/job/node-test-pull-request/6804/
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/joyeecheung
add missing link, fix typohttps://github.com/nodejs/node/pull/10282/commits/b8ed11bbe99faa45f482deaf8e7bf39bbcf4c69b
b8ed11bhttps://github.com/nodejs/node/pull/10282/commits/b8ed11bbe99faa45f482deaf8e7bf39bbcf4c69b
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 12, 2017https://github.com/nodejs/node/pull/10282#issuecomment-285942717
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/641/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/641/
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 12, 2017https://github.com/nodejs/node/pull/10282#issuecomment-285954872
efec14ahttps://github.com/nodejs/node/commit/efec14a7d12d9e07e4efcc8e5c0ad7f80c47f83f
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 12, 2017https://github.com/nodejs/node/pull/10282#event-996372670
addaleaxhttps://github.com/addaleax
Mar 12, 2017 https://github.com/nodejs/node/pull/10282#ref-commit-efec14a
https://github.com/joyeecheung
https://github.com/addaleax
assert: enforce type check in deepStrictEqualhttps://github.com/nodejs/node/commit/efec14a7d12d9e07e4efcc8e5c0ad7f80c47f83f
efec14ahttps://github.com/nodejs/node/commit/efec14a7d12d9e07e4efcc8e5c0ad7f80c47f83f
https://tc39.github.io/ecma262/#sec-object.prototype.tostringhttps://tc39.github.io/ecma262/#sec-object.prototype.tostring
#10258https://github.com/nodejs/node/issues/10258
#10282https://github.com/nodejs/node/pull/10282
jungx098https://github.com/jungx098
Mar 21, 2017 https://github.com/nodejs/node/pull/10282#ref-commit-e98d6b6
https://github.com/joyeecheung
https://github.com/jungx098
assert: enforce type check in deepStrictEqualhttps://github.com/jungx098/node/commit/e98d6b60b8a94265d206e8aab1f5b71baac0c0ab
e98d6b6https://github.com/jungx098/node/commit/e98d6b60b8a94265d206e8aab1f5b71baac0c0ab
https://tc39.github.io/ecma262/#sec-object.prototype.tostringhttps://tc39.github.io/ecma262/#sec-object.prototype.tostring
nodejs#10258https://github.com/nodejs/node/issues/10258
nodejs#10282https://github.com/nodejs/node/pull/10282
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 4, 2017 https://github.com/nodejs/node/pull/10282#ref-pullrequest-219383958
8.0.0 Release Proposal #12220 https://github.com/nodejs/node/pull/12220
https://github.com/kt3k
kt3khttps://github.com/kt3k
Jun 20, 2025 https://github.com/nodejs/node/pull/10282#ref-pullrequest-3161784686
fix(ext/node): improve comparison of faked objects in deepStrictEqual denoland/deno#29819 https://github.com/denoland/deno/pull/29819
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10282
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/10282/files/d27e611237e9e6c544d4b388bdd36b01d3fe3462
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/10282/files/2f4af83eaa0245157b949b42e6f9cb5bb7a4c6b0
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/10282/files/2f4af83eaa0245157b949b42e6f9cb5bb7a4c6b0
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/10282/files/3efc5149a9716dd519c33d31edbf580add7ae5b2
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/10282/files/7e868490be1c9fd63c3cce3efc2037e0471571c6
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
assert.deepStrictEqual is fooled by strange dates https://github.com/nodejs/node/issues/10258
Please reload this pagehttps://github.com/nodejs/node/pull/10282
https://github.com/joyeecheung
https://github.com/addaleax
https://github.com/Trott
https://github.com/jasnell
https://github.com/italoacasas
https://github.com/ChALkeR
https://github.com/ljharb
https://github.com/TimothyGu
https://github.com/mscdex
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.