René's URL Explorer Experiment


Title: src: don't overwrite non-writable vm globals by bnoordhuis · Pull Request #10227 · nodejs/node · GitHub

Open Graph Title: src: don't overwrite non-writable vm globals by bnoordhuis · Pull Request #10227 · nodejs/node

X Title: src: don't overwrite non-writable vm globals by bnoordhuis · Pull Request #10227 · nodejs/node

Description: @fhinkel Can you take a look? I couldn't figure out what is_contextual_store is needed for. Tests pass without it. CI: https://ci.nodejs.org/job/node-test-pull-request/5357/

Open Graph Description: @fhinkel Can you take a look? I couldn't figure out what is_contextual_store is needed for. Tests pass without it. CI: https://ci.nodejs.org/job/node-test-pull-request/5357/

X Description: @fhinkel Can you take a look? I couldn't figure out what is_contextual_store is needed for. Tests pass without it. CI: https://ci.nodejs.org/job/node-test-pull-request/5357/

Opengraph URL: https://github.com/nodejs/node/pull/10227

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5fbf5853-adbc-69ba-177e-f58e74ae35af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE792:34B6FA:1FB6B4:2C2FFB:696A659D
html-safe-nonce0e3b29c9d7c53e8bdff593a9f3089a54180ddaad8e599dbd85026933b24b020f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzkyOjM0QjZGQToxRkI2QjQ6MkMyRkZCOjY5NkE2NTlEIiwidmlzaXRvcl9pZCI6IjIzMDc4NTEzMzc2ODk4ODQwNjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd361383ee4b823b3b1e3dfcea4259d359c0ab49b757e56e115e4496150005281
hovercard-subject-tagpull_request:97464307
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10227/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f49018155477520095fdeb6d72fc34ca724837dc517f10c61648dbf9ad0783d8/nodejs/node/pull/10227
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f49018155477520095fdeb6d72fc34ca724837dc517f10c61648dbf9ad0783d8/nodejs/node/pull/10227
og:image:alt@fhinkel Can you take a look? I couldn't figure out what is_contextual_store is needed for. Tests pass without it. CI: https://ci.nodejs.org/job/node-test-pull-request/5357/
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release87cbd411c2982752221b5751d583a515b23bf5fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/10227#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10227
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10227
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/10227
Reloadhttps://github.com/nodejs/node/pull/10227
Reloadhttps://github.com/nodejs/node/pull/10227
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/10227
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/10227
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/10227#issue-comment-box
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix10223https://github.com/bnoordhuis/io.js/tree/fix10223
src: don't overwrite non-writable vm globals https://github.com/nodejs/node/pull/10227#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix10223https://github.com/bnoordhuis/io.js/tree/fix10223
Conversation 9 https://github.com/nodejs/node/pull/10227
Commits 1 https://github.com/nodejs/node/pull/10227/commits
Checks 0 https://github.com/nodejs/node/pull/10227/checks
Files changed https://github.com/nodejs/node/pull/10227/files
Please reload this pagehttps://github.com/nodejs/node/pull/10227
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 11, 2016https://github.com/nodejs/node/pull/10227#issue-194841350
Please reload this pagehttps://github.com/nodejs/node/pull/10227
@fhinkelhttps://github.com/fhinkel
https://ci.nodejs.org/job/node-test-pull-request/5357/https://ci.nodejs.org/job/node-test-pull-request/5357/
Please reload this pagehttps://github.com/nodejs/node/pull/10227
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
fhinkelhttps://github.com/fhinkel
December 11, 2016 16:38https://github.com/nodejs/node/pull/10227#event-889612633
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Dec 11, 2016https://github.com/nodejs/node/pull/10227#event-889612637
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 11, 2016 https://github.com/nodejs/node/pull/10227#ref-issue-194809058
Object.defineProperty on the global object does not handle 'writable' properly in vm context #10223 https://github.com/nodejs/node/issues/10223
https://github.com/mscdex
mscdexhttps://github.com/mscdex
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Dec 11, 2016https://github.com/nodejs/node/pull/10227#event-889620555
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Dec 11, 2016 https://github.com/nodejs/node/pull/10227#ref-issue-194392876
attempt-backport still does not work Edit: now working?! nodejs/github-bot#100 https://github.com/nodejs/github-bot/issues/100
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Dec 11, 2016https://github.com/nodejs/node/pull/10227#issuecomment-266296397
Please reload this pagehttps://github.com/nodejs/node/pull/10227
https://github.com/v8/v8/blob/master/src/objects.cc#L4812https://github.com/v8/v8/blob/master/src/objects.cc#L4812
Please reload this pagehttps://github.com/nodejs/node/pull/10227
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Dec 11, 2016 https://github.com/nodejs/node/pull/10227#pullrequestreview-12371708
View reviewed changes https://github.com/nodejs/node/pull/10227/files
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Dec 11, 2016 https://github.com/nodejs/node/pull/10227#pullrequestreview-12377781
View reviewed changes https://github.com/nodejs/node/pull/10227/files
test/parallel/test-vm-context.jshttps://github.com/nodejs/node/pull/10227/files#diff-8d6668ad1689a2cb32e8e9978d1a4648f23d28bcacb32007b61f920cebe9c8c7
benjamingrhttps://github.com/benjamingr
Dec 11, 2016https://github.com/nodejs/node/pull/10227#discussion_r91868516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10227
bnoordhuishttps://github.com/bnoordhuis
Dec 12, 2016https://github.com/nodejs/node/pull/10227#discussion_r91923480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10227
benjamingrhttps://github.com/benjamingr
Dec 12, 2016https://github.com/nodejs/node/pull/10227#discussion_r91946646
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/10227
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 12, 2016https://github.com/nodejs/node/pull/10227#event-890400382
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Dec 12, 2016https://github.com/nodejs/node/pull/10227#event-890414257
https://github.com/bnoordhuis
src: don't overwrite non-writable vm globalshttps://github.com/nodejs/node/pull/10227/commits/524f693872cf453af2655ec47356d25d52394e3d
524f693https://github.com/nodejs/node/pull/10227/commits/524f693872cf453af2655ec47356d25d52394e3d
nodejs#10223https://github.com/nodejs/node/issues/10223
nodejs#10227https://github.com/nodejs/node/pull/10227
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/70710d20fffee9d0b0c5e1c609b65f8923d4083a..524f693872cf453af2655ec47356d25d52394e3d
70710d2https://github.com/nodejs/node/commit/70710d20fffee9d0b0c5e1c609b65f8923d4083a
524f693https://github.com/nodejs/node/commit/524f693872cf453af2655ec47356d25d52394e3d
Compare https://github.com/nodejs/node/compare/70710d20fffee9d0b0c5e1c609b65f8923d4083a..524f693872cf453af2655ec47356d25d52394e3d
December 13, 2016 12:18https://github.com/nodejs/node/pull/10227#event-891914258
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 13, 2016https://github.com/nodejs/node/pull/10227#event-891914317
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
December 13, 2016 12:18https://github.com/nodejs/node/pull/10227#event-891914318
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Dec 13, 2016https://github.com/nodejs/node/pull/10227#event-891914364
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Dec 13, 2016https://github.com/nodejs/node/pull/10227#issuecomment-266724474
524f693https://github.com/nodejs/node/commit/524f693872cf453af2655ec47356d25d52394e3d
Please reload this pagehttps://github.com/nodejs/node/pull/10227
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
524f693https://github.com/nodejs/node/commit/524f693872cf453af2655ec47356d25d52394e3d
Dec 13, 2016https://github.com/nodejs/node/pull/10227#event-891915385
Fishrock123https://github.com/Fishrock123
Dec 13, 2016 https://github.com/nodejs/node/pull/10227#ref-commit-ec2f13f
https://github.com/bnoordhuis
https://github.com/Fishrock123
src: don't overwrite non-writable vm globalshttps://github.com/nodejs/node/commit/ec2f13fe66c5b65a5b028ea1833dd2091ca90963
ec2f13fhttps://github.com/nodejs/node/commit/ec2f13fe66c5b65a5b028ea1833dd2091ca90963
#10223https://github.com/nodejs/node/issues/10223
#10227https://github.com/nodejs/node/pull/10227
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Dec 15, 2016 https://github.com/nodejs/node/pull/10227#ref-pullrequest-195698085
v7.3.0 proposal #10277 https://github.com/nodejs/node/pull/10277
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 28, 2016 https://github.com/nodejs/node/pull/10227#ref-issue-197875229
Regression in Jest with jsdom #10492 https://github.com/nodejs/node/issues/10492
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 28, 2016https://github.com/nodejs/node/pull/10227#issuecomment-269505554
#10492https://github.com/nodejs/node/issues/10492
Please reload this pagehttps://github.com/nodejs/node/pull/10227
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 28, 2016 https://github.com/nodejs/node/pull/10227#ref-pullrequest-197765735
[WIP] Fix Console Logging in jsdom Env jestjs/jest#2457 https://github.com/jestjs/jest/pull/2457
https://github.com/cpojer
cpojerhttps://github.com/cpojer
Dec 29, 2016https://github.com/nodejs/node/pull/10227#issuecomment-269569052
jestjs/jest#2457 (comment)https://github.com/jestjs/jest/pull/2457#issuecomment-269527981
@thealphanerdhttps://github.com/thealphanerd
Please reload this pagehttps://github.com/nodejs/node/pull/10227
addaleaxhttps://github.com/addaleax
Jan 20, 2017 https://github.com/nodejs/node/pull/10227#ref-commit-179ea5e
https://github.com/addaleax
Revert "src: don't overwrite non-writable vm globals"https://github.com/addaleax/node/commit/179ea5e4a24d481230f740b9e19b72c0ab40e6ca
179ea5ehttps://github.com/addaleax/node/commit/179ea5e4a24d481230f740b9e19b72c0ab40e6ca
524f693https://github.com/addaleax/node/commit/524f693872cf453af2655ec47356d25d52394e3d
nodejs#10806https://github.com/nodejs/node/issues/10806
nodejs#10492https://github.com/nodejs/node/issues/10492
nodejs#10227https://github.com/nodejs/node/pull/10227
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Jan 22, 2017https://github.com/nodejs/node/pull/10227#event-932148718
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 22, 2017https://github.com/nodejs/node/pull/10227#issuecomment-274368779
Please reload this pagehttps://github.com/nodejs/node/pull/10227
addaleaxhttps://github.com/addaleax
Jan 25, 2017 https://github.com/nodejs/node/pull/10227#ref-commit-3e851cf
https://github.com/addaleax
Revert "src: don't overwrite non-writable vm globals"https://github.com/nodejs/node/commit/3e851cf18b06c50df79f2ecc4dce0ec7379c2f41
3e851cfhttps://github.com/nodejs/node/commit/3e851cf18b06c50df79f2ecc4dce0ec7379c2f41
524f693https://github.com/nodejs/node/commit/524f693872cf453af2655ec47356d25d52394e3d
#10806https://github.com/nodejs/node/issues/10806
#10492https://github.com/nodejs/node/issues/10492
#10227https://github.com/nodejs/node/pull/10227
#10920https://github.com/nodejs/node/pull/10920
targoshttps://github.com/targos
Jan 28, 2017 https://github.com/nodejs/node/pull/10227#ref-commit-69d1de1
https://github.com/addaleax
https://github.com/targos
Revert "src: don't overwrite non-writable vm globals"https://github.com/nodejs/node/commit/69d1de1abd8768b8744dd42bd9f8da1b6982d083
69d1de1https://github.com/nodejs/node/commit/69d1de1abd8768b8744dd42bd9f8da1b6982d083
524f693https://github.com/nodejs/node/commit/524f693872cf453af2655ec47356d25d52394e3d
#10806https://github.com/nodejs/node/issues/10806
#10492https://github.com/nodejs/node/issues/10492
#10227https://github.com/nodejs/node/pull/10227
#10920https://github.com/nodejs/node/pull/10920
italoacasashttps://github.com/italoacasas
Jan 30, 2017 https://github.com/nodejs/node/pull/10227#ref-commit-8a6367c
https://github.com/addaleax
Revert "src: don't overwrite non-writable vm globals"https://github.com/italoacasas/node/commit/8a6367cb206381e180d920966b524b6f734c650f
8a6367chttps://github.com/italoacasas/node/commit/8a6367cb206381e180d920966b524b6f734c650f
524f693https://github.com/italoacasas/node/commit/524f693872cf453af2655ec47356d25d52394e3d
nodejs#10806https://github.com/nodejs/node/issues/10806
nodejs#10492https://github.com/nodejs/node/issues/10492
nodejs#10227https://github.com/nodejs/node/pull/10227
nodejs#10920https://github.com/nodejs/node/pull/10920
italoacasashttps://github.com/italoacasas
Jan 30, 2017 https://github.com/nodejs/node/pull/10227#ref-commit-7ff3078
https://github.com/addaleax
Revert "src: don't overwrite non-writable vm globals"https://github.com/italoacasas/node/commit/7ff307830999ad8d547951a67c701132fe1a9988
7ff3078https://github.com/italoacasas/node/commit/7ff307830999ad8d547951a67c701132fe1a9988
524f693https://github.com/italoacasas/node/commit/524f693872cf453af2655ec47356d25d52394e3d
nodejs#10806https://github.com/nodejs/node/issues/10806
nodejs#10492https://github.com/nodejs/node/issues/10492
nodejs#10227https://github.com/nodejs/node/pull/10227
nodejs#10920https://github.com/nodejs/node/pull/10920
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Feb 1, 2017https://github.com/nodejs/node/pull/10227#issuecomment-276731984
@bnoordhuishttps://github.com/bnoordhuis
testhttps://github.com/nodejs/node/blob/master/test/parallel/test-vm-strict-mode.js
Please reload this pagehttps://github.com/nodejs/node/pull/10227
fhinkelhttps://github.com/fhinkel
Feb 3, 2017 https://github.com/nodejs/node/pull/10227#ref-commit-c081b5b
https://github.com/fhinkel
src: don't overwrite non-writable vm globalshttps://github.com/fhinkel/node/commit/c081b5b92cb78fdbc2c0ccd632e876f965952d6e
c081b5bhttps://github.com/fhinkel/node/commit/c081b5b92cb78fdbc2c0ccd632e876f965952d6e
nodejs#10223https://github.com/nodejs/node/issues/10223
nodejs#10227https://github.com/nodejs/node/pull/10227
fhinkelhttps://github.com/fhinkel
Feb 4, 2017 https://github.com/nodejs/node/pull/10227#ref-commit-e116cbe
https://github.com/fhinkel
src: don't overwrite non-writable vm globalshttps://github.com/nodejs/node/commit/e116cbe3207a471b3d604466baad49b141e32230
e116cbehttps://github.com/nodejs/node/commit/e116cbe3207a471b3d604466baad49b141e32230
#10223https://github.com/nodejs/node/issues/10223
#10227https://github.com/nodejs/node/pull/10227
#11109https://github.com/nodejs/node/pull/11109
italoacasashttps://github.com/italoacasas
Feb 5, 2017 https://github.com/nodejs/node/pull/10227#ref-commit-315d59f
https://github.com/fhinkel
src: don't overwrite non-writable vm globalshttps://github.com/italoacasas/node/commit/315d59fb1bb7b131194d088641baf44929d610e5
315d59fhttps://github.com/italoacasas/node/commit/315d59fb1bb7b131194d088641baf44929d610e5
nodejs#10223https://github.com/nodejs/node/issues/10223
nodejs#10227https://github.com/nodejs/node/pull/10227
nodejs#11109https://github.com/nodejs/node/pull/11109
italoacasashttps://github.com/italoacasas
Feb 14, 2017 https://github.com/nodejs/node/pull/10227#ref-commit-d8a5e1c
https://github.com/fhinkel
src: don't overwrite non-writable vm globalshttps://github.com/italoacasas/node/commit/d8a5e1c37ffc2aae67ec76db0bc895ff6975d32e
d8a5e1chttps://github.com/italoacasas/node/commit/d8a5e1c37ffc2aae67ec76db0bc895ff6975d32e
nodejs#10223https://github.com/nodejs/node/issues/10223
nodejs#10227https://github.com/nodejs/node/pull/10227
nodejs#11109https://github.com/nodejs/node/pull/11109
krydoshttps://github.com/krydos
Feb 25, 2017 https://github.com/nodejs/node/pull/10227#ref-commit-86da421
https://github.com/fhinkel
https://github.com/krydos
src: don't overwrite non-writable vm globalshttps://github.com/krydos/node/commit/86da421f253cbc369c08c36f3d3cf0aa12b61624
86da421https://github.com/krydos/node/commit/86da421f253cbc369c08c36f3d3cf0aa12b61624
nodejs#10223https://github.com/nodejs/node/issues/10223
nodejs#10227https://github.com/nodejs/node/pull/10227
nodejs#11109https://github.com/nodejs/node/pull/11109
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 24, 2023 https://github.com/nodejs/node/pull/10227#ref-pullrequest-1681672995
[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#97 https://github.com/aliscco/alisco-node/pull/97
https://github.com/aliscco
alisccohttps://github.com/aliscco
Apr 24, 2023 https://github.com/nodejs/node/pull/10227#ref-pullrequest-1681913629
[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#109 https://github.com/aliscco/alisco-node/pull/109
[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#122 https://github.com/aliscco/alisco-node/pull/122
[Snyk] Fix for 17 vulnerabilities aliscco/alisco-node#127 https://github.com/aliscco/alisco-node/pull/127
https://github.com/aliscco
alisccohttps://github.com/aliscco
Apr 24, 2023 https://github.com/nodejs/node/pull/10227#ref-pullrequest-1682200942
[Snyk] Fix for 19 vulnerabilities aliscco/alisco-node#128 https://github.com/aliscco/alisco-node/pull/128
[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#177 https://github.com/aliscco/alisco-node/pull/177
[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#182 https://github.com/aliscco/alisco-node/pull/182
[Snyk] Fix for 8 vulnerabilities aliscco/alisco-node#183 https://github.com/aliscco/alisco-node/pull/183
https://github.com/aliscco
alisccohttps://github.com/aliscco
Apr 26, 2023 https://github.com/nodejs/node/pull/10227#ref-pullrequest-1684099185
[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#195 https://github.com/aliscco/alisco-node/pull/195
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 26, 2023 https://github.com/nodejs/node/pull/10227#ref-pullrequest-1685888561
[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#249 https://github.com/aliscco/alisco-node/pull/249
https://github.com/aliscco
alisccohttps://github.com/aliscco
Apr 28, 2023 https://github.com/nodejs/node/pull/10227#ref-pullrequest-1687810686
[Snyk] Fix for 10 vulnerabilities aliscco/alisco-node#309 https://github.com/aliscco/alisco-node/pull/309
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 28, 2023 https://github.com/nodejs/node/pull/10227#ref-pullrequest-1688989848
[Snyk] Security upgrade eslint from 4.19.1 to 5.0.0 aliscco/alisco-node#336 https://github.com/aliscco/alisco-node/pull/336
https://github.com/aliscco
alisccohttps://github.com/aliscco
Apr 29, 2023 https://github.com/nodejs/node/pull/10227#ref-pullrequest-1689331202
[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#356 https://github.com/aliscco/alisco-node/pull/356
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10227
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/10227/files/bb7620a0b46ce671ef440c1a92907c5ce3c05d8d
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/10227/files/bb7620a0b46ce671ef440c1a92907c5ce3c05d8d
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Please reload this pagehttps://github.com/nodejs/node/pull/10227
https://github.com/bnoordhuis
https://github.com/fhinkel
https://github.com/MylesBorins
https://github.com/cpojer
https://github.com/benjamingr
https://github.com/mscdex
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.