René's URL Explorer Experiment


Title: [async_wrap] backport of gc abort on destroy() fix on v6.x by trevnorris · Pull Request #10096 · nodejs/node · GitHub

Open Graph Title: [async_wrap] backport of gc abort on destroy() fix on v6.x by trevnorris · Pull Request #10096 · nodejs/node

X Title: [async_wrap] backport of gc abort on destroy() fix on v6.x by trevnorris · Pull Request #10096 · nodejs/node

Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) async_wrap Description of change This is a backport o...

Open Graph Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) async_wrap Description of change This is a backport o...

X Description: Checklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) async_wrap Description of change This is a backport o...

Opengraph URL: https://github.com/nodejs/node/pull/10096

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:31c9bf9a-f1ae-c793-3f10-57d9cae5571d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id87B6:3410DA:1CE35F2:259210C:696B3C9F
html-safe-nonce377c84cd842951abea6d3b0d00f4238b171cb724128ad445549a81d574eded85
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0I2OjM0MTBEQToxQ0UzNUYyOjI1OTIxMEM6Njk2QjNDOUYiLCJ2aXNpdG9yX2lkIjoiMTQ5MjE0MzAxODQ2MDUyNzc3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac347ffc22c12c09f9da55879d075ed09b00c753d41d7df663b83df6d21940bd75
hovercard-subject-tagpull_request:96360964
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10096/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/703a2ffcc0b6b5994ab1418564c1e205045b6799826996918126895788b2d91d/nodejs/node/pull/10096
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/703a2ffcc0b6b5994ab1418564c1e205045b6799826996918126895788b2d91d/nodejs/node/pull/10096
og:image:altChecklist make -j8 test (UNIX), or vcbuild test nosign (Windows) passes commit message follows commit guidelines Affected core subsystem(s) async_wrap Description of change This is a backport o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrevnorris
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/10096#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10096
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10096
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/10096
Reloadhttps://github.com/nodejs/node/pull/10096
Reloadhttps://github.com/nodejs/node/pull/10096
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/10096
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/10096
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/10096#issue-comment-box
trevnorrishttps://github.com/trevnorris
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
trevnorris:destroy-gc-backport-v6https://github.com/trevnorris/node/tree/destroy-gc-backport-v6
[async_wrap] backport of gc abort on destroy() fix on v6.x https://github.com/nodejs/node/pull/10096#top
trevnorrishttps://github.com/trevnorris
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
trevnorris:destroy-gc-backport-v6https://github.com/trevnorris/node/tree/destroy-gc-backport-v6
Conversation 9 https://github.com/nodejs/node/pull/10096
Commits 3 https://github.com/nodejs/node/pull/10096/commits
Checks 0 https://github.com/nodejs/node/pull/10096/checks
Files changed https://github.com/nodejs/node/pull/10096/files
Please reload this pagehttps://github.com/nodejs/node/pull/10096
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Dec 2, 2016https://github.com/nodejs/node/pull/10096#issue-193228846
517e3a6https://github.com/nodejs/node/commit/517e3a642552679c855595baeff46ff81720fae4
cf5f4b8https://github.com/nodejs/node/commit/cf5f4b85f5ef7befa592d83b69be646f7efb236a
b49b496https://github.com/nodejs/node/commit/b49b496a92118bf786176bc3c763a292b9bdff5d
Please reload this pagehttps://github.com/nodejs/node/pull/10096
trevnorrishttps://github.com/trevnorris
December 2, 2016 14:58https://github.com/nodejs/node/pull/10096#commits-pushed-256534c
https://github.com/trevnorris
async_wrap: mode constructor/destructor to .cchttps://github.com/nodejs/node/pull/10096/commits/256534c3c25f6ab992e46d1c96c7e392384611d9
256534chttps://github.com/nodejs/node/pull/10096/commits/256534c3c25f6ab992e46d1c96c7e392384611d9
https://github.com/trevnorris
async_wrap: make Initialize a static class memberhttps://github.com/nodejs/node/pull/10096/commits/b420cb020df04e39e978ba86724904596606d20d
b420cb0https://github.com/nodejs/node/pull/10096/commits/b420cb020df04e39e978ba86724904596606d20d
https://github.com/trevnorris
async_wrap: call destroy() callback in uv_idle_thttps://github.com/nodejs/node/pull/10096/commits/340aee7354c475c5e841708e3cc76f3f9adc4b48
340aee7https://github.com/nodejs/node/pull/10096/commits/340aee7354c475c5e841708e3cc76f3f9adc4b48
nodejs#8216https://github.com/nodejs/node/issues/8216
nodejs#9465https://github.com/nodejs/node/issues/9465
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
async_wrap https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_wrap
Dec 2, 2016https://github.com/nodejs/node/pull/10096#event-880645164
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x
Dec 2, 2016https://github.com/nodejs/node/pull/10096#event-880645235
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
Dec 2, 2016https://github.com/nodejs/node/pull/10096#event-880646702
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 2, 2016https://github.com/nodejs/node/pull/10096#issuecomment-264575081
Please reload this pagehttps://github.com/nodejs/node/pull/10096
https://ci.nodejs.org/job/node-test-pull-request/5126/https://ci.nodejs.org/job/node-test-pull-request/5126/
Please reload this pagehttps://github.com/nodejs/node/pull/10096
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 2, 2016https://github.com/nodejs/node/pull/10096#event-880652575
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 2, 2016https://github.com/nodejs/node/pull/10096#issuecomment-264576170
Please reload this pagehttps://github.com/nodejs/node/pull/10096
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 2, 2016https://github.com/nodejs/node/pull/10096#issuecomment-264576849
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/10096
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Dec 2, 2016https://github.com/nodejs/node/pull/10096#issuecomment-264579704
@addaleaxhttps://github.com/addaleax
#10097https://github.com/nodejs/node/pull/10097
Please reload this pagehttps://github.com/nodejs/node/pull/10096
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 2, 2016https://github.com/nodejs/node/pull/10096#event-880722170
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 5, 2016https://github.com/nodejs/node/pull/10096#issuecomment-264955130
https://ci.nodejs.org/job/node-test-commit-smartos/5478/nodes=smartos15-64/tapTestReport/https://ci.nodejs.org/job/node-test-commit-smartos/5478/nodes=smartos15-64/tapTestReport/
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/10096
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 5, 2016https://github.com/nodejs/node/pull/10096#issuecomment-264969594
https://ci.nodejs.org/job/node-test-commit/6438/https://ci.nodejs.org/job/node-test-commit/6438/
Please reload this pagehttps://github.com/nodejs/node/pull/10096
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 6, 2016https://github.com/nodejs/node/pull/10096#issuecomment-265041123
Please reload this pagehttps://github.com/nodejs/node/pull/10096
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 6, 2016https://github.com/nodejs/node/pull/10096#issuecomment-265043004
Please reload this pagehttps://github.com/nodejs/node/pull/10096
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 6, 2016https://github.com/nodejs/node/pull/10096#event-883043575
MylesBorinshttps://github.com/MylesBorins
Dec 6, 2016 https://github.com/nodejs/node/pull/10096#ref-commit-9ed60d3
https://github.com/trevnorris
https://github.com/MylesBorins
async_wrap: mode constructor/destructor to .cchttps://github.com/nodejs/node/commit/9ed60d308cc99191ed47ae196d3ee4dd6cc1a942
9ed60d3https://github.com/nodejs/node/commit/9ed60d308cc99191ed47ae196d3ee4dd6cc1a942
#10096https://github.com/nodejs/node/pull/10096
MylesBorinshttps://github.com/MylesBorins
Dec 6, 2016 https://github.com/nodejs/node/pull/10096#ref-commit-3e5b2eb
https://github.com/trevnorris
https://github.com/MylesBorins
async_wrap: make Initialize a static class memberhttps://github.com/nodejs/node/commit/3e5b2eb49cbe042bf097fc41db9da7008d72392b
3e5b2ebhttps://github.com/nodejs/node/commit/3e5b2eb49cbe042bf097fc41db9da7008d72392b
#10096https://github.com/nodejs/node/pull/10096
MylesBorinshttps://github.com/MylesBorins
Dec 6, 2016 https://github.com/nodejs/node/pull/10096#ref-commit-f3b0cf5
https://github.com/trevnorris
https://github.com/MylesBorins
async_wrap: call destroy() callback in uv_idle_thttps://github.com/nodejs/node/commit/f3b0cf5052c43cbd3b2ab559b55d8f6a7a3db4bd
f3b0cf5https://github.com/nodejs/node/commit/f3b0cf5052c43cbd3b2ab559b55d8f6a7a3db4bd
#10096https://github.com/nodejs/node/pull/10096
#8216https://github.com/nodejs/node/issues/8216
#9465https://github.com/nodejs/node/issues/9465
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 6, 2016 https://github.com/nodejs/node/pull/10096#ref-pullrequest-190942302
v6.9.2 proposal #9735 https://github.com/nodejs/node/pull/9735
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Dec 21, 2016https://github.com/nodejs/node/pull/10096#issuecomment-268668924
@thealphanerdhttps://github.com/thealphanerd
#10400https://github.com/nodejs/node/pull/10400
Please reload this pagehttps://github.com/nodejs/node/pull/10096
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10096
https://github.com/MylesBorins
MylesBorins https://github.com/MylesBorins
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/10096
https://github.com/trevnorris
https://github.com/MylesBorins
https://github.com/addaleax
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.