| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:beecb9d9-b92b-c257-4eb1-ae1843beabd2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E1E4:E2AFA:1DFB:2472:69912F5A |
| html-safe-nonce | 5debaca74a82db28344fef9a7a878179a8e0c866352a698c6353d4f60cc81009 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUU0OkUyQUZBOjFERkI6MjQ3Mjo2OTkxMkY1QSIsInZpc2l0b3JfaWQiOiIzNzM5NDkxNzI5OTA2MTUxMjU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 612252db65e5cf147fe8bc0ec427ef98040a1003f7c97e33363ff456ffbcb58a |
| hovercard-subject-tag | pull_request:96140460 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/10052/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6c783fbd0298b3623918b3e14f6b183948ef3776936641463f431e116dbd748c/nodejs/node/pull/10052 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6c783fbd0298b3623918b3e14f6b183948ef3776936641463f431e116dbd748c/nodejs/node/pull/10052 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
project gitignore
Description of change
Obviously,... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sarahmeyer |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/10052#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10052 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10052 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/10052 |
| Reload | https://github.com/nodejs/node/pull/10052 |
| Reload | https://github.com/nodejs/node/pull/10052 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
710
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| sarahmeyer | https://github.com/sarahmeyer |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sarahmeyer:add-dsstore-to-gitignore | https://github.com/sarahmeyer/node/tree/add-dsstore-to-gitignore |
| Conversation | https://github.com/nodejs/node/pull/10052 |
| Commits1 (1) | https://github.com/nodejs/node/pull/10052/commits |
| Checks | https://github.com/nodejs/node/pull/10052/checks |
| Files changed | https://github.com/nodejs/node/pull/10052/files |
| gitignore: add osx .DS_STORE files | https://github.com/nodejs/node/pull/10052#top |
| sarahmeyer | https://github.com/sarahmeyer |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sarahmeyer:add-dsstore-to-gitignore | https://github.com/sarahmeyer/node/tree/add-dsstore-to-gitignore |
|
| https://github.com/sarahmeyer |
| sarahmeyer | https://github.com/sarahmeyer |
| Dec 1, 2016 | https://github.com/nodejs/node/pull/10052#issue-192920535 |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
|
| https://github.com/sarahmeyer |
| add osx .DS_STORE files to gitignore | https://github.com/nodejs/node/pull/10052/commits/dafbec00e32f3917673095865e44a04507b927c7 |
| dafbec0 | https://github.com/nodejs/node/pull/10052/commits/dafbec00e32f3917673095865e44a04507b927c7 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Dec 1, 2016 | https://github.com/nodejs/node/pull/10052#event-878878440 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
|
Dec 1, 2016
| https://github.com/nodejs/node/pull/10052#pullrequestreview-11022453 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/10052/files/dafbec00e32f3917673095865e44a04507b927c7 |
| https://github.com/kenany |
| kenany | https://github.com/kenany |
| Dec 1, 2016 | https://github.com/nodejs/node/pull/10052#issuecomment-264270719 |
| #159 | https://github.com/nodejs/node/pull/159 |
| #3357 | https://github.com/nodejs/node/pull/3357 |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 2, 2016 | https://github.com/nodejs/node/pull/10052#issuecomment-264375724 |
| #8016 | https://github.com/nodejs/node/pull/8016 |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
| Dec 2, 2016 | https://github.com/nodejs/node/pull/10052#issuecomment-264382609 |
| #8016 | https://github.com/nodejs/node/pull/8016 |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Dec 2, 2016 | https://github.com/nodejs/node/pull/10052#issuecomment-264411372 |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 2, 2016 | https://github.com/nodejs/node/pull/10052#issuecomment-264556909 |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Dec 3, 2016 | https://github.com/nodejs/node/pull/10052#issuecomment-264606226 |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
| @Fishrock123 | https://github.com/Fishrock123 |
| #8016 | https://github.com/nodejs/node/pull/8016 |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 3, 2016 | https://github.com/nodejs/node/pull/10052#issuecomment-264662356 |
| @gibfahn | https://github.com/gibfahn |
| @sarahmeyer | https://github.com/sarahmeyer |
| #8016 | https://github.com/nodejs/node/pull/8016 |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 3, 2016 | https://github.com/nodejs/node/pull/10052#event-881075898 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Dec 5, 2016
| https://github.com/nodejs/node/pull/10052#ref-commit-15cc7c0 |
|
| https://github.com/claudiorodriguez |
|
| https://github.com/Fishrock123 |
| meta: whitelist dotfiles in .gitignore | https://github.com/nodejs/node/commit/15cc7c0e1981ad46cfa86bde4b8bbd9393ead0cc |
| 15cc7c0 | https://github.com/nodejs/node/commit/15cc7c0e1981ad46cfa86bde4b8bbd9393ead0cc |
| #8010 | https://github.com/nodejs/node/pull/8010 |
| #9111 | https://github.com/nodejs/node/pull/9111 |
| #10052 | https://github.com/nodejs/node/pull/10052 |
| #8012 | https://github.com/nodejs/node/issues/8012 |
| #8016 | https://github.com/nodejs/node/pull/8016 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 5, 2016 | https://github.com/nodejs/node/pull/10052#issuecomment-264744856 |
| 15cc7c0 | https://github.com/nodejs/node/commit/15cc7c0e1981ad46cfa86bde4b8bbd9393ead0cc |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Dec 5, 2016 | https://github.com/nodejs/node/pull/10052#event-881424336 |
| addaleax | https://github.com/addaleax |
|
Dec 5, 2016
| https://github.com/nodejs/node/pull/10052#ref-commit-3253954 |
|
| https://github.com/claudiorodriguez |
|
| https://github.com/addaleax |
| meta: whitelist dotfiles in .gitignore | https://github.com/nodejs/node/commit/3253954e6226687c2c1eb5041ea6cf517ab288c9 |
| 3253954 | https://github.com/nodejs/node/commit/3253954e6226687c2c1eb5041ea6cf517ab288c9 |
| #8010 | https://github.com/nodejs/node/pull/8010 |
| #9111 | https://github.com/nodejs/node/pull/9111 |
| #10052 | https://github.com/nodejs/node/pull/10052 |
| #8012 | https://github.com/nodejs/node/issues/8012 |
| #8016 | https://github.com/nodejs/node/pull/8016 |
| jmdarling | https://github.com/jmdarling |
|
Dec 8, 2016
| https://github.com/nodejs/node/pull/10052#ref-commit-96ade1f |
|
| https://github.com/claudiorodriguez |
| meta: whitelist dotfiles in .gitignore | https://github.com/jmdarling/node/commit/96ade1ff3cce4f88ae176d8e7d29532a9b019792 |
| 96ade1f | https://github.com/jmdarling/node/commit/96ade1ff3cce4f88ae176d8e7d29532a9b019792 |
| nodejs#8010 | https://github.com/nodejs/node/pull/8010 |
| nodejs#9111 | https://github.com/nodejs/node/pull/9111 |
| nodejs#10052 | https://github.com/nodejs/node/pull/10052 |
| nodejs#8012 | https://github.com/nodejs/node/issues/8012 |
| nodejs#8016 | https://github.com/nodejs/node/pull/8016 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 20, 2016
| https://github.com/nodejs/node/pull/10052#ref-commit-65e134f |
|
| https://github.com/claudiorodriguez |
|
| https://github.com/MylesBorins |
| meta: whitelist dotfiles in .gitignore | https://github.com/nodejs/node/commit/65e134ff125f7d16817395ed95c13ed01aaa9a32 |
| 65e134f | https://github.com/nodejs/node/commit/65e134ff125f7d16817395ed95c13ed01aaa9a32 |
| #8010 | https://github.com/nodejs/node/pull/8010 |
| #9111 | https://github.com/nodejs/node/pull/9111 |
| #10052 | https://github.com/nodejs/node/pull/10052 |
| #8012 | https://github.com/nodejs/node/issues/8012 |
| #8016 | https://github.com/nodejs/node/pull/8016 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 20, 2016
| https://github.com/nodejs/node/pull/10052#ref-commit-0be56cd |
|
| https://github.com/claudiorodriguez |
|
| https://github.com/MylesBorins |
| meta: whitelist dotfiles in .gitignore | https://github.com/nodejs/node/commit/0be56cd1e9f8383f165036f0caac1363350ad522 |
| 0be56cd | https://github.com/nodejs/node/commit/0be56cd1e9f8383f165036f0caac1363350ad522 |
| #8010 | https://github.com/nodejs/node/pull/8010 |
| #9111 | https://github.com/nodejs/node/pull/9111 |
| #10052 | https://github.com/nodejs/node/pull/10052 |
| #8012 | https://github.com/nodejs/node/issues/8012 |
| #8016 | https://github.com/nodejs/node/pull/8016 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/10052#ref-commit-dc2e8a7 |
|
| https://github.com/claudiorodriguez |
|
| https://github.com/MylesBorins |
| meta: whitelist dotfiles in .gitignore | https://github.com/nodejs/node/commit/dc2e8a7bc3e540e27d0dcd20e86431c30a373790 |
| dc2e8a7 | https://github.com/nodejs/node/commit/dc2e8a7bc3e540e27d0dcd20e86431c30a373790 |
| #8010 | https://github.com/nodejs/node/pull/8010 |
| #9111 | https://github.com/nodejs/node/pull/9111 |
| #10052 | https://github.com/nodejs/node/pull/10052 |
| #8012 | https://github.com/nodejs/node/issues/8012 |
| #8016 | https://github.com/nodejs/node/pull/8016 |
| MylesBorins | https://github.com/MylesBorins |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/10052#ref-commit-b0cbc76 |
|
| https://github.com/claudiorodriguez |
|
| https://github.com/MylesBorins |
| meta: whitelist dotfiles in .gitignore | https://github.com/nodejs/node/commit/b0cbc7653ac6a98ddea7190402b107aa7668ed50 |
| b0cbc76 | https://github.com/nodejs/node/commit/b0cbc7653ac6a98ddea7190402b107aa7668ed50 |
| #8010 | https://github.com/nodejs/node/pull/8010 |
| #9111 | https://github.com/nodejs/node/pull/9111 |
| #10052 | https://github.com/nodejs/node/pull/10052 |
| #8012 | https://github.com/nodejs/node/issues/8012 |
| #8016 | https://github.com/nodejs/node/pull/8016 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 12, 2018
| https://github.com/nodejs/node/pull/10052#ref-pullrequest-369651063 |
|
build: add .DS_store to .gitgnore
#23554
| https://github.com/nodejs/node/pull/23554 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F10052 |
|
| https://github.com/imyller |
|
imyller
| https://github.com/imyller |
|
| https://github.com/nodejs/node/pull/10052/files/dafbec00e32f3917673095865e44a04507b927c7 |
|
| https://github.com/Fishrock123 |
|
Fishrock123
| https://github.com/Fishrock123 |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Please reload this page | https://github.com/nodejs/node/pull/10052 |
|
| https://github.com/sarahmeyer |
|
| https://github.com/kenany |
|
| https://github.com/Trott |
|
| https://github.com/imyller |
|
| https://github.com/bnoordhuis |
|
| https://github.com/Fishrock123 |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |