René's URL Explorer Experiment


Title: Readable with construct() and highWaterMark: 0 hangs in toArray() and for await · Issue #67668 · nodejs/node · GitHub

Open Graph Title: Readable with construct() and highWaterMark: 0 hangs in toArray() and for await · Issue #67668 · nodejs/node

X Title: Readable with construct() and highWaterMark: 0 hangs in toArray() and for await · Issue #67668 · nodejs/node

Description: Version v24.22.0, also on main (e8c279d) Platform Darwin 27.2.0 arm64 Subsystem stream What steps will reproduce the bug? 'use strict'; const { Readable } = require('node:stream'); const chunks = ['a', 'b']; const stream = new Readable({...

Open Graph Description: Version v24.22.0, also on main (e8c279d) Platform Darwin 27.2.0 arm64 Subsystem stream What steps will reproduce the bug? 'use strict'; const { Readable } = require('node:stream'); const chunks = [...

X Description: Version v24.22.0, also on main (e8c279d) Platform Darwin 27.2.0 arm64 Subsystem stream What steps will reproduce the bug? 'use strict'; const { Readable } = require('node:stream'); ...

Opengraph URL: https://github.com/nodejs/node/issues/67668

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Readable with construct() and highWaterMark: 0 hangs in toArray() and for await","articleBody":"### Version\n\nv24.22.0, also on main (e8c279d731f)\n\n### Platform\n\n```text\nDarwin 27.2.0 arm64\n```\n\n### Subsystem\n\nstream\n\n### What steps will reproduce the bug?\n\n```js\n'use strict';\nconst { Readable } = require('node:stream');\n\nconst chunks = ['a', 'b'];\nconst stream = new Readable({\n  highWaterMark: 0,\n  construct(callback) {\n    setImmediate(callback);\n  },\n  read() {\n    this.push(chunks.length ? chunks.shift() : null);\n  },\n});\n\nlet done = false;\nstream.toArray().then((data) => {\n  done = true;\n  console.log('done', data.map(String));\n});\nprocess.on('exit', () => {\n  if (!done) console.log('toArray() never resolved');\n});\n```\n\n### How often does it reproduce? Is there a required condition?\n\nAlways, when a `Readable` has `construct()` and `highWaterMark: 0`, and it is consumed with `read()` (`toArray()`, `for await`, a `'readable'` listener). Sync and async `construct()` both hang. Flowing mode (`'data'`) works.\n\n### What is the expected behavior? Why is that the expected behavior?\n\n`done [ 'a', 'b' ]`, the same as without `construct()`. With `highWaterMark: 1` it resolves too.\n\n### What do you see instead?\n\n`toArray() never resolved`. `_read()` is never called.\n\n### Additional information\n\nA `read()` during `construct()` is refused (https://github.com/nodejs/node/blob/e8c279d731f2c0eb6eaff03cd341fad469498107/lib/internal/streams/readable.js#L787) and leaves `needReadable` set. When construction finishes, `onConstructed` only calls `maybeReadMore()` (https://github.com/nodejs/node/blob/e8c279d731f2c0eb6eaff03cd341fad469498107/lib/internal/streams/readable.js#L338-L342), which does not read when `highWaterMark` is 0 and the stream is not flowing (https://github.com/nodejs/node/blob/e8c279d731f2c0eb6eaff03cd341fad469498107/lib/internal/streams/readable.js#L957-L959). Nothing calls `_read()` again.\n\n`fs.ReadStream` uses `construct()` too, so `fs.createReadStream(file, { highWaterMark: 0 }).toArray()` hangs for the same reason.\n\nI found this while looking into #67667. I have a fix ready and will open a PR.\n","author":{"url":"https://github.com/hamzakargin","@type":"Person","name":"hamzakargin"},"datePublished":"2026-11-21T07:01:41Z","url":"https://github.com/nodejs/node/issues/67668"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:146ea920-8c18-9781-9e58-d63e70b82354
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD89E:1C94F:22AD12A:2C735BA:6B01C683
html-safe-nonce16fb3a360c4c709bb9fb092a15c04eedc16fe5f6a63782c1fc03a07a13b5ce77
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODlFOjFDOTRGOjIyQUQxMkE6MkM3MzVCQTo2QjAxQzY4MyIsInZpc2l0b3JfaWQiOiI0MjM4NTM3NDc0ODM5NzkxMjM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfa16e23754b8e67981c6159dfb91c357fc0300841a3ec60bb77dae0abf6087de
hovercard-subject-tagissue:6525774216
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/67668/issue_layout
twitter:imagehttps://opengraph.githubassets.com/00364b51bee7b8e4608f5262d3d5fff930c743ed0b79ff5f40216037d89c775d/nodejs/node/issues/67668
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/00364b51bee7b8e4608f5262d3d5fff930c743ed0b79ff5f40216037d89c775d/nodejs/node/issues/67668
og:image:altVersion v24.22.0, also on main (e8c279d) Platform Darwin 27.2.0 arm64 Subsystem stream What steps will reproduce the bug? 'use strict'; const { Readable } = require('node:stream'); const chunks = [...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehamzakargin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/67668#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F67668
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F67668
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/67668
Reloadhttps://github.com/nodejs/node/issues/67668
Reloadhttps://github.com/nodejs/node/issues/67668
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67668
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67668
#67670https://github.com/nodejs/node/pull/67670
Readable with construct() and highWaterMark: 0 hangs in toArray() and for awaithttps://github.com/nodejs/node/issues/67668#top
#67670https://github.com/nodejs/node/pull/67670
https://github.com/hamzakargin
hamzakarginhttps://github.com/hamzakargin
on Nov 21, 2026https://github.com/nodejs/node/issues/67668#issue-6525774216
e8c279dhttps://github.com/nodejs/node/commit/e8c279d731f2c0eb6eaff03cd341fad469498107
node/lib/internal/streams/readable.jshttps://github.com/nodejs/node/blob/e8c279d731f2c0eb6eaff03cd341fad469498107/lib/internal/streams/readable.js#L787
e8c279dhttps://github.com/nodejs/node/commit/e8c279d731f2c0eb6eaff03cd341fad469498107
node/lib/internal/streams/readable.jshttps://github.com/nodejs/node/blob/e8c279d731f2c0eb6eaff03cd341fad469498107/lib/internal/streams/readable.js#L338-L342
e8c279dhttps://github.com/nodejs/node/commit/e8c279d731f2c0eb6eaff03cd341fad469498107
node/lib/internal/streams/readable.jshttps://github.com/nodejs/node/blob/e8c279d731f2c0eb6eaff03cd341fad469498107/lib/internal/streams/readable.js#L957-L959
e8c279dhttps://github.com/nodejs/node/commit/e8c279d731f2c0eb6eaff03cd341fad469498107
#67667https://github.com/nodejs/node/issues/67667
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/67668
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67668
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.