René's URL Explorer Experiment


Title: fs.createReadStream() with highWaterMark: 0 ends without reading any data · Issue #67667 · nodejs/node · GitHub

Open Graph Title: fs.createReadStream() with highWaterMark: 0 ends without reading any data · Issue #67667 · nodejs/node

X Title: fs.createReadStream() with highWaterMark: 0 ends without reading any data · Issue #67667 · nodejs/node

Description: Version v24.22.0, also on main (e8c279d) Platform Darwin 27.2.0 arm64 Subsystem fs What steps will reproduce the bug? 'use strict'; const fs = require('node:fs'); const chunks = []; fs.createReadStream(__filename, { highWaterMark: 0 }) ....

Open Graph Description: Version v24.22.0, also on main (e8c279d) Platform Darwin 27.2.0 arm64 Subsystem fs What steps will reproduce the bug? 'use strict'; const fs = require('node:fs'); const chunks = []; fs.createReadSt...

X Description: Version v24.22.0, also on main (e8c279d) Platform Darwin 27.2.0 arm64 Subsystem fs What steps will reproduce the bug? 'use strict'; const fs = require('node:fs'); const chunks = [];...

Opengraph URL: https://github.com/nodejs/node/issues/67667

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"fs.createReadStream() with highWaterMark: 0 ends without reading any data","articleBody":"### Version\n\nv24.22.0, also on main (e8c279d731f)\n\n### Platform\n\n```text\nDarwin 27.2.0 arm64\n```\n\n### Subsystem\n\nfs\n\n### What steps will reproduce the bug?\n\n```js\n'use strict';\nconst fs = require('node:fs');\n\nconst chunks = [];\nfs.createReadStream(__filename, { highWaterMark: 0 })\n  .on('data', (chunk) => chunks.push(chunk))\n  .on('end', () => {\n    console.log('read', Buffer.concat(chunks).length, 'of', fs.statSync(__filename).size, 'bytes');\n  });\n```\n\n### How often does it reproduce? Is there a required condition?\n\nAlways, when the stream's `highWaterMark` is 0. On main this also happens for every `fs.ReadStream` after `stream.setDefaultHighWaterMark(false, 0)`, since #66956.\n\n### What is the expected behavior? Why is that the expected behavior?\n\n`read 291 of 291 bytes`. `highWaterMark: 0` means \"do not buffer ahead\", not \"read nothing\". A plain `Readable` with `highWaterMark: 0` still delivers all its data.\n\n### What do you see instead?\n\n`read 0 of 291 bytes`. The stream emits `'end'` without any `'data'`.\n\n### Additional information\n\n`ReadStream.prototype._read(n)` gets `n = highWaterMark = 0`, clamps it with `MathMin(end - pos + 1, n)`, and then `if (n \u003c= 0) this.push(null)` ends the stream: https://github.com/nodejs/node/blob/e8c279d731f2c0eb6eaff03cd341fad469498107/lib/internal/fs/streams.js#L277-L285\n\nThis came up in the review of #66956 (thanks @mertcanaltin). I have a fix ready and will open a PR.\n","author":{"url":"https://github.com/hamzakargin","@type":"Person","name":"hamzakargin"},"datePublished":"2026-11-21T07:01:03Z","url":"https://github.com/nodejs/node/issues/67667"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2025f22a-2679-ce9c-5c0e-0b140edb8ca9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE526:187C1E:C05B20:FE9528:6B01C49B
html-safe-noncebf1578e0ba361e003d15b19e41d9f826c8eb90ef93a962c99dea99c515052e6d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTI2OjE4N0MxRTpDMDVCMjA6RkU5NTI4OjZCMDFDNDlCIiwidmlzaXRvcl9pZCI6Ijg1NTg5OTE3NDY3MjQzODE4NTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9f0617780bb7f50b0248c15c3e28eb2212fd1c2287495ac2dc3a5ea4fd16d6d4
hovercard-subject-tagissue:6525768258
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/67667/issue_layout
twitter:imagehttps://opengraph.githubassets.com/886b0d5ca7247f023bcde52a45f9bb70a7af49feaf8b1475f15dff020be3c599/nodejs/node/issues/67667
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/886b0d5ca7247f023bcde52a45f9bb70a7af49feaf8b1475f15dff020be3c599/nodejs/node/issues/67667
og:image:altVersion v24.22.0, also on main (e8c279d) Platform Darwin 27.2.0 arm64 Subsystem fs What steps will reproduce the bug? 'use strict'; const fs = require('node:fs'); const chunks = []; fs.createReadSt...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehamzakargin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/67667#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F67667
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F67667
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/67667
Reloadhttps://github.com/nodejs/node/issues/67667
Reloadhttps://github.com/nodejs/node/issues/67667
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67667
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67667
#67669https://github.com/nodejs/node/pull/67669
fs.createReadStream() with highWaterMark: 0 ends without reading any datahttps://github.com/nodejs/node/issues/67667#top
#67669https://github.com/nodejs/node/pull/67669
https://github.com/hamzakargin
hamzakarginhttps://github.com/hamzakargin
on Nov 21, 2026https://github.com/nodejs/node/issues/67667#issue-6525768258
e8c279dhttps://github.com/nodejs/node/commit/e8c279d731f2c0eb6eaff03cd341fad469498107
#66956https://github.com/nodejs/node/pull/66956
node/lib/internal/fs/streams.jshttps://github.com/nodejs/node/blob/e8c279d731f2c0eb6eaff03cd341fad469498107/lib/internal/fs/streams.js#L277-L285
e8c279dhttps://github.com/nodejs/node/commit/e8c279d731f2c0eb6eaff03cd341fad469498107
#66956https://github.com/nodejs/node/pull/66956
@mertcanaltinhttps://github.com/mertcanaltin
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/67667
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67667
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.