René's URL Explorer Experiment


Title: Temporal on v26.x: until() and round() add one smallestUnit to a whole number of years, months or weeks (temporal_rs 0.2.3) · Issue #67457 · nodejs/node · GitHub

Open Graph Title: Temporal on v26.x: until() and round() add one smallestUnit to a whole number of years, months or weeks (temporal_rs 0.2.3) · Issue #67457 · nodejs/node

X Title: Temporal on v26.x: until() and round() add one smallestUnit to a whole number of years, months or weeks (temporal_rs 0.2.3) · Issue #67457 · nodejs/node

Description: Version v26.13.1 (V8 14.6.202.34-node.40). Also v26.12.1 and v26.13.0. Platform Darwin 27.0.0 arm64 Subsystem temporal, deps/crates (temporal_rs) What steps will reproduce the bug? const start = Temporal.PlainDate.from("2000-01-01"); con...

Open Graph Description: Version v26.13.1 (V8 14.6.202.34-node.40). Also v26.12.1 and v26.13.0. Platform Darwin 27.0.0 arm64 Subsystem temporal, deps/crates (temporal_rs) What steps will reproduce the bug? const start = Te...

X Description: Version v26.13.1 (V8 14.6.202.34-node.40). Also v26.12.1 and v26.13.0. Platform Darwin 27.0.0 arm64 Subsystem temporal, deps/crates (temporal_rs) What steps will reproduce the bug? const start = Te...

Opengraph URL: https://github.com/nodejs/node/issues/67457

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Temporal on v26.x: until() and round() add one smallestUnit to a whole number of years, months or weeks (temporal_rs 0.2.3)","articleBody":"### Version\n\nv26.13.1 (V8 14.6.202.34-node.40). Also v26.12.1 and v26.13.0.\n\n### Platform\n\n```text\nDarwin 27.0.0 arm64\n```\n\n### Subsystem\n\ntemporal, deps/crates (temporal_rs)\n\n### What steps will reproduce the bug?\n\n```js\nconst start = Temporal.PlainDate.from(\"2000-01-01\");\nconst opts = (roundingMode, smallestUnit = \"months\") => ({ largestUnit: \"years\", smallestUnit, roundingMode });\n\nconsole.log(start.until(\"2001-01-01\", opts(\"halfExpand\")).toString());\nconsole.log(start.until(\"2003-01-01\", opts(\"ceil\")).toString());\nconsole.log(start.until(\"2001-01-01\", opts(\"ceil\", \"weeks\")).toString());\nconsole.log(Temporal.Duration.from(\"P31D\").round({ largestUnit: \"months\", smallestUnit: \"weeks\", roundingMode: \"ceil\", relativeTo: \"2012-01-01\" }).toString());\nconsole.log(Temporal.Duration.from(\"P7D\").round({ largestUnit: \"weeks\", smallestUnit: \"days\", relativeTo: \"2024-11-01T00:00:00+00:00[UTC]\" }).toString());\n```\n\n### How often does it reproduce? Is there a required condition?\n\nEvery time the result is a whole number of a larger unit, so the smallest unit comes out as 0, `smallestUnit` is `months` or `weeks` (or `days` from a `ZonedDateTime`), and the rounding mode can round up (`ceil`, `expand` or one of the `half` modes). `trunc` and `floor` give the right result, and so does `smallestUnit: \"days\"` from a `PlainDate` or `PlainDateTime`. `PlainDateTime`, `ZonedDateTime` and `since` are affected in the same way, in every calendar.\n\n### What is the expected behavior? Why is that the expected behavior?\n\n```text\nP1Y\nP3Y\nP1Y\nP1M\nP1W\n```\n\nEach end is exactly one or three years, one month or one week after the start, so there is nothing left to round up. Chromium 153.0.8010.12 and WebKit 26.6 print these five lines.\n\n### What do you see instead?\n\n```text\nP1Y1M\nP3Y1M\nP1Y1W\nP1M1W\nP1W1D\n```\n\nEach result has one extra unit of `smallestUnit`.\n\n### Additional information\n\nThe cause is in temporal_rs 0.2.3, which `deps/crates/Cargo.toml` pins on v26.x. When it builds the rounding window, it checks only whether the smallest unit is 0, not whether the whole duration is 0, so the window starts at the origin instead of at the end of the whole years, months or weeks.\n\n- Spec: tc39/proposal-temporal#3316, fixed by tc39/proposal-temporal#3319.\n- test262: tc39/test262@a70493eb104948583a7928d50eac28b6c81114bf adds `exact-multiple-of-larger-unit*.js` for `Duration.prototype.round` and for `since` and `until` on `PlainDate`, `PlainDateTime`, `PlainYearMonth` and `ZonedDateTime`.\n- temporal_rs: boa-dev/temporal#723, first released in 0.2.4.\n\n`main` pins 0.2.6, which has the fix. Could v26.x move to temporal_rs 0.2.4 or later, the way #64543 brought it to 0.2.3, or take boa-dev/temporal#723 on its own? The change is in `compute_nudge_window` in `src/builtins/core/duration/normalized.rs`.\n\n_Edited 2026-11-13: narrowed \"How often\" to the cases that give a wrong result._\n","author":{"url":"https://github.com/craig-o-curtis","@type":"Person","name":"craig-o-curtis"},"datePublished":"2026-11-13T15:50:12Z","url":"https://github.com/nodejs/node/issues/67457"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1a3ecff8-6c48-b3ec-37c1-737891182917
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id96C2:1FAD:111BBB3:16B9707:6B033638
html-safe-nonce4d536daef7b5bc3a1a7daf4963547395d2c6e9a797f2b8155631ba93cafbfe3f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkMyOjFGQUQ6MTExQkJCMzoxNkI5NzA3OjZCMDMzNjM4IiwidmlzaXRvcl9pZCI6IjMwMTc1MzY3NDg1NjY4MjA0MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccfa4ce95eb51a0ca93fa9514ea1fb90213148075f3d3ce5e0274c51406012b47
hovercard-subject-tagissue:6374849757
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/67457/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7c134fb22c3045b334b8bf2d886e7cd398bc2d96acb3152375e7ea087ab8a004/nodejs/node/issues/67457
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7c134fb22c3045b334b8bf2d886e7cd398bc2d96acb3152375e7ea087ab8a004/nodejs/node/issues/67457
og:image:altVersion v26.13.1 (V8 14.6.202.34-node.40). Also v26.12.1 and v26.13.0. Platform Darwin 27.0.0 arm64 Subsystem temporal, deps/crates (temporal_rs) What steps will reproduce the bug? const start = Te...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecraig-o-curtis
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/67457#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F67457
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F67457
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/67457
Reloadhttps://github.com/nodejs/node/issues/67457
Reloadhttps://github.com/nodejs/node/issues/67457
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests669 (669)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67457
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67457
Temporal on v26.x: until() and round() add one smallestUnit to a whole number of years, months or weeks (temporal_rs 0.2.3)https://github.com/nodejs/node/issues/67457#top
v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v26.x%22
v8 engineIssues and PRs related to the V8 dependency.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
https://github.com/craig-o-curtis
craig-o-curtishttps://github.com/craig-o-curtis
on Nov 13, 2026https://github.com/nodejs/node/issues/67457#issue-6374849757
Shady results when rounding duration with smallestUnit/largestUnit tc39/proposal-temporal#3316https://github.com/tc39/proposal-temporal/issues/3316
Polyfill: Fix detection of bounding window start tc39/proposal-temporal#3319https://github.com/tc39/proposal-temporal/pull/3319
tc39/test262@a70493ehttps://github.com/tc39/test262/commit/a70493eb104948583a7928d50eac28b6c81114bf
Fix ComputeNudgeWindow startEpochNs computation to check full startDateDuration sign boa-dev/temporal#723https://github.com/boa-dev/temporal/pull/723
#64543https://github.com/nodejs/node/pull/64543
boa-dev/temporal#723https://github.com/boa-dev/temporal/pull/723
craig-o-curtishttps://github.com/craig-o-curtis
on Nov 13, 2026https://github.com/nodejs/node/issues/67457#event-36055313616
docs(upstream): record every upstream filing, and probe for tc39 #332…https://github.com/northguild/gmt/commit/0e4ad43522f05b37756abfd5827c542624287a82
0e4ad43https://github.com/northguild/gmt/commit/0e4ad43522f05b37756abfd5827c542624287a82
https://github.com/tanveer-arch
tanveer-archhttps://github.com/tanveer-arch
on Nov 14, 2026https://github.com/nodejs/node/issues/67457#issuecomment-6872737839
inoway46https://github.com/inoway46
v8 engineIssues and PRs related to the V8 dependency.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
on Nov 14, 2026https://github.com/nodejs/node/issues/67457#event-36108651739
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
on Nov 14, 2026https://github.com/nodejs/node/issues/67457#issuecomment-6884616255
Renegade334https://github.com/Renegade334
v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v26.x%22
on Nov 14, 2026https://github.com/nodejs/node/issues/67457#event-36153701870
craig-o-curtishttps://github.com/craig-o-curtis
on Nov 15, 2026https://github.com/nodejs/node/issues/67457#event-36188056254
fix(core): right years and complete ranges in formatted dates; add th…https://github.com/northguild/gmt/commit/ba5fe2b2cae8a700f5dff4c346e2568ddfd2cfa1
ba5fe2bhttps://github.com/northguild/gmt/commit/ba5fe2b2cae8a700f5dff4c346e2568ddfd2cfa1
Renegade334https://github.com/Renegade334
[v26.x] deps: update temporal_rs to 0.2.4 #67474https://github.com/nodejs/node/pull/67474
on Nov 16, 2026https://github.com/nodejs/node/issues/67457#event-36288051550
aduh95https://github.com/aduh95
on Nov 19, 2026https://github.com/nodejs/node/issues/67457#event-36664064005
deps: V8: cherry-pick third_party/rust update from cce7146a7a2ahttps://github.com/nodejs/node/commit/408a64d0723b8ebadbf3cf167d776d845a0be83f
408a64dhttps://github.com/nodejs/node/commit/408a64d0723b8ebadbf3cf167d776d845a0be83f
deps: update Rust crates for V8 14.6.202.34-node.40https://github.com/nodejs/node/commit/b4325270e562c463e02f0ac53015a710c96fdf74
b432527https://github.com/nodejs/node/commit/b4325270e562c463e02f0ac53015a710c96fdf74
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/67457
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67457
v26.xIssues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v26.x%22
v8 engineIssues and PRs related to the V8 dependency.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlmax-age=0, private, must-revalidate

Viewport: width=device-width


URLs of crawlers that visited me.