René's URL Explorer Experiment


Title: sqlite: should `Database` close its connection on garbage collection? · Issue #67427 · nodejs/node · GitHub

Open Graph Title: sqlite: should `Database` close its connection on garbage collection? · Issue #67427 · nodejs/node

X Title: sqlite: should `Database` close its connection on garbage collection? · Issue #67427 · nodejs/node

Description: Background If a Database is garbage-collected while still open, its destructor (Database::~Database() in src/node_sqlite.cc) finalizes outstanding statements, deletes sessions, and closes the connection without notice. fs.FileHandle used...

Open Graph Description: Background If a Database is garbage-collected while still open, its destructor (Database::~Database() in src/node_sqlite.cc) finalizes outstanding statements, deletes sessions, and closes the conne...

X Description: Background If a Database is garbage-collected while still open, its destructor (Database::~Database() in src/node_sqlite.cc) finalizes outstanding statements, deletes sessions, and closes the conne...

Opengraph URL: https://github.com/nodejs/node/issues/67427

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"sqlite: should `Database` close its connection on garbage collection?","articleBody":"### Background\n\nIf a `Database` is garbage-collected while still open, its destructor ([`Database::~Database()` in `src/node_sqlite.cc`](https://github.com/nodejs/node/blob/main/src/node_sqlite.cc)) finalizes outstanding statements, deletes sessions, and closes the connection without notice.\n\n`fs.FileHandle` used to behave the same way and moved away from it. Closing on GC was runtime-deprecated in v14 and became End-of-Life (it throws) in v25 ([DEP0137](https://nodejs.org/api/deprecations.html#DEP0137)). @BurningEnlightenment raised this in #57445 as something to settle before `node:sqlite` is stable, because tightening the behavior afterward would be semver-major.\n\n### Why it might matter for SQLite\n\n- Until it's collected, an unclosed connection keeps its file locks, and in WAL mode it may delay the checkpoint. That timing depends on GC, so other connections or processes can hit `SQLITE_BUSY` at unpredictable times.\n- A connection closed implicitly can hide bugs, such as a forgotten `close()` in a transaction path.\n\n### Prior art\n\n- [better-sqlite3](https://github.com/WiseLibs/better-sqlite3/blob/master/src/objects/database.cpp) does what we do today: its destructor finalizes statements and closes the connection without notice, and it closes any remaining connections when the addon unloads. Matching it eases migration, which is a frequent request (e.g. #67353).\n- SQLite's official WASM build ([`@sqlite.org/sqlite-wasm`](https://github.com/sqlite/sqlite-wasm)) never closes on GC. Its docs say GC \"will never trigger close()\", so an unclosed connection leaks.\n- `fs.FileHandle` went from closing on GC to throwing ([DEP0137](https://nodejs.org/api/deprecations.html#DEP0137)). Part of the reason was async operations racing a GC-driven close, which doesn't apply here: all `node:sqlite` operations are synchronous, so nothing can be in flight when the destructor runs.\n- `using` / `Symbol.dispose` already provide explicit cleanup.\n\n### Options\n\n1. Keep the current behavior and document it as guaranteed.\n2. Keep closing on GC, but emit a warning when it happens. This could be added later without being semver-major.\n3. Follow DEP0137: deprecate, then throw.\n\nWhich behavior do we want to commit to for the stable API?\n","author":{"url":"https://github.com/TrevorBurnham","@type":"Person","name":"TrevorBurnham"},"datePublished":"2026-11-12T02:15:17Z","url":"https://github.com/nodejs/node/issues/67427"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:fd8d21e5-fc13-126d-1b4b-cad3adefeaf3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBF6A:65478:2CE28C4:3B952D4:6B01C69B
html-safe-nonce5fea57b14bf51e8fa2f837aad53de866f598d30147829c7a65f0e307f946cad7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjZBOjY1NDc4OjJDRTI4QzQ6M0I5NTJENDo2QjAxQzY5QiIsInZpc2l0b3JfaWQiOiIxOTA2NzIxMzEyMzI4NTAwODkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8d2698ebd7adb968536e69272ea4449b3b43f3f9df091f5c799443a012eefe0c
hovercard-subject-tagissue:6341168764
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/67427/issue_layout
twitter:imagehttps://opengraph.githubassets.com/de83ba6ebc81f98500376710dd2e2342f873e021e0f87ac5eb408e368bebb7d6/nodejs/node/issues/67427
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/de83ba6ebc81f98500376710dd2e2342f873e021e0f87ac5eb408e368bebb7d6/nodejs/node/issues/67427
og:image:altBackground If a Database is garbage-collected while still open, its destructor (Database::~Database() in src/node_sqlite.cc) finalizes outstanding statements, deletes sessions, and closes the conne...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrevorBurnham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/67427#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F67427
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F67427
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/67427
Reloadhttps://github.com/nodejs/node/issues/67427
Reloadhttps://github.com/nodejs/node/issues/67427
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67427
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67427
sqlite: should Database close its connection on garbage collection?https://github.com/nodejs/node/issues/67427#top
questionIssues asking questions about Node.js.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22question%22
sqliteIssues and PRs related to the SQLite subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22sqlite%22
https://github.com/TrevorBurnham
TrevorBurnhamhttps://github.com/TrevorBurnham
on Nov 12, 2026https://github.com/nodejs/node/issues/67427#issue-6341168764
Database::~Database() in src/node_sqlite.cchttps://github.com/nodejs/node/blob/main/src/node_sqlite.cc
DEP0137https://nodejs.org/api/deprecations.html#DEP0137
@BurningEnlightenmenthttps://github.com/BurningEnlightenment
#57445https://github.com/nodejs/node/issues/57445
better-sqlite3https://github.com/WiseLibs/better-sqlite3/blob/master/src/objects/database.cpp
sqlite: bind parameters the same way better-sqlite3 does. #67353https://github.com/nodejs/node/issues/67353
@sqlite.org/sqlite-wasmhttps://github.com/sqlite/sqlite-wasm
DEP0137https://nodejs.org/api/deprecations.html#DEP0137
araujoguihttps://github.com/araujogui
sqliteIssues and PRs related to the SQLite subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22sqlite%22
questionIssues asking questions about Node.js.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22question%22
on Nov 13, 2026https://github.com/nodejs/node/issues/67427#event-35983129520
https://github.com/araujogui
araujoguihttps://github.com/araujogui
on Nov 20, 2026https://github.com/nodejs/node/issues/67427#issuecomment-7041220515
#64232https://github.com/nodejs/node/pull/64232
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/67427
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/67427
questionIssues asking questions about Node.js.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22question%22
sqliteIssues and PRs related to the SQLite subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22sqlite%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.