René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"tls: TLSSocket session deserialization failure leaves errors on the OpenSSL error queue (wrong error codes in later crypto calls)","articleBody":"\n**Version:** v26.13.0 (also v24.22.2)\n**Platform:** macOS arm64; OpenSSL 3.5.9\n\n**What steps will reproduce the bug?**\n\n```js\n// repro.mjs — run: node repro.mjs\nimport tls from 'node:tls';\nimport crypto from 'node:crypto';\nconst badPem = '-----BEGIN PRIVATE KEY-----\\nAAAA\\n-----END PRIVATE KEY-----';\nconst code = () => { try { crypto.createPrivateKey(badPem); } catch (e) { return e.code; } };\nconsole.log('before:', code()); // ERR_OSSL_UNSUPPORTED\nconst session = Buffer.from(\n  '006e6f64656a733a746c733a73657373696f6e3a31000014676174657761792e6578616d706c652e746573746d6f636b65642073657373696f6e',\n  'hex',\n);\nconst socket = tls.connect({ host: '127.0.0.1', port: 9, servername: 'gateway.example.test', session });\nsocket.on('error', () => {});\nsocket.destroy();\nconsole.log('after: ', code()); // ERR_OSSL_ASN1_TOO_LONG (error left by d2i_SSL_SESSION)\n```\n\n**What is the expected behavior?** The same error code before and after. A session that cannot be deserialized should not leave errors on the OpenSSL error queue.\n\n**What do you see instead?** `after: ERR_OSSL_ASN1_TOO_LONG`. The leftover error from `d2i_SSL_SESSION` is reported by an unrelated call.\n\n**Additional information**\n\n- Follow-up of #67203, as suggested there. The abort itself is fixed by ae35a8fe801f6487e5737d93516536f1d8f514a2.\n- `TLSWrap::SetSession` → `GetTLSSession` → `d2i_SSL_SESSION` does not clear or pop the error queue on failure (`// TODO(tniessen): figure out error handling`). Using `ClearErrorOnReturn` there, or throwing `ERR_TLS_INVALID_SESSION`, would avoid it.\n- Seen in practice with a test HTTP interceptor that emits fake TLS sessions (mswjs/interceptors#892), which undici then reuses.\n","author":{"url":"https://github.com/webteamfrit","@type":"Person","name":"webteamfrit"},"datePublished":"2026-11-02T18:28:59Z","url":"https://github.com/nodejs/node/issues/67204"}