Title: deps: clarify criteria for cherry-picking upstream LIEF fixes · Issue #67164 · nodejs/node · GitHub
Open Graph Title: deps: clarify criteria for cherry-picking upstream LIEF fixes · Issue #67164 · nodejs/node
X Title: deps: clarify criteria for cherry-picking upstream LIEF fixes · Issue #67164 · nodejs/node
Description: Could we clarify when it is appropriate to cherry-pick upstream LIEF fixes into Node.js before an official LIEF release? The dependency maintenance guidelines generally require changes to have landed upstream, but do not explicitly requi...
Open Graph Description: Could we clarify when it is appropriate to cherry-pick upstream LIEF fixes into Node.js before an official LIEF release? The dependency maintenance guidelines generally require changes to have land...
X Description: Could we clarify when it is appropriate to cherry-pick upstream LIEF fixes into Node.js before an official LIEF release? The dependency maintenance guidelines generally require changes to have land...
Opengraph URL: https://github.com/nodejs/node/issues/67164
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"deps: clarify criteria for cherry-picking upstream LIEF fixes","articleBody":"Could we clarify when it is appropriate to cherry-pick upstream LIEF fixes into Node.js before an official LIEF release?\n\nThe [dependency maintenance guidelines](https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md#updating-dependencies) generally require changes to have landed upstream, but do not explicitly require an upstream release. In [#63934](https://github.com/nodejs/node/pull/63934#issuecomment-5493089494), inheriting fixes through a LIEF update was preferred over patching its bundled dependencies directly.\n\nThat seems like a reasonable default, but without a known release date, the timeline for resolving affected Node.js issues remains uncertain. Two examples are:\n\n- **#67048:** Generated SEAs fail on Linux arm64 with 16 KiB or 64 KiB pages. An upstream LIEF fix has been [tested successfully with Node.js v26.13.0](https://github.com/nodejs/node/issues/67048#issuecomment-6538441468).\n- **#66076:** A libc++ build failure in LIEF’s bundled frozen dependency. The fix was [incorporated into LIEF](https://github.com/lief-project/LIEF/pull/1386), but is awaiting a release.\n\nThese issues also affect Node.js 26, which has now entered LTS, although SEA remains at Stability 1.1 - Active development.\n\nWould case-by-case cherry-picks be appropriate when:\n\n- The fix has landed in LIEF upstream and addresses a significant Node.js regression or build failure.\n- The impact justifies carrying the fix rather than waiting for a release.\n- The patch can be adequately reviewed, tested, and tracked through subsequent LIEF updates.\n\nAre there additional LIEF-specific maintenance concerns we should consider?","author":{"url":"https://github.com/inoway46","@type":"Person","name":"inoway46"},"datePublished":"2026-10-31T16:44:53Z","url":"https://github.com/nodejs/node/issues/67164"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:55a2b4e9-3bd5-5ac9-32fd-683c2e8c9384 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B038:264FC7:78EC8C:A44781:6AED2EB8 |
| html-safe-nonce | 6583c2fd97f106f0dca1a5f8b3f1a6ff2da4dada7100492fffcc7d1f51daacd6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDM4OjI2NEZDNzo3OEVDOEM6QTQ0NzgxOjZBRUQyRUI4IiwidmlzaXRvcl9pZCI6IjYzMTYwOTM0MTE2NzI1MzQ3MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 73229a1aec9e4c056cbcabffa79c11da12c207cc6958774374482ed587bc5c5e |
| hovercard-subject-tag | issue:6137292417 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/67164/issue_layout |
| twitter:image | https://opengraph.githubassets.com/72f92ecfe25d91a9e47a44884281f60127635166b13b89f334bee9e7a38182ea/nodejs/node/issues/67164 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/72f92ecfe25d91a9e47a44884281f60127635166b13b89f334bee9e7a38182ea/nodejs/node/issues/67164 |
| og:image:alt | Could we clarify when it is appropriate to cherry-pick upstream LIEF fixes into Node.js before an official LIEF release? The dependency maintenance guidelines generally require changes to have land... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | inoway46 |
| hostname | github.com |
| expected-hostname | github.com |
| None | e51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ebb7b901cc154ecc179a44f266fcf69f343b30 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width