Title: http2: content-encoding is incorrectly listed in kSingleValueHeaders · Issue #67151 · nodejs/node · GitHub
Open Graph Title: http2: content-encoding is incorrectly listed in kSingleValueHeaders · Issue #67151 · nodejs/node
X Title: http2: content-encoding is incorrectly listed in kSingleValueHeaders · Issue #67151 · nodejs/node
Description: Version v26.13.0 Platform Subsystem No response What steps will reproduce the bug? Drafted by Gemini 4 Argon. In lib/internal/http2/util.js, HTTP2_HEADER_CONTENT_ENCODING is listed in kSingleValueHeaders: Incoming (mapToHeaders): When an...
Open Graph Description: Version v26.13.0 Platform Subsystem No response What steps will reproduce the bug? Drafted by Gemini 4 Argon. In lib/internal/http2/util.js, HTTP2_HEADER_CONTENT_ENCODING is listed in kSingleValueH...
X Description: Version v26.13.0 Platform Subsystem No response What steps will reproduce the bug? Drafted by Gemini 4 Argon. In lib/internal/http2/util.js, HTTP2_HEADER_CONTENT_ENCODING is listed in kSingleValueH...
Opengraph URL: https://github.com/nodejs/node/issues/67151
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"http2: content-encoding is incorrectly listed in kSingleValueHeaders","articleBody":"### Version\n\nv26.13.0\n\n### Platform\n\n```text\n\n```\n\n### Subsystem\n\n_No response_\n\n### What steps will reproduce the bug?\n\n*Drafted by Gemini 4 Argon.*\n\nIn [`lib/internal/http2/util.js`](https://github.com/nodejs/node/blob/main/lib/internal/http2/util.js), `HTTP2_HEADER_CONTENT_ENCODING` is listed in `kSingleValueHeaders`:\n\n- **Incoming (`mapToHeaders`)**: When an HTTP/2 peer sends multiple `content-encoding` header lines (e.g., `content-encoding: gzip` twice on Google Drive viewer endpoints), only the first value is kept in `headers['content-encoding']` and subsequent values are silently dropped (even with `strictSingleValueFields: false` from #59917). As a result, HTTP/2 clients only decompress the first layer and treat the still-compressed payload as decoded data, and reverse proxies forwarding `headers` strip the remaining encoding layers so downstream browsers fail to decode the response.\n- **Outgoing (`buildNgHeaderString`)**: Passing multiple `content-encoding` values throws `ERR_HTTP2_HEADER_SINGLE_VALUE` by default, preventing servers and proxies from sending or forwarding multi-value `content-encoding` headers.\n\n### Evidence\n\n1. **HTTP Semantics — RFC 9110 §8.4 (`Content-Encoding`) & §5.3**:\n > `Content-Encoding = #content-coding`\n >\n > If one or more encodings have been applied to a representation, the sender that applied the encodings MUST generate a Content-Encoding header field that lists the content codings in the order in which they were applied.\n\n Because `Content-Encoding` uses the `#element` list ABNF production, multiple `content-encoding` header field lines are valid per RFC 9110 §5.3 and must be combined in order with `', '` rather than discarded.\n\n2. **HTTP/2 & HPACK — RFC 9113 §8.2.1 & RFC 7541**:\n HTTP/2 only forbids connection-specific headers (`connection`, `transfer-encoding`, `keep-alive`, `upgrade`, `proxy-connection`); for all other fields, RFC 9113 §8.2.1 inherits RFC 9110 §5.3, allowing list-based headers to be transmitted as multiple separate HPACK header field entries (each referencing HPACK static table index 26 `content-encoding`). `nghttp2` itself accepts multiple `content-encoding` entries and delivers all of them in `rawHeaders`—the truncation happens purely in Node's JS `kSingleValueHeaders` check.\n\n3. **`node:http` consistency**: `lib/_http_incoming.js` (`_addHeaderLine`) does not treat `content-encoding` as single-value and joins duplicate lines with `', '`.\n\nRemoving `HTTP2_HEADER_CONTENT_ENCODING` from `kSingleValueHeaders` fixes both directions.\n\n### Compatibility\n\n- **No type change**: `headers['content-encoding']` remains `string | undefined` (`mapToHeaders` joins non-single-value headers with `', '`), and single `content-encoding` responses are unaffected.\n- **Incoming duplicate headers**: `headers['content-encoding']` becomes `'gzip, br'` instead of `'gzip'` (matching what a single `content-encoding: gzip, br` header or `node:http` already produces). Callers doing exact single-token checks (`headers['content-encoding'] === 'gzip'`) without splitting on `','` may stop matching when a peer sends multiple lines.\n- **Outgoing validation**: Passing multiple `content-encoding` values will succeed instead of throwing `ERR_HTTP2_HEADER_SINGLE_VALUE` (potentially `semver-major` per Node's error-removal policy).\n\n\n### How often does it reproduce? Is there a required condition?\n\n-\n\n### What is the expected behavior? Why is that the expected behavior?\n\n-\n\n### What do you see instead?\n\n-\n\n### Additional information\n\n_No response_","author":{"url":"https://github.com/panmenghan","@type":"Person","name":"panmenghan"},"datePublished":"2026-10-31T00:39:12Z","url":"https://github.com/nodejs/node/issues/67151"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9826e8ff-a45b-f762-f42b-6d512b2f67d0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B03A:3CFBC:CEEA78:11BA98F:6AFBE9B8 |
| html-safe-nonce | 89add2dd638f30dbca755924bb086fddf83e5b65b77d2d88b8660c0ab2cc8439 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDNBOjNDRkJDOkNFRUE3ODoxMUJBOThGOjZBRkJFOUI4IiwidmlzaXRvcl9pZCI6IjM1MjE0MTQwNjExMDA4ODY0NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4645d6d09dd3a956a744185e711b78f73f0c056298ef2f84d0e17066f6ca448a |
| hovercard-subject-tag | issue:6129222431 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/67151/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6dcd7212ef6840cae506e023fc5475c2a39d85bfd25c283adf24ca2aea4961ef/nodejs/node/issues/67151 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6dcd7212ef6840cae506e023fc5475c2a39d85bfd25c283adf24ca2aea4961ef/nodejs/node/issues/67151 |
| og:image:alt | Version v26.13.0 Platform Subsystem No response What steps will reproduce the bug? Drafted by Gemini 4 Argon. In lib/internal/http2/util.js, HTTP2_HEADER_CONTENT_ENCODING is listed in kSingleValueH... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | panmenghan |
| hostname | github.com |
| expected-hostname | github.com |
| None | 744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | df859c48a4c8b4c0009c19bb4e82101aacb4b998 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width