René's URL Explorer Experiment


Title: crypto: scrypt with params over maxmem leaves an OpenSSL error queued; the next createPrivateKey fails · Issue #66668 · nodejs/node · GitHub

Open Graph Title: crypto: scrypt with params over maxmem leaves an OpenSSL error queued; the next createPrivateKey fails · Issue #66668 · nodejs/node

X Title: crypto: scrypt with params over maxmem leaves an OpenSSL error queued; the next createPrivateKey fails · Issue #66668 · nodejs/node

Description: Version v24.13.0 (OpenSSL 3.5.4) Platform Windows 11 x64 (10.0.22631). Not yet checked on Linux/macOS. Subsystem crypto What steps will reproduce the bug? import crypto from "node:crypto"; const { privateKey } = crypto.generateKeyPairSyn...

Open Graph Description: Version v24.13.0 (OpenSSL 3.5.4) Platform Windows 11 x64 (10.0.22631). Not yet checked on Linux/macOS. Subsystem crypto What steps will reproduce the bug? import crypto from "node:crypto"; const { ...

X Description: Version v24.13.0 (OpenSSL 3.5.4) Platform Windows 11 x64 (10.0.22631). Not yet checked on Linux/macOS. Subsystem crypto What steps will reproduce the bug? import crypto from "node:crypto"...

Opengraph URL: https://github.com/nodejs/node/issues/66668

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.3


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"crypto: scrypt with params over maxmem leaves an OpenSSL error queued; the next createPrivateKey fails","articleBody":"### Version\nv24.13.0 (OpenSSL 3.5.4)\n\n### Platform\nWindows 11 x64 (10.0.22631). Not yet checked on Linux/macOS.\n\n### Subsystem\ncrypto\n\n### What steps will reproduce the bug?\n\n```js\nimport crypto from \"node:crypto\";\n\nconst { privateKey } = crypto.generateKeyPairSync(\"rsa\", {\n  modulusLength: 2048,\n  privateKeyEncoding: { type: \"pkcs8\", format: \"pem\" },\n  publicKeyEncoding: { type: \"spki\", format: \"pem\" },\n});\n\ncrypto.createPrivateKey(privateKey); // ok\n\ntry {\n  // 128 * r * (N + 2) > maxmem → ERR_CRYPTO_INVALID_SCRYPT_PARAMS (expected)\n  crypto.scryptSync(\"pw\", crypto.randomBytes(16), 32, { N: 131072, r: 32, p: 1, maxmem: 256 * 1024 * 1024 });\n} catch (e) {\n  console.log(e.code); // ERR_CRYPTO_INVALID_SCRYPT_PARAMS\n}\n\ncrypto.createPrivateKey(privateKey);\n// throws: ERR_OSSL_EVP_MEMORY_LIMIT_EXCEEDED\n//   error:030000AC:digital envelope routines::memory limit exceeded\n\ncrypto.createPrivateKey(privateKey); // ok again\n```\n\nThe asynchronous `crypto.scrypt(..., cb)` behaves the same way: its parameter check throws synchronously and leaves the\nsame error queued.\n\n### How often does it reproduce? Is there a required condition?\nAlways, when the scrypt parameters exceed `maxmem` (the memory check). A non-power-of-two `N` (also\n`ERR_CRYPTO_INVALID_SCRYPT_PARAMS`) does not leave an error behind.\n\n### What is the expected behavior? Why is that the expected behavior?\nThe failed scrypt parameter check should not affect unrelated later crypto calls: `createPrivateKey` of a valid key\nshould succeed. The OpenSSL error queue should be cleared when the parameter check fails, as Node does elsewhere.\n\n### What do you see instead?\nThe first `createPrivateKey` (or other key-parsing call) after the failed scrypt throws the scrypt's\n`EVP_R_MEMORY_LIMIT_EXCEEDED`. Through jsonwebtoken this surfaced as «secretOrPrivateKey must be an asymmetric key when\nusing RS256» (jsonwebtoken retries a key that fails `createPrivateKey` as an HMAC secret), which made it look like a\nrandom signing failure under load.\n\n### Additional information\nThe likely source is the fix for #53291 (PR #53300): when `ncrypto::checkScryptParams` fails, `src/crypto/crypto_scrypt.cc`\n(line ~92 on `main`) reads the OpenSSL error with `ERR_peek_last_error()` to build the message, but never pops or\nclears it, so it stays queued for the next OpenSSL consumer on the thread. A `ClearErrorOnReturn` (or\n`ERR_get_error()` / `ERR_clear_error()` after formatting) on that path should fix it. Same class as #45485\n(`X509Certificate.checkPrivateKey()` with a non-matching key makes the next `createPrivateKey()` fail), #21281 and\n#42793.\n","author":{"url":"https://github.com/etray7","@type":"Person","name":"etray7"},"datePublished":"2026-10-12T01:42:24Z","url":"https://github.com/nodejs/node/issues/66668"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:68a1ef37-c771-b85c-13e0-f0daeebe7861
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8DA2:27CA4:2984FDA:3746605:6B033B08
html-safe-noncea7145c84e1ea2fb9b058cd2c7bd83714fad2f8643349f49434616bfb3477baa7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REEyOjI3Q0E0OjI5ODRGREE6Mzc0NjYwNTo2QjAzM0IwOCIsInZpc2l0b3JfaWQiOiIzNDk4NjM2ODc0NTczMTAxODMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2c64b1ef717c64a0284bae5eb23e230543a59ee05ae3633da81e9341b3504fc7
hovercard-subject-tagissue:5807165611
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/66668/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c6c5fdb5527f1cf2a51d5bb909af3018a2f4fe429c1c066d947ce3e81716bdce/nodejs/node/issues/66668
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c6c5fdb5527f1cf2a51d5bb909af3018a2f4fe429c1c066d947ce3e81716bdce/nodejs/node/issues/66668
og:image:altVersion v24.13.0 (OpenSSL 3.5.4) Platform Windows 11 x64 (10.0.22631). Not yet checked on Linux/macOS. Subsystem crypto What steps will reproduce the bug? import crypto from "node:crypto"; const { ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameetray7
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/66668#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F66668
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F66668
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/66668
Reloadhttps://github.com/nodejs/node/issues/66668
Reloadhttps://github.com/nodejs/node/issues/66668
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/66668
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/66668
#66671https://github.com/nodejs/node/pull/66671
crypto: scrypt with params over maxmem leaves an OpenSSL error queued; the next createPrivateKey failshttps://github.com/nodejs/node/issues/66668#top
#66671https://github.com/nodejs/node/pull/66671
https://github.com/etray7
etray7https://github.com/etray7
on Oct 12, 2026https://github.com/nodejs/node/issues/66668#issue-5807165611
#53291https://github.com/nodejs/node/issues/53291
#53300https://github.com/nodejs/node/pull/53300
#45485https://github.com/nodejs/node/issues/45485
#21281https://github.com/nodejs/node/issues/21281
#42793https://github.com/nodejs/node/pull/42793
nodejs-github-bothttps://github.com/nodejs-github-bot
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#66671https://github.com/nodejs/node/pull/66671
on Oct 19, 2026https://github.com/nodejs/node/issues/66668#event-33609272504
manzoorwanijkhttps://github.com/manzoorwanijk
on Oct 19, 2026https://github.com/nodejs/node/issues/66668#event-33612714298
crypto: do not leak scrypt param check errorshttps://github.com/manzoorwanijk/nodejs/commit/fccdbc8b99c4579636f4b7e980731f79cbc64231
fccdbc8https://github.com/manzoorwanijk/nodejs/commit/fccdbc8b99c4579636f4b7e980731f79cbc64231
aduh95https://github.com/aduh95
on Nov 12, 2026https://github.com/nodejs/node/issues/66668#event-35938462530
crypto: do not leak scrypt param check errorshttps://github.com/nodejs/node/commit/1441eae2bfe96dc6ff45b785908e1c1e50c86f1a
1441eaehttps://github.com/nodejs/node/commit/1441eae2bfe96dc6ff45b785908e1c1e50c86f1a
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/66668
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/66668
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlmax-age=0, private, must-revalidate

Viewport: width=device-width


URLs of crawlers that visited me.