René's URL Explorer Experiment


Title: ffi: `exportArrayBuffer` type check is fooled by `Symbol.toStringTag` · Issue #66454 · nodejs/node · GitHub

Open Graph Title: ffi: `exportArrayBuffer` type check is fooled by `Symbol.toStringTag` · Issue #66454 · nodejs/node

X Title: ffi: `exportArrayBuffer` type check is fooled by `Symbol.toStringTag` · Issue #66454 · nodejs/node

Description: Version main Platform macOS 26.7.1 Subsystem ffi What steps will reproduce the bug? import ffi from 'node:ffi'; const dest = new ArrayBuffer(8); const ptr = ffi.getRawPointer(dest); // Real ArrayBuffer with a custom tag: rejected. const ...

Open Graph Description: Version main Platform macOS 26.7.1 Subsystem ffi What steps will reproduce the bug? import ffi from 'node:ffi'; const dest = new ArrayBuffer(8); const ptr = ffi.getRawPointer(dest); // Real ArrayBu...

X Description: Version main Platform macOS 26.7.1 Subsystem ffi What steps will reproduce the bug? import ffi from 'node:ffi'; const dest = new ArrayBuffer(8); const ptr = ffi.getRawPointer(dest); // Real...

Opengraph URL: https://github.com/nodejs/node/issues/66454

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ffi: `exportArrayBuffer` type check is fooled by `Symbol.toStringTag`","articleBody":"### Version\n\nmain\n\n### Platform\n\n```text\nmacOS 26.7.1\n```\n\n### Subsystem\n\nffi\n\n### What steps will reproduce the bug?\n\n```js\nimport ffi from 'node:ffi';\n\nconst dest = new ArrayBuffer(8);\nconst ptr = ffi.getRawPointer(dest);\n\n// Real ArrayBuffer with a custom tag: rejected.\nconst real = new ArrayBuffer(4);\nObject.defineProperty(real, Symbol.toStringTag, { value: 'Custom' });\ntry {\n  ffi.exportArrayBuffer(real, ptr, 8);\n} catch (err) {\n  console.log('real:', err.code, err.message);\n}\n\n// Fake object tagged as ArrayBuffer: passes the JS check.\nconst fake = { [Symbol.toStringTag]: 'ArrayBuffer', byteLength: 4 };\ntry {\n  ffi.exportArrayBuffer(fake, ptr, 8);\n} catch (err) {\n  console.log('fake:', err.code, err.message);\n}\n```\n\n### How often does it reproduce? Is there a required condition?\n\nAlways\n\n### What is the expected behavior? Why is that the expected behavior?\n\nThe `arrayBuffer` argument is documented as `{ArrayBuffer}`\nDocs https://github.com/nodejs/node/blob/main/doc/api/ffi.md#ffiexportarraybufferarraybuffer-pointer-length\n\nSo the check should depend on whether the value really is an `ArrayBuffer`, not on its tag. A real `ArrayBuffer` should be copied.\nThe fake object should be rejected in JS with `The \"arrayBuffer\" argument must be an instance of ArrayBuffer`.\n\n### What do you see instead?\n\n```console\nreal: ERR_INVALID_ARG_TYPE The \"arrayBuffer\" argument must be an instance of ArrayBuffer. Received an instance of ArrayBuffer\nfake: ERR_INVALID_ARG_TYPE The first argument must be a Buffer, ArrayBuffer, SharedArrayBuffer, or ArrayBufferView\n```\n\n### Additional information\n\n_No response_","author":{"url":"https://github.com/trivikr","@type":"Person","name":"trivikr"},"datePublished":"2026-10-02T03:41:48Z","url":"https://github.com/nodejs/node/issues/66454"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:cfe6bad2-886e-d2ce-8592-8c6993fc0765
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE046:1E45AC:7920B4:9D7B9A:6AED336A
html-safe-nonce1f4c062e2928a839ddab3487a03ebeebd7b9cfcb8239c17bc10da639ac6960dc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDQ2OjFFNDVBQzo3OTIwQjQ6OUQ3QjlBOjZBRUQzMzZBIiwidmlzaXRvcl9pZCI6IjU5OTg4NjE2NjgyODY1NDI2OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac421d2eb6e079732bbc342298ab62b7c4a4c478c425968914b3b929a22ac2cac6
hovercard-subject-tagissue:5672548891
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/66454/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ded770e629e22a707558ec7737c25070a24f01b56c7f5dd2d4800cfd96931c3c/nodejs/node/issues/66454
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ded770e629e22a707558ec7737c25070a24f01b56c7f5dd2d4800cfd96931c3c/nodejs/node/issues/66454
og:image:altVersion main Platform macOS 26.7.1 Subsystem ffi What steps will reproduce the bug? import ffi from 'node:ffi'; const dest = new ArrayBuffer(8); const ptr = ffi.getRawPointer(dest); // Real ArrayBu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/66454#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F66454
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F66454
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/66454
Reloadhttps://github.com/nodejs/node/issues/66454
Reloadhttps://github.com/nodejs/node/issues/66454
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/66454
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/66454
#66455https://github.com/nodejs/node/pull/66455
ffi: exportArrayBuffer type check is fooled by Symbol.toStringTaghttps://github.com/nodejs/node/issues/66454#top
#66455https://github.com/nodejs/node/pull/66455
ffiIssues and PRs related to experimental Foreign Function Interface support.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22ffi%22
https://github.com/trivikr
trivikrhttps://github.com/trivikr
on Oct 2, 2026https://github.com/nodejs/node/issues/66454#issue-5672548891
https://github.com/nodejs/node/blob/main/doc/api/ffi.md#ffiexportarraybufferarraybuffer-pointer-lengthhttps://github.com/nodejs/node/blob/main/doc/api/ffi.md#ffiexportarraybufferarraybuffer-pointer-length
trivikrhttps://github.com/trivikr
ffiIssues and PRs related to experimental Foreign Function Interface support.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22ffi%22
on Oct 2, 2026https://github.com/nodejs/node/issues/66454#event-32307218676
nodejs-github-bothttps://github.com/nodejs-github-bot
on Oct 4, 2026https://github.com/nodejs/node/issues/66454#event-32427246225
ffi: fix exportArrayBuffer type checkhttps://github.com/nodejs/node/commit/04904eb4ca488300816cc260cf794598c16a65ab
04904ebhttps://github.com/nodejs/node/commit/04904eb4ca488300816cc260cf794598c16a65ab
nodejs-github-bothttps://github.com/nodejs-github-bot
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#66455https://github.com/nodejs/node/pull/66455
on Oct 4, 2026https://github.com/nodejs/node/issues/66454#event-32427246240
richardlauhttps://github.com/richardlau
on Oct 12, 2026https://github.com/nodejs/node/issues/66454#event-33063912714
ffi: fix exportArrayBuffer type checkhttps://github.com/nodejs/node/commit/c1073f31ded6b902bf102641f4b3220cff56091c
c1073f3https://github.com/nodejs/node/commit/c1073f31ded6b902bf102641f4b3220cff56091c
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/66454
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/66454
ffiIssues and PRs related to experimental Foreign Function Interface support.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22ffi%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.