René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Eagerly format default AbortController abort reasons to avoid retaining canceled work","articleBody":"Could `controller.abort()` eagerly read the default reason’s stack, following the [existing streams workaround](https://github.com/nodejs/node/blob/v26.8.2/lib/internal/streams/destroy.js#L31-L35) and its [original discussion](https://github.com/nodejs/node/pull/34103#issuecomment-652002364)?\n\nA retained signal can keep the canceled job alive through `signal → reason → V8 stack → caller’s receiver`, including large buffers. This surfaced while investigating [jsdom window retention](https://github.com/jsdom/jsdom/issues/4337).\n\nRun this as an `.mjs` file with `node --expose-gc`. Verified on Node **v26.8.2**, Linux x64:\n\n```js\nimport { setImmediate } from \"node:timers/promises\";\n\nclass RenderJob {\n  input = Buffer.alloc(32 * 1024 * 1024, 1);\n  controller = new AbortController();\n\n  cancel() {\n    this.controller.abort();\n    return this.controller.signal;\n  }\n}\n\nasync function retainedMiB() {\n  for (let i = 0; i \u003c 5; ++i) {\n    await setImmediate();\n    global.gc();\n  }\n  return Math.round(process.memoryUsage().arrayBuffers / 1024 ** 2);\n}\n\n// Model dependencies retaining signals after the jobs are discarded.\nconst signals = Array.from({ length: 4 }, () => new RenderJob().cancel());\nconsole.log(await retainedMiB()); // 128\nconsole.log(signals.every(signal => signal.aborted)); // true\n\nfor (const signal of signals) void signal.reason.stack;\n\nconsole.log(await retainedMiB()); // 0\nconsole.log(signals.every(signal => signal.aborted)); // true\n```\n\nThe same signals and reasons remain alive throughout; reading their stacks releases all 128 MiB.\n\nI propose formatting only newly created default reasons, leaving caller-supplied reasons untouched. This preserves error identity and stack text with the default formatter. Formatting should follow abort notifications, and formatter exceptions should not escape `abort()`.\n\n\u003cdetails>\n\u003csummary>GPT-6 Astra Extra High's suggested diff\u003c/summary>\n\n```diff\n-  abort(reason = new DOMException('This operation was aborted', 'AbortError')) {\n-    abortSignal(this.#signal ??= new AbortSignal(kDontThrowSymbol), reason);\n+  abort(reason = undefined) {\n+    const signal = this.#signal ??= new AbortSignal(kDontThrowSymbol);\n+    if (signal[kAborted]) return;\n+\n+    const isDefaultReason = reason === undefined;\n+    if (isDefaultReason) {\n+      reason = new DOMException('This operation was aborted', 'AbortError');\n+    }\n+\n+    abortSignal(signal, reason);\n+\n+    if (isDefaultReason) {\n+      try {\n+        // Release references retained by V8's unformatted stack.\n+        // See https://github.com/nodejs/node/pull/34103#issuecomment-652002364\n+        reason.stack; // eslint-disable-line no-unused-expressions\n+      } catch {\n+        // A custom stack formatter must not make cancellation throw.\n+      }\n+    }\n   }\n```\n\n\u003c/details>\n\nThe tradeoffs are extra formatting work and earlier `Error.prepareStackTrace` execution. Custom formatters that retain call sites or throw may still retain the objects. This is the same compromise streams already makes.\n\nAlternately, if the Node.js team has good V8 contacts, it might be good to raise this with them. It's kind of ridiculous for large objects to be retained in this way all because of `Error.prepareStackTrace`, in my opinion.","author":{"url":"https://github.com/domenic","@type":"Person","name":"domenic"},"datePublished":"2026-09-22T01:21:57Z","url":"https://github.com/nodejs/node/issues/66192"}