René's URL Explorer Experiment

Title: dgram: socket.send() crash when input array is modified · Issue #6616 · nodejs/node · GitHub

Open Graph Title: dgram: socket.send() crash when input array is modified · Issue #6616 · nodejs/node

X Title: dgram: socket.send() crash when input array is modified · Issue #6616 · nodejs/node

Description: #4374 introduces a bug: it makes socket.send() accept an array but it's not resilient against that array getting modified afterwards: $ node -e ' var a = ["boom!"], s = dgram.createSocket("udp4"); s.send(a, 1234); a.splice(0); ' node: .....

Open Graph Description: #4374 introduces a bug: it makes socket.send() accept an array but it's not resilient against that array getting modified afterwards: $ node -e ' var a = ["boom!"], s = dgram.createSocket("udp4"); ...

X Description: #4374 introduces a bug: it makes socket.send() accept an array but it's not resilient against that array getting modified afterwards: $ node -e ' var a = ["boom!"], s = dgram.crea...

Opengraph URL: https://github.com/nodejs/node/issues/6616

X: @github

direct link

Domain: github.com

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"dgram: socket.send() crash when input array is modified","articleBody":"#4374 introduces a bug: it makes `socket.send()` accept an array but it's not resilient against that array getting modified afterwards:\n\n```\n$ node -e '\n  var a = [\"boom!\"], s = dgram.createSocket(\"udp4\");\n  s.send(a, 1234);\n  a.splice(0);\n'\nnode: ../deps/uv/src/unix/udp.c:390: uv__udp_send: Assertion `nbufs \u003e 0' failed.\nAborted (core dumped)\n```\n\nA secondary issue with #4374 is that it penalizes the common case of passing in a buffer by always wrapping it in an array.\n\n/cc @mcollina @jasnell\n","author":{"url":"https://github.com/bnoordhuis","@type":"Person","name":"bnoordhuis"},"datePublished":"2016-05-06T09:40:37.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/6616/node/issues/6616"}

Links:

Viewport: width=device-width