René's URL Explorer Experiment


Title: sqlite: remove the null prototype from result rows · Issue #65799 · nodejs/node · GitHub

Open Graph Title: sqlite: remove the null prototype from result rows · Issue #65799 · nodejs/node

X Title: sqlite: remove the null prototype from result rows · Issue #65799 · nodejs/node

Description: Current behavior Rows returned by get(), all() and iterate() are created with a null prototype. The V8 API that does this produces dictionary-mode objects, and V8 will not cache a prototype transition on a dictionary map, so every row al...

Open Graph Description: Current behavior Rows returned by get(), all() and iterate() are created with a null prototype. The V8 API that does this produces dictionary-mode objects, and V8 will not cache a prototype transit...

X Description: Current behavior Rows returned by get(), all() and iterate() are created with a null prototype. The V8 API that does this produces dictionary-mode objects, and V8 will not cache a prototype transit...

Opengraph URL: https://github.com/nodejs/node/issues/65799

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"sqlite: remove the null prototype from result rows","articleBody":"**Current behavior**\n\nRows returned by `get()`, `all()` and `iterate()` are created with a `null` prototype. The V8 API that does this produces dictionary-mode objects, and V8 will not cache a prototype transition on a dictionary map, so every row also gets its own freshly allocated hidden class. Rows from the same statement therefore share no shape: they are slow to build, and every property access on them in user code is megamorphic.\n\n**Proposal**\n\nDrop the null prototype and build rows with `v8::DictionaryTemplate`, cached per statement. Rows become ordinary objects, and every row of a statement shares one hidden class.\n\n**Pros**\n\n- `all()` is 10–37% faster depending on the query; reading the rows afterwards is far cheaper still.\n- Consistent with `run()`, which already returns an ordinary object, and with `better-sqlite3`.\n\n**Cons**\n\n- Semver-major.\n- Rows can no longer be indexed by untrusted keys without `Object.hasOwn()` — `row.toString` and `row.constructor` start resolving through `Object.prototype`.\n- User code comparing rows against `{ __proto__: null, ... }` breaks.\n\nPrototype pollution is not a concern either way: rows are built by defining own properties directly, so a `__proto__` column is an own property and never reaches `Object.prototype`.\n\nI have benchmarks and a working implementation if there is interest.\n","author":{"url":"https://github.com/araujogui","@type":"Person","name":"araujogui"},"datePublished":"2026-09-04T17:45:47Z","url":"https://github.com/nodejs/node/issues/65799"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8541046c-4ee2-6cdd-f052-dc58444178a3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDA5E:9EF81:73096F:959653:6AED3131
html-safe-nonce8a532b6f3b5c92a33ecee1b87d0922adab08e5f4bab473dcd06a950fb80e86d6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTVFOjlFRjgxOjczMDk2Rjo5NTk2NTM6NkFFRDMxMzEiLCJ2aXNpdG9yX2lkIjoiOTAzMDkxMzQ0MTcxODQxNTY2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5f6fec3843b3e7eaff34f23a127ab97ac70dfc12262798dc03590416f9acd6cf
hovercard-subject-tagissue:5351269540
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/65799/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9f35d070c64ce103bdfdfb1f7b15b6493e82ff6d6d95716eae293ef83d1fe199/nodejs/node/issues/65799
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9f35d070c64ce103bdfdfb1f7b15b6493e82ff6d6d95716eae293ef83d1fe199/nodejs/node/issues/65799
og:image:altCurrent behavior Rows returned by get(), all() and iterate() are created with a null prototype. The V8 API that does this produces dictionary-mode objects, and V8 will not cache a prototype transit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamearaujogui
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/65799#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F65799
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F65799
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/65799
Reloadhttps://github.com/nodejs/node/issues/65799
Reloadhttps://github.com/nodejs/node/issues/65799
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/65799
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/65799
#66385https://github.com/nodejs/node/pull/66385
sqlite: remove the null prototype from result rowshttps://github.com/nodejs/node/issues/65799#top
#66385https://github.com/nodejs/node/pull/66385
https://github.com/araujogui
araujoguihttps://github.com/araujogui
on Sep 4, 2026https://github.com/nodejs/node/issues/65799#issue-5351269540
https://github.com/bakkot
bakkothttps://github.com/bakkot
on Sep 4, 2026https://github.com/nodejs/node/issues/65799#issuecomment-5547616453
https://github.com/aduh95
aduh95https://github.com/aduh95
on Sep 5, 2026https://github.com/nodejs/node/issues/65799#issuecomment-5550892826
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
on Sep 5, 2026https://github.com/nodejs/node/issues/65799#issuecomment-5551584095
https://github.com/araujogui
araujoguihttps://github.com/araujogui
on Sep 5, 2026https://github.com/nodejs/node/issues/65799#issuecomment-5553172381
always builds a dictionary-mode objecthttps://github.com/nodejs/node/blob/9f04fcd70d28ac691f592d3c0c1e00a28998eb51/deps/v8/src/api/api.cc#L7811-L7851
won't cache a prototype transition when the source map is a dictionary maphttps://github.com/nodejs/node/blob/9f04fcd70d28ac691f592d3c0c1e00a28998eb51/deps/v8/src/objects/transitions.cc#L425-L426
caches one map per (context, template)https://github.com/nodejs/node/blob/9f04fcd70d28ac691f592d3c0c1e00a28998eb51/deps/v8/src/objects/templates.cc#L268-L276
release-mode CHECK_EQhttps://github.com/nodejs/node/blob/9f04fcd70d28ac691f592d3c0c1e00a28998eb51/deps/v8/src/objects/templates.cc#L306
are cached when the source map is fasthttps://github.com/nodejs/node/blob/9f04fcd70d28ac691f592d3c0c1e00a28998eb51/deps/v8/src/objects/map.cc#L2591-L2605
the object-literal map it roots at is fasthttps://github.com/nodejs/node/blob/9f04fcd70d28ac691f592d3c0c1e00a28998eb51/deps/v8/src/heap/factory.cc#L4236-L4262
it came out to 8 lineshttps://github.com/nodejs/node/blob/9f04fcd70d28ac691f592d3c0c1e00a28998eb51/deps/v8/src/objects/templates.cc#L223-L363
araujoguihttps://github.com/araujogui
on Oct 6, 2026https://github.com/nodejs/node/issues/65799#event-32557195657
sqlite: use shared-shape objects for result rowshttps://github.com/araujogui/node/commit/46793f98967478722e8c639d384b2e1ec7e86db8
46793f9https://github.com/araujogui/node/commit/46793f98967478722e8c639d384b2e1ec7e86db8
nodejs-github-bothttps://github.com/nodejs-github-bot
on Oct 14, 2026https://github.com/nodejs/node/issues/65799#event-33258048595
sqlite: use shared-shape objects for result rowshttps://github.com/nodejs/node/commit/68df1db7b030718cd62fb89eef51960d4c858970
68df1dbhttps://github.com/nodejs/node/commit/68df1db7b030718cd62fb89eef51960d4c858970
nodejs-github-bothttps://github.com/nodejs-github-bot
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#66385https://github.com/nodejs/node/pull/66385
on Oct 14, 2026https://github.com/nodejs/node/issues/65799#event-33258048677
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/65799
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/65799
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.