René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"sqlite: session[Symbol.dispose]() silently ignores the in-use guard","articleBody":"### Version\n\nv27.0.0-pre (current main)\n\n### Platform\n\n```text\nLinux ari-cachyos 7.1.8-1-cachyos #1 SMP PREEMPT_DYNAMIC Mon, 10 Aug 2026 19:39:40 +0000 x86_64 GNU/Linux\n```\n\n### Subsystem\n\nnode:sqlite\n\n### What steps will reproduce the bug?\n\n```js\nconst { DatabaseSync, constants } = require('node:sqlite');\n\nfor (const [name, close] of [\n  ['close()', (session) => session.close()],\n  ['[Symbol.dispose]()', (session) => session[Symbol.dispose]()],\n]) {\n  const db = new DatabaseSync(':memory:');\n  db.exec('CREATE TABLE data(key INTEGER PRIMARY KEY, value TEXT)');\n  const session = db.createSession({ table: 'data' });\n  db.exec(\"INSERT INTO data VALUES (1, 'value')\");\n\n  let attempted = false;\n  db.setAuthorizer(() => {\n    if (!attempted) {\n      attempted = true;\n      try {\n        close(session);\n        console.log(`${name}: no throw`);\n      } catch (error) {\n        console.log(`${name}: ${error.code}: ${error.message}`);\n      }\n    }\n    return constants.SQLITE_OK;\n  });\n\n  session.changeset();\n  db.setAuthorizer(null);\n  session.close();\n  db.close();\n}\n```\n\n### How often does it reproduce? Is there a required condition?\n\nEvery time disposal is attempted while the session is generating a changeset or patchset.\n\n### What is the expected behavior? Why is that the expected behavior?\n\n`session[Symbol.dispose]()` should throw the same `ERR_INVALID_STATE` as `session.close()` when the session cannot be closed safely. `StatementSync` already follows this pattern: its disposal propagates the active-statement guard, with coverage in `test/parallel/test-sqlite-diagnostic-channel.js` under “subscriber cannot close the database or statement”.\n\nExpected output:\n\n```text\nclose(): ERR_INVALID_STATE: session is currently in use\n[Symbol.dispose](): ERR_INVALID_STATE: session is currently in use\n```\n\n### What do you see instead?\n\n```text\nclose(): ERR_INVALID_STATE: session is currently in use\n[Symbol.dispose](): no throw\n```\n\n`Session::Dispose()` catches and discards the exception from `Session::Close()`. The session remains open even though disposal appeared to succeed.\n\n### Additional information\n\nThe reentrancy guard added by #65349 works: `sqlite3session_delete()` is not called while changeset generation is active, so this does not reproduce the use-after-free that the guard prevents. The remaining bug is the silent no-op and inconsistent error propagation from `[Symbol.dispose]()`.\n","author":{"url":"https://github.com/arimxyer","@type":"Person","name":"arimxyer"},"datePublished":"2026-08-20T22:01:02Z","url":"https://github.com/nodejs/node/issues/65447"}