René's URL Explorer Experiment


Title: test_runner: JUnit report is truncated when a failed test triggers empty context.diagnostic() · Issue #65355 · nodejs/node · GitHub

Open Graph Title: test_runner: JUnit report is truncated when a failed test triggers empty context.diagnostic() · Issue #65355 · nodejs/node

X Title: test_runner: JUnit report is truncated when a failed test triggers empty context.diagnostic() · Issue #65355 · nodejs/node

Description: Version v24.15.0 Platform Microsoft Windows NT 10.0.26200.0 x64 Subsystem test_runner What steps will reproduce the bug? Create any test file, like junit.test.mjs: import { fail } from 'node:assert/strict'; import { test } from 'node:tes...

Open Graph Description: Version v24.15.0 Platform Microsoft Windows NT 10.0.26200.0 x64 Subsystem test_runner What steps will reproduce the bug? Create any test file, like junit.test.mjs: import { fail } from 'node:assert...

X Description: Version v24.15.0 Platform Microsoft Windows NT 10.0.26200.0 x64 Subsystem test_runner What steps will reproduce the bug? Create any test file, like junit.test.mjs: import { fail } from 'node:as...

Opengraph URL: https://github.com/nodejs/node/issues/65355

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"test_runner: JUnit report is truncated when a failed test triggers empty context.diagnostic()","articleBody":"### Version\n\nv24.15.0\n\n### Platform\n\n```text\nMicrosoft Windows NT 10.0.26200.0 x64\n```\n\n### Subsystem\n\ntest_runner\n\n### What steps will reproduce the bug?\n\n1. Create any test file, like `junit.test.mjs`:\n\n    ```js\n    import { fail } from 'node:assert/strict';\n    import { test } from 'node:test';\n\n    await test('testName', (context) => {\n      context.diagnostic('');\n      fail();\n    });\n    ```\n2. Run the test via console\n\n    ```powershell\n    node --test --test-reporter=junit \".\\junit.test.mjs\"\n    ```\n\n### How often does it reproduce? Is there a required condition?\n\nAlways.\n\n### What is the expected behavior? Why is that the expected behavior?\n\nThe JUnit reporter should gracefully handle empty diagnostic messages (e.g., `context.diagnostic('')`). It should format them as empty XML comments (`\u003c!--  -->`) without throwing errors, aligning with the default `spec` reporter which successfully prints empty lines for empty diagnostic events. The generated XML report must remain valid and fully closed with the `\u003c/testsuites>` tag.\n\n\n### What do you see instead?\n\nWhen a failed test contains an empty diagnostic call, the internal XML formatter (`treeToXML`) evaluates the falsy empty string `if (comment)` as false and mistakenly tries to read `ObjectEntries(attrs)` from an undefined object. This causes an unhandled `TypeError` inside the stream generator, silently destroying the stream and leaving the JUnit XML report truncated and broken.\n\nStack trace:\n\n```text\nTypeError: Cannot convert undefined or null to object\n    at entries (\u003canonymous>)\n    at treeToXML (node:internal/test_runner/reporter/junit:46:7)\n    at junitReporter (node:internal/test_runner/reporter/junit:160:11)\n```\n\n\n### Additional information\n\n_No response_","author":{"url":"https://github.com/AlexCannonball","@type":"Person","name":"AlexCannonball"},"datePublished":"2026-08-17T18:25:41Z","url":"https://github.com/nodejs/node/issues/65355"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c56c5141-a7e3-bd5e-e5da-ec204ed1d3b1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB5F0:36D84F:817BFC:ACA2B4:6AED299E
html-safe-nonce1f9533f758200cb156ade63b232659233f3c9859cf98b1447928eba0b929d904
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUYwOjM2RDg0Rjo4MTdCRkM6QUNBMkI0OjZBRUQyOTlFIiwidmlzaXRvcl9pZCI6IjU5NDYyOTA1MjEyNTkxOTA2ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd7d14b8d1b4c401b6475f3854c0229de8c4a2f12cfe6190ac3bdf7b50ee48108
hovercard-subject-tagissue:5174184609
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/65355/issue_layout
twitter:imagehttps://opengraph.githubassets.com/0b6f74cf17001ebfbc07ceba40394b937aedc1b648884e01801ca7b981697263/nodejs/node/issues/65355
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0b6f74cf17001ebfbc07ceba40394b937aedc1b648884e01801ca7b981697263/nodejs/node/issues/65355
og:image:altVersion v24.15.0 Platform Microsoft Windows NT 10.0.26200.0 x64 Subsystem test_runner What steps will reproduce the bug? Create any test file, like junit.test.mjs: import { fail } from 'node:assert...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexCannonball
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/nodejs/node/issues/65355#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F65355
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fissues%2F65355
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/issues/65355
Reloadhttps://github.com/nodejs/node/issues/65355
Reloadhttps://github.com/nodejs/node/issues/65355
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/65355
New issuehttps://github.com/login?return_to=https://github.com/nodejs/node/issues/65355
#65357https://github.com/nodejs/node/pull/65357
test_runner: JUnit report is truncated when a failed test triggers empty context.diagnostic()https://github.com/nodejs/node/issues/65355#top
#65357https://github.com/nodejs/node/pull/65357
test_runnerIssues and PRs related to the test runner subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22test_runner%22
https://github.com/AlexCannonball
AlexCannonballhttps://github.com/AlexCannonball
on Aug 17, 2026https://github.com/nodejs/node/issues/65355#issue-5174184609
trivikrhttps://github.com/trivikr
test_runnerIssues and PRs related to the test runner subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22test_runner%22
on Aug 18, 2026https://github.com/nodejs/node/issues/65355#event-29596599284
nodejs-github-bothttps://github.com/nodejs-github-bot
completedhttps://github.com/nodejs/node/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#65357https://github.com/nodejs/node/pull/65357
on Aug 19, 2026https://github.com/nodejs/node/issues/65355#event-29703429443
nodejs-github-bothttps://github.com/nodejs-github-bot
on Aug 19, 2026https://github.com/nodejs/node/issues/65355#event-29703429509
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/commit/03fb38410b23eb7e443bfe586c212e3185aad86e
03fb384https://github.com/nodejs/node/commit/03fb38410b23eb7e443bfe586c212e3185aad86e
aduh95https://github.com/aduh95
on Aug 25, 2026https://github.com/nodejs/node/issues/65355#event-30010177647
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/commit/af8df85278ad9efd67f92e151e2bd28396865829
af8df85https://github.com/nodejs/node/commit/af8df85278ad9efd67f92e151e2bd28396865829
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/commit/9572a0b15fb36ef2e40e16c454a2e504975bf867
9572a0bhttps://github.com/nodejs/node/commit/9572a0b15fb36ef2e40e16c454a2e504975bf867
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/commit/dfaa058f77518102459e71561ae196069666e735
dfaa058https://github.com/nodejs/node/commit/dfaa058f77518102459e71561ae196069666e735
aduh95https://github.com/aduh95
on Sep 7, 2026https://github.com/nodejs/node/issues/65355#event-30681663090
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/commit/02d44f2ede6ebbc88fa56cdd1a4b4cc64318cf41
02d44f2https://github.com/nodejs/node/commit/02d44f2ede6ebbc88fa56cdd1a4b4cc64318cf41
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/commit/6a248acefe2483c67926abe5e237b00661292586
6a248achttps://github.com/nodejs/node/commit/6a248acefe2483c67926abe5e237b00661292586
Sign up for freehttps://github.com/signup?return_to=https://github.com/nodejs/node/issues/65355
Sign in to commenthttps://github.com/login?return_to=https://github.com/nodejs/node/issues/65355
test_runnerIssues and PRs related to the test runner subsystem.https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22test_runner%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.