Title: stream/iter: Share "drop-newest" can eagerly drain the upstream source · Issue #65337 · nodejs/node · GitHub
Open Graph Title: stream/iter: Share "drop-newest" can eagerly drain the upstream source · Issue #65337 · nodejs/node
X Title: stream/iter: Share "drop-newest" can eagerly drain the upstream source · Issue #65337 · nodejs/node
Description: Version main Platform N/A Subsystem stream What steps will reproduce the bug? import { share } from 'node:stream/iter'; let batchesYielded = 0; async function* source() { for (let i = 0; i < 7; i++) { batchesYielded++; console.log('sourc...
Open Graph Description: Version main Platform N/A Subsystem stream What steps will reproduce the bug? import { share } from 'node:stream/iter'; let batchesYielded = 0; async function* source() { for (let i = 0; i < 7; i++...
X Description: Version main Platform N/A Subsystem stream What steps will reproduce the bug? import { share } from 'node:stream/iter'; let batchesYielded = 0; async function* source() { for (let i = 0; i ...
Opengraph URL: https://github.com/nodejs/node/issues/65337
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"stream/iter: Share \"drop-newest\" can eagerly drain the upstream source","articleBody":"### Version\n\nmain\n\n### Platform\n\n```text\nN/A\n```\n\n### Subsystem\n\nstream\n\n### What steps will reproduce the bug?\n\n```js\nimport { share } from 'node:stream/iter';\n\nlet batchesYielded = 0;\n\nasync function* source() {\n for (let i = 0; i \u003c 7; i++) {\n batchesYielded++;\n console.log('source yielded', i);\n yield [new Uint8Array(16_384).fill(i)];\n }\n}\n\nconst shared = share(source(), {\n budget: 16_384,\n backpressure: 'drop-newest',\n});\n\nconst fast = shared.pull()[Symbol.asyncIterator]();\nconst stalled = shared.pull();\n\nlet result = await fast.next();\nconsole.log('after first next', {\n done: result.done,\n firstByte: result.value?.[0][0],\n batchesYielded,\n});\n\nconst second = fast.next();\n\nawait new Promise(setImmediate);\nconsole.log('batches after one event-loop turn:', batchesYielded);\n\nshared.cancel();\nconsole.log('second next:', await second);\n\nvoid stalled;\n```\n\n### How often does it reproduce? Is there a required condition?\n\nAlways\n\n### What is the expected behavior? Why is that the expected behavior?\n\n```console\nsource yielded 0\nafter first next { done: false, firstByte: 0, batchesYielded: 1 }\nsource yielded 1\nbatches after one event-loop turn: 2\nsecond next: [Object: null prototype] { done: true, value: undefined }\n```\n\nThe second `fast.next()` should discard only one upstream result and then wait for buffer space. `shared.cancel()` subsequently settles that pending call so the repro exits cleanly.\n\nFrom [§13.2.2: Share buffering and backpressure](https://iter-streams.proposal.wintertc.org/#share-backpressure):\n> “With `\"drop-newest\"`, the upstream pull result is discarded.”\n\n### What do you see instead?\n\n```console\nsource yielded 0\nafter first next { done: false, firstByte: 0, batchesYielded: 1 }\nsource yielded 1\nsource yielded 2\nsource yielded 3\nsource yielded 4\nsource yielded 5\nsource yielded 6\nbatches after one event-loop turn: 7\nsecond next: [Object: null prototype] { done: true, value: undefined }\n```\n\nOne `fast.next()` pulls and discards all six remaining batches while the buffer is full.\n\n### Additional information\n\n_No response_","author":{"url":"https://github.com/trivikr","@type":"Person","name":"trivikr"},"datePublished":"2026-08-16T21:27:46Z","url":"https://github.com/nodejs/node/issues/65337"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4b0fdf9b-3f68-99c9-4312-794834068e54 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D2DA:204D3A:494281:63C7F8:6AED1BE9 |
| html-safe-nonce | 55c0bbebc3e4501d1150058567fac4afe55908ff25a6d3f89c2d8d2e57fe6312 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkRBOjIwNEQzQTo0OTQyODE6NjNDN0Y4OjZBRUQxQkU5IiwidmlzaXRvcl9pZCI6Ijc4NTg2ODI4OTgwMjAxMTMzODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1e823f6f18e0a352b66cba4683a5298491eacd5ce3663dc3ce247681d47647fb |
| hovercard-subject-tag | issue:5166457794 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/65337/issue_layout |
| twitter:image | https://opengraph.githubassets.com/25fe41387bc1d6c571b9789e100977069dfb9e1c01bb6bb2ec2d09e88d16ee02/nodejs/node/issues/65337 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/25fe41387bc1d6c571b9789e100977069dfb9e1c01bb6bb2ec2d09e88d16ee02/nodejs/node/issues/65337 |
| og:image:alt | Version main Platform N/A Subsystem stream What steps will reproduce the bug? import { share } from 'node:stream/iter'; let batchesYielded = 0; async function* source() { for (let i = 0; i < 7; i++... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | trivikr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e12fd03aa775dceadc5a793c3a0791e43ca256bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width