Title: doc: commit `Signed-off-by` instructions missing details · Issue #64799 · nodejs/node · GitHub
Open Graph Title: doc: commit `Signed-off-by` instructions missing details · Issue #64799 · nodejs/node
X Title: doc: commit `Signed-off-by` instructions missing details · Issue #64799 · nodejs/node
Description: Situation If linting finds a problem with a missing Signed-off-by trailer, then the logs contain the following error: Error: not ok 6 signed-off-by: Commit must have a "Signed-off-by" trailer () ... ... ... # Please review the commit mes...
Open Graph Description: Situation If linting finds a problem with a missing Signed-off-by trailer, then the logs contain the following error: Error: not ok 6 signed-off-by: Commit must have a "Signed-off-by" trailer () .....
X Description: Situation If linting finds a problem with a missing Signed-off-by trailer, then the logs contain the following error: Error: not ok 6 signed-off-by: Commit must have a "Signed-off-by" tra...
Opengraph URL: https://github.com/nodejs/node/issues/64799
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"doc: commit `Signed-off-by` instructions missing details","articleBody":"## Situation\n\nIf linting finds a problem with a missing `Signed-off-by` trailer, then the logs contain the following error:\n\n```console\nError: not ok 6 signed-off-by: Commit must have a \"Signed-off-by\" trailer ()\n...\n...\n...\n# Please review the commit message guidelines:\n# https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines\n```\n\nhttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines says:\n\n---\n\n6. Your commit must contain the `Signed-off-by` line with your name and email\n address as an acknowledgement that you agree to the [Developer Certificate of Origin](https://github.com/nodejs/node/blob/main/CONTRIBUTING.md#developers-certificate-of-origin-11).\n Bot generated commits are exempt from this requirement. If a commit has\n multiple authors, the `Signed-off-by` line should be added for each author;\n and at least one should match the author information in the commit metadata.\n This rule does not apply to dependency updates (e.g. cherry-picks), release\n commits, or backport commits.\n\n---\n\nIt does not however give the details that were in issue https://github.com/nodejs/node/issues/62577 and that said:\n\n---\n**How?**\n\nWhen you create a commit, use the `-s` flag, e.g. `git commit -s`. This will automatically add the `Signed-off-by` trailer in your commit message using your configured named (sic) and email address.\n\n---\n\n## Suggestion\n\nAdd detail to https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines to instruct how to add a `Signed-off-by` trailer automatically to a commit.\n\nLink to the `git` documentation:\n\nhttps://git-scm.com/docs/git-commit#Documentation/git-commit.txt--s\n\nwith the `git commit` options:\n\n-s\n--signoff\n\n---\n\nPossibly mention also the \"Signed-off-by\" trailer option in the commit options menu in [GitHub Desktop](https://docs.github.com/en/desktop), added to 3.5.7, Mar 31, 2026, through https://github.com/desktop/desktop/pull/21741 (Thanks to @JakobJingleheimer for spotting this function, which only seems to be documented in the [GitHub Desktop release notes](https://desktop.github.com/release-notes/)!)\n","author":{"url":"https://github.com/MikeMcC399","@type":"Person","name":"MikeMcC399"},"datePublished":"2026-07-28T06:32:58Z","url":"https://github.com/nodejs/node/issues/64799"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0faef4aa-fd2c-6ca0-bf48-f72f46485576 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E752:C63F3:C2263C:101E56A:6AED3C57 |
| html-safe-nonce | b1bceb9555f817a15a47af795be3cb00dc237ed510078b640f5f9a91a95dfcf5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzUyOkM2M0YzOkMyMjYzQzoxMDFFNTZBOjZBRUQzQzU3IiwidmlzaXRvcl9pZCI6IjUxNDI2Mjk2MjM5NDk3Njk4MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 789d54c9ff9ef7b1f607c7c59955ec37882145f569b1b2014c2a23d56d854dc4 |
| hovercard-subject-tag | issue:4995663232 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node/64799/issue_layout |
| twitter:image | https://opengraph.githubassets.com/992c2103e252e784789e114934003e8a0266ef96d0e2dbaddd4cb33ffb05bbdc/nodejs/node/issues/64799 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/992c2103e252e784789e114934003e8a0266ef96d0e2dbaddd4cb33ffb05bbdc/nodejs/node/issues/64799 |
| og:image:alt | Situation If linting finds a problem with a missing Signed-off-by trailer, then the logs contain the following error: Error: not ok 6 signed-off-by: Commit must have a "Signed-off-by" trailer () ..... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MikeMcC399 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 26c92a9388ddfad3fa88d132b5d5f0b4747030233dcc4e5efb05f1cbae152184 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c629ad99c254d306375fc8354d04321c2c362236 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width